René's URL Explorer Experiment


Title: src: make `AsyncResource` destructor virtual by addaleax · Pull Request #20633 · nodejs/node · GitHub

Open Graph Title: src: make `AsyncResource` destructor virtual by addaleax · Pull Request #20633 · nodejs/node

X Title: src: make `AsyncResource` destructor virtual by addaleax · Pull Request #20633 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: AsyncResource is intended to be a base class, and since we don’t know what API consumers will do with it in their own code, it’s good practice to make its destructor virtual. This should not be ABI...

X Description: AsyncResource is intended to be a base class, and since we don’t know what API consumers will do with it in their own code, it’s good practice to make its destructor virtual. This should not be ABI...

Opengraph URL: https://github.com/nodejs/node/pull/20633

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b98dd85f-eda3-7041-590e-2e3044a1c403
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE7E:1A5E8A:28A88F7:33EF37C:6991C3CC
html-safe-nonce61fbae7bd09fac4996b58b9991f4e141ef5de7b68f2a505fadc9a70c1ff85789
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTdFOjFBNUU4QToyOEE4OEY3OjMzRUYzN0M6Njk5MUMzQ0MiLCJ2aXNpdG9yX2lkIjoiNzAwNTU1NzQ2NjY5MDg1NjQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac742e6684ace1469982ffd4d2a78a9ce83806cee73b078d76413cfb649e9bd026
hovercard-subject-tagpull_request:186978328
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20633/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3eccb775d0b683da6c32d9bf200447874f63ec46465993cd65959f9034bea2b1/nodejs/node/pull/20633
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3eccb775d0b683da6c32d9bf200447874f63ec46465993cd65959f9034bea2b1/nodejs/node/pull/20633
og:image:altAsyncResource is intended to be a base class, and since we don’t know what API consumers will do with it in their own code, it’s good practice to make its destructor virtual. This should not be ABI...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20633#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20633
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20633
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20633
Reloadhttps://github.com/nodejs/node/pull/20633
Reloadhttps://github.com/nodejs/node/pull/20633
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20633
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:virtual-async-resourcehttps://github.com/addaleax/node/tree/virtual-async-resource
Conversationhttps://github.com/nodejs/node/pull/20633
Commits1 (1)https://github.com/nodejs/node/pull/20633/commits
Checkshttps://github.com/nodejs/node/pull/20633/checks
Files changedhttps://github.com/nodejs/node/pull/20633/files
src: make AsyncResource destructor virtualhttps://github.com/nodejs/node/pull/20633#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:virtual-async-resourcehttps://github.com/addaleax/node/tree/virtual-async-resource
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018https://github.com/nodejs/node/pull/20633#issue-321644822
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20633
https://github.com/addaleax
src: make AsyncResource destructor virtualhttps://github.com/nodejs/node/pull/20633/commits/4386d67082a558fba2d12db072aa8d7366a68f7a
4386d67https://github.com/nodejs/node/pull/20633/commits/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
May 9, 2018https://github.com/nodejs/node/pull/20633#event-1618074963
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 9, 2018https://github.com/nodejs/node/pull/20633#event-1618075041
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018https://github.com/nodejs/node/pull/20633#issuecomment-387802588
https://ci.nodejs.org/job/node-test-commit/18339/https://ci.nodejs.org/job/node-test-commit/18339/
Please reload this pagehttps://github.com/nodejs/node/pull/20633
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 9, 2018 https://github.com/nodejs/node/pull/20633#pullrequestreview-118826047
View reviewed changes https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/danbev
danbevhttps://github.com/danbev
May 11, 2018 https://github.com/nodejs/node/pull/20633#pullrequestreview-119314127
View reviewed changes https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 11, 2018 https://github.com/nodejs/node/pull/20633#pullrequestreview-119340455
View reviewed changes https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 11, 2018https://github.com/nodejs/node/pull/20633#event-1621682951
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 11, 2018https://github.com/nodejs/node/pull/20633#issuecomment-388329269
https://ci.nodejs.org/job/node-test-commit-windows-fanned/17901/https://ci.nodejs.org/job/node-test-commit-windows-fanned/17901/
Please reload this pagehttps://github.com/nodejs/node/pull/20633
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 11, 2018 https://github.com/nodejs/node/pull/20633#pullrequestreview-119464561
View reviewed changes https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018https://github.com/nodejs/node/pull/20633#issuecomment-388875998
00f395dhttps://github.com/nodejs/node/commit/00f395db45f20c4fd2b8ea48a6b97b5b72494c4c
Please reload this pagehttps://github.com/nodejs/node/pull/20633
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018https://github.com/nodejs/node/pull/20633#event-1625233531
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 16:18https://github.com/nodejs/node/pull/20633#event-1625233824
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20633#ref-commit-00f395d
https://github.com/addaleax
src: make AsyncResource destructor virtualhttps://github.com/nodejs/node/commit/00f395db45f20c4fd2b8ea48a6b97b5b72494c4c
00f395dhttps://github.com/nodejs/node/commit/00f395db45f20c4fd2b8ea48a6b97b5b72494c4c
#20633https://github.com/nodejs/node/pull/20633
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20633#ref-commit-d223e3c
https://github.com/addaleax
src: make AsyncResource destructor virtualhttps://github.com/nodejs/node/commit/d223e3ca415c0f5b7751cb0fa8f808a318dcd071
d223e3chttps://github.com/nodejs/node/commit/d223e3ca415c0f5b7751cb0fa8f808a318dcd071
#20633https://github.com/nodejs/node/pull/20633
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20633#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Jun 29, 2018https://github.com/nodejs/node/pull/20633#event-1709713521
addaleaxhttps://github.com/addaleax
Jun 29, 2018 https://github.com/nodejs/node/pull/20633#ref-commit-9b611d2
https://github.com/addaleax
src: make AsyncResource destructor virtualhttps://github.com/nodejs/node/commit/9b611d27ff8a49dc8cfc0d353c82383ba0871119
9b611d2https://github.com/nodejs/node/commit/9b611d27ff8a49dc8cfc0d353c82383ba0871119
#20633https://github.com/nodejs/node/pull/20633
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 9, 2018 https://github.com/nodejs/node/pull/20633#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
rvagghttps://github.com/rvagg
Aug 16, 2018 https://github.com/nodejs/node/pull/20633#ref-commit-342dbff
https://github.com/addaleax
https://github.com/rvagg
src: make AsyncResource destructor virtualhttps://github.com/nodejs/node/commit/342dbff852fb2ec54c2aec8c5886e2401c081e8d
342dbffhttps://github.com/nodejs/node/commit/342dbff852fb2ec54c2aec8c5886e2401c081e8d
#20633https://github.com/nodejs/node/pull/20633
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20633
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20633/files/4386d67082a558fba2d12db072aa8d7366a68f7a
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/20633
https://github.com/addaleax
https://github.com/danbev
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.