| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:45a9319f-9bdb-3801-f780-99279deec7f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8220:189FE3:1951535:2067DDF:6991B55E |
| html-safe-nonce | 1c9e0e6c5647a3002a4d42199e2fa0c417fff35537991288e4ed1472f3aaaa1e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjIwOjE4OUZFMzoxOTUxNTM1OjIwNjdEREY6Njk5MUI1NUUiLCJ2aXNpdG9yX2lkIjoiMzMwNzE3NTU2MDQzNDc5MTc3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 915303b2527a7a643814c87b7669eb331c7be289fd5840b1104839b785a435c1 |
| hovercard-subject-tag | pull_request:186946269 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20629/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3ed2846b18d109e70b728fe2e9f8297d49fa94d44ac7c6ff36f42ef6722efc79/nodejs/node/pull/20629 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3ed2846b18d109e70b728fe2e9f8297d49fa94d44ac7c6ff36f42ef6722efc79/nodejs/node/pull/20629 |
| og:image:alt | In the document for fs, there are several functions that state "No
arguments other than a possible exception are given to the completion
callback." (ex> fs.access, fs.chmod, fs.close, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dankang |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/20629#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20629 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20629 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/20629 |
| Reload | https://github.com/nodejs/node/pull/20629 |
| Reload | https://github.com/nodejs/node/pull/20629 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| dankang | https://github.com/dankang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dankang:fs-callback | https://github.com/dankang/node/tree/fs-callback |
| Conversation | https://github.com/nodejs/node/pull/20629 |
| Commits1 (1) | https://github.com/nodejs/node/pull/20629/commits |
| Checks | https://github.com/nodejs/node/pull/20629/checks |
| Files changed | https://github.com/nodejs/node/pull/20629/files |
| src: remove 2nd undefined argument in node_file.cc | https://github.com/nodejs/node/pull/20629#top |
| dankang | https://github.com/dankang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dankang:fs-callback | https://github.com/dankang/node/tree/fs-callback |
|
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#issue-321602383 |
| async.waterfall | https://caolan.github.io/async/docs.html#waterfall |
| #20335 | https://github.com/nodejs/node/issues/20335 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#event-1617816460 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387768821 |
| https://ci.nodejs.org/job/node-test-pull-request/14741/ | https://ci.nodejs.org/job/node-test-pull-request/14741/ |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
May 9, 2018
| https://github.com/nodejs/node/pull/20629#pullrequestreview-118779555 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20629/files |
| src/node_file.cc | https://github.com/nodejs/node/pull/20629/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| mscdex | https://github.com/mscdex |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#discussion_r187073430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| dankang | https://github.com/dankang |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#discussion_r187077933 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387772448 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387778919 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| @mscdex | https://github.com/mscdex |
| #20335 | https://github.com/nodejs/node/issues/20335 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387788665 |
| https://ci.nodejs.org/job/node-test-pull-request/14743/ | https://ci.nodejs.org/job/node-test-pull-request/14743/ |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 9, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387812221 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387924392 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387945774 |
| https://ci.nodejs.org/job/node-test-pull-request/14776/ | https://ci.nodejs.org/job/node-test-pull-request/14776/ |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387954253 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| force-pushed | https://github.com/nodejs/node/compare/49f4b09d502cab60628fdce82eebb926913c0fc2..c3ab50c718d28e8b3bbe04d5b55dce0096ffddbc |
| 49f4b09 | https://github.com/nodejs/node/commit/49f4b09d502cab60628fdce82eebb926913c0fc2 |
| c3ab50c | https://github.com/nodejs/node/commit/c3ab50c718d28e8b3bbe04d5b55dce0096ffddbc |
|
Compare
| https://github.com/nodejs/node/compare/49f4b09d502cab60628fdce82eebb926913c0fc2..c3ab50c718d28e8b3bbe04d5b55dce0096ffddbc |
| May 10, 2018 08:18 | https://github.com/nodejs/node/pull/20629#event-1619292115 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-387986786 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-388018810 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| force-pushed | https://github.com/nodejs/node/compare/c3ab50c718d28e8b3bbe04d5b55dce0096ffddbc..8aa9c1783d26511af726a8db8916f14267535dd8 |
| c3ab50c | https://github.com/nodejs/node/commit/c3ab50c718d28e8b3bbe04d5b55dce0096ffddbc |
| 8aa9c17 | https://github.com/nodejs/node/commit/8aa9c1783d26511af726a8db8916f14267535dd8 |
|
Compare
| https://github.com/nodejs/node/compare/c3ab50c718d28e8b3bbe04d5b55dce0096ffddbc..8aa9c1783d26511af726a8db8916f14267535dd8 |
| May 10, 2018 12:21 | https://github.com/nodejs/node/pull/20629#event-1619662019 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-388054146 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-388083654 |
| https://ci.nodejs.org/job/node-test-pull-request/14794/ | https://ci.nodejs.org/job/node-test-pull-request/14794/ |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#event-1620761572 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#event-1620762112 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 10, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-388193893 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| force-pushed | https://github.com/nodejs/node/compare/38357242466bb82cb55c5f7337d77f1d148d6573..7b958c3744c427d7e45dc68bdbc28e293b0bca15 |
| 3835724 | https://github.com/nodejs/node/commit/38357242466bb82cb55c5f7337d77f1d148d6573 |
| 7b958c3 | https://github.com/nodejs/node/commit/7b958c3744c427d7e45dc68bdbc28e293b0bca15 |
|
Compare
| https://github.com/nodejs/node/compare/38357242466bb82cb55c5f7337d77f1d148d6573..7b958c3744c427d7e45dc68bdbc28e293b0bca15 |
| May 11, 2018 14:22 | https://github.com/nodejs/node/pull/20629#event-1622052738 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 11, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-388392654 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| addaleax | https://github.com/addaleax |
| bnoordhuis | https://github.com/bnoordhuis |
| May 12, 2018 23:18 | https://github.com/nodejs/node/pull/20629#event-1623363685 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 12, 2018
| https://github.com/nodejs/node/pull/20629#pullrequestreview-119638973 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20629/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
May 14, 2018
| https://github.com/nodejs/node/pull/20629#pullrequestreview-119727589 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20629/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| May 14, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-388730902 |
| https://ci.nodejs.org/job/node-test-pull-request/14854/ | https://ci.nodejs.org/job/node-test-pull-request/14854/ |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
|
| https://github.com/dankang |
| src: remove 2nd undefined argument in node_file.cc | https://github.com/nodejs/node/pull/20629/commits/b7ab367139ad0920858275db4fd523b497d71380 |
| b7ab367 | https://github.com/nodejs/node/pull/20629/commits/b7ab367139ad0920858275db4fd523b497d71380 |
| https://caolan.github.io/async/docs.html#waterfall | https://caolan.github.io/async/docs.html#waterfall |
| nodejs#20335 | https://github.com/nodejs/node/issues/20335 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| force-pushed | https://github.com/nodejs/node/compare/7b958c3744c427d7e45dc68bdbc28e293b0bca15..b7ab367139ad0920858275db4fd523b497d71380 |
| 7b958c3 | https://github.com/nodejs/node/commit/7b958c3744c427d7e45dc68bdbc28e293b0bca15 |
| b7ab367 | https://github.com/nodejs/node/commit/b7ab367139ad0920858275db4fd523b497d71380 |
|
Compare
| https://github.com/nodejs/node/compare/7b958c3744c427d7e45dc68bdbc28e293b0bca15..b7ab367139ad0920858275db4fd523b497d71380 |
| May 15, 2018 02:59 | https://github.com/nodejs/node/pull/20629#event-1626213101 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
May 18, 2018
| https://github.com/nodejs/node/pull/20629#pullrequestreview-121266608 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20629/files/b7ab367139ad0920858275db4fd523b497d71380 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 18, 2018 | https://github.com/nodejs/node/pull/20629#event-1633294918 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 18, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-390066920 |
| https://ci.nodejs.org/job/node-test-pull-request/14943/ | https://ci.nodejs.org/job/node-test-pull-request/14943/ |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| BridgeAR | https://github.com/BridgeAR |
|
May 18, 2018
| https://github.com/nodejs/node/pull/20629#ref-commit-60cc8ff |
|
| https://github.com/dankang |
|
| https://github.com/BridgeAR |
| src: remove 2nd undefined argument in node_file.cc | https://github.com/BridgeAR/node/commit/60cc8ff096c98c3bfd5c4906ac9af3e9c220a748 |
| 60cc8ff | https://github.com/BridgeAR/node/commit/60cc8ff096c98c3bfd5c4906ac9af3e9c220a748 |
| https://caolan.github.io/async/docs.html#waterfall | https://caolan.github.io/async/docs.html#waterfall |
| nodejs#20629 | https://github.com/nodejs/node/pull/20629 |
| nodejs#20335 | https://github.com/nodejs/node/issues/20335 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 18, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-390214004 |
| 60cc8ff | https://github.com/nodejs/node/commit/60cc8ff096c98c3bfd5c4906ac9af3e9c220a748 |
| @dankang | https://github.com/dankang |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| May 18, 2018 | https://github.com/nodejs/node/pull/20629#event-1634325464 |
| https://github.com/dankang |
| dankang | https://github.com/dankang |
| May 19, 2018 | https://github.com/nodejs/node/pull/20629#issuecomment-390367680 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20629#ref-issue-325067653 |
|
fs methods returning an additional, undefined value in callback
#20872
| https://github.com/nodejs/node/issues/20872 |
| MylesBorins | https://github.com/MylesBorins |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20629#ref-commit-3edb04d |
|
| https://github.com/dankang |
|
| https://github.com/MylesBorins |
| src: remove 2nd undefined argument in node_file.cc | https://github.com/nodejs/node/commit/3edb04d0651788340f4494cf43ffd6dbf1811de8 |
| 3edb04d | https://github.com/nodejs/node/commit/3edb04d0651788340f4494cf43ffd6dbf1811de8 |
| https://caolan.github.io/async/docs.html#waterfall | https://caolan.github.io/async/docs.html#waterfall |
| #20629 | https://github.com/nodejs/node/pull/20629 |
| #20335 | https://github.com/nodejs/node/issues/20335 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 22, 2018
| https://github.com/nodejs/node/pull/20629#ref-pullrequest-322922249 |
|
v10.2.0 proposal
#20724
| https://github.com/nodejs/node/pull/20724 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20629 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/20629/files/7b958c3744c427d7e45dc68bdbc28e293b0bca15 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/20629/files/7b958c3744c427d7e45dc68bdbc28e293b0bca15 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/20629/files/b7ab367139ad0920858275db4fd523b497d71380 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/20629/files/c2504aadd5bd0e8ad77a5ea2bb14d6c81fdc7a50 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
Node 10.0.0 fs.close is called with a second undefined argument.
| https://github.com/nodejs/node/issues/20335 |
| Please reload this page | https://github.com/nodejs/node/pull/20629 |
|
| https://github.com/dankang |
|
| https://github.com/mscdex |
|
| https://github.com/joyeecheung |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |