René's URL Explorer Experiment


Title: lib: return directly from packageMainCache by danbev · Pull Request #20591 · nodejs/node · GitHub

Open Graph Title: lib: return directly from packageMainCache by danbev · Pull Request #20591 · nodejs/node

X Title: lib: return directly from packageMainCache by danbev · Pull Request #20591 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later. Checklist make -j4 test (UNIX), or vcbuild test...

X Description: This commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later. Checklist make -j4 test (UNIX), or vcbuild test...

Opengraph URL: https://github.com/nodejs/node/pull/20591

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c19c634c-89c3-0e6c-7036-01aa7d3397e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB14:1BCE7D:3A6E26:497F3D:69921B5E
html-safe-nonce895dba15107bfe0ee0b1b19a433096c2e08368a3c074cc98c5283fb919b44da8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjE0OjFCQ0U3RDozQTZFMjY6NDk3RjNEOjY5OTIxQjVFIiwidmlzaXRvcl9pZCI6IjI1NjUwNDU2NjkwMzg3MjM1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac537057ab417ada5c6ad7d4864d55d8ea1952e534c59ad21b9f10534bbddc567e
hovercard-subject-tagpull_request:186554083
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20591/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5a68fe6b8d54bfef2c3f84ba7634b9d49403383325408e87a99e0bdcc20ccbf/nodejs/node/pull/20591
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5a68fe6b8d54bfef2c3f84ba7634b9d49403383325408e87a99e0bdcc20ccbf/nodejs/node/pull/20591
og:image:altThis commit updates readPackage to return directly when calling packageMainCache instead of storing the result in a local var and returning later. Checklist make -j4 test (UNIX), or vcbuild test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20591#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20591
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20591
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20591
Reloadhttps://github.com/nodejs/node/pull/20591
Reloadhttps://github.com/nodejs/node/pull/20591
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20591
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:loaders_readPackagehttps://github.com/danbev/node/tree/loaders_readPackage
Conversationhttps://github.com/nodejs/node/pull/20591
Commits1 (1)https://github.com/nodejs/node/pull/20591/commits
Checkshttps://github.com/nodejs/node/pull/20591/checks
Files changedhttps://github.com/nodejs/node/pull/20591/files
lib: return directly from packageMainCachehttps://github.com/nodejs/node/pull/20591#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:loaders_readPackagehttps://github.com/danbev/node/tree/loaders_readPackage
https://github.com/danbev
danbevhttps://github.com/danbev
May 8, 2018https://github.com/nodejs/node/pull/20591#issue-321080185
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20591
https://github.com/danbev
lib: return directly from packageMainCachehttps://github.com/nodejs/node/pull/20591/commits/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
0fc159bhttps://github.com/nodejs/node/pull/20591/commits/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/danbev
danbevhttps://github.com/danbev
May 8, 2018https://github.com/nodejs/node/pull/20591#issuecomment-387317415
https://ci.nodejs.org/job/node-test-pull-request/14711/https://ci.nodejs.org/job/node-test-pull-request/14711/
Please reload this pagehttps://github.com/nodejs/node/pull/20591
https://github.com/targos
targoshttps://github.com/targos
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118260616
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/targos
targoshttps://github.com/targos
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118260617
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/devsnek
devsnekhttps://github.com/devsnek
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118343173
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118397818
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/trivikr
trivikrhttps://github.com/trivikr
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
May 8, 2018https://github.com/nodejs/node/pull/20591#event-1615495737
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118399449
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 8, 2018https://github.com/nodejs/node/pull/20591#event-1615577225
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118412291
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 8, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118416017
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 9, 2018 https://github.com/nodejs/node/pull/20591#pullrequestreview-118940637
View reviewed changes https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/danbev
danbevhttps://github.com/danbev
May 10, 2018https://github.com/nodejs/node/pull/20591#issuecomment-387940532
6446510https://github.com/nodejs/node/commit/6446510066e1d8951a81ae0fe4ce8e6f3649ae54
Please reload this pagehttps://github.com/nodejs/node/pull/20591
https://github.com/danbev
danbevhttps://github.com/danbev
May 10, 2018https://github.com/nodejs/node/pull/20591#event-1618991879
https://github.com/danbev
danbevhttps://github.com/danbev
May 10, 2018 03:23https://github.com/nodejs/node/pull/20591#event-1618992100
danbevhttps://github.com/danbev
May 10, 2018 https://github.com/nodejs/node/pull/20591#ref-commit-6446510
https://github.com/danbev
lib: return directly from packageMainCachehttps://github.com/nodejs/node/commit/6446510066e1d8951a81ae0fe4ce8e6f3649ae54
6446510https://github.com/nodejs/node/commit/6446510066e1d8951a81ae0fe4ce8e6f3649ae54
#20591https://github.com/nodejs/node/pull/20591
targoshttps://github.com/targos
May 12, 2018 https://github.com/nodejs/node/pull/20591#ref-commit-7c13e54
https://github.com/danbev
https://github.com/targos
lib: return directly from packageMainCachehttps://github.com/nodejs/node/commit/7c13e54ca75a0cb36a8399d0feaa5e2d833a7494
7c13e54https://github.com/nodejs/node/commit/7c13e54ca75a0cb36a8399d0feaa5e2d833a7494
#20591https://github.com/nodejs/node/pull/20591
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20591#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20591
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/20591/files/0fc159bac7fad9f3ee8bfe46e440b65f2fe71fd6
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Please reload this pagehttps://github.com/nodejs/node/pull/20591
https://github.com/danbev
https://github.com/jasnell
https://github.com/targos
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/devsnek
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.