| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:94437148-bbf4-d10e-7435-2bbf7768cf6f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CBA:23DC68:2CB110:399403:69926E02 |
| html-safe-nonce | 81a30b89a66984ad2bd284a0006416000a361aee361803f97b3d9f81f6754d20 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0JBOjIzREM2ODoyQ0IxMTA6Mzk5NDAzOjY5OTI2RTAyIiwidmlzaXRvcl9pZCI6IjIyNjAwNzMyNTM5MDg0MDk4NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7687e412ccb886eefc26700a910b57100586c9c186b57166c01e7c9cbce74e35 |
| hovercard-subject-tag | pull_request:186499344 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20587/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c4ebee7ff44224ab7d0c9555f458d4d7b5d8d6c47e21808462f63fa8f79ad6ad/nodejs/node/pull/20587 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c4ebee7ff44224ab7d0c9555f458d4d7b5d8d6c47e21808462f63fa8f79ad6ad/nodejs/node/pull/20587 |
| og:image:alt | Add test cases for AES key wrapping and only detect output length in
cipher case. The reason being is the returned output length is
insufficient in AES key unwrapping case.
Signed-off-by: Yihong Wa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | yhwang |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/20587#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20587 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20587 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/20587 |
| Reload | https://github.com/nodejs/node/pull/20587 |
| Reload | https://github.com/nodejs/node/pull/20587 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| yhwang | https://github.com/yhwang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| yhwang:add-aes-keywrap-test | https://github.com/yhwang/node/tree/add-aes-keywrap-test |
| Conversation | https://github.com/nodejs/node/pull/20587 |
| Commits1 (1) | https://github.com/nodejs/node/pull/20587/commits |
| Checks | https://github.com/nodejs/node/pull/20587/checks |
| Files changed | https://github.com/nodejs/node/pull/20587/files |
| crypto: add test case for AES key wrapping | https://github.com/nodejs/node/pull/20587#top |
| yhwang | https://github.com/yhwang |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| yhwang:add-aes-keywrap-test | https://github.com/yhwang/node/tree/add-aes-keywrap-test |
|
| https://github.com/yhwang |
| yhwang | https://github.com/yhwang |
| May 8, 2018 | https://github.com/nodejs/node/pull/20587#issue-321004206 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
|
| https://github.com/yhwang |
| crypto: add test case for AES key wrapping | https://github.com/nodejs/node/pull/20587/commits/8f934329305dea09286d69d3140135d0bd975de8 |
| 8f93432 | https://github.com/nodejs/node/pull/20587/commits/8f934329305dea09286d69d3140135d0bd975de8 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| May 8, 2018 | https://github.com/nodejs/node/pull/20587#event-1614182499 |
| https://github.com/yhwang |
| yhwang | https://github.com/yhwang |
| May 8, 2018 | https://github.com/nodejs/node/pull/20587#issuecomment-387249681 |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 8, 2018
| https://github.com/nodejs/node/pull/20587#pullrequestreview-118260376 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8 |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/20587#pullrequestreview-118260376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 8, 2018
| https://github.com/nodejs/node/pull/20587#ref-pullrequest-318529723 |
|
crypto: allocate more memory for cipher.update()
#20370
| https://github.com/nodejs/node/pull/20370 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
May 8, 2018
| https://github.com/nodejs/node/pull/20587#pullrequestreview-118265628 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 8, 2018
| https://github.com/nodejs/node/pull/20587#pullrequestreview-118418530 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| jasnell | https://github.com/jasnell |
| May 8, 2018 | https://github.com/nodejs/node/pull/20587#discussion_r186773196 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| yhwang | https://github.com/yhwang |
| May 8, 2018 | https://github.com/nodejs/node/pull/20587#discussion_r186818800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.com/yhwang |
| yhwang | https://github.com/yhwang |
| May 8, 2018 | https://github.com/nodejs/node/pull/20587#issuecomment-387495125 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
May 9, 2018
| https://github.com/nodejs/node/pull/20587#ref-pullrequest-321304972 |
|
[v10.x] src: more automatic memory management in node_crypto.cc
#20609
| https://github.com/nodejs/node/pull/20609 |
| https://github.com/yhwang |
| yhwang | https://github.com/yhwang |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 9, 2018 | https://github.com/nodejs/node/pull/20587#event-1617883191 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 12, 2018 | https://github.com/nodejs/node/pull/20587#issuecomment-388562709 |
| https://ci.nodejs.org/job/node-test-pull-request/14822/ | https://ci.nodejs.org/job/node-test-pull-request/14822/ |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 12, 2018 | https://github.com/nodejs/node/pull/20587#issuecomment-388585773 |
| e3ceae7 | https://github.com/nodejs/node/commit/e3ceae724cf32ca2a7c13565170acead20a58c9c |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.com/targos |
| targos | https://github.com/targos |
| May 12, 2018 | https://github.com/nodejs/node/pull/20587#event-1623344558 |
| targos | https://github.com/targos |
|
May 12, 2018
| https://github.com/nodejs/node/pull/20587#ref-commit-e3ceae7 |
|
| https://github.com/yhwang |
|
| https://github.com/targos |
| crypto: add test case for AES key wrapping | https://github.com/nodejs/node/commit/e3ceae724cf32ca2a7c13565170acead20a58c9c |
| e3ceae7 | https://github.com/nodejs/node/commit/e3ceae724cf32ca2a7c13565170acead20a58c9c |
| #20587 | https://github.com/nodejs/node/pull/20587 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 12, 2018
| https://github.com/nodejs/node/pull/20587#ref-issue-322546334 |
|
Need help to backport crypto changes to v10.x-staging
#20691
| https://github.com/nodejs/node/issues/20691 |
| tniessen | https://github.com/tniessen |
|
May 13, 2018
| https://github.com/nodejs/node/pull/20587#ref-commit-8177b22 |
|
| https://github.com/yhwang |
|
| https://github.com/tniessen |
| crypto: add test case for AES key wrapping | https://github.com/tniessen/node/commit/8177b22285e37de2966b1f0b9f01e235d86cdba9 |
| 8177b22 | https://github.com/tniessen/node/commit/8177b22285e37de2966b1f0b9f01e235d86cdba9 |
| nodejs#20587 | https://github.com/nodejs/node/pull/20587 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
May 13, 2018
| https://github.com/nodejs/node/pull/20587#ref-pullrequest-322616197 |
|
(v10.x backport) Backport 12 crypto commits
#20706
| https://github.com/nodejs/node/pull/20706 |
| addaleax | https://github.com/addaleax |
|
May 14, 2018
| https://github.com/nodejs/node/pull/20587#ref-commit-cecec46 |
|
| https://github.com/yhwang |
|
| https://github.com/addaleax |
| crypto: add test case for AES key wrapping | https://github.com/nodejs/node/commit/cecec462044b505fb1d9903cd2298e9468bc7540 |
| cecec46 | https://github.com/nodejs/node/commit/cecec462044b505fb1d9903cd2298e9468bc7540 |
| #20706 | https://github.com/nodejs/node/pull/20706 |
| #20587 | https://github.com/nodejs/node/pull/20587 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 14, 2018
| https://github.com/nodejs/node/pull/20587#ref-pullrequest-322922249 |
|
v10.2.0 proposal
#20724
| https://github.com/nodejs/node/pull/20724 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| May 14, 2018 | https://github.com/nodejs/node/pull/20587#event-1625592541 |
| https://github.com/yhwang |
| yhwang | https://github.com/yhwang |
| May 16, 2018 05:35 | https://github.com/nodejs/node/pull/20587#event-1628751287 |
| https://github.com/yhwang |
| yhwang | https://github.com/yhwang |
| May 31, 2018 | https://github.com/nodejs/node/pull/20587#issuecomment-393414911 |
| @bnoordhuis | https://github.com/bnoordhuis |
| openssl/openssl#6266 | https://github.com/openssl/openssl/pull/6266 |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20587 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/20587/files/8f934329305dea09286d69d3140135d0bd975de8 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/20587 |
|
| https://github.com/yhwang |
|
| https://github.com/targos |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |