René's URL Explorer Experiment


Title: test: add tests for fsPromises.chown to increase coverage by shisama · Pull Request #20574 · nodejs/node · GitHub

Open Graph Title: test: add tests for fsPromises.chown to increase coverage by shisama · Pull Request #20574 · nodejs/node

X Title: test: add tests for fsPromises.chown to increase coverage by shisama · Pull Request #20574 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: To increase test coverage for fs/promises, add tests for methods chown(), filehandle.chown() and lchown(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...

X Description: To increase test coverage for fs/promises, add tests for methods chown(), filehandle.chown() and lchown(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...

Opengraph URL: https://github.com/nodejs/node/pull/20574

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f371a755-aad6-96bb-9b2b-200dbe59e437
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC57E:3C612:1EF2D17:272AB60:6991915B
html-safe-nonce4860104050742ca56bab4671aa0decf373cb1459260596ed1dbe4c59fb0ee974
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTdFOjNDNjEyOjFFRjJEMTc6MjcyQUI2MDo2OTkxOTE1QiIsInZpc2l0b3JfaWQiOiI4ODk5NTk3OTM5MDYxNjU3OTQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd1cec7fead8110321dbe063b1d824a9fd6328aee6f1aa91a3fa5e57ed5ecabfd
hovercard-subject-tagpull_request:186335259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20574/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/267355c7ad42e3dd6994c5f1aefa9c75c0b2fee1a6fabbb3b658f42c24fbc623/nodejs/node/pull/20574
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/267355c7ad42e3dd6994c5f1aefa9c75c0b2fee1a6fabbb3b658f42c24fbc623/nodejs/node/pull/20574
og:image:altTo increase test coverage for fs/promises, add tests for methods chown(), filehandle.chown() and lchown(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshisama
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20574#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20574
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20574
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20574
Reloadhttps://github.com/nodejs/node/pull/20574
Reloadhttps://github.com/nodejs/node/pull/20574
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20574
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
shisamahttps://github.com/shisama
nodejs:masterhttps://github.com/nodejs/node/tree/master
shisama:test-fs-promises-chownhttps://github.com/shisama/node/tree/test-fs-promises-chown
Conversationhttps://github.com/nodejs/node/pull/20574
Commits4 (4)https://github.com/nodejs/node/pull/20574/commits
Checkshttps://github.com/nodejs/node/pull/20574/checks
Files changedhttps://github.com/nodejs/node/pull/20574/files
test: add tests for fsPromises.chown to increase coveragehttps://github.com/nodejs/node/pull/20574#top
shisamahttps://github.com/shisama
nodejs:masterhttps://github.com/nodejs/node/tree/master
shisama:test-fs-promises-chownhttps://github.com/shisama/node/tree/test-fs-promises-chown
https://github.com/shisama
shisamahttps://github.com/shisama
May 7, 2018https://github.com/nodejs/node/pull/20574#issue-320782875
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 7, 2018https://github.com/nodejs/node/pull/20574#event-1612792777
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
May 8, 2018https://github.com/nodejs/node/pull/20574#event-1614625708
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-121269987
View reviewed changes https://github.com/nodejs/node/pull/20574/files
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/20574#issuecomment-390070681
https://ci.nodejs.org/job/node-test-pull-request/14945/https://ci.nodejs.org/job/node-test-pull-request/14945/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 18, 2018https://github.com/nodejs/node/pull/20574#event-1633316783
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-121623512
View reviewed changes https://github.com/nodejs/node/pull/20574/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 21, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-121765795
View reviewed changes https://github.com/nodejs/node/pull/20574/files
test/parallel/test-fs-promises.jshttps://github.com/nodejs/node/pull/20574/files#diff-1ff0d07958f5cf5b0aef4a7cf63f5f14fe08abe050cee2bb0a4f9d0869e30033
cjihrighttps://github.com/cjihrig
May 21, 2018https://github.com/nodejs/node/pull/20574#discussion_r189563946
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20574
shisamahttps://github.com/shisama
May 22, 2018https://github.com/nodejs/node/pull/20574#discussion_r189795750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
May 21, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-121934295
View reviewed changes https://github.com/nodejs/node/pull/20574/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/20574#pullrequestreview-121934295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/e7b2fdfcdcf5ebb1c7725c7d3a75ee2eb115ef73..b4fd1854e78ab520b07897719d148b690cee0d5a
e7b2fdfhttps://github.com/nodejs/node/commit/e7b2fdfcdcf5ebb1c7725c7d3a75ee2eb115ef73
b4fd185https://github.com/nodejs/node/commit/b4fd1854e78ab520b07897719d148b690cee0d5a
Compare https://github.com/nodejs/node/compare/e7b2fdfcdcf5ebb1c7725c7d3a75ee2eb115ef73..b4fd1854e78ab520b07897719d148b690cee0d5a
May 22, 2018 07:18https://github.com/nodejs/node/pull/20574#event-1638567151
https://github.com/Trott
Trotthttps://github.com/Trott
May 22, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391103177
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://ci.nodejs.org/job/node-test-pull-request/15028/https://ci.nodejs.org/job/node-test-pull-request/15028/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 22, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-122307839
View reviewed changes https://github.com/nodejs/node/pull/20574/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/20574#pullrequestreview-121934295
May 22, 2018 18:59https://github.com/nodejs/node/pull/20574#event-1640119522
https://github.com/Trott
Trotthttps://github.com/Trott
May 22, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391104997
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
May 22, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-122345878
View reviewed changes https://github.com/nodejs/node/pull/20574/files
Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/nodejs/node/pull/20574#pullrequestreview-122345878
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/shisama
shisamahttps://github.com/shisama
May 23, 2018https://github.com/nodejs/node/pull/20574#event-1640823402
https://github.com/shisama
shisamahttps://github.com/shisama
May 23, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391215499
@Trotthttps://github.com/Trott
https://nodejs.org/api/fs.html#fs_fspromises_lchown_path_uid_gidhttps://nodejs.org/api/fs.html#fs_fspromises_lchown_path_uid_gid
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
May 23, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391227858
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://ci.nodejs.org/job/node-test-pull-request/15047/https://ci.nodejs.org/job/node-test-pull-request/15047/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 23, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391372275
https://ci.nodejs.org/job/node-test-pull-request/15056/https://ci.nodejs.org/job/node-test-pull-request/15056/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/shisama
shisamahttps://github.com/shisama
May 24, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391560976
@jasnellhttps://github.com/jasnell
#20907https://github.com/nodejs/node/issues/20907
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 24, 2018https://github.com/nodejs/node/pull/20574#issuecomment-391803387
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 28, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-123782694
View reviewed changes https://github.com/nodejs/node/pull/20574/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/20574#pullrequestreview-123782694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 29, 2018https://github.com/nodejs/node/pull/20574#issuecomment-392913507
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
May 31, 2018https://github.com/nodejs/node/pull/20574#issuecomment-393378037
https://ci.nodejs.org/job/node-test-pull-request/15174/https://ci.nodejs.org/job/node-test-pull-request/15174/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
May 31, 2018https://github.com/nodejs/node/pull/20574#issuecomment-393378233
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/511e7441ce7d855a5a6808cebf53e38e178e0575..0e3a4ca9b36c48a712a90aa393e6cf2b308c934d
511e744https://github.com/nodejs/node/commit/511e7441ce7d855a5a6808cebf53e38e178e0575
0e3a4cahttps://github.com/nodejs/node/commit/0e3a4ca9b36c48a712a90aa393e6cf2b308c934d
Compare https://github.com/nodejs/node/compare/511e7441ce7d855a5a6808cebf53e38e178e0575..0e3a4ca9b36c48a712a90aa393e6cf2b308c934d
May 31, 2018 03:36https://github.com/nodejs/node/pull/20574#event-1655056953
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/a41e7463a4c6796cd725b339bd5c5930d94c00c0..8041fa3eb36ea062d8ccb5d586d2b8f120e8d181
a41e746https://github.com/nodejs/node/commit/a41e7463a4c6796cd725b339bd5c5930d94c00c0
8041fa3https://github.com/nodejs/node/commit/8041fa3eb36ea062d8ccb5d586d2b8f120e8d181
Compare https://github.com/nodejs/node/compare/a41e7463a4c6796cd725b339bd5c5930d94c00c0..8041fa3eb36ea062d8ccb5d586d2b8f120e8d181
June 12, 2018 00:59https://github.com/nodejs/node/pull/20574#event-1675184422
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/8041fa3eb36ea062d8ccb5d586d2b8f120e8d181..012b2cc5df12a0e3d6afd878e4b05e2714467ac1
8041fa3https://github.com/nodejs/node/commit/8041fa3eb36ea062d8ccb5d586d2b8f120e8d181
012b2cchttps://github.com/nodejs/node/commit/012b2cc5df12a0e3d6afd878e4b05e2714467ac1
Compare https://github.com/nodejs/node/compare/8041fa3eb36ea062d8ccb5d586d2b8f120e8d181..012b2cc5df12a0e3d6afd878e4b05e2714467ac1
June 21, 2018 15:56https://github.com/nodejs/node/pull/20574#event-1694040083
https://github.com/shisama
shisamahttps://github.com/shisama
Jun 22, 2018https://github.com/nodejs/node/pull/20574#issuecomment-399284644
@Trotthttps://github.com/Trott
#21322https://github.com/nodejs/node/pull/21322
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 22, 2018https://github.com/nodejs/node/pull/20574#issuecomment-399313560
@Trotthttps://github.com/Trott
#21322https://github.com/nodejs/node/pull/21322
@shisamahttps://github.com/shisama
https://ci.nodejs.org/job/node-test-pull-request/15560/https://ci.nodejs.org/job/node-test-pull-request/15560/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 25, 2018https://github.com/nodejs/node/pull/20574#issuecomment-399847934
@Trotthttps://github.com/Trott
@mhdawsonhttps://github.com/mhdawson
@cjihrighttps://github.com/cjihrig
@jasnellhttps://github.com/jasnell
@BridgeARhttps://github.com/BridgeAR
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 25, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-131746253
View reviewed changes https://github.com/nodejs/node/pull/20574/files
test/parallel/test-fs-promises.jshttps://github.com/nodejs/node/pull/20574/files#diff-1ff0d07958f5cf5b0aef4a7cf63f5f14fe08abe050cee2bb0a4f9d0869e30033
cjihrighttps://github.com/cjihrig
Jun 25, 2018https://github.com/nodejs/node/pull/20574#discussion_r197910576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#21498https://github.com/nodejs/node/pull/21498
Please reload this pagehttps://github.com/nodejs/node/pull/20574
shisamahttps://github.com/shisama
Jul 1, 2018https://github.com/nodejs/node/pull/20574#discussion_r199351233
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20574
shisamahttps://github.com/shisama
Jul 19, 2018https://github.com/nodejs/node/pull/20574#discussion_r203596185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/20574#pullrequestreview-122345878
June 26, 2018 05:15https://github.com/nodejs/node/pull/20574#event-1700474301
https://github.com/shisama
shisamahttps://github.com/shisama
force-pushedhttps://github.com/nodejs/node/compare/f2d508bbee8ed9754371c1d26d8ba7946e78c271..345ddc5702949dd82ed1740cbd7f629dd232661f
f2d508bhttps://github.com/nodejs/node/commit/f2d508bbee8ed9754371c1d26d8ba7946e78c271
345ddc5https://github.com/nodejs/node/commit/345ddc5702949dd82ed1740cbd7f629dd232661f
Compare https://github.com/nodejs/node/compare/f2d508bbee8ed9754371c1d26d8ba7946e78c271..345ddc5702949dd82ed1740cbd7f629dd232661f
July 1, 2018 14:12https://github.com/nodejs/node/pull/20574#event-1710306513
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jul 1, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-133462316
View reviewed changes https://github.com/nodejs/node/pull/20574/files
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Jul 10, 2018 https://github.com/nodejs/node/pull/20574#ref-issue-318996925
fs/promises test coverage is poor. #20435 https://github.com/nodejs/node/issues/20435
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 30, 2018https://github.com/nodejs/node/pull/20574#event-1759100165
July 29, 2018 20:39https://github.com/nodejs/node/pull/20574#commits-pushed-7521a3e
https://github.com/TimothyGu
test: add tests for fs/promises chown to increase coveragehttps://github.com/nodejs/node/pull/20574/commits/7521a3e06f3d159849ce9b9848f0a6058d2ce82b
7521a3ehttps://github.com/nodejs/node/pull/20574/commits/7521a3e06f3d159849ce9b9848f0a6058d2ce82b
https://github.com/TimothyGu
test: fix failure in test-fs-promises on Windowshttps://github.com/nodejs/node/pull/20574/commits/ed2faa8a191e7752f354099eee2cb46900e9e767
ed2faa8https://github.com/nodejs/node/pull/20574/commits/ed2faa8a191e7752f354099eee2cb46900e9e767
https://github.com/TimothyGu
test: add fsPromises.chown error testhttps://github.com/nodejs/node/pull/20574/commits/d195aca9dae867e2c197efc9650f02d91be69f2c
d195acahttps://github.com/nodejs/node/pull/20574/commits/d195aca9dae867e2c197efc9650f02d91be69f2c
https://github.com/TimothyGu
test: call fsPromises.lchown() on non-Windowshttps://github.com/nodejs/node/pull/20574/commits/b1183ac1bf6d4a1d44dc39e89f427f1e97e735ab
b1183achttps://github.com/nodejs/node/pull/20574/commits/b1183ac1bf6d4a1d44dc39e89f427f1e97e735ab
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018 https://github.com/nodejs/node/pull/20574#pullrequestreview-141367412
View reviewed changes https://github.com/nodejs/node/pull/20574/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
force-pushedhttps://github.com/nodejs/node/compare/345ddc5702949dd82ed1740cbd7f629dd232661f..b1183ac1bf6d4a1d44dc39e89f427f1e97e735ab
345ddc5https://github.com/nodejs/node/commit/345ddc5702949dd82ed1740cbd7f629dd232661f
b1183achttps://github.com/nodejs/node/commit/b1183ac1bf6d4a1d44dc39e89f427f1e97e735ab
Compare https://github.com/nodejs/node/compare/345ddc5702949dd82ed1740cbd7f629dd232661f..b1183ac1bf6d4a1d44dc39e89f427f1e97e735ab
July 30, 2018 00:41https://github.com/nodejs/node/pull/20574#event-1759102135
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018https://github.com/nodejs/node/pull/20574#issuecomment-408718088
https://ci.nodejs.org/job/node-test-pull-request/16070/https://ci.nodejs.org/job/node-test-pull-request/16070/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018https://github.com/nodejs/node/pull/20574#event-1759102823
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018https://github.com/nodejs/node/pull/20574#issuecomment-408755830
https://ci.nodejs.org/job/node-test-commit-windows-fanned/19550/https://ci.nodejs.org/job/node-test-commit-windows-fanned/19550/
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018https://github.com/nodejs/node/pull/20574#issuecomment-408940342
a4ce449https://github.com/nodejs/node/commit/a4ce449bb7b0e2f9edba75baf2a2f652a6750454
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018https://github.com/nodejs/node/pull/20574#event-1760733536
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 30, 2018https://github.com/nodejs/node/pull/20574#event-1760736210
TimothyGuhttps://github.com/TimothyGu
Jul 30, 2018 https://github.com/nodejs/node/pull/20574#ref-commit-a4ce449
https://github.com/TimothyGu
test: add tests for fs/promises chown functionshttps://github.com/nodejs/node/commit/a4ce449bb7b0e2f9edba75baf2a2f652a6750454
a4ce449https://github.com/nodejs/node/commit/a4ce449bb7b0e2f9edba75baf2a2f652a6750454
#20574https://github.com/nodejs/node/pull/20574
targoshttps://github.com/targos
Jul 31, 2018 https://github.com/nodejs/node/pull/20574#ref-commit-4510ca3
https://github.com/targos
test: add tests for fs/promises chown functionshttps://github.com/nodejs/node/commit/4510ca349ec7434424c435bad859dfa4e78d4585
4510ca3https://github.com/nodejs/node/commit/4510ca349ec7434424c435bad859dfa4e78d4585
#20574https://github.com/nodejs/node/pull/20574
https://github.com/targos
targoshttps://github.com/targos
Jul 31, 2018 https://github.com/nodejs/node/pull/20574#ref-pullrequest-346084280
v10.8.0 proposal #22040 https://github.com/nodejs/node/pull/22040
2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-nodejs#212 https://github.com/beevelop/docker-nodejs/issues/212
2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#223 https://github.com/beevelop/docker-android-nodejs/issues/223
2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#224 https://github.com/beevelop/docker-android-nodejs/issues/224
2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#225 https://github.com/beevelop/docker-android-nodejs/issues/225
2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#226 https://github.com/beevelop/docker-android-nodejs/issues/226
2018-08-01 Version 10.8.0 (Current) @targos beevelop/docker-android-nodejs#227 https://github.com/beevelop/docker-android-nodejs/issues/227
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20574
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20574/files/f2d508bbee8ed9754371c1d26d8ba7946e78c271
https://github.com/ChALkeR
ChALkeR https://github.com/ChALkeR
https://github.com/nodejs/node/pull/20574/files/345ddc5702949dd82ed1740cbd7f629dd232661f
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20574/files/e19121e28f2ecb2609f845a22d9460a34b57d428
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20574/files/e19121e28f2ecb2609f845a22d9460a34b57d428
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/20574/files/511e7441ce7d855a5a6808cebf53e38e178e0575
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/20574/files/45703c5b122f27923c318a84ec64e875107fddc9
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20574/files/345ddc5702949dd82ed1740cbd7f629dd232661f
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/20574
https://github.com/shisama
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/jasnell
https://github.com/apapirovski
https://github.com/TimothyGu
https://github.com/ChALkeR
https://github.com/cjihrig
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.