René's URL Explorer Experiment


Title: src: minor refactor to string_search.h by addaleax · Pull Request #20546 · nodejs/node · GitHub

Open Graph Title: src: minor refactor to string_search.h by addaleax · Pull Request #20546 · nodejs/node

X Title: src: minor refactor to string_search.h by addaleax · Pull Request #20546 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Use std::max instead of a custom variant Use member method pointers to avoid an extra layer of indirection Stop transferring Vector into the node namespace Checklist make -j4 test (UNIX), or v...

X Description: Use std::max instead of a custom variant Use member method pointers to avoid an extra layer of indirection Stop transferring Vector into the node namespace Checklist make -j4 test (UNIX), or v...

Opengraph URL: https://github.com/nodejs/node/pull/20546

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3031452b-b653-c1c7-765f-b3d97150e73c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB118:9618A:18937B7:1F4FE3B:6991ADE2
html-safe-nonce49101c520dba1008db6adc8b97a9d87f26e3d8ccffb879cc8fcfe9ddc127c347
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE4Ojk2MThBOjE4OTM3Qjc6MUY0RkUzQjo2OTkxQURFMiIsInZpc2l0b3JfaWQiOiIyNTc5NjE5MzEwMzU3MDMyNDE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac55f77881c72299235d416c4634270bf8d16e24e2f30a3ba07b1ea827f9175ea7
hovercard-subject-tagpull_request:186167055
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20546/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38fd8d234ba230dece1b4d7dd36e5ba301af12724faedc6b5f40b5326b849408/nodejs/node/pull/20546
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38fd8d234ba230dece1b4d7dd36e5ba301af12724faedc6b5f40b5326b849408/nodejs/node/pull/20546
og:image:altUse std::max instead of a custom variant Use member method pointers to avoid an extra layer of indirection Stop transferring Vector into the node namespace Checklist make -j4 test (UNIX), or v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20546#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20546
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20546
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20546
Reloadhttps://github.com/nodejs/node/pull/20546
Reloadhttps://github.com/nodejs/node/pull/20546
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20546
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:stringsearch-refactorhttps://github.com/addaleax/node/tree/stringsearch-refactor
Conversationhttps://github.com/nodejs/node/pull/20546
Commits1 (1)https://github.com/nodejs/node/pull/20546/commits
Checkshttps://github.com/nodejs/node/pull/20546/checks
Files changedhttps://github.com/nodejs/node/pull/20546/files
src: minor refactor to string_search.hhttps://github.com/nodejs/node/pull/20546#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:stringsearch-refactorhttps://github.com/addaleax/node/tree/stringsearch-refactor
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2018https://github.com/nodejs/node/pull/20546#issue-320526900
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20546
https://github.com/addaleax
src: minor refactor to string_search.hhttps://github.com/nodejs/node/pull/20546/commits/19566777de5c3f22bc3519af7de9613407b27f71
1956677https://github.com/nodejs/node/pull/20546/commits/19566777de5c3f22bc3519af7de9613407b27f71
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
May 5, 2018https://github.com/nodejs/node/pull/20546#event-1611357834
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2018https://github.com/nodejs/node/pull/20546#issuecomment-386821903
https://ci.nodejs.org/job/node-test-commit/18252/https://ci.nodejs.org/job/node-test-commit/18252/
Please reload this pagehttps://github.com/nodejs/node/pull/20546
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2018https://github.com/nodejs/node/pull/20546#issuecomment-386827102
https://ci.nodejs.org/job/node-test-commit-freebsd/17534/https://ci.nodejs.org/job/node-test-commit-freebsd/17534/
Please reload this pagehttps://github.com/nodejs/node/pull/20546
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 6, 2018 https://github.com/nodejs/node/pull/20546#pullrequestreview-117849765
View reviewed changes https://github.com/nodejs/node/pull/20546/files/19566777de5c3f22bc3519af7de9613407b27f71
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 6, 2018https://github.com/nodejs/node/pull/20546#event-1611808670
https://github.com/danbev
danbevhttps://github.com/danbev
May 7, 2018 https://github.com/nodejs/node/pull/20546#pullrequestreview-117885074
View reviewed changes https://github.com/nodejs/node/pull/20546/files/19566777de5c3f22bc3519af7de9613407b27f71
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 7, 2018 https://github.com/nodejs/node/pull/20546#pullrequestreview-118019351
View reviewed changes https://github.com/nodejs/node/pull/20546/files/19566777de5c3f22bc3519af7de9613407b27f71
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018https://github.com/nodejs/node/pull/20546#issuecomment-387794383
9873875https://github.com/nodejs/node/commit/987387534aba3f23346e5b076058fcb567651389
Please reload this pagehttps://github.com/nodejs/node/pull/20546
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018https://github.com/nodejs/node/pull/20546#event-1618023612
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 9, 2018 16:18https://github.com/nodejs/node/pull/20546#event-1618023731
addaleaxhttps://github.com/addaleax
May 9, 2018 https://github.com/nodejs/node/pull/20546#ref-commit-9873875
https://github.com/addaleax
src: minor refactor to string_search.hhttps://github.com/nodejs/node/commit/987387534aba3f23346e5b076058fcb567651389
9873875https://github.com/nodejs/node/commit/987387534aba3f23346e5b076058fcb567651389
#20546https://github.com/nodejs/node/pull/20546
targoshttps://github.com/targos
May 12, 2018 https://github.com/nodejs/node/pull/20546#ref-commit-5803973
https://github.com/addaleax
https://github.com/targos
src: minor refactor to string_search.hhttps://github.com/nodejs/node/commit/5803973206af7c60c6cbc186afdc38d5c8fae65f
5803973https://github.com/nodejs/node/commit/5803973206af7c60c6cbc186afdc38d5c8fae65f
#20546https://github.com/nodejs/node/pull/20546
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20546#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20546
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20546/files/19566777de5c3f22bc3519af7de9613407b27f71
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/20546/files/19566777de5c3f22bc3519af7de9613407b27f71
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20546/files/19566777de5c3f22bc3519af7de9613407b27f71
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/20546
https://github.com/addaleax
https://github.com/danbev
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.