René's URL Explorer Experiment


Title: assert: make sure throws is able to handle primitives by BridgeAR · Pull Request #20482 · nodejs/node · GitHub

Open Graph Title: assert: make sure throws is able to handle primitives by BridgeAR · Pull Request #20482 · nodejs/node

X Title: assert: make sure throws is able to handle primitives by BridgeAR · Pull Request #20482 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes some possible issues with assert.throws in combination with an validation object. It will now properly handle primitive values being thrown as error. It also makes sure the generatedMess...

X Description: This fixes some possible issues with assert.throws in combination with an validation object. It will now properly handle primitive values being thrown as error. It also makes sure the generatedMess...

Opengraph URL: https://github.com/nodejs/node/pull/20482

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3903327-fb26-389a-79eb-eac63da62ba7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DEC:1E8EEE:A9B826:D9242C:69922D96
html-safe-nonced53ff97845b2f98ff0909ab0373fd46b064cc9441a58bdda24ea6132aa96e3ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REVDOjFFOEVFRTpBOUI4MjY6RDkyNDJDOjY5OTIyRDk2IiwidmlzaXRvcl9pZCI6IjgxMDUyMjg1MjkxODczMDI4MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccad19b0332629dc54a1c9f9b44f1cff1749e55f2e67fe5c26b56d4da6030f50e
hovercard-subject-tagpull_request:185571242
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20482/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/16e700d8a2f1b071feb0fa53fdf712af78f08afef34bb95273ef094c19756108/nodejs/node/pull/20482
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/16e700d8a2f1b071feb0fa53fdf712af78f08afef34bb95273ef094c19756108/nodejs/node/pull/20482
og:image:altThis fixes some possible issues with assert.throws in combination with an validation object. It will now properly handle primitive values being thrown as error. It also makes sure the generatedMess...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20482#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20482
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20482
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20482
Reloadhttps://github.com/nodejs/node/pull/20482
Reloadhttps://github.com/nodejs/node/pull/20482
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20482
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-assertion-thingshttps://github.com/BridgeAR/node/tree/fix-assertion-things
Conversationhttps://github.com/nodejs/node/pull/20482
Commits1 (1)https://github.com/nodejs/node/pull/20482/commits
Checkshttps://github.com/nodejs/node/pull/20482/checks
Files changedhttps://github.com/nodejs/node/pull/20482/files
assert: make sure throws is able to handle primitiveshttps://github.com/nodejs/node/pull/20482#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:fix-assertion-thingshttps://github.com/BridgeAR/node/tree/fix-assertion-things
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018https://github.com/nodejs/node/pull/20482#issue-319725337
Please reload this pagehttps://github.com/nodejs/node/pull/20482
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
May 2, 2018https://github.com/nodejs/node/pull/20482#event-1606533082
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018https://github.com/nodejs/node/pull/20482#issuecomment-386136096
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://ci.nodejs.org/job/node-test-pull-request/14639/https://ci.nodejs.org/job/node-test-pull-request/14639/
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 3, 2018https://github.com/nodejs/node/pull/20482#issuecomment-386194479
Please reload this pagehttps://github.com/nodejs/node/pull/20482
#20487https://github.com/nodejs/node/pull/20487
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
May 6, 2018https://github.com/nodejs/node/pull/20482#event-1611832782
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
May 7, 2018https://github.com/nodejs/node/pull/20482#event-1612704387
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/c3026d9ea4084f5f805a0d4740838b4e1ddc2525..6b1f886efbe226c321eb8c24725b9c5b52de8793
c3026d9https://github.com/nodejs/node/commit/c3026d9ea4084f5f805a0d4740838b4e1ddc2525
6b1f886https://github.com/nodejs/node/commit/6b1f886efbe226c321eb8c24725b9c5b52de8793
Compare https://github.com/nodejs/node/compare/c3026d9ea4084f5f805a0d4740838b4e1ddc2525..6b1f886efbe226c321eb8c24725b9c5b52de8793
May 7, 2018 11:24https://github.com/nodejs/node/pull/20482#event-1612705265
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 7, 2018https://github.com/nodejs/node/pull/20482#issuecomment-387035899
https://ci.nodejs.org/job/node-test-pull-request/14696/https://ci.nodejs.org/job/node-test-pull-request/14696/
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 7, 2018https://github.com/nodejs/node/pull/20482#issuecomment-387038726
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 7, 2018https://github.com/nodejs/node/pull/20482#issuecomment-387041140
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 7, 2018https://github.com/nodejs/node/pull/20482#issuecomment-387042236
https://ci.nodejs.org/job/node-test-pull-request/14698/https://ci.nodejs.org/job/node-test-pull-request/14698/
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 9, 2018https://github.com/nodejs/node/pull/20482#issuecomment-387803117
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 9, 2018 https://github.com/nodejs/node/pull/20482#pullrequestreview-118825320
View reviewed changes https://github.com/nodejs/node/pull/20482/files
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 9, 2018https://github.com/nodejs/node/pull/20482#event-1618148614
https://github.com/targos
targoshttps://github.com/targos
May 10, 2018 https://github.com/nodejs/node/pull/20482#pullrequestreview-119036305
View reviewed changes https://github.com/nodejs/node/pull/20482/files
https://github.com/BridgeAR
assert: make sure throws is able to handle primitiveshttps://github.com/nodejs/node/pull/20482/commits/34b48183644eb37f7552c3868fca9552bf7711c3
34b4818https://github.com/nodejs/node/pull/20482/commits/34b48183644eb37f7552c3868fca9552bf7711c3
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/ee4907aaa0c1e53c8ed7af4a186496acf7344186..34b48183644eb37f7552c3868fca9552bf7711c3
ee4907ahttps://github.com/nodejs/node/commit/ee4907aaa0c1e53c8ed7af4a186496acf7344186
34b4818https://github.com/nodejs/node/commit/34b48183644eb37f7552c3868fca9552bf7711c3
Compare https://github.com/nodejs/node/compare/ee4907aaa0c1e53c8ed7af4a186496acf7344186..34b48183644eb37f7552c3868fca9552bf7711c3
May 10, 2018 11:25https://github.com/nodejs/node/pull/20482#event-1619584611
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018https://github.com/nodejs/node/pull/20482#issuecomment-388027719
https://ci.nodejs.org/job/node-test-pull-request/14781/https://ci.nodejs.org/job/node-test-pull-request/14781/
Please reload this pagehttps://github.com/nodejs/node/pull/20482
BridgeARhttps://github.com/BridgeAR
May 10, 2018 https://github.com/nodejs/node/pull/20482#ref-commit-560925f
https://github.com/BridgeAR
assert: make sure throws is able to handle primitiveshttps://github.com/BridgeAR/node/commit/560925fe22bfc23860b04704ff4cae21e4dd19ff
560925fhttps://github.com/BridgeAR/node/commit/560925fe22bfc23860b04704ff4cae21e4dd19ff
nodejs#20482https://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018https://github.com/nodejs/node/pull/20482#issuecomment-388036362
560925fhttps://github.com/nodejs/node/commit/560925fe22bfc23860b04704ff4cae21e4dd19ff
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018https://github.com/nodejs/node/pull/20482#event-1619652537
targoshttps://github.com/targos
May 12, 2018 https://github.com/nodejs/node/pull/20482#ref-commit-bb857d9
https://github.com/BridgeAR
https://github.com/targos
assert: make sure throws is able to handle primitiveshttps://github.com/nodejs/node/commit/bb857d9e71e98614a6ca9efc6363be565dc4df54
bb857d9https://github.com/nodejs/node/commit/bb857d9e71e98614a6ca9efc6363be565dc4df54
#20482https://github.com/nodejs/node/pull/20482
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20482#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:31https://github.com/nodejs/node/pull/20482#event-2962607452
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20482
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20482/files/ee4907aaa0c1e53c8ed7af4a186496acf7344186
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/20482/files/ee4907aaa0c1e53c8ed7af4a186496acf7344186
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Please reload this pagehttps://github.com/nodejs/node/pull/20482
https://github.com/BridgeAR
https://github.com/addaleax
https://github.com/jasnell
https://github.com/targos
https://github.com/vsemozhetbyt
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.