René's URL Explorer Experiment


Title: assert: validate input stricter by BridgeAR · Pull Request #20481 · nodejs/node · GitHub

Open Graph Title: assert: validate input stricter by BridgeAR · Pull Request #20481 · nodejs/node

X Title: assert: validate input stricter by BridgeAR · Pull Request #20481 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This makes sure invalid error objects are not ignored when using assert.throws and assert.rejects. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...

X Description: This makes sure invalid error objects are not ignored when using assert.throws and assert.rejects. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...

Opengraph URL: https://github.com/nodejs/node/pull/20481

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:180b49f3-9489-6c9a-f568-7409be73b290
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB0C:118805:1DF4591:264529E:69927F6D
html-safe-nonce376003f21746eae881293e38eb38c8fc7f892d4584274de545079c478e912a73
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjBDOjExODgwNToxREY0NTkxOjI2NDUyOUU6Njk5MjdGNkQiLCJ2aXNpdG9yX2lkIjoiMjg5NTc3NDQ1NTc2NTgyNzQzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac50168699033b6a4efb444ce947a8450f07e4b0e36ae91f971be95dbebfe9a739
hovercard-subject-tagpull_request:185571106
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20481/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5b15adb6453f7b9d14dbeb2d9a023cd65cd62e74684c7689b6ee122a2a72149c/nodejs/node/pull/20481
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b15adb6453f7b9d14dbeb2d9a023cd65cd62e74684c7689b6ee122a2a72149c/nodejs/node/pull/20481
og:image:altThis makes sure invalid error objects are not ignored when using assert.throws and assert.rejects. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20481#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20481
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20481
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20481
Reloadhttps://github.com/nodejs/node/pull/20481
Reloadhttps://github.com/nodejs/node/pull/20481
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20481
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:assert-stricter-input-validationhttps://github.com/BridgeAR/node/tree/assert-stricter-input-validation
Conversationhttps://github.com/nodejs/node/pull/20481
Commits1 (1)https://github.com/nodejs/node/pull/20481/commits
Checkshttps://github.com/nodejs/node/pull/20481/checks
Files changedhttps://github.com/nodejs/node/pull/20481/files
assert: validate input stricterhttps://github.com/nodejs/node/pull/20481#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:assert-stricter-input-validationhttps://github.com/BridgeAR/node/tree/assert-stricter-input-validation
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018https://github.com/nodejs/node/pull/20481#issue-319725150
Please reload this pagehttps://github.com/nodejs/node/pull/20481
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
May 2, 2018https://github.com/nodejs/node/pull/20481#event-1606531935
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
May 2, 2018https://github.com/nodejs/node/pull/20481#event-1606548941
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
apapirovskihttps://github.com/apapirovski
May 2, 2018 22:03https://github.com/nodejs/node/pull/20481#event-1606549024
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018https://github.com/nodejs/node/pull/20481#issuecomment-386135896
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://ci.nodejs.org/job/node-test-pull-request/14638/https://ci.nodejs.org/job/node-test-pull-request/14638/
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
apapirovskihttps://github.com/apapirovski
May 2, 2018 22:04https://github.com/nodejs/node/pull/20481#event-1606549801
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/719f3af76047711d0c1fd90c9867d468a4d85fe2..5eff6a5c42e17e257747ab9fc067c323ce5ab0d1
719f3afhttps://github.com/nodejs/node/commit/719f3af76047711d0c1fd90c9867d468a4d85fe2
5eff6a5https://github.com/nodejs/node/commit/5eff6a5c42e17e257747ab9fc067c323ce5ab0d1
Compare https://github.com/nodejs/node/compare/719f3af76047711d0c1fd90c9867d468a4d85fe2..5eff6a5c42e17e257747ab9fc067c323ce5ab0d1
May 2, 2018 22:26https://github.com/nodejs/node/pull/20481#event-1606579077
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018https://github.com/nodejs/node/pull/20481#issuecomment-386140916
Please reload this pagehttps://github.com/nodejs/node/pull/20481
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018https://github.com/nodejs/node/pull/20481#issuecomment-386153116
bdf5be9#r28831219https://github.com/nodejs/node/commit/bdf5be98dd901f6c312938198439dbda0b20d517#r28831219
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 3, 2018https://github.com/nodejs/node/pull/20481#issuecomment-386194521
Please reload this pagehttps://github.com/nodejs/node/pull/20481
#20487https://github.com/nodejs/node/pull/20487
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/Trott
Trotthttps://github.com/Trott
May 3, 2018https://github.com/nodejs/node/pull/20481#issuecomment-386196405
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 4, 2018 https://github.com/nodejs/node/pull/20481#pullrequestreview-117467404
View reviewed changes https://github.com/nodejs/node/pull/20481/files
https://github.com/Trott
Trotthttps://github.com/Trott
May 4, 2018https://github.com/nodejs/node/pull/20481#issuecomment-386659284
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/5eff6a5c42e17e257747ab9fc067c323ce5ab0d1..d1c2c463eb43109ef5e65e738edddecbc7d4b402
5eff6a5https://github.com/nodejs/node/commit/5eff6a5c42e17e257747ab9fc067c323ce5ab0d1
d1c2c46https://github.com/nodejs/node/commit/d1c2c463eb43109ef5e65e738edddecbc7d4b402
Compare https://github.com/nodejs/node/compare/5eff6a5c42e17e257747ab9fc067c323ce5ab0d1..d1c2c463eb43109ef5e65e738edddecbc7d4b402
May 7, 2018 11:28https://github.com/nodejs/node/pull/20481#event-1612710617
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 7, 2018https://github.com/nodejs/node/pull/20481#issuecomment-387036991
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://ci.nodejs.org/job/node-test-pull-request/14697/https://ci.nodejs.org/job/node-test-pull-request/14697/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1401/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1401/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1402/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1402/
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 7, 2018https://github.com/nodejs/node/pull/20481#event-1614091725
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 7, 2018 23:08https://github.com/nodejs/node/pull/20481#event-1614091779
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 8, 2018 https://github.com/nodejs/node/pull/20481#pullrequestreview-118463236
View reviewed changes https://github.com/nodejs/node/pull/20481/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/20481#pullrequestreview-118463236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/targos
targoshttps://github.com/targos
May 10, 2018 https://github.com/nodejs/node/pull/20481#pullrequestreview-119043009
View reviewed changes https://github.com/nodejs/node/pull/20481/files
https://github.com/BridgeAR
assert: validate input stricterhttps://github.com/nodejs/node/pull/20481/commits/f8a902375ced3e92f19129e89388ea0879b1845b
f8a9023https://github.com/nodejs/node/pull/20481/commits/f8a902375ced3e92f19129e89388ea0879b1845b
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/d1c2c463eb43109ef5e65e738edddecbc7d4b402..f8a902375ced3e92f19129e89388ea0879b1845b
d1c2c46https://github.com/nodejs/node/commit/d1c2c463eb43109ef5e65e738edddecbc7d4b402
f8a9023https://github.com/nodejs/node/commit/f8a902375ced3e92f19129e89388ea0879b1845b
Compare https://github.com/nodejs/node/compare/d1c2c463eb43109ef5e65e738edddecbc7d4b402..f8a902375ced3e92f19129e89388ea0879b1845b
May 10, 2018 12:17https://github.com/nodejs/node/pull/20481#event-1619656555
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018https://github.com/nodejs/node/pull/20481#issuecomment-388039941
https://ci.nodejs.org/job/node-test-pull-request/14784/https://ci.nodejs.org/job/node-test-pull-request/14784/
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018https://github.com/nodejs/node/pull/20481#issuecomment-388053101
21c3a40https://github.com/nodejs/node/commit/21c3a402d486234fb00fcb130802b8fcabd97de8
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 10, 2018https://github.com/nodejs/node/pull/20481#event-1619773585
BridgeARhttps://github.com/BridgeAR
May 10, 2018 https://github.com/nodejs/node/pull/20481#ref-commit-21c3a40
https://github.com/BridgeAR
assert: validate input stricterhttps://github.com/BridgeAR/node/commit/21c3a402d486234fb00fcb130802b8fcabd97de8
21c3a40https://github.com/BridgeAR/node/commit/21c3a402d486234fb00fcb130802b8fcabd97de8
nodejs#20481https://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
January 20, 2020 11:32https://github.com/nodejs/node/pull/20481#event-2962612107
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Jan 13, 2023 https://github.com/nodejs/node/pull/20481#pullrequestreview-1247008213
View reviewed changes https://github.com/nodejs/node/pull/20481/files/f8a902375ced3e92f19129e89388ea0879b1845b
lib/assert.jshttps://github.com/nodejs/node/pull/20481/files/f8a902375ced3e92f19129e89388ea0879b1845b#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
ljharbhttps://github.com/ljharb
Jan 13, 2023https://github.com/nodejs/node/pull/20481#discussion_r1069004361
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20481
BridgeARhttps://github.com/BridgeAR
Jan 13, 2023https://github.com/nodejs/node/pull/20481#discussion_r1069108693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20481
ljharbhttps://github.com/ljharb
Jan 13, 2023https://github.com/nodejs/node/pull/20481#discussion_r1069791075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20481
BridgeARhttps://github.com/BridgeAR
Jan 13, 2023https://github.com/nodejs/node/pull/20481#discussion_r1069925979
Please reload this pagehttps://github.com/nodejs/node/pull/20481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20481
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/20481/files/f8a902375ced3e92f19129e89388ea0879b1845b
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/20481/files/d1c2c463eb43109ef5e65e738edddecbc7d4b402
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20481/files/5eff6a5c42e17e257747ab9fc067c323ce5ab0d1
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/20481/files/d1c2c463eb43109ef5e65e738edddecbc7d4b402
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/20481
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/ljharb
https://github.com/mcollina
https://github.com/jasnell
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.