René's URL Explorer Experiment


Title: tls: cleanup onhandshakestart callback by apapirovski · Pull Request #20466 · nodejs/node · GitHub

Open Graph Title: tls: cleanup onhandshakestart callback by apapirovski · Pull Request #20466 · nodejs/node

X Title: tls: cleanup onhandshakestart callback by apapirovski · Pull Request #20466 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Re-arrange and cleanup the flow of the onhandshakestart to be more clear and less repetitive. Exit early in the case of a first ever handshake for a given connection. Checklist make -j4 test (U...

X Description: Re-arrange and cleanup the flow of the onhandshakestart to be more clear and less repetitive. Exit early in the case of a first ever handshake for a given connection. Checklist make -j4 test (U...

Opengraph URL: https://github.com/nodejs/node/pull/20466

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d461296d-bcd7-f476-7770-141bdabfdd72
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA798:1F64D6:2776A96:326055A:6991C3DE
html-safe-nonce6af16fb20d5773e115f6563c50c66787b51c0a01757069e433407a47a6869e1c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzk4OjFGNjRENjoyNzc2QTk2OjMyNjA1NUE6Njk5MUMzREUiLCJ2aXNpdG9yX2lkIjoiODYyODE4NjAxOTE4NTkzNTMyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1338500fc1ec263aeea6690d625e52834c2f5055010396ca2d6ce219bd4269d
hovercard-subject-tagpull_request:185402123
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20466/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7042468609d1f4925aacd95e04646c020ae95e03915501d1147ff2316ebe9df6/nodejs/node/pull/20466
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7042468609d1f4925aacd95e04646c020ae95e03915501d1147ff2316ebe9df6/nodejs/node/pull/20466
og:image:altRe-arrange and cleanup the flow of the onhandshakestart to be more clear and less repetitive. Exit early in the case of a first ever handshake for a given connection. Checklist make -j4 test (U...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapapirovski
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20466#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20466
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20466
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20466
Reloadhttps://github.com/nodejs/node/pull/20466
Reloadhttps://github.com/nodejs/node/pull/20466
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20466
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:patch-cleanup-onhandshakestarthttps://github.com/apapirovski/node/tree/patch-cleanup-onhandshakestart
Conversationhttps://github.com/nodejs/node/pull/20466
Commits1 (1)https://github.com/nodejs/node/pull/20466/commits
Checkshttps://github.com/nodejs/node/pull/20466/checks
Files changedhttps://github.com/nodejs/node/pull/20466/files
tls: cleanup onhandshakestart callbackhttps://github.com/nodejs/node/pull/20466#top
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:patch-cleanup-onhandshakestarthttps://github.com/apapirovski/node/tree/patch-cleanup-onhandshakestart
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 2, 2018https://github.com/nodejs/node/pull/20466#issue-319504574
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20466
https://github.com/apapirovski
tls: cleanup onhandshakestart callbackhttps://github.com/nodejs/node/pull/20466/commits/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
ffbb81dhttps://github.com/nodejs/node/pull/20466/commits/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
May 2, 2018https://github.com/nodejs/node/pull/20466#event-1605172113
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 2, 2018 https://github.com/nodejs/node/pull/20466#pullrequestreview-116849761
View reviewed changes https://github.com/nodejs/node/pull/20466/files/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/20466/files/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
apapirovskihttps://github.com/apapirovski
May 2, 2018https://github.com/nodejs/node/pull/20466#discussion_r185458797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20466
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 2, 2018https://github.com/nodejs/node/pull/20466#issuecomment-385939472
https://ci.nodejs.org/job/node-test-pull-request/14623/https://ci.nodejs.org/job/node-test-pull-request/14623/
Please reload this pagehttps://github.com/nodejs/node/pull/20466
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 2, 2018 https://github.com/nodejs/node/pull/20466#pullrequestreview-116854542
View reviewed changes https://github.com/nodejs/node/pull/20466/files/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 2, 2018https://github.com/nodejs/node/pull/20466#event-1606369334
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2018https://github.com/nodejs/node/pull/20466#issuecomment-386799850
https://ci.nodejs.org/job/node-test-commit-osx/18327/https://ci.nodejs.org/job/node-test-commit-osx/18327/
Please reload this pagehttps://github.com/nodejs/node/pull/20466
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 5, 2018 https://github.com/nodejs/node/pull/20466#pullrequestreview-117814490
View reviewed changes https://github.com/nodejs/node/pull/20466/files/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 6, 2018https://github.com/nodejs/node/pull/20466#issuecomment-386855146
491ae12https://github.com/nodejs/node/commit/491ae12e412076ac9360d34516c827e941caed12
Please reload this pagehttps://github.com/nodejs/node/pull/20466
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 6, 2018https://github.com/nodejs/node/pull/20466#event-1611547661
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 6, 2018 05:28https://github.com/nodejs/node/pull/20466#event-1611547672
apapirovskihttps://github.com/apapirovski
May 6, 2018 https://github.com/nodejs/node/pull/20466#ref-commit-491ae12
https://github.com/apapirovski
tls: cleanup onhandshakestart callbackhttps://github.com/nodejs/node/commit/491ae12e412076ac9360d34516c827e941caed12
491ae12https://github.com/nodejs/node/commit/491ae12e412076ac9360d34516c827e941caed12
#20466https://github.com/nodejs/node/pull/20466
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20466#ref-commit-fc311f2
https://github.com/apapirovski
https://github.com/MylesBorins
tls: cleanup onhandshakestart callbackhttps://github.com/nodejs/node/commit/fc311f20eb2e03943f7ed4f87ca47caec9b78119
fc311f2https://github.com/nodejs/node/commit/fc311f20eb2e03943f7ed4f87ca47caec9b78119
#20466https://github.com/nodejs/node/pull/20466
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20466#ref-pullrequest-321253491
v10.1.0 proposal #20606 https://github.com/nodejs/node/pull/20606
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20466#ref-commit-cfb2f34
https://github.com/apapirovski
https://github.com/MylesBorins
tls: cleanup onhandshakestart callbackhttps://github.com/nodejs/node/commit/cfb2f34ca6600815d636dd9e928048afa4393ae2
cfb2f34https://github.com/nodejs/node/commit/cfb2f34ca6600815d636dd9e928048afa4393ae2
#20466https://github.com/nodejs/node/pull/20466
MylesBorinshttps://github.com/MylesBorins
May 9, 2018 https://github.com/nodejs/node/pull/20466#ref-commit-1ebec18
https://github.com/apapirovski
https://github.com/MylesBorins
tls: cleanup onhandshakestart callbackhttps://github.com/nodejs/node/commit/1ebec18624368285541823b54c65136df7ff6ca6
1ebec18https://github.com/nodejs/node/commit/1ebec18624368285541823b54c65136df7ff6ca6
#20466https://github.com/nodejs/node/pull/20466
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20466
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20466/files/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20466/files/ffbb81d5a9e22e363c3670044bbe6c06ef5d59ac
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/20466
https://github.com/apapirovski
https://github.com/addaleax
https://github.com/bnoordhuis
https://github.com/BridgeAR
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.