René's URL Explorer Experiment


Title: events: optimize condition for optimal scenario by apapirovski · Pull Request #20452 · nodejs/node · GitHub

Open Graph Title: events: optimize condition for optimal scenario by apapirovski · Pull Request #20452 · nodejs/node

X Title: events: optimize condition for optimal scenario by apapirovski · Pull Request #20452 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Instead of always checking whether we've already warned about a possible EventEmitter memory leak, first run the rest of the code as accessing custom properties on an Array is decently slow. I ...

X Description: Instead of always checking whether we've already warned about a possible EventEmitter memory leak, first run the rest of the code as accessing custom properties on an Array is decently slow...

Opengraph URL: https://github.com/nodejs/node/pull/20452

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d35a539c-5363-c4b9-3493-fb5d92c29775
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD96A:13117A:138B946:191B6B9:69924A44
html-safe-nonceaac172fa669b746563402d810ca2ce05303ef1b499c78b1dfcf55351326dc284
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTZBOjEzMTE3QToxMzhCOTQ2OjE5MUI2Qjk6Njk5MjRBNDQiLCJ2aXNpdG9yX2lkIjoiODY4OTI4MzMwMzM2MTEwNDQ1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd422a8737fcfe57ba8637adfebc260f4fa94c14db3b125f911eb74f729c42417
hovercard-subject-tagpull_request:185163280
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20452/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2ebf03c49d82463fa2777f8398fa1333393ccbd1f8f6f9921f1fa8bb5606fde4/nodejs/node/pull/20452
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2ebf03c49d82463fa2777f8398fa1333393ccbd1f8f6f9921f1fa8bb5606fde4/nodejs/node/pull/20452
og:image:altInstead of always checking whether we've already warned about a possible EventEmitter memory leak, first run the rest of the code as accessing custom properties on an Array is decently slow. I ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapapirovski
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20452#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20452
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20452
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20452
Reloadhttps://github.com/nodejs/node/pull/20452
Reloadhttps://github.com/nodejs/node/pull/20452
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20452
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:patch-events-max-listeners-checkhttps://github.com/apapirovski/node/tree/patch-events-max-listeners-check
Conversationhttps://github.com/nodejs/node/pull/20452
Commits2 (2)https://github.com/nodejs/node/pull/20452/commits
Checkshttps://github.com/nodejs/node/pull/20452/checks
Files changedhttps://github.com/nodejs/node/pull/20452/files
events: optimize condition for optimal scenariohttps://github.com/nodejs/node/pull/20452#top
apapirovskihttps://github.com/apapirovski
nodejs:masterhttps://github.com/nodejs/node/tree/master
apapirovski:patch-events-max-listeners-checkhttps://github.com/apapirovski/node/tree/patch-events-max-listeners-check
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 1, 2018https://github.com/nodejs/node/pull/20452#issue-319177078
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/apapirovski
events: optimize condition for optimal scenariohttps://github.com/nodejs/node/pull/20452/commits/282749f26e2cd4b9b9c064242eef4ec2fbc82353
282749fhttps://github.com/nodejs/node/pull/20452/commits/282749f26e2cd4b9b9c064242eef4ec2fbc82353
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
May 1, 2018https://github.com/nodejs/node/pull/20452#event-1603231305
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 1, 2018https://github.com/nodejs/node/pull/20452#issuecomment-385651871
https://ci.nodejs.org/job/node-test-pull-request/14608/https://ci.nodejs.org/job/node-test-pull-request/14608/
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/mscdex
mscdexhttps://github.com/mscdex
May 1, 2018https://github.com/nodejs/node/pull/20452#issuecomment-385652768
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 1, 2018https://github.com/nodejs/node/pull/20452#issuecomment-385653809
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 1, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-116633994
View reviewed changes https://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 2, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-116775698
View reviewed changes https://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 2, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-116807413
View reviewed changes https://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353
lib/events.jshttps://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9
bnoordhuishttps://github.com/bnoordhuis
May 2, 2018https://github.com/nodejs/node/pull/20452#discussion_r185423767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20452
apapirovskihttps://github.com/apapirovski
May 2, 2018https://github.com/nodejs/node/pull/20452#discussion_r185425960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/apapirovski
fixup: simplify conditional furtherhttps://github.com/nodejs/node/pull/20452/commits/71a1aa1b9021b20e98305143afaf034d6e76171c
71a1aa1https://github.com/nodejs/node/pull/20452/commits/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 2, 2018https://github.com/nodejs/node/pull/20452#issuecomment-385909647
@bnoordhuishttps://github.com/bnoordhuis
https://ci.nodejs.org/job/node-test-pull-request/14621/https://ci.nodejs.org/job/node-test-pull-request/14621/
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 2, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-116818465
View reviewed changes https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 2, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-116827706
View reviewed changes https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 2, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-116837733
View reviewed changes https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 2, 2018https://github.com/nodejs/node/pull/20452#event-1606368762
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 3, 2018 https://github.com/nodejs/node/pull/20452#pullrequestreview-117149835
View reviewed changes https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 3, 2018https://github.com/nodejs/node/pull/20452#issuecomment-386283217
fe87945https://github.com/nodejs/node/commit/fe8794560a22cc62a482bf071e2050ce1ea6ea3e
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 3, 2018https://github.com/nodejs/node/pull/20452#event-1607583732
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 3, 2018 12:45https://github.com/nodejs/node/pull/20452#event-1607583888
apapirovskihttps://github.com/apapirovski
May 3, 2018 https://github.com/nodejs/node/pull/20452#ref-commit-fe87945
https://github.com/apapirovski
events: optimize condition for optimal scenariohttps://github.com/nodejs/node/commit/fe8794560a22cc62a482bf071e2050ce1ea6ea3e
fe87945https://github.com/nodejs/node/commit/fe8794560a22cc62a482bf071e2050ce1ea6ea3e
#20452https://github.com/nodejs/node/pull/20452
MylesBorinshttps://github.com/MylesBorins
May 4, 2018 https://github.com/nodejs/node/pull/20452#ref-commit-52e6ef0
https://github.com/apapirovski
https://github.com/MylesBorins
events: optimize condition for optimal scenariohttps://github.com/nodejs/node/commit/52e6ef0ace737ee0da0b9b833d4fa610d4fb4fee
52e6ef0https://github.com/nodejs/node/commit/52e6ef0ace737ee0da0b9b833d4fa610d4fb4fee
#20452https://github.com/nodejs/node/pull/20452
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20452#ref-pullrequest-321253491
v10.1.0 proposal #20606 https://github.com/nodejs/node/pull/20606
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20452#ref-commit-58a65d6
https://github.com/apapirovski
https://github.com/MylesBorins
events: optimize condition for optimal scenariohttps://github.com/nodejs/node/commit/58a65d668975d9fd65cfbba754c2fc72a8b9236c
58a65d6https://github.com/nodejs/node/commit/58a65d668975d9fd65cfbba754c2fc72a8b9236c
#20452https://github.com/nodejs/node/pull/20452
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20452
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/20452/files/282749f26e2cd4b9b9c064242eef4ec2fbc82353
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20452/files/71a1aa1b9021b20e98305143afaf034d6e76171c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
Please reload this pagehttps://github.com/nodejs/node/pull/20452
https://github.com/apapirovski
https://github.com/mscdex
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.