René's URL Explorer Experiment


Title: test, fs: introduce helper function to test fs.* methods as fsPromises.* methods by Trott · Pull Request #20439 · nodejs/node · GitHub

Open Graph Title: test, fs: introduce helper function to test fs.* methods as fsPromises.* methods by Trott · Pull Request #20439 · nodejs/node

X Title: test, fs: introduce helper function to test fs.* methods as fsPromises.* methods by Trott · Pull Request #20439 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Introduce common.fsTest() helper function which (hopefully) makes it easy to repurpose all test-fs-* tests to also test equivalent functionality in fsPromises.* methods. As a proof-of-concept, use ...

X Description: Introduce common.fsTest() helper function which (hopefully) makes it easy to repurpose all test-fs-* tests to also test equivalent functionality in fsPromises.* methods. As a proof-of-concept, use ...

Opengraph URL: https://github.com/nodejs/node/pull/20439

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:09b9d1c9-fb25-8d35-efc5-3e07c684b7f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA34:30050E:ACB7A6:DDBDC1:69922A24
html-safe-noncee34b5b4034b361df1148f09231f02639f23d9c4846acecaadd14a0ccc7f963bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTM0OjMwMDUwRTpBQ0I3QTY6RERCREMxOjY5OTIyQTI0IiwidmlzaXRvcl9pZCI6IjUxODk1Njg4MTQ2OTg4NjcyMzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac64bfbb4fe2d74059cf3d391f536c48039d937c2aa5040887e6d8b6d8a94ecc58
hovercard-subject-tagpull_request:185093234
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20439/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ee311a743d32b7695c6ab82f3634347feb2969a07e98245408258a8bc38527a/nodejs/node/pull/20439
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ee311a743d32b7695c6ab82f3634347feb2969a07e98245408258a8bc38527a/nodejs/node/pull/20439
og:image:altIntroduce common.fsTest() helper function which (hopefully) makes it easy to repurpose all test-fs-* tests to also test equivalent functionality in fsPromises.* methods. As a proof-of-concept, use ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20439#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20439
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20439
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20439
Reloadhttps://github.com/nodejs/node/pull/20439
Reloadhttps://github.com/nodejs/node/pull/20439
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20439
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fs-callbackifyhttps://github.com/Trott/io.js/tree/fs-callbackify
Conversationhttps://github.com/nodejs/node/pull/20439
Commits10 (10)https://github.com/nodejs/node/pull/20439/commits
Checkshttps://github.com/nodejs/node/pull/20439/checks
Files changedhttps://github.com/nodejs/node/pull/20439/files
test, fs: introduce helper function to test fs.* methods as fsPromises.* methodshttps://github.com/nodejs/node/pull/20439#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fs-callbackifyhttps://github.com/Trott/io.js/tree/fs-callbackify
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 30, 2018https://github.com/nodejs/node/pull/20439#issue-319074204
@ChALkeRhttps://github.com/ChALkeR
@jasnellhttps://github.com/jasnell
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Apr 30, 2018https://github.com/nodejs/node/pull/20439#event-1602652031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Apr 30, 2018https://github.com/nodejs/node/pull/20439#event-1602652093
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 30, 2018 https://github.com/nodejs/node/pull/20439#ref-issue-318996925
fs/promises test coverage is poor. #20435 https://github.com/nodejs/node/issues/20435
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 30, 2018https://github.com/nodejs/node/pull/20439#issuecomment-385563183
https://ci.nodejs.org/job/node-test-pull-request/14605/https://ci.nodejs.org/job/node-test-pull-request/14605/
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 1, 2018https://github.com/nodejs/node/pull/20439#issuecomment-385564659
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 1, 2018https://github.com/nodejs/node/pull/20439#issuecomment-385590775
Please reload this pagehttps://github.com/nodejs/node/pull/20439
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
May 1, 2018https://github.com/nodejs/node/pull/20439#issuecomment-385597697
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 1, 2018 https://github.com/nodejs/node/pull/20439#ref-pullrequest-318737809
fs: promises fixes #20407 https://github.com/nodejs/node/pull/20407
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 1, 2018 https://github.com/nodejs/node/pull/20439#pullrequestreview-116509378
View reviewed changes https://github.com/nodejs/node/pull/20439/files
test/common/README.mdhttps://github.com/nodejs/node/pull/20439/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
lpincahttps://github.com/lpinca
May 1, 2018https://github.com/nodejs/node/pull/20439#discussion_r185173700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
test/common/README.mdhttps://github.com/nodejs/node/pull/20439/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
lpincahttps://github.com/lpinca
May 1, 2018https://github.com/nodejs/node/pull/20439#discussion_r185173776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
test/parallel/test-fs-link.jshttps://github.com/nodejs/node/pull/20439/files#diff-0b70cd2e373dbed5778abe7916378597c858ef3f5f5f4149829dab29645d96f8
lpincahttps://github.com/lpinca
May 1, 2018https://github.com/nodejs/node/pull/20439#discussion_r185176061
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
May 1, 2018 https://github.com/nodejs/node/pull/20439#pullrequestreview-116543156
View reviewed changes https://github.com/nodejs/node/pull/20439/files
test/common/README.mdhttps://github.com/nodejs/node/pull/20439/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
vsemozhetbythttps://github.com/vsemozhetbyt
May 1, 2018https://github.com/nodejs/node/pull/20439#discussion_r185202720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
Trotthttps://github.com/Trott
May 3, 2018https://github.com/nodejs/node/pull/20439#discussion_r185686863
Please reload this pagehttps://github.com/nodejs/node/pull/20439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
test/common/README.mdhttps://github.com/nodejs/node/pull/20439/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
vsemozhetbythttps://github.com/vsemozhetbyt
May 1, 2018https://github.com/nodejs/node/pull/20439#discussion_r185203349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
test/common/README.mdhttps://github.com/nodejs/node/pull/20439/files#diff-4c0f5f25d9424c0e74d3544841707f668cd6481053ccea1cc0a5eaa36814d2a6
vsemozhetbythttps://github.com/vsemozhetbyt
May 1, 2018https://github.com/nodejs/node/pull/20439#discussion_r185203371
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 1, 2018https://github.com/nodejs/node/pull/20439#issuecomment-385676254
Please reload this pagehttps://github.com/nodejs/node/pull/20439
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/4921ce2772ef049e436bdce9ea730f260b5c714d..d4cd54ee36708cfb25a95843c9b77673873fc16c
4921ce2https://github.com/nodejs/node/commit/4921ce2772ef049e436bdce9ea730f260b5c714d
d4cd54ehttps://github.com/nodejs/node/commit/d4cd54ee36708cfb25a95843c9b77673873fc16c
Compare https://github.com/nodejs/node/compare/4921ce2772ef049e436bdce9ea730f260b5c714d..d4cd54ee36708cfb25a95843c9b77673873fc16c
May 3, 2018 02:30https://github.com/nodejs/node/pull/20439#event-1606806687
https://github.com/Trott
Trotthttps://github.com/Trott
May 3, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386185721
Please reload this pagehttps://github.com/nodejs/node/pull/20439
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/f5faa2fdd25ec6844fb8a99e8a9d62e5092a3982..9bcc7f474f006266919eabec89c70fa6791ce149
f5faa2fhttps://github.com/nodejs/node/commit/f5faa2fdd25ec6844fb8a99e8a9d62e5092a3982
9bcc7f4https://github.com/nodejs/node/commit/9bcc7f474f006266919eabec89c70fa6791ce149
Compare https://github.com/nodejs/node/compare/f5faa2fdd25ec6844fb8a99e8a9d62e5092a3982..9bcc7f474f006266919eabec89c70fa6791ce149
May 4, 2018 05:14https://github.com/nodejs/node/pull/20439#event-1609121797
https://github.com/Trott
Trotthttps://github.com/Trott
May 4, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386507648
@ChALkeRhttps://github.com/ChALkeR
https://github.com/Trott/io.js/blob/9bcc7f474f006266919eabec89c70fa6791ce149/test/parallel/test-fs-append-file.js#L114-L150https://github.com/Trott/io.js/blob/9bcc7f474f006266919eabec89c70fa6791ce149/test/parallel/test-fs-append-file.js#L114-L150
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
May 4, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386508233
Please reload this pagehttps://github.com/nodejs/node/pull/20439
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/337402534b2bd41723326aec8865f063cc96d609..ce2c8db96d55c1a661bba99fc4ba0c366afb3bd4
3374025https://github.com/nodejs/node/commit/337402534b2bd41723326aec8865f063cc96d609
ce2c8dbhttps://github.com/nodejs/node/commit/ce2c8db96d55c1a661bba99fc4ba0c366afb3bd4
Compare https://github.com/nodejs/node/compare/337402534b2bd41723326aec8865f063cc96d609..ce2c8db96d55c1a661bba99fc4ba0c366afb3bd4
May 5, 2018 04:31https://github.com/nodejs/node/pull/20439#event-1611119399
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 5, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386796653
Please reload this pagehttps://github.com/nodejs/node/pull/20439
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 5, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386808863
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
May 5, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386818977
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
May 5, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386819272
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 5, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386829746
Please reload this pagehttps://github.com/nodejs/node/pull/20439
@Trotthttps://github.com/Trott
#20548https://github.com/nodejs/node/issues/20548
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
May 5, 2018 https://github.com/nodejs/node/pull/20439#ref-issue-320535588
fs/promises API inconsitency (.close not there) #20548 https://github.com/nodejs/node/issues/20548
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/ce2c8db96d55c1a661bba99fc4ba0c366afb3bd4..594322a2a2c5ffdb9bfcd218cd586b3fd4b68258
ce2c8dbhttps://github.com/nodejs/node/commit/ce2c8db96d55c1a661bba99fc4ba0c366afb3bd4
594322ahttps://github.com/nodejs/node/commit/594322a2a2c5ffdb9bfcd218cd586b3fd4b68258
Compare https://github.com/nodejs/node/compare/ce2c8db96d55c1a661bba99fc4ba0c366afb3bd4..594322a2a2c5ffdb9bfcd218cd586b3fd4b68258
May 5, 2018 23:12https://github.com/nodejs/node/pull/20439#event-1611467147
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 5, 2018https://github.com/nodejs/node/pull/20439#issuecomment-386842711
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/20439
Trotthttps://github.com/Trott
May 7, 2018 20:54https://github.com/nodejs/node/pull/20439#commits-pushed-324b8fc
https://github.com/Trott
test: add common.fsTest()https://github.com/nodejs/node/pull/20439/commits/324b8fcda38427ed6d49d377c2d739595eb7b811
324b8fchttps://github.com/nodejs/node/pull/20439/commits/324b8fcda38427ed6d49d377c2d739595eb7b811
https://github.com/Trott
test: apply test to fsPromises.link()https://github.com/nodejs/node/pull/20439/commits/cb83dcbf7df02a87b6b0f900c86d9ddc3847e78f
cb83dcbhttps://github.com/nodejs/node/pull/20439/commits/cb83dcbf7df02a87b6b0f900c86d9ddc3847e78f
Trotthttps://github.com/Trott
May 7, 2018 20:54https://github.com/nodejs/node/pull/20439#commits-pushed-91479d9
https://github.com/Trott
test: apply test to fsPromises.access()https://github.com/nodejs/node/pull/20439/commits/91479d9014dd1151f97016bcb1146c239577b999
91479d9https://github.com/nodejs/node/pull/20439/commits/91479d9014dd1151f97016bcb1146c239577b999
https://github.com/Trott
test: apply test to fsPromises.unlink()https://github.com/nodejs/node/pull/20439/commits/09423c57053c58c810fc39a960605930e1768a06
09423c5https://github.com/nodejs/node/pull/20439/commits/09423c57053c58c810fc39a960605930e1768a06
https://github.com/Trott
test: apply test to fsPromises.appendFile()https://github.com/nodejs/node/pull/20439/commits/78f1bd5f3a87dc269c1319fe82c1440bc0ac4513
78f1bd5https://github.com/nodejs/node/pull/20439/commits/78f1bd5f3a87dc269c1319fe82c1440bc0ac4513
https://github.com/Trott
test: apply test to fsPromises.* functionshttps://github.com/nodejs/node/pull/20439/commits/1c39230d782462e564d616a4d4e564a9d495aac8
1c39230https://github.com/nodejs/node/pull/20439/commits/1c39230d782462e564d616a4d4e564a9d495aac8
https://github.com/Trott
test: apply test to fsPromises.readfile()https://github.com/nodejs/node/pull/20439/commits/e39495f3c98e041d8183c71cd678213106a27552
e39495fhttps://github.com/nodejs/node/pull/20439/commits/e39495f3c98e041d8183c71cd678213106a27552
https://github.com/Trott
test: apply buffer arg test to fsPromiseshttps://github.com/nodejs/node/pull/20439/commits/9900478367a206d37910769ae76b9f3f8e33edfd
9900478https://github.com/nodejs/node/pull/20439/commits/9900478367a206d37910769ae76b9f3f8e33edfd
https://github.com/Trott
test: apply chmod test to fsPromiseshttps://github.com/nodejs/node/pull/20439/commits/5f1b84092cc3f3d0a3ed260e575614104e93a961
5f1b840https://github.com/nodejs/node/pull/20439/commits/5f1b84092cc3f3d0a3ed260e575614104e93a961
https://github.com/Trott
test: apply fs.chown() test to fsPromises.chown()https://github.com/nodejs/node/pull/20439/commits/63f3ff6e533f35e32844548570db6a5fac683e3a
63f3ff6https://github.com/nodejs/node/pull/20439/commits/63f3ff6e533f35e32844548570db6a5fac683e3a
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/b9898cc482fa917ef3e0926cc6f13bb43db40700..63f3ff6e533f35e32844548570db6a5fac683e3a
b9898cchttps://github.com/nodejs/node/commit/b9898cc482fa917ef3e0926cc6f13bb43db40700
63f3ff6https://github.com/nodejs/node/commit/63f3ff6e533f35e32844548570db6a5fac683e3a
Compare https://github.com/nodejs/node/compare/b9898cc482fa917ef3e0926cc6f13bb43db40700..63f3ff6e533f35e32844548570db6a5fac683e3a
May 8, 2018 03:55https://github.com/nodejs/node/pull/20439#event-1614367438
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
May 8, 2018https://github.com/nodejs/node/pull/20439#event-1614625667
https://github.com/Trott
Trotthttps://github.com/Trott
May 10, 2018 https://github.com/nodejs/node/pull/20439#ref-pullrequest-322125204
test: apply test-fs-access to promises API #20667 https://github.com/nodejs/node/pull/20667
https://github.com/liron-navon
liron-navonhttps://github.com/liron-navon
May 15, 2018https://github.com/nodejs/node/pull/20439#issuecomment-389244744
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
May 15, 2018https://github.com/nodejs/node/pull/20439#issuecomment-389250085
@liron-navonhttps://github.com/liron-navon
#20739https://github.com/nodejs/node/pull/20739
#20667https://github.com/nodejs/node/pull/20667
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 23, 2018https://github.com/nodejs/node/pull/20439#issuecomment-391449866
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
Trotthttps://github.com/Trott
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 2, 2018https://github.com/nodejs/node/pull/20439#event-1659379451
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 10, 2018https://github.com/nodejs/node/pull/20439#event-1672481984
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Aug 24, 2018 https://github.com/nodejs/node/pull/20439#ref-issue-353334184
dns.promises test coverage is poor #22471 https://github.com/nodejs/node/issues/22471
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:49https://github.com/nodejs/node/pull/20439#event-5890963961
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20439
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/20439/files/5f40bf880e1481cee36eadbdc326982d30ec7f55
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/20439/files/5f40bf880e1481cee36eadbdc326982d30ec7f55
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/20439
https://github.com/Trott
https://github.com/TimothyGu
https://github.com/ChALkeR
https://github.com/BridgeAR
https://github.com/liron-navon
https://github.com/jasnell
https://github.com/lpinca
https://github.com/vsemozhetbyt
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.