| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8a12dba9-eeac-b6e5-68ab-65755f68d3f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C806:1F69FD:1F37B84:281ED83:6991C37D |
| html-safe-nonce | ce43f73b66dc25235959b70d4e1b1c85a7719e76aba229aa8d640f3e4c4189ac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODA2OjFGNjlGRDoxRjM3Qjg0OjI4MUVEODM6Njk5MUMzN0QiLCJ2aXNpdG9yX2lkIjoiMTAyNDUyMjIwMzY5NDIxMTgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e03a2428ab4e4998498e39e4e21588fa8d37b1756ff5c5d5eb549e3f2790b4e0 |
| hovercard-subject-tag | pull_request:184942591 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20422/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/19271201b6bf528b1e10863dd8a15fbce5103656cc432d022e2639641d8bcbe3/nodejs/node/pull/20422 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/19271201b6bf528b1e10863dd8a15fbce5103656cc432d022e2639641d8bcbe3/nodejs/node/pull/20422 |
| og:image:alt | This commit removes unnecesary requires of http and internal/util in
http2/core.js
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/20422#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20422 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20422 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/20422 |
| Reload | https://github.com/nodejs/node/pull/20422 |
| Reload | https://github.com/nodejs/node/pull/20422 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/20422 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
713
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:http2_core_requires | https://github.com/danbev/node/tree/http2_core_requires |
| Conversation | https://github.com/nodejs/node/pull/20422 |
| Commits1 (1) | https://github.com/nodejs/node/pull/20422/commits |
| Checks | https://github.com/nodejs/node/pull/20422/checks |
| Files changed | https://github.com/nodejs/node/pull/20422/files |
| http2: reduce require calls in http2/core | https://github.com/nodejs/node/pull/20422#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:http2_core_requires | https://github.com/danbev/node/tree/http2_core_requires |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 30, 2018 | https://github.com/nodejs/node/pull/20422#issue-318871837 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/20422 |
|
| https://github.com/danbev |
| http2: reduce require calls in http2/core | https://github.com/nodejs/node/pull/20422/commits/c929963ba1997ade99265f0cab5620054896c054 |
| c929963 | https://github.com/nodejs/node/pull/20422/commits/c929963ba1997ade99265f0cab5620054896c054 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Apr 30, 2018 | https://github.com/nodejs/node/pull/20422#event-1601384972 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 30, 2018 | https://github.com/nodejs/node/pull/20422#issuecomment-385383191 |
| https://ci.nodejs.org/job/node-test-pull-request/14596/ | https://ci.nodejs.org/job/node-test-pull-request/14596/ |
| Please reload this page | https://github.com/nodejs/node/pull/20422 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 30, 2018 | https://github.com/nodejs/node/pull/20422#issuecomment-385383763 |
| Please reload this page | https://github.com/nodejs/node/pull/20422 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Apr 30, 2018
| https://github.com/nodejs/node/pull/20422#pullrequestreview-116270773 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Apr 30, 2018
| https://github.com/nodejs/node/pull/20422#pullrequestreview-116305792 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Apr 30, 2018
| https://github.com/nodejs/node/pull/20422#pullrequestreview-116399102 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
May 1, 2018
| https://github.com/nodejs/node/pull/20422#pullrequestreview-116489037 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 2, 2018 | https://github.com/nodejs/node/pull/20422#issuecomment-385880249 |
| 557f570 | https://github.com/nodejs/node/commit/557f5702eccd48da757df9adc5385d664717a173 |
| Please reload this page | https://github.com/nodejs/node/pull/20422 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 2, 2018 | https://github.com/nodejs/node/pull/20422#event-1604744822 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| May 2, 2018 06:46 | https://github.com/nodejs/node/pull/20422#event-1604745134 |
| danbev | https://github.com/danbev |
|
May 2, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-557f570 |
|
| https://github.com/danbev |
| http2: reduce require calls in http2/core | https://github.com/danbev/node/commit/557f5702eccd48da757df9adc5385d664717a173 |
| 557f570 | https://github.com/danbev/node/commit/557f5702eccd48da757df9adc5385d664717a173 |
| nodejs#20422 | https://github.com/nodejs/node/pull/20422 |
| MylesBorins | https://github.com/MylesBorins |
|
May 4, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-42bbaa3 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| http2: reduce require calls in http2/core | https://github.com/nodejs/node/commit/42bbaa338db3cb4a01e4ff83a88ad52251d7adb9 |
| 42bbaa3 | https://github.com/nodejs/node/commit/42bbaa338db3cb4a01e4ff83a88ad52251d7adb9 |
| #20422 | https://github.com/nodejs/node/pull/20422 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
May 8, 2018
| https://github.com/nodejs/node/pull/20422#ref-pullrequest-321253491 |
|
v10.1.0 proposal
#20606
| https://github.com/nodejs/node/pull/20606 |
| kjin | https://github.com/kjin |
|
Aug 23, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-27a337a |
|
| https://github.com/danbev |
|
| https://github.com/kjin |
| http2: reduce require calls in http2/core | https://github.com/kjin/node/commit/27a337ab837bdc5e9689672c031587bf22b98f81 |
| 27a337a | https://github.com/kjin/node/commit/27a337ab837bdc5e9689672c031587bf22b98f81 |
| nodejs#20422 | https://github.com/nodejs/node/pull/20422 |
| kjin | https://github.com/kjin |
|
Sep 11, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-1f55a39 |
|
| https://github.com/danbev |
|
| https://github.com/kjin |
| http2: reduce require calls in http2/core | https://github.com/kjin/node/commit/1f55a39e35ea8629e551ef101f26b60c3a9976c5 |
| 1f55a39 | https://github.com/kjin/node/commit/1f55a39e35ea8629e551ef101f26b60c3a9976c5 |
| nodejs#20422 | https://github.com/nodejs/node/pull/20422 |
| kjin | https://github.com/kjin |
|
Sep 19, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-1b7d030 |
|
| https://github.com/danbev |
|
| https://github.com/kjin |
| http2: reduce require calls in http2/core | https://github.com/kjin/node/commit/1b7d03098396140a7fa89335e5d8dbb61d8d1586 |
| 1b7d030 | https://github.com/kjin/node/commit/1b7d03098396140a7fa89335e5d8dbb61d8d1586 |
| nodejs#20422 | https://github.com/nodejs/node/pull/20422 |
| kjin | https://github.com/kjin |
|
Oct 16, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-d9efc87 |
|
| https://github.com/danbev |
|
| https://github.com/kjin |
| http2: reduce require calls in http2/core | https://github.com/kjin/node/commit/d9efc870e39343d4a794fa59262e2292da1d5b2b |
| d9efc87 | https://github.com/kjin/node/commit/d9efc870e39343d4a794fa59262e2292da1d5b2b |
| nodejs#20422 | https://github.com/nodejs/node/pull/20422 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 17, 2018
| https://github.com/nodejs/node/pull/20422#ref-commit-74192dd |
|
| https://github.com/danbev |
|
| https://github.com/BethGriggs |
| http2: reduce require calls in http2/core | https://github.com/nodejs/node/commit/74192ddb6617b2656d9cdf77b3500d83f949e2f8 |
| 74192dd | https://github.com/nodejs/node/commit/74192ddb6617b2656d9cdf77b3500d83f949e2f8 |
| #22850 | https://github.com/nodejs/node/pull/22850 |
| #20422 | https://github.com/nodejs/node/pull/20422 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 30, 2018
| https://github.com/nodejs/node/pull/20422#ref-pullrequest-375564151 |
|
v8.13.0 proposal
#23974
| https://github.com/nodejs/node/pull/23974 |
| https://github.com/beevelop |
| beevelop | https://github.com/beevelop |
|
Nov 20, 2018
| https://github.com/nodejs/node/pull/20422#ref-issue-382804528 |
|
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs
beevelop/docker-android-nodejs#250
| https://github.com/beevelop/docker-android-nodejs/issues/250 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20422 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
|
| https://github.com/apapirovski |
|
apapirovski
| https://github.com/apapirovski |
|
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/20422/files/c929963ba1997ade99265f0cab5620054896c054 |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Please reload this page | https://github.com/nodejs/node/pull/20422 |
|
| https://github.com/danbev |
|
| https://github.com/BridgeAR |
|
| https://github.com/apapirovski |
|
| https://github.com/lpinca |
|
| https://github.com/TimothyGu |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |