René's URL Explorer Experiment


Title: fs: promises fixes by ChALkeR · Pull Request #20407 · nodejs/node · GitHub

Open Graph Title: fs: promises fixes by ChALkeR · Pull Request #20407 · nodejs/node

X Title: fs: promises fixes by ChALkeR · Pull Request #20407 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This fixes two...

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This fixes two...

Opengraph URL: https://github.com/nodejs/node/pull/20407

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:de53e609-c0a3-bb39-9b68-6256b7ff2687
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB70:15D7ED:3252B6:42125F:6991DCA5
html-safe-nonce9a762551e2dfc98552722709d554139a408f6ebce91389dbcdd2d4a7f25590fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjcwOjE1RDdFRDozMjUyQjY6NDIxMjVGOjY5OTFEQ0E1IiwidmlzaXRvcl9pZCI6IjIyMjgxMDAxMzAwODI1MTIwMzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9affcc889427ebc2385b14cdd20079ffa712126b44858fe935977e6c89ff2f38
hovercard-subject-tagpull_request:184847231
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20407/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8e9e017004b5abcacd8ece149b13af6d01d5adb65ca5961f750a3525d00691b5/nodejs/node/pull/20407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8e9e017004b5abcacd8ece149b13af6d01d5adb65ca5961f750a3525d00691b5/nodejs/node/pull/20407
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines This fixes two...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameChALkeR
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20407#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20407
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20407
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20407
Reloadhttps://github.com/nodejs/node/pull/20407
Reloadhttps://github.com/nodejs/node/pull/20407
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20407
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ChALkeRhttps://github.com/ChALkeR
nodejs:masterhttps://github.com/nodejs/node/tree/master
ChALkeR:fs-promises-fixeshttps://github.com/ChALkeR/io.js/tree/fs-promises-fixes
Conversationhttps://github.com/nodejs/node/pull/20407
Commits2 (2)https://github.com/nodejs/node/pull/20407/commits
Checkshttps://github.com/nodejs/node/pull/20407/checks
Files changedhttps://github.com/nodejs/node/pull/20407/files
fs: promises fixeshttps://github.com/nodejs/node/pull/20407#top
ChALkeRhttps://github.com/ChALkeR
nodejs:masterhttps://github.com/nodejs/node/tree/master
ChALkeR:fs-promises-fixeshttps://github.com/ChALkeR/io.js/tree/fs-promises-fixes
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Apr 29, 2018https://github.com/nodejs/node/pull/20407#issue-318737809
Please reload this pagehttps://github.com/nodejs/node/pull/20407
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
#19811https://github.com/nodejs/node/pull/19811
#20406https://github.com/nodejs/node/issues/20406
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Apr 29, 2018https://github.com/nodejs/node/pull/20407#event-1600626679
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 29, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116174365
View reviewed changes https://github.com/nodejs/node/pull/20407/files
lib/fs/promises.jshttps://github.com/nodejs/node/pull/20407/files#diff-fd96bd25094560438434575177dd6ca9207a8b6903dac354f17e28450aa6c5c4
mscdexhttps://github.com/mscdex
Apr 29, 2018https://github.com/nodejs/node/pull/20407#discussion_r184890884
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20407
ChALkeRhttps://github.com/ChALkeR
Apr 29, 2018https://github.com/nodejs/node/pull/20407#discussion_r184890988
Please reload this pagehttps://github.com/nodejs/node/pull/20407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mscdexhttps://github.com/mscdex
https://coverage.nodejs.org/coverage-b55a11d1b17b3e4b/root/fs/promises.js.htmlhttps://coverage.nodejs.org/coverage-b55a11d1b17b3e4b/root/fs/promises.js.html
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Apr 29, 2018https://github.com/nodejs/node/pull/20407#event-1600634579
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Apr 29, 2018 https://github.com/nodejs/node/pull/20407#ref-issue-318734916
fs: promises have undocumented write(string,…) method #20406 https://github.com/nodejs/node/issues/20406
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Apr 29, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116178668
View reviewed changes https://github.com/nodejs/node/pull/20407/files
https://github.com/davisjam
davisjamhttps://github.com/davisjam
Apr 29, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116179821
View reviewed changes https://github.com/nodejs/node/pull/20407/files
davisjamhttps://github.com/davisjam
https://github.com/nodejs/node/pull/20407#pullrequestreview-116179821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Apr 30, 2018https://github.com/nodejs/node/pull/20407#issuecomment-385325968
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Apr 30, 2018 https://github.com/nodejs/node/pull/20407#ref-issue-318996925
fs/promises test coverage is poor. #20435 https://github.com/nodejs/node/issues/20435
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Apr 30, 2018https://github.com/nodejs/node/pull/20407#issuecomment-385496123
Please reload this pagehttps://github.com/nodejs/node/pull/20407
@davisjamhttps://github.com/davisjam
@mscdexhttps://github.com/mscdex
#20435https://github.com/nodejs/node/issues/20435
#20435 (comment)https://github.com/nodejs/node/issues/20435#issuecomment-385495776
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Apr 30, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116402930
View reviewed changes https://github.com/nodejs/node/pull/20407/files
https://github.com/davisjam
davisjamhttps://github.com/davisjam
Apr 30, 2018https://github.com/nodejs/node/pull/20407#issuecomment-385501026
@ChALkeRhttps://github.com/ChALkeR
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/davisjam
davisjamhttps://github.com/davisjam
Apr 30, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116403759
View reviewed changes https://github.com/nodejs/node/pull/20407/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 30, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116404661
View reviewed changes https://github.com/nodejs/node/pull/20407/files
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 30, 2018https://github.com/nodejs/node/pull/20407#issuecomment-385531020
Please reload this pagehttps://github.com/nodejs/node/pull/20407
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 1, 2018https://github.com/nodejs/node/pull/20407#issuecomment-385599391
Please reload this pagehttps://github.com/nodejs/node/pull/20407
@mscdexhttps://github.com/mscdex
@devsnekhttps://github.com/devsnek
#20439https://github.com/nodejs/node/pull/20439
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 1, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-116533294
View reviewed changes https://github.com/nodejs/node/pull/20407/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 6, 2018 https://github.com/nodejs/node/pull/20407#ref-pullrequest-320550723
fs: refactor promises version of lchown and lchmod #20551 https://github.com/nodejs/node/pull/20551
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 6, 2018https://github.com/nodejs/node/pull/20407#issuecomment-386843788
@mscdexhttps://github.com/mscdex
@devsnekhttps://github.com/devsnek
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 6, 2018https://github.com/nodejs/node/pull/20407#issuecomment-386844314
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 6, 2018https://github.com/nodejs/node/pull/20407#issuecomment-386896006
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
May 8, 2018https://github.com/nodejs/node/pull/20407#event-1614625660
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
force-pushedhttps://github.com/nodejs/node/compare/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1..e2ae64385c19eeba54f8d3d7baf49059adbb1d9e
5b8c64dhttps://github.com/nodejs/node/commit/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
e2ae643https://github.com/nodejs/node/commit/e2ae64385c19eeba54f8d3d7baf49059adbb1d9e
Compare https://github.com/nodejs/node/compare/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1..e2ae64385c19eeba54f8d3d7baf49059adbb1d9e
May 8, 2018 08:05https://github.com/nodejs/node/pull/20407#event-1614666616
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 8, 2018https://github.com/nodejs/node/pull/20407#issuecomment-387320479
https://ci.nodejs.org/job/node-test-pull-request/14712/https://ci.nodejs.org/job/node-test-pull-request/14712/
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/thefourtheye
thefourtheyehttps://github.com/thefourtheye
May 8, 2018 https://github.com/nodejs/node/pull/20407#pullrequestreview-118266881
View reviewed changes https://github.com/nodejs/node/pull/20407/files
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 8, 2018https://github.com/nodejs/node/pull/20407#issuecomment-387353224
Please reload this pagehttps://github.com/nodejs/node/pull/20407
ChALkeRhttps://github.com/ChALkeR
May 8, 2018 13:10https://github.com/nodejs/node/pull/20407#commits-pushed-ca6b12e
https://github.com/ChALkeR
fs: remove broken code in promises/writehttps://github.com/nodejs/node/pull/20407/commits/ca6b12e28df53110de7ee58699d5af099d036c67
ca6b12ehttps://github.com/nodejs/node/pull/20407/commits/ca6b12e28df53110de7ee58699d5af099d036c67
nodejs#20407https://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
fs: fchmod->fchown in promises/lchownhttps://github.com/nodejs/node/pull/20407/commits/15f743165cdb61bcc4dcaf865f18931f2c883b41
15f7431https://github.com/nodejs/node/pull/20407/commits/15f743165cdb61bcc4dcaf865f18931f2c883b41
nodejs#20407https://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
force-pushedhttps://github.com/nodejs/node/compare/e2ae64385c19eeba54f8d3d7baf49059adbb1d9e..15f743165cdb61bcc4dcaf865f18931f2c883b41
e2ae643https://github.com/nodejs/node/commit/e2ae64385c19eeba54f8d3d7baf49059adbb1d9e
15f7431https://github.com/nodejs/node/commit/15f743165cdb61bcc4dcaf865f18931f2c883b41
Compare https://github.com/nodejs/node/compare/e2ae64385c19eeba54f8d3d7baf49059adbb1d9e..15f743165cdb61bcc4dcaf865f18931f2c883b41
May 8, 2018 10:16https://github.com/nodejs/node/pull/20407#event-1614924186
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
May 8, 2018https://github.com/nodejs/node/pull/20407#issuecomment-387356445
Please reload this pagehttps://github.com/nodejs/node/pull/20407
dd03709...15f7431https://github.com/nodejs/node/compare/dd03709148ec49b55792a1e29144634a323326b0...15f743165cdb61bcc4dcaf865f18931f2c883b41
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
15f7431https://github.com/nodejs/node/commit/15f743165cdb61bcc4dcaf865f18931f2c883b41
May 8, 2018https://github.com/nodejs/node/pull/20407#event-1614932671
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20407#ref-commit-acf3019
https://github.com/ChALkeR
https://github.com/MylesBorins
fs: remove broken code in promises/writehttps://github.com/nodejs/node/commit/acf3019e021388f2eb3b23ca5a87721fff5db509
acf3019https://github.com/nodejs/node/commit/acf3019e021388f2eb3b23ca5a87721fff5db509
#20407https://github.com/nodejs/node/pull/20407
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20407#ref-commit-88f9c38
https://github.com/ChALkeR
https://github.com/MylesBorins
fs: fchmod->fchown in promises/lchownhttps://github.com/nodejs/node/commit/88f9c38e79e53a3f1141e2d29a831da2ae8df988
88f9c38https://github.com/nodejs/node/commit/88f9c38e79e53a3f1141e2d29a831da2ae8df988
#20407https://github.com/nodejs/node/pull/20407
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20407#ref-pullrequest-321253491
v10.1.0 proposal #20606 https://github.com/nodejs/node/pull/20606
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20407#ref-commit-0dec568
https://github.com/ChALkeR
https://github.com/MylesBorins
fs: remove broken code in promises/writehttps://github.com/nodejs/node/commit/0dec5684566db37c96d7e28e5bebd0849bdc8dd5
0dec568https://github.com/nodejs/node/commit/0dec5684566db37c96d7e28e5bebd0849bdc8dd5
#20407https://github.com/nodejs/node/pull/20407
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20407#ref-commit-f5ca39d
https://github.com/ChALkeR
https://github.com/MylesBorins
fs: fchmod->fchown in promises/lchownhttps://github.com/nodejs/node/commit/f5ca39dde59d828065a6ce607579e0f2ec414806
f5ca39dhttps://github.com/nodejs/node/commit/f5ca39dde59d828065a6ce607579e0f2ec414806
#20407https://github.com/nodejs/node/pull/20407
MylesBorinshttps://github.com/MylesBorins
May 9, 2018 https://github.com/nodejs/node/pull/20407#ref-commit-eb724f0
https://github.com/ChALkeR
https://github.com/MylesBorins
fs: remove broken code in promises/writehttps://github.com/nodejs/node/commit/eb724f00a359aec22079a9969e259b5b74ea3845
eb724f0https://github.com/nodejs/node/commit/eb724f00a359aec22079a9969e259b5b74ea3845
#20407https://github.com/nodejs/node/pull/20407
MylesBorinshttps://github.com/MylesBorins
May 9, 2018 https://github.com/nodejs/node/pull/20407#ref-commit-eb483db
https://github.com/ChALkeR
https://github.com/MylesBorins
fs: fchmod->fchown in promises/lchownhttps://github.com/nodejs/node/commit/eb483dbac57516f2920215682d81a8319ca25a8a
eb483dbhttps://github.com/nodejs/node/commit/eb483dbac57516f2920215682d81a8319ca25a8a
#20407https://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Aug 23, 2018 https://github.com/nodejs/node/pull/20407#ref-issue-353334184
dns.promises test coverage is poor #22471 https://github.com/nodejs/node/issues/22471
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20407
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20407/files/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/20407/files/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20407/files/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/20407/files/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
https://github.com/thefourtheye
thefourtheye https://github.com/thefourtheye
https://github.com/nodejs/node/pull/20407/files/e2ae64385c19eeba54f8d3d7baf49059adbb1d9e
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20407/files/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
https://github.com/davisjam
davisjam https://github.com/davisjam
https://github.com/nodejs/node/pull/20407/files/5b8c64d09ee2ac2a67f6b5c9dde7a7c4b1c3e3d1
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
Please reload this pagehttps://github.com/nodejs/node/pull/20407
https://github.com/ChALkeR
https://github.com/benjamingr
https://github.com/davisjam
https://github.com/mscdex
https://github.com/BridgeAR
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/vsemozhetbyt
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.