René's URL Explorer Experiment


Title: http2: compat avoid bind and properly cleanup stream by ronag · Pull Request #20374 · nodejs/node · GitHub

Open Graph Title: http2: compat avoid bind and properly cleanup stream by ronag · Pull Request #20374 · nodejs/node

X Title: http2: compat avoid bind and properly cleanup stream by ronag · Pull Request #20374 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Avoid unnecessary function bind. Also fixes a bug where kProxySocket was assigned null on the wrong object as well as properly cleanup the stream object. Checklis make -j4 test (UNIX), or vcbuild...

X Description: Avoid unnecessary function bind. Also fixes a bug where kProxySocket was assigned null on the wrong object as well as properly cleanup the stream object. Checklis make -j4 test (UNIX), or vcbuild...

Opengraph URL: https://github.com/nodejs/node/pull/20374

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1f2ad9c4-f2c2-26f4-ff1c-bbcd2fee26df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0EA:1F28AF:5F420C:7BEA9D:6991E1B1
html-safe-nonce874192f13053cfc51eb0e88f6e20b98fbe65dc7d540fa547cc1f9fac73b5877a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEVBOjFGMjhBRjo1RjQyMEM6N0JFQTlEOjY5OTFFMUIxIiwidmlzaXRvcl9pZCI6IjgxODk4NjIwMjc5ODYwNjc4ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8b343069f852d46765e0dc65bc6843fa73488dae05ef4333f26dd383198f7124
hovercard-subject-tagpull_request:184742255
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20374/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1deff06ec4d52bcabd3e78029a9f116ea3d5b96db307722734530814172861a/nodejs/node/pull/20374
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1deff06ec4d52bcabd3e78029a9f116ea3d5b96db307722734530814172861a/nodejs/node/pull/20374
og:image:altAvoid unnecessary function bind. Also fixes a bug where kProxySocket was assigned null on the wrong object as well as properly cleanup the stream object. Checklis make -j4 test (UNIX), or vcbuild...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20374#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20374
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20374
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20374
Reloadhttps://github.com/nodejs/node/pull/20374
Reloadhttps://github.com/nodejs/node/pull/20374
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20374
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http2-compat-perfhttps://github.com/nxtedition/node/tree/http2-compat-perf
Conversationhttps://github.com/nodejs/node/pull/20374
Commits1 (1)https://github.com/nodejs/node/pull/20374/commits
Checkshttps://github.com/nodejs/node/pull/20374/checks
Files changedhttps://github.com/nodejs/node/pull/20374/files
http2: compat avoid bind and properly cleanup streamhttps://github.com/nodejs/node/pull/20374#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http2-compat-perfhttps://github.com/nxtedition/node/tree/http2-compat-perf
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 27, 2018https://github.com/nodejs/node/pull/20374#issue-318568928
Please reload this pagehttps://github.com/nodejs/node/pull/20374
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Apr 27, 2018https://github.com/nodejs/node/pull/20374#event-1599763127
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/ebc8bb266cba8ea8998aaaa768f8aff646ce4418..34ad49a12c951ff71d2407a28381d25353b4558e
ebc8bb2https://github.com/nodejs/node/commit/ebc8bb266cba8ea8998aaaa768f8aff646ce4418
34ad49ahttps://github.com/nodejs/node/commit/34ad49a12c951ff71d2407a28381d25353b4558e
Compare https://github.com/nodejs/node/compare/ebc8bb266cba8ea8998aaaa768f8aff646ce4418..34ad49a12c951ff71d2407a28381d25353b4558e
April 27, 2018 23:02https://github.com/nodejs/node/pull/20374#event-1599786683
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 27, 2018https://github.com/nodejs/node/pull/20374#event-1599786779
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d57ba331e3320cc871ca5233b54767520af3e086..6c861609808a77f51cd82f3537d91fefd4cc3eb5
d57ba33https://github.com/nodejs/node/commit/d57ba331e3320cc871ca5233b54767520af3e086
6c86160https://github.com/nodejs/node/commit/6c861609808a77f51cd82f3537d91fefd4cc3eb5
Compare https://github.com/nodejs/node/compare/d57ba331e3320cc871ca5233b54767520af3e086..6c861609808a77f51cd82f3537d91fefd4cc3eb5
April 27, 2018 23:11https://github.com/nodejs/node/pull/20374#event-1599793566
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 27, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-116107542
View reviewed changes https://github.com/nodejs/node/pull/20374/files
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
mscdexhttps://github.com/mscdex
Apr 27, 2018https://github.com/nodejs/node/pull/20374#discussion_r184827195
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
ronaghttps://github.com/ronag
Apr 27, 2018https://github.com/nodejs/node/pull/20374#discussion_r184827684
Please reload this pagehttps://github.com/nodejs/node/pull/20374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/6c861609808a77f51cd82f3537d91fefd4cc3eb5..8a5874a15e4830a1339215498a7c9d1afc2a604a
6c86160https://github.com/nodejs/node/commit/6c861609808a77f51cd82f3537d91fefd4cc3eb5
8a5874ahttps://github.com/nodejs/node/commit/8a5874a15e4830a1339215498a7c9d1afc2a604a
Compare https://github.com/nodejs/node/compare/6c861609808a77f51cd82f3537d91fefd4cc3eb5..8a5874a15e4830a1339215498a7c9d1afc2a604a
April 27, 2018 23:37https://github.com/nodejs/node/pull/20374#event-1599815857
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 27, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-116108936
View reviewed changes https://github.com/nodejs/node/pull/20374/files
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
mscdexhttps://github.com/mscdex
Apr 27, 2018https://github.com/nodejs/node/pull/20374#discussion_r184828395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/8a5874a15e4830a1339215498a7c9d1afc2a604a..96b0de96453680f087475bd19f53db775a29afe0
8a5874ahttps://github.com/nodejs/node/commit/8a5874a15e4830a1339215498a7c9d1afc2a604a
96b0de9https://github.com/nodejs/node/commit/96b0de96453680f087475bd19f53db775a29afe0
Compare https://github.com/nodejs/node/compare/8a5874a15e4830a1339215498a7c9d1afc2a604a..96b0de96453680f087475bd19f53db775a29afe0
April 27, 2018 23:40https://github.com/nodejs/node/pull/20374#event-1599817967
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Apr 28, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-116122714
View reviewed changes https://github.com/nodejs/node/pull/20374/files
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/20374#pullrequestreview-116122714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841247
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841384
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841423
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184841445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/d7a0fbd74edd461f65dc0a92623b22849ec3d000..525429a7b00b4ead5420cf9a06ce52a19a1af856
d7a0fbdhttps://github.com/nodejs/node/commit/d7a0fbd74edd461f65dc0a92623b22849ec3d000
525429ahttps://github.com/nodejs/node/commit/525429a7b00b4ead5420cf9a06ce52a19a1af856
Compare https://github.com/nodejs/node/compare/d7a0fbd74edd461f65dc0a92623b22849ec3d000..525429a7b00b4ead5420cf9a06ce52a19a1af856
April 28, 2018 11:47https://github.com/nodejs/node/pull/20374#event-1600086005
https://github.com/ronag
ronaghttps://github.com/ronag
Apr 28, 2018https://github.com/nodejs/node/pull/20374#issuecomment-385169152
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/20d1dcef992e5901e610291f9813da86a539179d..93c4f7d5174f9259736577af68a36c9df6411dca
20d1dcehttps://github.com/nodejs/node/commit/20d1dcef992e5901e610291f9813da86a539179d
93c4f7dhttps://github.com/nodejs/node/commit/93c4f7d5174f9259736577af68a36c9df6411dca
Compare https://github.com/nodejs/node/compare/20d1dcef992e5901e610291f9813da86a539179d..93c4f7d5174f9259736577af68a36c9df6411dca
April 28, 2018 11:49https://github.com/nodejs/node/pull/20374#event-1600086658
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Apr 28, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-116138862
View reviewed changes https://github.com/nodejs/node/pull/20374/files
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184855558
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Apr 28, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-116138889
View reviewed changes https://github.com/nodejs/node/pull/20374/files
lib/internal/http2/compat.jshttps://github.com/nodejs/node/pull/20374/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#discussion_r184855586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/93c4f7d5174f9259736577af68a36c9df6411dca..823bc930f942adda4d99bd4946a2c0bbc37abcc1
93c4f7dhttps://github.com/nodejs/node/commit/93c4f7d5174f9259736577af68a36c9df6411dca
823bc93https://github.com/nodejs/node/commit/823bc930f942adda4d99bd4946a2c0bbc37abcc1
Compare https://github.com/nodejs/node/compare/93c4f7d5174f9259736577af68a36c9df6411dca..823bc930f942adda4d99bd4946a2c0bbc37abcc1
April 28, 2018 14:40https://github.com/nodejs/node/pull/20374#event-1600151285
https://github.com/ronag
http2: compat avoid bind and propertly cleanup stream.https://github.com/nodejs/node/pull/20374/commits/ae506532e959d1a375970c05d76a07905d5609aa
ae50653https://github.com/nodejs/node/pull/20374/commits/ae506532e959d1a375970c05d76a07905d5609aa
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/823bc930f942adda4d99bd4946a2c0bbc37abcc1..ae506532e959d1a375970c05d76a07905d5609aa
823bc93https://github.com/nodejs/node/commit/823bc930f942adda4d99bd4946a2c0bbc37abcc1
ae50653https://github.com/nodejs/node/commit/ae506532e959d1a375970c05d76a07905d5609aa
Compare https://github.com/nodejs/node/compare/823bc930f942adda4d99bd4946a2c0bbc37abcc1..ae506532e959d1a375970c05d76a07905d5609aa
April 28, 2018 14:41https://github.com/nodejs/node/pull/20374#event-1600151540
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Apr 28, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-116142261
View reviewed changes https://github.com/nodejs/node/pull/20374/files/ae506532e959d1a375970c05d76a07905d5609aa
apapirovskihttps://github.com/apapirovski
https://github.com/nodejs/node/pull/20374#pullrequestreview-116142261
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Apr 28, 2018https://github.com/nodejs/node/pull/20374#issuecomment-385188319
https://ci.nodejs.org/job/node-test-pull-request/14566/https://ci.nodejs.org/job/node-test-pull-request/14566/
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 29, 2018https://github.com/nodejs/node/pull/20374#event-1600534668
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 7, 2018https://github.com/nodejs/node/pull/20374#issuecomment-386996123
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 7, 2018https://github.com/nodejs/node/pull/20374#issuecomment-387010523
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 7, 2018https://github.com/nodejs/node/pull/20374#issuecomment-387011499
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 7, 2018https://github.com/nodejs/node/pull/20374#issuecomment-387011995
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 7, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-117992043
View reviewed changes https://github.com/nodejs/node/pull/20374/files/ae506532e959d1a375970c05d76a07905d5609aa
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 14, 2018https://github.com/nodejs/node/pull/20374#issuecomment-388881871
https://ci.nodejs.org/job/node-test-pull-request/14865/https://ci.nodejs.org/job/node-test-pull-request/14865/
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 14, 2018 https://github.com/nodejs/node/pull/20374#pullrequestreview-120033715
View reviewed changes https://github.com/nodejs/node/pull/20374/files/ae506532e959d1a375970c05d76a07905d5609aa
apapirovskihttps://github.com/apapirovski
May 16, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-0d762af
https://github.com/ronag
https://github.com/apapirovski
http2: avoid bind and properly clean up in compathttps://github.com/nodejs/node/commit/0d762af48ea4cc298d59724ef5c9d06ff2c6a066
0d762afhttps://github.com/nodejs/node/commit/0d762af48ea4cc298d59724ef5c9d06ff2c6a066
#20374https://github.com/nodejs/node/pull/20374
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 16, 2018https://github.com/nodejs/node/pull/20374#issuecomment-389392676
0d762afhttps://github.com/nodejs/node/commit/0d762af48ea4cc298d59724ef5c9d06ff2c6a066
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 16, 2018https://github.com/nodejs/node/pull/20374#event-1628706231
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-de2b047
https://github.com/ronag
https://github.com/MylesBorins
http2: avoid bind and properly clean up in compathttps://github.com/nodejs/node/commit/de2b04772b9bd298363668f59266cefb811818ca
de2b047https://github.com/nodejs/node/commit/de2b04772b9bd298363668f59266cefb811818ca
#20374https://github.com/nodejs/node/pull/20374
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/20374#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
kjinhttps://github.com/kjin
Aug 23, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-101361c
https://github.com/ronag
https://github.com/kjin
http2: avoid bind and properly clean up in compathttps://github.com/kjin/node/commit/101361c2529875413b9defd7a1fe51bee3485b54
101361chttps://github.com/kjin/node/commit/101361c2529875413b9defd7a1fe51bee3485b54
nodejs#20374https://github.com/nodejs/node/pull/20374
kjinhttps://github.com/kjin
Sep 11, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-fce762e
https://github.com/ronag
https://github.com/kjin
http2: avoid bind and properly clean up in compathttps://github.com/kjin/node/commit/fce762e298c01ff079d7b4765182ea2dfa77d1cf
fce762ehttps://github.com/kjin/node/commit/fce762e298c01ff079d7b4765182ea2dfa77d1cf
nodejs#20374https://github.com/nodejs/node/pull/20374
kjinhttps://github.com/kjin
Sep 19, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-6f5b38f
https://github.com/ronag
https://github.com/kjin
http2: avoid bind and properly clean up in compathttps://github.com/kjin/node/commit/6f5b38f090b76d3137007934eaec4d700559678e
6f5b38fhttps://github.com/kjin/node/commit/6f5b38f090b76d3137007934eaec4d700559678e
nodejs#20374https://github.com/nodejs/node/pull/20374
kjinhttps://github.com/kjin
Oct 16, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-11f194f
https://github.com/ronag
https://github.com/kjin
http2: avoid bind and properly clean up in compathttps://github.com/kjin/node/commit/11f194ff7491a24a0c2047f19ff7c4e4507ff1b5
11f194fhttps://github.com/kjin/node/commit/11f194ff7491a24a0c2047f19ff7c4e4507ff1b5
nodejs#20374https://github.com/nodejs/node/pull/20374
BethGriggshttps://github.com/BethGriggs
Oct 17, 2018 https://github.com/nodejs/node/pull/20374#ref-commit-d1b7825
https://github.com/ronag
https://github.com/BethGriggs
http2: avoid bind and properly clean up in compathttps://github.com/nodejs/node/commit/d1b78252b18a212e49f49bb03bc5ebbd61e88ff5
d1b7825https://github.com/nodejs/node/commit/d1b78252b18a212e49f49bb03bc5ebbd61e88ff5
#22850https://github.com/nodejs/node/pull/22850
#20374https://github.com/nodejs/node/pull/20374
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 30, 2018 https://github.com/nodejs/node/pull/20374#ref-pullrequest-375564151
v8.13.0 proposal #23974 https://github.com/nodejs/node/pull/23974
https://github.com/beevelop
beevelophttps://github.com/beevelop
Nov 20, 2018 https://github.com/nodejs/node/pull/20374#ref-issue-382804528
2018-11-20 Version 8.13.0 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#250 https://github.com/beevelop/docker-android-nodejs/issues/250
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20374
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20374/files/ae506532e959d1a375970c05d76a07905d5609aa
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20374/files/ae506532e959d1a375970c05d76a07905d5609aa
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/20374/files/8a5874a15e4830a1339215498a7c9d1afc2a604a
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/20374/files/ae506532e959d1a375970c05d76a07905d5609aa
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/20374
https://github.com/ronag
https://github.com/apapirovski
https://github.com/mcollina
https://github.com/mscdex
https://github.com/jasnell
https://github.com/trivikr
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.