René's URL Explorer Experiment


Title: tools: add eslint check for skipIfEslintMissing by richardlau · Pull Request #20372 · nodejs/node · GitHub

Open Graph Title: tools: add eslint check for skipIfEslintMissing by richardlau · Pull Request #20372 · nodejs/node

X Title: tools: add eslint check for skipIfEslintMissing by richardlau · Pull Request #20372 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Add a custom eslint rule to check for common.skipIfEslintMissing() to allow tests to run from source tarballs that do not include eslint. Fix up tests that were failing the new check. Refs: #20336 ...

X Description: Add a custom eslint rule to check for common.skipIfEslintMissing() to allow tests to run from source tarballs that do not include eslint. Fix up tests that were failing the new check. Refs: #20336 ...

Opengraph URL: https://github.com/nodejs/node/pull/20372

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c253599f-bd80-c6e5-34e9-88235643cc10
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8DA:C5131:35695F:45B0D7:69920DC7
html-safe-nonceac12225b931edebd0f6754b023c3da4dc4ce6e837cd5bc9fbe5f75b148e95a48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOERBOkM1MTMxOjM1Njk1Rjo0NUIwRDc6Njk5MjBEQzciLCJ2aXNpdG9yX2lkIjoiMTc2MTUxNzYzNzc4MTgxODgyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb30dc22bcdb4bebc1a065ed6f9948f7f3ee28d10294b5a22d697e6ea555a57ab
hovercard-subject-tagpull_request:184714983
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20372/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7494f504a6c9df4b91dbc974a229de16129c5e5db535a9fd66c81dc22bdcf4a1/nodejs/node/pull/20372
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7494f504a6c9df4b91dbc974a229de16129c5e5db535a9fd66c81dc22bdcf4a1/nodejs/node/pull/20372
og:image:altAdd a custom eslint rule to check for common.skipIfEslintMissing() to allow tests to run from source tarballs that do not include eslint. Fix up tests that were failing the new check. Refs: #20336 ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20372#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20372
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20372
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20372
Reloadhttps://github.com/nodejs/node/pull/20372
Reloadhttps://github.com/nodejs/node/pull/20372
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20372
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:eslintcheckhttps://github.com/richardlau/node-1/tree/eslintcheck
Conversationhttps://github.com/nodejs/node/pull/20372
Commits1 (1)https://github.com/nodejs/node/pull/20372/commits
Checkshttps://github.com/nodejs/node/pull/20372/checks
Files changedhttps://github.com/nodejs/node/pull/20372/files
tools: add eslint check for skipIfEslintMissinghttps://github.com/nodejs/node/pull/20372#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:eslintcheckhttps://github.com/richardlau/node-1/tree/eslintcheck
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issue-318533007
Please reload this pagehttps://github.com/nodejs/node/pull/20372
#20336 (comment)https://github.com/nodejs/node/issues/20336#issuecomment-385046748
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Apr 27, 2018https://github.com/nodejs/node/pull/20372#event-1599541183
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 27, 2018 https://github.com/nodejs/node/pull/20372#pullrequestreview-116066978
View reviewed changes https://github.com/nodejs/node/pull/20372/files
tools/eslint-rules/eslint-check.jshttps://github.com/nodejs/node/pull/20372/files#diff-c95b06e00f094f13c7bc2119377fbf07cc58193cd32b45e6842b8796abdb432e
addaleaxhttps://github.com/addaleax
Apr 27, 2018https://github.com/nodejs/node/pull/20372#discussion_r184793340
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20372
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#discussion_r184794566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018 https://github.com/nodejs/node/pull/20372#ref-issue-318094903
mips failures for parallel/test-buffer-write(float|double) #20336 https://github.com/nodejs/node/issues/20336
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385085309
https://ci.nodejs.org/job/node-test-commit-plinux/nodes=ppcle-ubuntu1404/17266/consolehttps://ci.nodejs.org/job/node-test-commit-plinux/nodes=ppcle-ubuntu1404/17266/console
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385087583
#19701https://github.com/nodejs/node/pull/19701
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385089939
https://ci.nodejs.org/job/node-test-pull-request/14555/https://ci.nodejs.org/job/node-test-pull-request/14555/
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/refack
refackhttps://github.com/refack
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385090872
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385092591
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385095346
Please reload this pagehttps://github.com/nodejs/node/pull/20372
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/refack
refackhttps://github.com/refack
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385096178
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/refack
refackhttps://github.com/refack
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385096635
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385098352
node/test/common/index.jshttps://github.com/nodejs/node/blob/a4b4854e2ff0f3de69caa5e46d001575b9e22273/test/common/index.js#L495-L501
a4b4854https://github.com/nodejs/node/commit/a4b4854e2ff0f3de69caa5e46d001575b9e22273
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/refack
refackhttps://github.com/refack
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385112181
node/test/common/index.jshttps://github.com/nodejs/node/blob/a4b4854e2ff0f3de69caa5e46d001575b9e22273/test/common/index.js#L496
a4b4854https://github.com/nodejs/node/commit/a4b4854e2ff0f3de69caa5e46d001575b9e22273
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385119612
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 28, 2018https://github.com/nodejs/node/pull/20372#issuecomment-385141527
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://ci.nodejs.org/job/node-test-commit-arm-fanned/829/https://ci.nodejs.org/job/node-test-commit-arm-fanned/829/
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 28, 2018 https://github.com/nodejs/node/pull/20372#pullrequestreview-116147652
View reviewed changes https://github.com/nodejs/node/pull/20372/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 3, 2018 https://github.com/nodejs/node/pull/20372#pullrequestreview-117455676
View reviewed changes https://github.com/nodejs/node/pull/20372/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 3, 2018 https://github.com/nodejs/node/pull/20372#pullrequestreview-117464684
View reviewed changes https://github.com/nodejs/node/pull/20372/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 4, 2018https://github.com/nodejs/node/pull/20372#issuecomment-386614702
@refackhttps://github.com/refack
#20336https://github.com/nodejs/node/issues/20336
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
tools: add eslint check for skipIfEslintMissinghttps://github.com/nodejs/node/pull/20372/commits/870ae722279678a6d4f49b664bd4fba2051fbf4a
870ae72https://github.com/nodejs/node/pull/20372/commits/870ae722279678a6d4f49b664bd4fba2051fbf4a
nodejs#20336https://github.com/nodejs/node/issues/20336
nodejs#20372https://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/4be9ad2fea2d763e3258d1d5ef4df28fd0e40bad..870ae722279678a6d4f49b664bd4fba2051fbf4a
4be9ad2https://github.com/nodejs/node/commit/4be9ad2fea2d763e3258d1d5ef4df28fd0e40bad
870ae72https://github.com/nodejs/node/commit/870ae722279678a6d4f49b664bd4fba2051fbf4a
Compare https://github.com/nodejs/node/compare/4be9ad2fea2d763e3258d1d5ef4df28fd0e40bad..870ae722279678a6d4f49b664bd4fba2051fbf4a
May 8, 2018 14:45https://github.com/nodejs/node/pull/20372#event-1615477500
https://github.com/richardlau
richardlauhttps://github.com/richardlau
870ae72https://github.com/nodejs/node/commit/870ae722279678a6d4f49b664bd4fba2051fbf4a
May 8, 2018https://github.com/nodejs/node/pull/20372#event-1615481875
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 8, 2018https://github.com/nodejs/node/pull/20372#issuecomment-387428166
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 8, 2018 14:48https://github.com/nodejs/node/pull/20372#event-1615484971
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20372#ref-commit-aad2c23
https://github.com/richardlau
https://github.com/MylesBorins
tools: add eslint check for skipIfEslintMissinghttps://github.com/nodejs/node/commit/aad2c23dcac7e490f6fb4377c49abb409fda0802
aad2c23https://github.com/nodejs/node/commit/aad2c23dcac7e490f6fb4377c49abb409fda0802
#20336https://github.com/nodejs/node/issues/20336
#20372https://github.com/nodejs/node/pull/20372
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20372#ref-pullrequest-321253491
v10.1.0 proposal #20606 https://github.com/nodejs/node/pull/20606
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20372#ref-commit-f17a711
https://github.com/richardlau
https://github.com/MylesBorins
tools: add eslint check for skipIfEslintMissinghttps://github.com/nodejs/node/commit/f17a71181e89a6a74352fab30d6ca1ec18abdee5
f17a711https://github.com/nodejs/node/commit/f17a71181e89a6a74352fab30d6ca1ec18abdee5
#20336https://github.com/nodejs/node/issues/20336
#20372https://github.com/nodejs/node/pull/20372
MylesBorinshttps://github.com/MylesBorins
May 9, 2018 https://github.com/nodejs/node/pull/20372#ref-commit-f7267b4
https://github.com/richardlau
https://github.com/MylesBorins
tools: add eslint check for skipIfEslintMissinghttps://github.com/nodejs/node/commit/f7267b4af0b6a2d2284764c5311cab741171bbf6
f7267b4https://github.com/nodejs/node/commit/f7267b4af0b6a2d2284764c5311cab741171bbf6
#20336https://github.com/nodejs/node/issues/20336
#20372https://github.com/nodejs/node/pull/20372
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 10, 2018 https://github.com/nodejs/node/pull/20372#ref-pullrequest-329590999
[v9.x backport] assert: fix diff color output #21154 https://github.com/nodejs/node/pull/21154
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 23, 2018 https://github.com/nodejs/node/pull/20372#ref-issue-383780104
make test error - Error: Cannot find module '../../tools/eslint' #24579 https://github.com/nodejs/node/issues/24579
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20372
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20372/files/4be9ad2fea2d763e3258d1d5ef4df28fd0e40bad
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/20372/files/4be9ad2fea2d763e3258d1d5ef4df28fd0e40bad
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/20372/files/fa5947d6eb3f5708f48e85ccbec6e5b719d8ff3d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20372/files/4be9ad2fea2d763e3258d1d5ef4df28fd0e40bad
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/20372
https://github.com/richardlau
https://github.com/refack
https://github.com/jasnell
https://github.com/Trott
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.