René's URL Explorer Experiment


Title: tools: fix TypeError from `test.py --time` by richardlau · Pull Request #20368 · nodejs/node · GitHub

Open Graph Title: tools: fix TypeError from `test.py --time` by richardlau · Pull Request #20368 · nodejs/node

X Title: tools: fix TypeError from `test.py --time` by richardlau · Pull Request #20368 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. Fixes: #20341 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit me...

X Description: Calculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. Fixes: #20341 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit me...

Opengraph URL: https://github.com/nodejs/node/pull/20368

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:899997bf-a38e-7647-4524-42d61a073cdc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC858:1BCE7D:168DF59:1CF1AC0:69925F7C
html-safe-nonce1614e80437ef514163c59998f8504e867dbd1751c8298fd40fe56f07025349c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODU4OjFCQ0U3RDoxNjhERjU5OjFDRjFBQzA6Njk5MjVGN0MiLCJ2aXNpdG9yX2lkIjoiODY5MjE1ODEwMTA2NTk4MTgyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace19d02772b21db7124f20fb483fb139c8aedd1f538cd0ed3fba86359006e4279
hovercard-subject-tagpull_request:184694630
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20368/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c277a600fd4d0a50b375bc0a390f64f1567e0f01e9bd1cf1196688561dd4b9d5/nodejs/node/pull/20368
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c277a600fd4d0a50b375bc0a390f64f1567e0f01e9bd1cf1196688561dd4b9d5/nodejs/node/pull/20368
og:image:altCalculated durations are timedelta objects but the FormatTime function is expecting a number in seconds. Fixes: #20341 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit me...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerichardlau
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20368#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20368
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20368
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20368
Reloadhttps://github.com/nodejs/node/pull/20368
Reloadhttps://github.com/nodejs/node/pull/20368
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20368
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 717 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:testpytimehttps://github.com/richardlau/node-1/tree/testpytime
Conversationhttps://github.com/nodejs/node/pull/20368
Commits1 (1)https://github.com/nodejs/node/pull/20368/commits
Checkshttps://github.com/nodejs/node/pull/20368/checks
Files changedhttps://github.com/nodejs/node/pull/20368/files
tools: fix TypeError from test.py --timehttps://github.com/nodejs/node/pull/20368#top
richardlauhttps://github.com/richardlau
nodejs:masterhttps://github.com/nodejs/node/tree/master
richardlau:testpytimehttps://github.com/richardlau/node-1/tree/testpytime
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20368#issue-318505597
#20341https://github.com/nodejs/node/issues/20341
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20368
https://github.com/richardlau
tools: fix TypeError from test.py --timehttps://github.com/nodejs/node/pull/20368/commits/1fcb189fb89ec179011042d84ec7fc6b7d4ee592
1fcb189https://github.com/nodejs/node/pull/20368/commits/1fcb189fb89ec179011042d84ec7fc6b7d4ee592
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Apr 27, 2018https://github.com/nodejs/node/pull/20368#event-1599376222
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018 https://github.com/nodejs/node/pull/20368#ref-issue-318167638
test.py --time throws TypeError: a float is required #20341 https://github.com/nodejs/node/issues/20341
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20368#issuecomment-385056165
https://ci.nodejs.org/job/node-test-pull-request/14550/https://ci.nodejs.org/job/node-test-pull-request/14550/
Please reload this pagehttps://github.com/nodejs/node/pull/20368
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 27, 2018https://github.com/nodejs/node/pull/20368#issuecomment-385079761
Please reload this pagehttps://github.com/nodejs/node/pull/20368
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 29, 2018https://github.com/nodejs/node/pull/20368#issuecomment-385253429
Please reload this pagehttps://github.com/nodejs/node/pull/20368
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Apr 29, 2018https://github.com/nodejs/node/pull/20368#event-1600535484
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 29, 2018 https://github.com/nodejs/node/pull/20368#pullrequestreview-116171889
View reviewed changes https://github.com/nodejs/node/pull/20368/files/1fcb189fb89ec179011042d84ec7fc6b7d4ee592
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 29, 2018https://github.com/nodejs/node/pull/20368#event-1600599847
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 3, 2018 https://github.com/nodejs/node/pull/20368#pullrequestreview-117139292
View reviewed changes https://github.com/nodejs/node/pull/20368/files/1fcb189fb89ec179011042d84ec7fc6b7d4ee592
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 3, 2018https://github.com/nodejs/node/pull/20368#issuecomment-386194236
ab15198https://github.com/nodejs/node/commit/ab15198471cdd62b9c98619b033ac17f0f56d01e
Please reload this pagehttps://github.com/nodejs/node/pull/20368
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 3, 2018https://github.com/nodejs/node/pull/20368#event-1606918293
trivikrhttps://github.com/trivikr
May 3, 2018 https://github.com/nodejs/node/pull/20368#ref-commit-ab15198
https://github.com/richardlau
https://github.com/trivikr
tools: fix TypeError from test.py --timehttps://github.com/nodejs/node/commit/ab15198471cdd62b9c98619b033ac17f0f56d01e
ab15198https://github.com/nodejs/node/commit/ab15198471cdd62b9c98619b033ac17f0f56d01e
#20368https://github.com/nodejs/node/pull/20368
#20341https://github.com/nodejs/node/issues/20341
MylesBorinshttps://github.com/MylesBorins
May 4, 2018 https://github.com/nodejs/node/pull/20368#ref-commit-f6d37f2
https://github.com/richardlau
https://github.com/MylesBorins
tools: fix TypeError from test.py --timehttps://github.com/nodejs/node/commit/f6d37f2bee17a4b1efd8d3a60a6769d1e86c0a96
f6d37f2https://github.com/nodejs/node/commit/f6d37f2bee17a4b1efd8d3a60a6769d1e86c0a96
#20368https://github.com/nodejs/node/pull/20368
#20341https://github.com/nodejs/node/issues/20341
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20368#ref-pullrequest-321253491
v10.1.0 proposal #20606 https://github.com/nodejs/node/pull/20606
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20368#ref-commit-3912551
https://github.com/richardlau
https://github.com/MylesBorins
tools: fix TypeError from test.py --timehttps://github.com/nodejs/node/commit/3912551252cea6bf9422c4150fd9a95fe69fc1af
3912551https://github.com/nodejs/node/commit/3912551252cea6bf9422c4150fd9a95fe69fc1af
#20368https://github.com/nodejs/node/pull/20368
#20341https://github.com/nodejs/node/issues/20341
MylesBorinshttps://github.com/MylesBorins
Aug 17, 2018 https://github.com/nodejs/node/pull/20368#ref-commit-246c2d1
https://github.com/richardlau
https://github.com/MylesBorins
tools: fix TypeError from test.py --timehttps://github.com/nodejs/node/commit/246c2d18cb5cf7ff7b3952b15e49034f25bc0c4c
246c2d1https://github.com/nodejs/node/commit/246c2d18cb5cf7ff7b3952b15e49034f25bc0c4c
#20368https://github.com/nodejs/node/pull/20368
#20341https://github.com/nodejs/node/issues/20341
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Aug 17, 2018 https://github.com/nodejs/node/pull/20368#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20368
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/20368/files/1fcb189fb89ec179011042d84ec7fc6b7d4ee592
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20368/files/1fcb189fb89ec179011042d84ec7fc6b7d4ee592
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/20368
https://github.com/richardlau
https://github.com/BridgeAR
https://github.com/trivikr
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.