René's URL Explorer Experiment


Title: crypto: add checkIsArrayBufferView by danbev · Pull Request #20251 · nodejs/node · GitHub

Open Graph Title: crypto: add checkIsArrayBufferView by danbev · Pull Request #20251 · nodejs/node

X Title: crypto: add checkIsArrayBufferView by danbev · Pull Request #20251 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit adds a checkIsArrayBufferView function to avoid some code duplication in sig.js Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidel...

X Description: This commit adds a checkIsArrayBufferView function to avoid some code duplication in sig.js Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidel...

Opengraph URL: https://github.com/nodejs/node/pull/20251

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:45d63f24-a78c-299a-6e06-9d4cc8814e14
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC7E:2464D3:5B5622:7724AC:69927818
html-safe-noncec0666c07fd2dc50a2b4b0d94ea8910f834a5282e3b0284ee66a7f2fd6392fd3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzdFOjI0NjREMzo1QjU2MjI6NzcyNEFDOjY5OTI3ODE4IiwidmlzaXRvcl9pZCI6IjUzODgzMzQ1MTgzMjQ3MzYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2c6e5b4f4749c8344a5128da2d12c51e1b526845b572d587cca6133ea1ac94a7
hovercard-subject-tagpull_request:183713036
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20251/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c7ad5e8f5751fef349830ce6c81000b3caa20ed949d7b9700611d4ce92ceff0/nodejs/node/pull/20251
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c7ad5e8f5751fef349830ce6c81000b3caa20ed949d7b9700611d4ce92ceff0/nodejs/node/pull/20251
og:image:altThis commit adds a checkIsArrayBufferView function to avoid some code duplication in sig.js Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20251#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20251
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20251
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20251
Reloadhttps://github.com/nodejs/node/pull/20251
Reloadhttps://github.com/nodejs/node/pull/20251
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20251
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 716 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_sig_check_is_array_buffer_viewhttps://github.com/danbev/node/tree/crypto_sig_check_is_array_buffer_view
Conversationhttps://github.com/nodejs/node/pull/20251
Commits4 (4)https://github.com/nodejs/node/pull/20251/commits
Checkshttps://github.com/nodejs/node/pull/20251/checks
Files changedhttps://github.com/nodejs/node/pull/20251/files
crypto: add checkIsArrayBufferViewhttps://github.com/nodejs/node/pull/20251#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_sig_check_is_array_buffer_viewhttps://github.com/danbev/node/tree/crypto_sig_check_is_array_buffer_view
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 24, 2018https://github.com/nodejs/node/pull/20251#issue-317194764
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20251
https://github.com/danbev
crypto: add checkIsArrayBufferViewhttps://github.com/nodejs/node/pull/20251/commits/57406df0d6764b4d61085b480ae1a6e06af3f84d
57406dfhttps://github.com/nodejs/node/pull/20251/commits/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Apr 24, 2018https://github.com/nodejs/node/pull/20251#event-1591403918
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 24, 2018https://github.com/nodejs/node/pull/20251#issuecomment-383905872
https://ci.nodejs.org/job/node-test-pull-request/14473/https://ci.nodejs.org/job/node-test-pull-request/14473/
Please reload this pagehttps://github.com/nodejs/node/pull/20251
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114765175
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20251#pullrequestreview-114765175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/20251
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114782518
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114814973
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114819916
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114832996
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114842813
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-114848211
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/lpinca
lpincahttps://github.com/lpinca
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 24, 2018https://github.com/nodejs/node/pull/20251#event-1592554346
https://github.com/RatoX
RatoXhttps://github.com/RatoX
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-115003128
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/RodolfoSilva
RodolfoSilvahttps://github.com/RodolfoSilva
Apr 24, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-115004433
View reviewed changes https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 25, 2018https://github.com/nodejs/node/pull/20251#issuecomment-384156035
Please reload this pagehttps://github.com/nodejs/node/pull/20251
danbevhttps://github.com/danbev
April 25, 2018 07:37https://github.com/nodejs/node/pull/20251#commits-pushed-118a012
https://github.com/danbev
squash: switch order of parametershttps://github.com/nodejs/node/pull/20251/commits/118a012530d96f4b6f8cf5d17afc87836ac4d207
118a012https://github.com/nodejs/node/pull/20251/commits/118a012530d96f4b6f8cf5d17afc87836ac4d207
https://github.com/danbev
squash: move checkIsArrayBufferView to utilhttps://github.com/nodejs/node/pull/20251/commits/af79dadc9201d4fa4900b29e040c2a9f89e307a9
af79dadhttps://github.com/nodejs/node/pull/20251/commits/af79dadc9201d4fa4900b29e040c2a9f89e307a9
https://github.com/danbev
crypto: make pbkdf2 use checkIsArrayBufferViewhttps://github.com/nodejs/node/pull/20251/commits/a6a66ecceb9e26ea8513f98aa46f7ad40d26d457
a6a66echttps://github.com/nodejs/node/pull/20251/commits/a6a66ecceb9e26ea8513f98aa46f7ad40d26d457
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 25, 2018https://github.com/nodejs/node/pull/20251#issuecomment-384187491
https://ci.nodejs.org/job/node-test-pull-request/14487/https://ci.nodejs.org/job/node-test-pull-request/14487/
Please reload this pagehttps://github.com/nodejs/node/pull/20251
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 25, 2018 https://github.com/nodejs/node/pull/20251#pullrequestreview-115100841
View reviewed changes https://github.com/nodejs/node/pull/20251/files/a6a66ecceb9e26ea8513f98aa46f7ad40d26d457
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 26, 2018https://github.com/nodejs/node/pull/20251#issuecomment-384523142
fe70af9https://github.com/nodejs/node/commit/fe70af90726b8105b10e172996561685133e4662
2061248https://github.com/nodejs/node/commit/20612486d9c56b4e1f3c8f28b9edd827ceaa0500
Please reload this pagehttps://github.com/nodejs/node/pull/20251
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 26, 2018https://github.com/nodejs/node/pull/20251#event-1595672755
danbevhttps://github.com/danbev
Apr 26, 2018 https://github.com/nodejs/node/pull/20251#ref-commit-fe70af9
https://github.com/danbev
crypto: add checkIsArrayBufferViewhttps://github.com/nodejs/node/commit/fe70af90726b8105b10e172996561685133e4662
fe70af9https://github.com/nodejs/node/commit/fe70af90726b8105b10e172996561685133e4662
#20251https://github.com/nodejs/node/pull/20251
danbevhttps://github.com/danbev
Apr 26, 2018 https://github.com/nodejs/node/pull/20251#ref-commit-2061248
https://github.com/danbev
crypto: make pbkdf2 use checkIsArrayBufferViewhttps://github.com/nodejs/node/commit/20612486d9c56b4e1f3c8f28b9edd827ceaa0500
2061248https://github.com/nodejs/node/commit/20612486d9c56b4e1f3c8f28b9edd827ceaa0500
#20251https://github.com/nodejs/node/pull/20251
https://github.com/danbev
danbevhttps://github.com/danbev
April 26, 2018 06:01https://github.com/nodejs/node/pull/20251#event-1595673010
MylesBorinshttps://github.com/MylesBorins
May 4, 2018 https://github.com/nodejs/node/pull/20251#ref-commit-61e9396
https://github.com/danbev
https://github.com/MylesBorins
crypto: add checkIsArrayBufferViewhttps://github.com/nodejs/node/commit/61e93963ce326d35de9dcecaae43c22d8c7f8c2c
61e9396https://github.com/nodejs/node/commit/61e93963ce326d35de9dcecaae43c22d8c7f8c2c
#20251https://github.com/nodejs/node/pull/20251
MylesBorinshttps://github.com/MylesBorins
May 4, 2018 https://github.com/nodejs/node/pull/20251#ref-commit-e17280e
https://github.com/danbev
https://github.com/MylesBorins
crypto: make pbkdf2 use checkIsArrayBufferViewhttps://github.com/nodejs/node/commit/e17280e8c94e18740909e66081dae0801114e2f8
e17280ehttps://github.com/nodejs/node/commit/e17280e8c94e18740909e66081dae0801114e2f8
#20251https://github.com/nodejs/node/pull/20251
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 8, 2018 https://github.com/nodejs/node/pull/20251#ref-pullrequest-321253491
v10.1.0 proposal #20606 https://github.com/nodejs/node/pull/20606
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20251
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/20251/files/a6a66ecceb9e26ea8513f98aa46f7ad40d26d457
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/RodolfoSilva
RodolfoSilva https://github.com/RodolfoSilva
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
https://github.com/RatoX
RatoX https://github.com/RatoX
https://github.com/nodejs/node/pull/20251/files/57406df0d6764b4d61085b480ae1a6e06af3f84d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/20251
https://github.com/danbev
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/RodolfoSilva
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/RatoX
https://github.com/joyeecheung
https://github.com/trivikr
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.