| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:679bd518-0c90-5aa0-4f29-81f76afe9073 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED84:202BCA:2C171FC:381E889:6991B59E |
| html-safe-nonce | 27bc6de338cdafcfd0005a405f8a2a977b5e92687be9a0f293163210e48e7c63 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDg0OjIwMkJDQToyQzE3MUZDOjM4MUU4ODk6Njk5MUI1OUUiLCJ2aXNpdG9yX2lkIjoiNjA1NDg0MDc3MzA1NjI0NzE5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9ab5e74b8f8f322c4e9e190d3764f0ea81216b6c0f5756822cff73f59ac05475 |
| hovercard-subject-tag | pull_request:183393476 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20221/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/22aae4d00ce20dad2980502120d0e8ecbf1f71685c85d447b5f7a232fafa9525/nodejs/node/pull/20221 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/22aae4d00ce20dad2980502120d0e8ecbf1f71685c85d447b5f7a232fafa9525/nodejs/node/pull/20221 |
| og:image:alt | This commit removes the usage of the deprectated
crypto.DEFAULT_ENCODING.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | danbev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/20221#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20221 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20221 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/20221 |
| Reload | https://github.com/nodejs/node/pull/20221 |
| Reload | https://github.com/nodejs/node/pull/20221 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/20221 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:crypto_remove_crypto.DEFAULT_ENCODING_usage | https://github.com/danbev/node/tree/crypto_remove_crypto.DEFAULT_ENCODING_usage |
| Conversation | https://github.com/nodejs/node/pull/20221 |
| Commits1 (1) | https://github.com/nodejs/node/pull/20221/commits |
| Checks | https://github.com/nodejs/node/pull/20221/checks |
| Files changed | https://github.com/nodejs/node/pull/20221/files |
| test: remove crypto.DEFAULT_ENCODING usage | https://github.com/nodejs/node/pull/20221#top |
| danbev | https://github.com/danbev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| danbev:crypto_remove_crypto.DEFAULT_ENCODING_usage | https://github.com/danbev/node/tree/crypto_remove_crypto.DEFAULT_ENCODING_usage |
|
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 23, 2018 | https://github.com/nodejs/node/pull/20221#issue-316756962 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/20221 |
|
| https://github.com/danbev |
| test: remove crypto.DEFAULT_ENCODING usage | https://github.com/nodejs/node/pull/20221/commits/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
| 44c9fc7 | https://github.com/nodejs/node/pull/20221/commits/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Apr 23, 2018 | https://github.com/nodejs/node/pull/20221#event-1588821201 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 23, 2018 | https://github.com/nodejs/node/pull/20221#issuecomment-383532557 |
| https://ci.nodejs.org/job/node-test-pull-request/14437/ | https://ci.nodejs.org/job/node-test-pull-request/14437/ |
| Please reload this page | https://github.com/nodejs/node/pull/20221 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Apr 23, 2018
| https://github.com/nodejs/node/pull/20221#pullrequestreview-114402725 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20221/files/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 23, 2018 | https://github.com/nodejs/node/pull/20221#event-1589261227 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 23, 2018
| https://github.com/nodejs/node/pull/20221#pullrequestreview-114473245 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20221/files/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Apr 24, 2018
| https://github.com/nodejs/node/pull/20221#pullrequestreview-114677951 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/20221/files/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 25, 2018 | https://github.com/nodejs/node/pull/20221#issuecomment-384156338 |
| c521a20 | https://github.com/nodejs/node/commit/c521a20f43a12368625ce9bb42b67af1572a04b8 |
| Please reload this page | https://github.com/nodejs/node/pull/20221 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| Apr 25, 2018 | https://github.com/nodejs/node/pull/20221#event-1593122530 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
| April 25, 2018 04:20 | https://github.com/nodejs/node/pull/20221#event-1593122712 |
| danbev | https://github.com/danbev |
|
Apr 25, 2018
| https://github.com/nodejs/node/pull/20221#ref-commit-c521a20 |
|
| https://github.com/danbev |
| test: remove crypto.DEFAULT_ENCODING usage | https://github.com/danbev/node/commit/c521a20f43a12368625ce9bb42b67af1572a04b8 |
| c521a20 | https://github.com/danbev/node/commit/c521a20f43a12368625ce9bb42b67af1572a04b8 |
| nodejs#20221 | https://github.com/nodejs/node/pull/20221 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| May 4, 2018 | https://github.com/nodejs/node/pull/20221#event-1610155088 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| May 4, 2018 | https://github.com/nodejs/node/pull/20221#issuecomment-386643706 |
| the guide | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/20221 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 12, 2018
| https://github.com/nodejs/node/pull/20221#ref-issue-322546334 |
|
Need help to backport crypto changes to v10.x-staging
#20691
| https://github.com/nodejs/node/issues/20691 |
| tniessen | https://github.com/tniessen |
|
May 13, 2018
| https://github.com/nodejs/node/pull/20221#ref-commit-9e9dad6 |
|
| https://github.com/danbev |
|
| https://github.com/tniessen |
| test: remove crypto.DEFAULT_ENCODING usage | https://github.com/tniessen/node/commit/9e9dad689afe2bd7987a0e7d41faf7a5948a901d |
| 9e9dad6 | https://github.com/tniessen/node/commit/9e9dad689afe2bd7987a0e7d41faf7a5948a901d |
| nodejs#20221 | https://github.com/nodejs/node/pull/20221 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
May 13, 2018
| https://github.com/nodejs/node/pull/20221#ref-pullrequest-322616197 |
|
(v10.x backport) Backport 12 crypto commits
#20706
| https://github.com/nodejs/node/pull/20706 |
| addaleax | https://github.com/addaleax |
|
May 14, 2018
| https://github.com/nodejs/node/pull/20221#ref-commit-eb21a6b |
|
| https://github.com/danbev |
|
| https://github.com/addaleax |
| test: remove crypto.DEFAULT_ENCODING usage | https://github.com/nodejs/node/commit/eb21a6b7f6995b914c1897f89bae78c575ac8919 |
| eb21a6b | https://github.com/nodejs/node/commit/eb21a6b7f6995b914c1897f89bae78c575ac8919 |
| #20706 | https://github.com/nodejs/node/pull/20706 |
| #20221 | https://github.com/nodejs/node/pull/20221 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
May 14, 2018
| https://github.com/nodejs/node/pull/20221#ref-pullrequest-322922249 |
|
v10.2.0 proposal
#20724
| https://github.com/nodejs/node/pull/20724 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x |
|
backport-requested-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x |
| May 14, 2018 | https://github.com/nodejs/node/pull/20221#event-1625590784 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20221 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/20221/files/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/20221/files/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/20221/files/44c9fc7c0d151fc43fd0436085f4774a4b14a984 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/20221 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/BridgeAR |
|
| https://github.com/trivikr |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |