René's URL Explorer Experiment


Title: src: fix node_crypto.cc compiler warnings by danbev · Pull Request #20216 · nodejs/node · GitHub

Open Graph Title: src: fix node_crypto.cc compiler warnings by danbev · Pull Request #20216 · nodejs/node

X Title: src: fix node_crypto.cc compiler warnings by danbev · Pull Request #20216 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Currently the following compiler warnings are issued by clang: ../src/node_crypto.cc:2801:56: warning: '&&' within '||' [-Wlogical-op-parentheses] return tag_len == 4 || tag...

X Description: Currently the following compiler warnings are issued by clang: ../src/node_crypto.cc:2801:56: warning: '&&' within '||' [-Wlogical-op-parentheses] re...

Opengraph URL: https://github.com/nodejs/node/pull/20216

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5da26fd2-aa45-38c5-c7fe-f32105bb02dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D8C:E58C0:2247F85:2BA08F8:6991ADDC
html-safe-nonce72dde80ddfbbcd62d14091363dc0e74dbcf7a01f07b4f67a0eda8ea60d290b9c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDhDOkU1OEMwOjIyNDdGODU6MkJBMDhGODo2OTkxQUREQyIsInZpc2l0b3JfaWQiOiI1ODc1NjcyNjM4ODkwODE0OTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacece5c44038a6bb658f972a4e32d27cb37c479b33da694e975e553faffded7a4e
hovercard-subject-tagpull_request:183330542
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/20216/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c1e8920fcf7c8c89ac57e617b5bcac312f92ccd161e92c9df984cc39f46fb64/nodejs/node/pull/20216
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c1e8920fcf7c8c89ac57e617b5bcac312f92ccd161e92c9df984cc39f46fb64/nodejs/node/pull/20216
og:image:altCurrently the following compiler warnings are issued by clang: ../src/node_crypto.cc:2801:56: warning: '&&' within '||' [-Wlogical-op-parentheses] return tag_len == 4 || tag...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/20216#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20216
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20216
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/20216
Reloadhttps://github.com/nodejs/node/pull/20216
Reloadhttps://github.com/nodejs/node/pull/20216
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/20216
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_logical_op_warningshttps://github.com/danbev/node/tree/crypto_logical_op_warnings
Conversationhttps://github.com/nodejs/node/pull/20216
Commits1 (1)https://github.com/nodejs/node/pull/20216/commits
Checkshttps://github.com/nodejs/node/pull/20216/checks
Files changedhttps://github.com/nodejs/node/pull/20216/files
src: fix node_crypto.cc compiler warningshttps://github.com/nodejs/node/pull/20216#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto_logical_op_warningshttps://github.com/danbev/node/tree/crypto_logical_op_warnings
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 23, 2018https://github.com/nodejs/node/pull/20216#issue-316668306
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/danbev
src: fix node_crypto.cc compiler warningshttps://github.com/nodejs/node/pull/20216/commits/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
fc8d655https://github.com/nodejs/node/pull/20216/commits/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Apr 23, 2018https://github.com/nodejs/node/pull/20216#event-1588307737
https://github.com/danbev
danbevhttps://github.com/danbev
Apr 23, 2018https://github.com/nodejs/node/pull/20216#issuecomment-383460681
https://ci.nodejs.org/job/node-test-pull-request/14430/https://ci.nodejs.org/job/node-test-pull-request/14430/
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#pullrequestreview-114298663
View reviewed changes https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#pullrequestreview-114307084
View reviewed changes https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 23, 2018https://github.com/nodejs/node/pull/20216#issuecomment-383529258
#20039 (comment)https://github.com/nodejs/node/pull/20039#discussion_r183205393
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#pullrequestreview-114416296
View reviewed changes https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Apr 23, 2018https://github.com/nodejs/node/pull/20216#event-1589339528
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#ref-pullrequest-316890063
src: fix compiler warnings in node_crypto.cc #20231 https://github.com/nodejs/node/pull/20231
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#pullrequestreview-114463326
View reviewed changes https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 23, 2018https://github.com/nodejs/node/pull/20216#issuecomment-383641198
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#pullrequestreview-114465035
View reviewed changes https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#pullrequestreview-114471665
View reviewed changes https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 23, 2018https://github.com/nodejs/node/pull/20216#issuecomment-383698606
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 23, 2018https://github.com/nodejs/node/pull/20216#issuecomment-383746429
15fd0d9https://github.com/nodejs/node/commit/15fd0d95f88a57aab618cac0a91c8332c8c07498
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 23, 2018https://github.com/nodejs/node/pull/20216#event-1590320970
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 23, 2018https://github.com/nodejs/node/pull/20216#event-1590321381
addaleaxhttps://github.com/addaleax
Apr 23, 2018 https://github.com/nodejs/node/pull/20216#ref-commit-15fd0d9
https://github.com/danbev
https://github.com/addaleax
src: fix node_crypto.cc compiler warningshttps://github.com/nodejs/node/commit/15fd0d95f88a57aab618cac0a91c8332c8c07498
15fd0d9https://github.com/nodejs/node/commit/15fd0d95f88a57aab618cac0a91c8332c8c07498
#20216https://github.com/nodejs/node/pull/20216
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 24, 2018 https://github.com/nodejs/node/pull/20216#ref-pullrequest-314374978
crypto: allow to restrict valid GCM tag length #20039 https://github.com/nodejs/node/pull/20039
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
May 4, 2018https://github.com/nodejs/node/pull/20216#event-1610152511
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 4, 2018https://github.com/nodejs/node/pull/20216#issuecomment-386643309
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/targos
targoshttps://github.com/targos
May 12, 2018 https://github.com/nodejs/node/pull/20216#ref-issue-322546334
Need help to backport crypto changes to v10.x-staging #20691 https://github.com/nodejs/node/issues/20691
tniessenhttps://github.com/tniessen
May 13, 2018 https://github.com/nodejs/node/pull/20216#ref-commit-1ae5218
https://github.com/danbev
https://github.com/tniessen
src: fix node_crypto.cc compiler warningshttps://github.com/tniessen/node/commit/1ae5218e252f2b37cf69b0cf092286a7931a0b9f
1ae5218https://github.com/tniessen/node/commit/1ae5218e252f2b37cf69b0cf092286a7931a0b9f
nodejs#20216https://github.com/nodejs/node/pull/20216
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 13, 2018 https://github.com/nodejs/node/pull/20216#ref-pullrequest-322616197
(v10.x backport) Backport 12 crypto commits #20706 https://github.com/nodejs/node/pull/20706
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20216#ref-commit-fd5adbc
https://github.com/danbev
https://github.com/addaleax
src: fix node_crypto.cc compiler warningshttps://github.com/nodejs/node/commit/fd5adbc9c3cb9342d9a698505af4d37bb6134d4f
fd5adbchttps://github.com/nodejs/node/commit/fd5adbc9c3cb9342d9a698505af4d37bb6134d4f
#20706https://github.com/nodejs/node/pull/20706
#20216https://github.com/nodejs/node/pull/20216
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 14, 2018 https://github.com/nodejs/node/pull/20216#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/targos
targoshttps://github.com/targos
backported-to-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v10.x
backport-requested-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v10.x
Jun 7, 2018https://github.com/nodejs/node/pull/20216#event-1668609804
https://github.com/danbev
danbevhttps://github.com/danbev
August 20, 2019 07:53https://github.com/nodejs/node/pull/20216#event-2568718948
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F20216
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/20216/files/fc8d655dc692fea1c5e147d7694b26ba962bf5a7
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/20216
https://github.com/danbev
https://github.com/tniessen
https://github.com/addaleax
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/joyeecheung
https://github.com/richardlau
https://github.com/BridgeAR
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.