René's URL Explorer Experiment


Title: buffer: prevent abort on bad proto by trevnorris · Pull Request #2012 · nodejs/node · GitHub

Open Graph Title: buffer: prevent abort on bad proto by trevnorris · Pull Request #2012 · nodejs/node

X Title: buffer: prevent abort on bad proto by trevnorris · Pull Request #2012 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If an object's prototype is munged it's possible to bypass the instanceof check and cause the application to abort. Instead now use HasInstance() to verify that the object is a Buffer, and ...

X Description: If an object's prototype is munged it's possible to bypass the instanceof check and cause the application to abort. Instead now use HasInstance() to verify that the object is a Buff...

Opengraph URL: https://github.com/nodejs/node/pull/2012

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e24e1f06-d7db-ea91-83a4-806b37ca767a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE490:13DDC4:48176A4:64DD25C:6A4F7A75
html-safe-nonce28650651967edaf1e203774657b6e3fb9fd1177dc38886f62e429ed6ba17c83f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDkwOjEzRERDNDo0ODE3NkE0OjY0REQyNUM6NkE0RjdBNzUiLCJ2aXNpdG9yX2lkIjoiMjMwNTkyMTYzODk2MzU3NTQxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd3c81ee6deb956308da2ce36f426346924af1a1d8214fbe5dfdd3c9dc137ad70
hovercard-subject-tagpull_request:38048930
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/2012/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3f202dd7d24d443d2dc8c1d73f16e9bd5bce6a395fe928378505e472a3d26d5b/nodejs/node/pull/2012
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f202dd7d24d443d2dc8c1d73f16e9bd5bce6a395fe928378505e472a3d26d5b/nodejs/node/pull/2012
og:image:altIf an object's prototype is munged it's possible to bypass the instanceof check and cause the application to abort. Instead now use HasInstance() to verify that the object is a Buffer, and ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/2012#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2012
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2012
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/2012
Reloadhttps://github.com/nodejs/node/pull/2012
Reloadhttps://github.com/nodejs/node/pull/2012
Please reload this pagehttps://github.com/nodejs/node/pull/2012
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/2012
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:buffer-throw-not-aborthttps://github.com/trevnorris/node/tree/buffer-throw-not-abort
Conversationhttps://github.com/nodejs/node/pull/2012
Commits1 (1)https://github.com/nodejs/node/pull/2012/commits
Checkshttps://github.com/nodejs/node/pull/2012/checks
Files changedhttps://github.com/nodejs/node/pull/2012/files
buffer: prevent abort on bad protohttps://github.com/nodejs/node/pull/2012#top
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:buffer-throw-not-aborthttps://github.com/trevnorris/node/tree/buffer-throw-not-abort
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 18, 2015https://github.com/nodejs/node/pull/2012#issue-89389176
#1486https://github.com/nodejs/node/pull/1486
@bnoordhuishttps://github.com/bnoordhuis
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/48/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/48/
Please reload this pagehttps://github.com/nodejs/node/pull/2012
https://github.com/mscdex
mscdexhttps://github.com/mscdex
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Jun 18, 2015https://github.com/nodejs/node/pull/2012#event-334664665
brendanashworthhttps://github.com/brendanashworth
Jun 18, 2015 https://github.com/nodejs/node/pull/2012#discussion-diff-32789470
View reviewed changes https://github.com/nodejs/node/pull/2012/files#diff-350a47ce3b465de76a4c984dc2b0cff360592b22d9a84215c283c14f6d9fcb4e
test/parallel/test-buffer-fakes.jshttps://github.com/nodejs/node/pull/2012/files#diff-350a47ce3b465de76a4c984dc2b0cff360592b22d9a84215c283c14f6d9fcb4e
brendanashworthhttps://github.com/brendanashworth
Jun 18, 2015https://github.com/nodejs/node/pull/2012#discussion_r32789470
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
trevnorrishttps://github.com/trevnorris
Jun 19, 2015https://github.com/nodejs/node/pull/2012#discussion_r32793147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
brendanashworthhttps://github.com/brendanashworth
Jun 23, 2015https://github.com/nodejs/node/pull/2012#discussion_r33100317
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
trevnorrishttps://github.com/trevnorris
Jun 23, 2015https://github.com/nodejs/node/pull/2012#discussion_r33101793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-symbol.prototype.tostringhttps://people.mozilla.org/~jorendorff/es6-draft.html#sec-symbol.prototype.tostring
Please reload this pagehttps://github.com/nodejs/node/pull/2012
brendanashworthhttps://github.com/brendanashworth
Jun 24, 2015https://github.com/nodejs/node/pull/2012#discussion_r33112300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
trevnorrishttps://github.com/trevnorris
Jun 25, 2015https://github.com/nodejs/node/pull/2012#discussion_r33278053
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 19, 2015 https://github.com/nodejs/node/pull/2012#ref-pullrequest-86472389
buffer: prevent failed assertions #1922 https://github.com/nodejs/node/pull/1922
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/cae58834d040b94fddde88dce2e60de6d57e52bd..5bfea5a9c8c622165bb6dc941713ff5040ba644e
cae5883https://github.com/nodejs/node/commit/cae58834d040b94fddde88dce2e60de6d57e52bd
5bfea5ahttps://github.com/nodejs/node/commit/5bfea5a9c8c622165bb6dc941713ff5040ba644e
Compare https://github.com/nodejs/node/compare/cae58834d040b94fddde88dce2e60de6d57e52bd..5bfea5a9c8c622165bb6dc941713ff5040ba644e
June 22, 2015 16:33https://github.com/nodejs/node/pull/2012#event-336899611
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7..628a3ab0930c8500483aa72a340e503cda41cf0b
9d21135https://github.com/nodejs/node/commit/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7
628a3abhttps://github.com/nodejs/node/commit/628a3ab0930c8500483aa72a340e503cda41cf0b
Compare https://github.com/nodejs/node/compare/9d211351bd96fe023ab2e4d73f8b62e5eceb67c7..628a3ab0930c8500483aa72a340e503cda41cf0b
June 25, 2015 09:18https://github.com/nodejs/node/pull/2012#event-339839173
bnoordhuishttps://github.com/bnoordhuis
Jun 25, 2015 https://github.com/nodejs/node/pull/2012#discussion-diff-33285221
View reviewed changes https://github.com/nodejs/node/pull/2012/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
src/node_buffer.cchttps://github.com/nodejs/node/pull/2012/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
bnoordhuishttps://github.com/bnoordhuis
Jun 25, 2015https://github.com/nodejs/node/pull/2012#discussion_r33285221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
trevnorrishttps://github.com/trevnorris
Jun 25, 2015https://github.com/nodejs/node/pull/2012#discussion_r33285779
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
https://github.com/trevnorris
buffer: prevent abort on bad protohttps://github.com/nodejs/node/pull/2012/commits/2a4ec45ab1085e7d00c39f3f8ce5e4850c9b9cb9
2a4ec45https://github.com/nodejs/node/pull/2012/commits/2a4ec45ab1085e7d00c39f3f8ce5e4850c9b9cb9
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/5bfea5a9c8c622165bb6dc941713ff5040ba644e..2a4ec45ab1085e7d00c39f3f8ce5e4850c9b9cb9
5bfea5ahttps://github.com/nodejs/node/commit/5bfea5a9c8c622165bb6dc941713ff5040ba644e
2a4ec45https://github.com/nodejs/node/commit/2a4ec45ab1085e7d00c39f3f8ce5e4850c9b9cb9
Compare https://github.com/nodejs/node/compare/5bfea5a9c8c622165bb6dc941713ff5040ba644e..2a4ec45ab1085e7d00c39f3f8ce5e4850c9b9cb9
June 25, 2015 18:23https://github.com/nodejs/node/pull/2012#event-340360058
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 25, 2015https://github.com/nodejs/node/pull/2012#issuecomment-115354277
@bnoordhuishttps://github.com/bnoordhuis
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/83/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/83/
Please reload this pagehttps://github.com/nodejs/node/pull/2012
bnoordhuishttps://github.com/bnoordhuis
Jun 25, 2015 https://github.com/nodejs/node/pull/2012#discussion-diff-33290508
View reviewed changes https://github.com/nodejs/node/pull/2012/files/2a4ec45ab1085e7d00c39f3f8ce5e4850c9b9cb9#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
lib/buffer.jshttps://github.com/nodejs/node/pull/2012/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
bnoordhuishttps://github.com/bnoordhuis
Jun 25, 2015https://github.com/nodejs/node/pull/2012#discussion_r33290508
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/2012
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 25, 2015https://github.com/nodejs/node/pull/2012#issuecomment-115359966
Please reload this pagehttps://github.com/nodejs/node/pull/2012
trevnorrishttps://github.com/trevnorris
Jun 25, 2015 https://github.com/nodejs/node/pull/2012#ref-commit-1cd9eeb
https://github.com/trevnorris
buffer: prevent abort on bad protohttps://github.com/nodejs/node/commit/1cd9eeb55696625ee8413f9e169c73e9eb21ce76
1cd9eebhttps://github.com/nodejs/node/commit/1cd9eeb55696625ee8413f9e169c73e9eb21ce76
#1486https://github.com/nodejs/node/pull/1486
#1922https://github.com/nodejs/node/pull/1922
#1485https://github.com/nodejs/node/issues/1485
#2012https://github.com/nodejs/node/pull/2012
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 25, 2015https://github.com/nodejs/node/pull/2012#issuecomment-115366279
1cd9eebhttps://github.com/nodejs/node/commit/1cd9eeb55696625ee8413f9e169c73e9eb21ce76
Please reload this pagehttps://github.com/nodejs/node/pull/2012
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 25, 2015https://github.com/nodejs/node/pull/2012#event-340403383
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
June 25, 2015 19:12https://github.com/nodejs/node/pull/2012#event-340405666
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jun 30, 2015 https://github.com/nodejs/node/pull/2012#ref-issue-92018636
Release proposal: v2.3.2 #2083 https://github.com/nodejs/node/issues/2083
mscdexhttps://github.com/mscdex
Jul 9, 2015 https://github.com/nodejs/node/pull/2012#ref-commit-40c334d
https://github.com/trevnorris
https://github.com/mscdex
buffer: prevent abort on bad protohttps://github.com/mscdex/io.js/commit/40c334de2c4e855fda9f75ec5444c7b4ced2c77b
40c334dhttps://github.com/mscdex/io.js/commit/40c334de2c4e855fda9f75ec5444c7b4ced2c77b
nodejs#1486https://github.com/nodejs/node/pull/1486
nodejs#1922https://github.com/nodejs/node/pull/1922
nodejs#1485https://github.com/nodejs/node/issues/1485
nodejs#2012https://github.com/nodejs/node/pull/2012
https://github.com/gr00nd
gr00ndhttps://github.com/gr00nd
Feb 6, 2024 https://github.com/nodejs/node/pull/2012#ref-pullrequest-2119982872
[Snyk] Upgrade commander from 2.11.0 to 11.1.0 gr00nd/node#9 https://github.com/gr00nd/node/pull/9
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F2012
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Please reload this pagehttps://github.com/nodejs/node/pull/2012
https://github.com/trevnorris
https://github.com/bnoordhuis
https://github.com/brendanashworth
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.