| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1669260a-e075-16b2-8f3b-44655ca01fb7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7F0:1BF4D5:1C1793:24268F:69921B5B |
| html-safe-nonce | eb5b93a3a3689ccf55bc5d340153fb8a706a75eacf78de2433c7788d30ceee6b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0YwOjFCRjRENToxQzE3OTM6MjQyNjhGOjY5OTIxQjVCIiwidmlzaXRvcl9pZCI6IjQzOTM1ODAwMDQ1ODUzODA2OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a5374a48e4241c2dfb573b8555cc110a41106490516fde281e9599be7f7278b3 |
| hovercard-subject-tag | pull_request:180530030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19911/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b1e58a77621bd850aa5787ac26dd7fd0009b657c1aab2c7fc2d78e8aadc03da7/nodejs/node/pull/19911 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1e58a77621bd850aa5787ac26dd7fd0009b657c1aab2c7fc2d78e8aadc03da7/nodejs/node/pull/19911 |
| og:image:alt | which behaves like --preserve-symlinks but for require.main. Fixes #19383
Checklist
I realize there is more to do here, but I wanted to send this out early for feedback. If there aren't any q... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dgoldstein0 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/19911#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19911 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19911 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/19911 |
| Reload | https://github.com/nodejs/node/pull/19911 |
| Reload | https://github.com/nodejs/node/pull/19911 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| dgoldstein0 | https://github.com/dgoldstein0 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dgoldstein0:master | https://github.com/dgoldstein0/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/19911 |
| Commits6 (6) | https://github.com/nodejs/node/pull/19911/commits |
| Checks | https://github.com/nodejs/node/pull/19911/checks |
| Files changed | https://github.com/nodejs/node/pull/19911/files |
| Add a --preserve-symlinks-main option | https://github.com/nodejs/node/pull/19911#top |
| dgoldstein0 | https://github.com/dgoldstein0 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| dgoldstein0:master | https://github.com/dgoldstein0/node/tree/master |
|
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Apr 10, 2018 | https://github.com/nodejs/node/pull/19911#issue-312827886 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| #19383 | https://github.com/nodejs/node/issues/19383 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Apr 10, 2018 | https://github.com/nodejs/node/pull/19911#event-1565622615 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 10, 2018
| https://github.com/nodejs/node/pull/19911#pullrequestreview-110890217 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19911/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/19911#pullrequestreview-110890217 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| src/node.cc | https://github.com/nodejs/node/pull/19911/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a |
| jasnell | https://github.com/jasnell |
| Apr 10, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180465807 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Apr 11, 2018
| https://github.com/nodejs/node/pull/19911#pullrequestreview-111173001 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19911/files |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| https://github.com/nodejs/node/pull/19911#pullrequestreview-111173001 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| doc/api/cli.md | https://github.com/nodejs/node/pull/19911/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180707833 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| doc/api/cli.md | https://github.com/nodejs/node/pull/19911/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180708099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| doc/api/cli.md | https://github.com/nodejs/node/pull/19911/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180708787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| doc/api/cli.md | https://github.com/nodejs/node/pull/19911/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180709106 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| lib/internal/modules/cjs/loader.js | https://github.com/nodejs/node/pull/19911/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180709904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180979823 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| lib/internal/modules/cjs/loader.js | https://github.com/nodejs/node/pull/19911/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r180710150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 11, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-380410364 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| @dgoldstein0 | https://github.com/dgoldstein0 |
| these notes | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#step-1-fork |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-380698107 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-380722172 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/settings/emails | https://github.com/settings/emails |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-380723267 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 12, 2018
| https://github.com/nodejs/node/pull/19911#pullrequestreview-111690395 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19911/files |
| doc/api/cli.md | https://github.com/nodejs/node/pull/19911/files#diff-7349c17bce4d97526eefcb6f8291d617e7edb92ed9927fd3b9264e8014fc4e7c |
| jasnell | https://github.com/jasnell |
| Apr 12, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r181137430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Apr 13, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r181523609 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| force-pushed | https://github.com/nodejs/node/compare/768bb2b9523258741c42c4c159cf985a299db994..64a57666c167b20e3d7781746c059c6e2fcb3bbf |
| 768bb2b | https://github.com/nodejs/node/commit/768bb2b9523258741c42c4c159cf985a299db994 |
| 64a5766 | https://github.com/nodejs/node/commit/64a57666c167b20e3d7781746c059c6e2fcb3bbf |
|
Compare
| https://github.com/nodejs/node/compare/768bb2b9523258741c42c4c159cf985a299db994..64a57666c167b20e3d7781746c059c6e2fcb3bbf |
| April 13, 2018 22:55 | https://github.com/nodejs/node/pull/19911#event-1574273496 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Apr 13, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-381279848 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Apr 23, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-383496935 |
| @dgoldstein0 | https://github.com/dgoldstein0 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Apr 23, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-383525753 |
| … | https://github.com/nodejs/node/pull/19911 |
| @dgoldstein0 | https://github.com/dgoldstein0 |
| https://github.com/dgoldstein0 | https://github.com/dgoldstein0 |
| #19911 (comment) | https://github.com/nodejs/node/pull/19911#issuecomment-383496935 |
| https://github.com/notifications/unsubscribe-auth/ABBndxfM3n6mXNzGzVhcKw9gR7fib8-8ks5trZHJgaJpZM4TN1-y | https://github.com/notifications/unsubscribe-auth/ABBndxfM3n6mXNzGzVhcKw9gR7fib8-8ks5trZHJgaJpZM4TN1-y |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| May 3, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-386165829 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 3, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-386459736 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 3, 2018
| https://github.com/nodejs/node/pull/19911#pullrequestreview-117465232 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19911/files |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
May 4, 2018
| https://github.com/nodejs/node/pull/19911#pullrequestreview-117534381 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19911/files |
| test/es-module/test-esm-preserve-symlinks-main.js | https://github.com/nodejs/node/pull/19911/files#diff-ec16074a10df7a519529e0b09d6ed41f7c2dc2bbbd1a541252d0005b80e1ce21 |
| bnoordhuis | https://github.com/bnoordhuis |
| May 4, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r186024929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 7, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-387223879 |
| https://ci.nodejs.org/job/node-test-pull-request/14706/ | https://ci.nodejs.org/job/node-test-pull-request/14706/ |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 7, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-387229414 |
| @dgoldstein0 | https://github.com/dgoldstein0 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| May 7, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-387229778 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| May 7, 2018 22:49 | https://github.com/nodejs/node/pull/19911#commits-pushed-8a799d9 |
| Add a --preserve-symlinks-main option which behaves like --preserve-s… | https://github.com/nodejs/node/pull/19911/commits/8a799d966fffffb8d56ad1fa0a956607eb947398 |
| 8a799d9 | https://github.com/nodejs/node/pull/19911/commits/8a799d966fffffb8d56ad1fa0a956607eb947398 |
| Update docs for --preserve-symlinks-main | https://github.com/nodejs/node/pull/19911/commits/ccd3ce8f81f7fccf75f1b74891a4d2ecffbc5fb3 |
| ccd3ce8 | https://github.com/nodejs/node/pull/19911/commits/ccd3ce8f81f7fccf75f1b74891a4d2ecffbc5fb3 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 7, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-387231074 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| May 7, 2018 22:54 | https://github.com/nodejs/node/pull/19911#commits-pushed-58c973f |
| fix documentation nits | https://github.com/nodejs/node/pull/19911/commits/58c973f04e62943823564603b5f6f48e3d7de242 |
| 58c973f | https://github.com/nodejs/node/pull/19911/commits/58c973f04e62943823564603b5f6f48e3d7de242 |
| rephrase doc | https://github.com/nodejs/node/pull/19911/commits/e434980992252725a95672b58a34c52610cdcd5e |
| e434980 | https://github.com/nodejs/node/pull/19911/commits/e434980992252725a95672b58a34c52610cdcd5e |
| Add a test | https://github.com/nodejs/node/pull/19911/commits/4d8cfddcc31338f391eace883a230db986fa7bc4 |
| 4d8cfdd | https://github.com/nodejs/node/pull/19911/commits/4d8cfddcc31338f391eace883a230db986fa7bc4 |
| fix lint | https://github.com/nodejs/node/pull/19911/commits/0ec6486a24791315db0270207b1f6095183e966f |
| 0ec6486 | https://github.com/nodejs/node/pull/19911/commits/0ec6486a24791315db0270207b1f6095183e966f |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| force-pushed | https://github.com/nodejs/node/compare/34c5b15fb304d3811afebbcd8c0d268499726b17..0ec6486a24791315db0270207b1f6095183e966f |
| 34c5b15 | https://github.com/nodejs/node/commit/34c5b15fb304d3811afebbcd8c0d268499726b17 |
| 0ec6486 | https://github.com/nodejs/node/commit/0ec6486a24791315db0270207b1f6095183e966f |
|
Compare
| https://github.com/nodejs/node/compare/34c5b15fb304d3811afebbcd8c0d268499726b17..0ec6486a24791315db0270207b1f6095183e966f |
| May 7, 2018 22:56 | https://github.com/nodejs/node/pull/19911#event-1614077663 |
| https://github.com/dgoldstein0 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| May 7, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-387232055 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 7, 2018 | https://github.com/nodejs/node/pull/19911#issuecomment-387233002 |
| https://ci.nodejs.org/job/node-test-pull-request/14707/ | https://ci.nodejs.org/job/node-test-pull-request/14707/ |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/Alhadis |
| Alhadis | https://github.com/Alhadis |
|
May 15, 2018
| https://github.com/nodejs/node/pull/19911#ref-pullrequest-323085099 |
|
doc: fix linter warnings and typos in manpage
#20741
| https://github.com/nodejs/node/pull/20741 |
| Trott | https://github.com/Trott |
|
May 17, 2018
| https://github.com/nodejs/node/pull/19911#ref-commit-c8e7f8f |
|
| https://github.com/Alhadis |
|
| https://github.com/Trott |
| doc: fix linter warnings and typos in manpage | https://github.com/Trott/io.js/commit/c8e7f8f77e1aa57564204e6f43213813794f97a3 |
| c8e7f8f | https://github.com/Trott/io.js/commit/c8e7f8f77e1aa57564204e6f43213813794f97a3 |
| nodejs#19911 | https://github.com/nodejs/node/pull/19911 |
| nodejs#20741 | https://github.com/nodejs/node/pull/20741 |
| MylesBorins | https://github.com/MylesBorins |
|
May 22, 2018
| https://github.com/nodejs/node/pull/19911#ref-commit-657f8cb |
|
| https://github.com/Alhadis |
|
| https://github.com/MylesBorins |
| doc: fix linter warnings and typos in manpage | https://github.com/nodejs/node/commit/657f8cbe41688d4f7efad8feb88d2b02202c9ebc |
| 657f8cb | https://github.com/nodejs/node/commit/657f8cbe41688d4f7efad8feb88d2b02202c9ebc |
| #19911 | https://github.com/nodejs/node/pull/19911 |
| #20741 | https://github.com/nodejs/node/pull/20741 |
| MylesBorins | https://github.com/MylesBorins |
|
May 22, 2018
| https://github.com/nodejs/node/pull/19911#ref-commit-d765fb6 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| 2018-05-23, Version 10.2.0 (Current) | https://github.com/nodejs/node/commit/d765fb6b2db342d54a18155ede21d20b17706a36 |
| d765fb6 | https://github.com/nodejs/node/commit/d765fb6b2db342d54a18155ede21d20b17706a36 |
| #20668 | https://github.com/nodejs/node/pull/20668 |
| #20485 | https://github.com/nodejs/node/pull/20485 |
| #20235 | https://github.com/nodejs/node/pull/20235 |
| #20039 | https://github.com/nodejs/node/pull/20039 |
| #20403 | https://github.com/nodejs/node/pull/20403 |
| #20075 | https://github.com/nodejs/node/pull/20075 |
| #20611 | https://github.com/nodejs/node/pull/20611 |
| #19911 | https://github.com/nodejs/node/pull/19911 |
| #20298 | https://github.com/nodejs/node/pull/20298 |
| #20639 | https://github.com/nodejs/node/pull/20639 |
| #19377 | https://github.com/nodejs/node/pull/19377 |
| #20542 | https://github.com/nodejs/node/pull/20542 |
| #20539 | https://github.com/nodejs/node/pull/20539 |
| #20541 | https://github.com/nodejs/node/pull/20541 |
| #20724 | https://github.com/nodejs/node/pull/20724 |
| MylesBorins | https://github.com/MylesBorins |
|
May 23, 2018
| https://github.com/nodejs/node/pull/19911#ref-commit-f6b6b3f |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| 2018-05-23, Version 10.2.0 (Current) | https://github.com/nodejs/node/commit/f6b6b3fa0713b7e5a696fbbd1b22f9b6d4603d14 |
| f6b6b3f | https://github.com/nodejs/node/commit/f6b6b3fa0713b7e5a696fbbd1b22f9b6d4603d14 |
| #20668 | https://github.com/nodejs/node/pull/20668 |
| #20485 | https://github.com/nodejs/node/pull/20485 |
| #20235 | https://github.com/nodejs/node/pull/20235 |
| #20039 | https://github.com/nodejs/node/pull/20039 |
| #20403 | https://github.com/nodejs/node/pull/20403 |
| #20075 | https://github.com/nodejs/node/pull/20075 |
| #20611 | https://github.com/nodejs/node/pull/20611 |
| #19911 | https://github.com/nodejs/node/pull/19911 |
| #20298 | https://github.com/nodejs/node/pull/20298 |
| #20639 | https://github.com/nodejs/node/pull/20639 |
| #19377 | https://github.com/nodejs/node/pull/19377 |
| #20542 | https://github.com/nodejs/node/pull/20542 |
| #20539 | https://github.com/nodejs/node/pull/20539 |
| #20541 | https://github.com/nodejs/node/pull/20541 |
| #20724 | https://github.com/nodejs/node/pull/20724 |
| MylesBorins | https://github.com/MylesBorins |
|
May 23, 2018
| https://github.com/nodejs/node/pull/19911#ref-commit-5cbb905 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| 2018-05-23, Version 10.2.0 (Current) | https://github.com/nodejs/node/commit/5cbb905c1af7cea2d709932d59827d7c6d03ef4a |
| 5cbb905 | https://github.com/nodejs/node/commit/5cbb905c1af7cea2d709932d59827d7c6d03ef4a |
| #20668 | https://github.com/nodejs/node/pull/20668 |
| #20485 | https://github.com/nodejs/node/pull/20485 |
| #20235 | https://github.com/nodejs/node/pull/20235 |
| #20039 | https://github.com/nodejs/node/pull/20039 |
| #20403 | https://github.com/nodejs/node/pull/20403 |
| #20075 | https://github.com/nodejs/node/pull/20075 |
| #20611 | https://github.com/nodejs/node/pull/20611 |
| #19911 | https://github.com/nodejs/node/pull/19911 |
| #20298 | https://github.com/nodejs/node/pull/20298 |
| #20639 | https://github.com/nodejs/node/pull/20639 |
| #19377 | https://github.com/nodejs/node/pull/19377 |
| #20542 | https://github.com/nodejs/node/pull/20542 |
| #20539 | https://github.com/nodejs/node/pull/20539 |
| #20541 | https://github.com/nodejs/node/pull/20541 |
| #20724 | https://github.com/nodejs/node/pull/20724 |
| MylesBorins | https://github.com/MylesBorins |
|
May 23, 2018
| https://github.com/nodejs/node/pull/19911#ref-commit-82f1811 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| 2018-05-23, Version 10.2.0 (Current) | https://github.com/nodejs/node/commit/82f18118ff8ddb7ad76f4c6bc40737e8fb8c20d2 |
| 82f1811 | https://github.com/nodejs/node/commit/82f18118ff8ddb7ad76f4c6bc40737e8fb8c20d2 |
| #20668 | https://github.com/nodejs/node/pull/20668 |
| #20485 | https://github.com/nodejs/node/pull/20485 |
| #20235 | https://github.com/nodejs/node/pull/20235 |
| #20039 | https://github.com/nodejs/node/pull/20039 |
| #20403 | https://github.com/nodejs/node/pull/20403 |
| #20075 | https://github.com/nodejs/node/pull/20075 |
| #20611 | https://github.com/nodejs/node/pull/20611 |
| #19911 | https://github.com/nodejs/node/pull/19911 |
| #20298 | https://github.com/nodejs/node/pull/20298 |
| #20639 | https://github.com/nodejs/node/pull/20639 |
| #19377 | https://github.com/nodejs/node/pull/19377 |
| #20542 | https://github.com/nodejs/node/pull/20542 |
| #20539 | https://github.com/nodejs/node/pull/20539 |
| #20541 | https://github.com/nodejs/node/pull/20541 |
| #20724 | https://github.com/nodejs/node/pull/20724 |
| https://github.com/jdalton |
| jdalton | https://github.com/jdalton |
|
Jun 17, 2018
| https://github.com/nodejs/node/pull/19911#pullrequestreview-129398530 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19911/files/0ec6486a24791315db0270207b1f6095183e966f |
| lib/internal/modules/cjs/loader.js | https://github.com/nodejs/node/pull/19911/files/0ec6486a24791315db0270207b1f6095183e966f#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142 |
| jdalton | https://github.com/jdalton |
| Jun 17, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r195938801 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| node/lib/internal/modules/cjs/loader.js | https://github.com/nodejs/node/blob/452d73df23f3283797f1e1099a1fddc635643d45/lib/internal/modules/cjs/loader.js#L193-L199 |
| 452d73d | https://github.com/nodejs/node/commit/452d73df23f3283797f1e1099a1fddc635643d45 |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Jun 18, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r196012888 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| dgoldstein0 | https://github.com/dgoldstein0 |
| Jun 18, 2018 | https://github.com/nodejs/node/pull/19911#discussion_r196015116 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
|
Jul 31, 2019
| https://github.com/nodejs/node/pull/19911#ref-pullrequest-474393787 |
|
[Fix] preserveSymlinks: false ensure that files are realpathed
browserify/resolve#197
| https://github.com/browserify/resolve/pull/197 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19911 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/19911/files/680cba3b41126f3af89ff833248b64e0037782ba |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/19911/files/680cba3b41126f3af89ff833248b64e0037782ba |
|
| https://github.com/jdalton |
|
jdalton
| https://github.com/jdalton |
|
| https://github.com/nodejs/node/pull/19911/files/0ec6486a24791315db0270207b1f6095183e966f |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/19911/files/2b2fd50c4474c50f3e21185b5d42b11a96371d57 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/19911 |
|
| https://github.com/dgoldstein0 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/BridgeAR |
|
| https://github.com/Fishrock123 |
|
| https://github.com/Trott |
|
| https://github.com/ljharb |
|
| https://github.com/jdalton |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |