René's URL Explorer Experiment


Title: test: add Buffer slice UTF-8 test by Trott · Pull Request #1989 · nodejs/node · GitHub

Open Graph Title: test: add Buffer slice UTF-8 test by Trott · Pull Request #1989 · nodejs/node

X Title: test: add Buffer slice UTF-8 test by Trott · Pull Request #1989 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Gets rid of another TODO comment in the tests. Thing is, I'm not sure this is really needed. There seem to be things in other places in this test file that would trigger utf8Slice(), at least ...

X Description: Gets rid of another TODO comment in the tests. Thing is, I'm not sure this is really needed. There seem to be things in other places in this test file that would trigger utf8Slice(), at le...

Opengraph URL: https://github.com/nodejs/node/pull/1989

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8f890c25-c0ac-65cd-f86f-946d694108eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD25E:33952:55E1004:7905E63:6A4FF5AF
html-safe-nonce4ce01262c60c77a349762b865c7422e256d0cc06584ec1942a6537610d06c38d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjVFOjMzOTUyOjU1RTEwMDQ6NzkwNUU2Mzo2QTRGRjVBRiIsInZpc2l0b3JfaWQiOiIzMjgzMTczMzI4OTg3MDkyMzk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb67f810f1e70ad24e3fefd1bb5d0fc36d81708d616419440bb084d066951d253
hovercard-subject-tagpull_request:37760093
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1989/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/777590f4bfccf74da6cb31318d03cb33d33bb443cf1d411fc4e4f69686c9fe9f/nodejs/node/pull/1989
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/777590f4bfccf74da6cb31318d03cb33d33bb443cf1d411fc4e4f69686c9fe9f/nodejs/node/pull/1989
og:image:altGets rid of another TODO comment in the tests. Thing is, I'm not sure this is really needed. There seem to be things in other places in this test file that would trigger utf8Slice(), at least ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None3bd0ff5d28a87b4801a63fb38c2a21a91b0a700dca159dc9416aeae05771b899
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release67a336083e4dcb40224dc2c01cd4c7ed413bdb09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1989#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1989
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1989
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1989
Reloadhttps://github.com/nodejs/node/pull/1989
Reloadhttps://github.com/nodejs/node/pull/1989
Please reload this pagehttps://github.com/nodejs/node/pull/1989
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1989
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 976 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:utf8-buffer-slicehttps://github.com/Trott/io.js/tree/utf8-buffer-slice
Conversationhttps://github.com/nodejs/node/pull/1989
Commits1 (1)https://github.com/nodejs/node/pull/1989/commits
Checkshttps://github.com/nodejs/node/pull/1989/checks
Files changedhttps://github.com/nodejs/node/pull/1989/files
test: add Buffer slice UTF-8 testhttps://github.com/nodejs/node/pull/1989#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:utf8-buffer-slicehttps://github.com/Trott/io.js/tree/utf8-buffer-slice
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 16, 2015https://github.com/nodejs/node/pull/1989#issue-88620149
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/1989
https://github.com/Trott
Trotthttps://github.com/Trott
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Jun 16, 2015https://github.com/nodejs/node/pull/1989#event-331730858
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015 https://github.com/nodejs/node/pull/1989#discussion-diff-32491893
View reviewed changes https://github.com/nodejs/node/pull/1989/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05
test/parallel/test-buffer.jshttps://github.com/nodejs/node/pull/1989/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1989#discussion_r32491893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1989
Trotthttps://github.com/Trott
Jun 16, 2015https://github.com/nodejs/node/pull/1989#discussion_r32491941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1989
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/1b9ce171ea57c552a027479e67f2fb6e7a5c6d7c..9710534ae8386aab12e396a7eed80e9658067e75
1b9ce17https://github.com/nodejs/node/commit/1b9ce171ea57c552a027479e67f2fb6e7a5c6d7c
9710534https://github.com/nodejs/node/commit/9710534ae8386aab12e396a7eed80e9658067e75
Compare https://github.com/nodejs/node/compare/1b9ce171ea57c552a027479e67f2fb6e7a5c6d7c..9710534ae8386aab12e396a7eed80e9658067e75
June 16, 2015 05:26https://github.com/nodejs/node/pull/1989#event-331736411
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 16, 2015https://github.com/nodejs/node/pull/1989#issuecomment-112295828
@brendanashworthhttps://github.com/brendanashworth
Please reload this pagehttps://github.com/nodejs/node/pull/1989
trevnorrishttps://github.com/trevnorris
Jun 16, 2015 https://github.com/nodejs/node/pull/1989#discussion-diff-32492700
View reviewed changes https://github.com/nodejs/node/pull/1989/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05
test/parallel/test-buffer.jshttps://github.com/nodejs/node/pull/1989/files#diff-9b302d1821563473bc03304aded13441bd1370dca748efe9825b3af0deb07b05
trevnorrishttps://github.com/trevnorris
Jun 16, 2015https://github.com/nodejs/node/pull/1989#discussion_r32492700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1989
Trotthttps://github.com/Trott
Jun 16, 2015https://github.com/nodejs/node/pull/1989#discussion_r32494012
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1989
https://github.com/Trott
test: add Buffer slice UTF-8 testhttps://github.com/nodejs/node/pull/1989/commits/3b817569a658007aee007535e60d43e1f11e200a
3b81756https://github.com/nodejs/node/pull/1989/commits/3b817569a658007aee007535e60d43e1f11e200a
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/9710534ae8386aab12e396a7eed80e9658067e75..3b817569a658007aee007535e60d43e1f11e200a
9710534https://github.com/nodejs/node/commit/9710534ae8386aab12e396a7eed80e9658067e75
3b81756https://github.com/nodejs/node/commit/3b817569a658007aee007535e60d43e1f11e200a
Compare https://github.com/nodejs/node/compare/9710534ae8386aab12e396a7eed80e9658067e75..3b817569a658007aee007535e60d43e1f11e200a
June 16, 2015 06:26https://github.com/nodejs/node/pull/1989#event-331767216
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 16, 2015https://github.com/nodejs/node/pull/1989#issuecomment-112308666
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/1989
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 17, 2015https://github.com/nodejs/node/pull/1989#issuecomment-112889306
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/40/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/40/
Please reload this pagehttps://github.com/nodejs/node/pull/1989
Trotthttps://github.com/Trott
Jun 17, 2015 https://github.com/nodejs/node/pull/1989#ref-commit-0abcf44
https://github.com/Trott
https://github.com/trevnorris
test: add Buffer slice UTF-8 testhttps://github.com/nodejs/node/commit/0abcf44d6b1a31250272eb4a4e24192eeba53db1
0abcf44https://github.com/nodejs/node/commit/0abcf44d6b1a31250272eb4a4e24192eeba53db1
#1989https://github.com/nodejs/node/pull/1989
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 17, 2015https://github.com/nodejs/node/pull/1989#issuecomment-112915111
0abcf44https://github.com/nodejs/node/commit/0abcf44d6b1a31250272eb4a4e24192eeba53db1
Please reload this pagehttps://github.com/nodejs/node/pull/1989
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 17, 2015https://github.com/nodejs/node/pull/1989#event-333508474
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jun 18, 2015 https://github.com/nodejs/node/pull/1989#ref-pullrequest-88863937
Release proposal: v2.3.1 #1996 https://github.com/nodejs/node/pull/1996
https://github.com/Trott
Trotthttps://github.com/Trott
January 9, 2022 22:02https://github.com/nodejs/node/pull/1989#event-5862809473
[Snyk] Fix for 13 vulnerabilities aliscco/alisco-node#112 https://github.com/aliscco/alisco-node/pull/112
[Snyk] Fix for 5 vulnerabilities aliscco/alisco-node#348 https://github.com/aliscco/alisco-node/pull/348
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#477 https://github.com/aliscco/alisco-node/pull/477
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#487 https://github.com/aliscco/alisco-node/pull/487
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1989
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/1989
https://github.com/Trott
https://github.com/trevnorris
https://github.com/brendanashworth
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.