René's URL Explorer Experiment


Title: util: fix isBuffer by brendanashworth · Pull Request #1988 · nodejs/node · GitHub

Open Graph Title: util: fix isBuffer by brendanashworth · Pull Request #1988 · nodejs/node

X Title: util: fix isBuffer by brendanashworth · Pull Request #1988 · nodejs/node

Description: Importing Buffer caused a circular dependency issue. We need to use the globally exported variable to get around this. Fixes: #1987 This is just quick patch to fix the bug, I hope we can later find...

Open Graph Description: Importing Buffer caused a circular dependency issue. We need to use the globally exported variable to get around this. Fixes: #1987 This is just quick patch to fix the bug, I hope we can later find...

X Description: Importing Buffer caused a circular dependency issue. We need to use the globally exported variable to get around this. Fixes: #1987 This is just quick patch to fix the bug, I hope we can later find...

Opengraph URL: https://github.com/nodejs/node/pull/1988

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ac239b1d-4055-830a-2f4f-f9c0eca2553e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA48:2B1AB1:1C8258B:2562255:696B3C6C
html-safe-nonce889c5d1ffe89548159097c44275a495043952f2320d40d65351faaf87ea91bec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTQ4OjJCMUFCMToxQzgyNThCOjI1NjIyNTU6Njk2QjNDNkMiLCJ2aXNpdG9yX2lkIjoiNDE0OTc0OTA1OTAxMTk1MTcyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1783234ee1651c839831f22247c013c515e3972753b483426c4d4c53720b3177
hovercard-subject-tagpull_request:37759017
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1988/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7cd6dcf26334838b2ea54806d978fb2f799e4bb749e424f5881407b1a731105/nodejs/node/pull/1988
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7cd6dcf26334838b2ea54806d978fb2f799e4bb749e424f5881407b1a731105/nodejs/node/pull/1988
og:image:altImporting Buffer caused a circular dependency issue. We need to use the globally exported variable to get around this. Fixes: #1987 This is just quick patch to fix the bug, I hope we can later find...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrendanashworth
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1988#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1988
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1988
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1988
Reloadhttps://github.com/nodejs/node/pull/1988
Reloadhttps://github.com/nodejs/node/pull/1988
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1988
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/1988
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/1988#issue-comment-box
brendanashworthhttps://github.com/brendanashworth
nodejs:masterhttps://github.com/nodejs/node/tree/master
brendanashworth:fix/util-bufferhttps://github.com/brendanashworth/io.js/tree/fix/util-buffer
util: fix isBuffer https://github.com/nodejs/node/pull/1988#top
brendanashworthhttps://github.com/brendanashworth
nodejs:masterhttps://github.com/nodejs/node/tree/master
brendanashworth:fix/util-bufferhttps://github.com/brendanashworth/io.js/tree/fix/util-buffer
Conversation 13 https://github.com/nodejs/node/pull/1988
Commits 3 https://github.com/nodejs/node/pull/1988/commits
Checks 0 https://github.com/nodejs/node/pull/1988/checks
Files changed https://github.com/nodejs/node/pull/1988/files
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issue-88613910
#1987https://github.com/nodejs/node/issues/1987
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112286064
@silverwindhttps://github.com/silverwind
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/targos
targoshttps://github.com/targos
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112286070
this linehttps://github.com/nodejs/io.js/blob/master/lib/buffer.js#L13
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/mscdex
mscdexhttps://github.com/mscdex
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Jun 16, 2015https://github.com/nodejs/node/pull/1988#event-331715410
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
force-pushedhttps://github.com/nodejs/node/compare/2456ba438a087f816b01170eec01b0761c3c27fc..d1b524706e5bc37cc5d0d31274ef3c97426d5128
2456ba4https://github.com/nodejs/node/commit/2456ba438a087f816b01170eec01b0761c3c27fc
d1b5247https://github.com/nodejs/node/commit/d1b524706e5bc37cc5d0d31274ef3c97426d5128
Compare https://github.com/nodejs/node/compare/2456ba438a087f816b01170eec01b0761c3c27fc..d1b524706e5bc37cc5d0d31274ef3c97426d5128
June 16, 2015 04:44https://github.com/nodejs/node/pull/1988#event-331717898
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112287381
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
util: move deprecate() to internal modulehttps://github.com/nodejs/node/pull/1988/commits/03a6fd4b44607ea7d92c365f70436960c8c1f257
03a6fd4https://github.com/nodejs/node/pull/1988/commits/03a6fd4b44607ea7d92c365f70436960c8c1f257
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
force-pushedhttps://github.com/nodejs/node/compare/d1b524706e5bc37cc5d0d31274ef3c97426d5128..2eabd33572479f62b3ffbb8a6e21450a113906b3
d1b5247https://github.com/nodejs/node/commit/d1b524706e5bc37cc5d0d31274ef3c97426d5128
2eabd33https://github.com/nodejs/node/commit/2eabd33572479f62b3ffbb8a6e21450a113906b3
Compare https://github.com/nodejs/node/compare/d1b524706e5bc37cc5d0d31274ef3c97426d5128..2eabd33572479f62b3ffbb8a6e21450a113906b3
June 16, 2015 04:53https://github.com/nodejs/node/pull/1988#event-331722957
https://github.com/brendanashworth
buffer: fix cyclic dependency with utilhttps://github.com/nodejs/node/pull/1988/commits/c6c706fa80f887be57327d88dc2caa03f1e4a876
c6c706fhttps://github.com/nodejs/node/pull/1988/commits/c6c706fa80f887be57327d88dc2caa03f1e4a876
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
force-pushedhttps://github.com/nodejs/node/compare/2eabd33572479f62b3ffbb8a6e21450a113906b3..c6c706fa80f887be57327d88dc2caa03f1e4a876
2eabd33https://github.com/nodejs/node/commit/2eabd33572479f62b3ffbb8a6e21450a113906b3
c6c706fhttps://github.com/nodejs/node/commit/c6c706fa80f887be57327d88dc2caa03f1e4a876
Compare https://github.com/nodejs/node/compare/2eabd33572479f62b3ffbb8a6e21450a113906b3..c6c706fa80f887be57327d88dc2caa03f1e4a876
June 16, 2015 04:53https://github.com/nodejs/node/pull/1988#event-331723126
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112291172
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
util: dont repeat isBufferhttps://github.com/nodejs/node/pull/1988/commits/5905ab2072f516367cf8182a15de2e0b803cd485
5905ab2https://github.com/nodejs/node/pull/1988/commits/5905ab2072f516367cf8182a15de2e0b803cd485
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112292259
@brendanashworthhttps://github.com/brendanashworth
#1892https://github.com/nodejs/node/pull/1892
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112293812
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112294109
@silverwindhttps://github.com/silverwind
#1892https://github.com/nodejs/node/pull/1892
#1892https://github.com/nodejs/node/pull/1892
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112294361
#1892https://github.com/nodejs/node/pull/1892
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112296094
#1892https://github.com/nodejs/node/pull/1892
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112298898
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/17/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/17/
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112598518
@brendanashworthhttps://github.com/brendanashworth
671e64ahttps://github.com/nodejs/node/commit/671e64ac732532892e543c0a8d6efd0b8639e757
@rvagghttps://github.com/rvagg
@Fishrock123https://github.com/Fishrock123
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112598972
@silverwindhttps://github.com/silverwind
3806d87https://github.com/nodejs/node/commit/3806d875d3dbff96041638299a1974579e9a5b4a
they were talking about a CVEhttps://github.com/nodejs/io.js/pull/1811#issuecomment-110793722
Please reload this pagehttps://github.com/nodejs/node/pull/1988
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015 https://github.com/nodejs/node/pull/1988#ref-commit-1d79f57
https://github.com/brendanashworth
util: move deprecate() to internal modulehttps://github.com/nodejs/node/commit/1d79f572f170de918a186db7036290975ffb1bfc
1d79f57https://github.com/nodejs/node/commit/1d79f572f170de918a186db7036290975ffb1bfc
#1988https://github.com/nodejs/node/pull/1988
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015 https://github.com/nodejs/node/pull/1988#ref-commit-d5637e6
https://github.com/brendanashworth
buffer: fix cyclic dependency with utilhttps://github.com/nodejs/node/commit/d5637e67c9d01763c2cb4c202413b4d5890e0486
d5637e6https://github.com/nodejs/node/commit/d5637e67c9d01763c2cb4c202413b4d5890e0486
#1988https://github.com/nodejs/node/pull/1988
#1987https://github.com/nodejs/node/issues/1987
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015 https://github.com/nodejs/node/pull/1988#ref-commit-626432d
https://github.com/brendanashworth
util: dont repeat isBufferhttps://github.com/nodejs/node/commit/626432d843aaf3abc60b2db2b265b95023fd5938
626432dhttps://github.com/nodejs/node/commit/626432d843aaf3abc60b2db2b265b95023fd5938
#1988https://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#issuecomment-112601518
671e64a...626432dhttps://github.com/nodejs/node/compare/671e64ac732532892e543c0a8d6efd0b8639e757...626432d843aaf3abc60b2db2b265b95023fd5938
#1996https://github.com/nodejs/node/pull/1996
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 16, 2015https://github.com/nodejs/node/pull/1988#event-332636812
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 17, 2015 https://github.com/nodejs/node/pull/1988#ref-pullrequest-84936245
util: util.deprecate improvement #1892 https://github.com/nodejs/node/pull/1892
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jun 18, 2015 https://github.com/nodejs/node/pull/1988#ref-pullrequest-88863937
Release proposal: v2.3.1 #1996 https://github.com/nodejs/node/pull/1996
[Snyk] Fix for 13 vulnerabilities aliscco/alisco-node#112 https://github.com/aliscco/alisco-node/pull/112
[Snyk] Fix for 5 vulnerabilities aliscco/alisco-node#348 https://github.com/aliscco/alisco-node/pull/348
https://github.com/aliscco
alisccohttps://github.com/aliscco
Jun 21, 2023 https://github.com/nodejs/node/pull/1988#ref-pullrequest-1768382430
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#477 https://github.com/aliscco/alisco-node/pull/477
https://github.com/aliscco
alisccohttps://github.com/aliscco
Jun 21, 2023 https://github.com/nodejs/node/pull/1988#ref-pullrequest-1768588255
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#487 https://github.com/aliscco/alisco-node/pull/487
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1988
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
util.isBuffer(...) fails on 2.3.0 https://github.com/nodejs/node/issues/1987
Please reload this pagehttps://github.com/nodejs/node/pull/1988
https://github.com/brendanashworth
https://github.com/targos
https://github.com/silverwind
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.