René's URL Explorer Experiment


Title: buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength by joyeecheung · Pull Request #19738 · nodejs/node · GitHub

Open Graph Title: buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength by joyeecheung · Pull Request #19738 · nodejs/node

X Title: buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLength by joyeecheung · Pull Request #19738 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This was added in v8 6.2 by v8/v8@19fee8b, looks like a safe replacement for our own buffer::kMaxLength Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows c...

X Description: This was added in v8 6.2 by v8/v8@19fee8b, looks like a safe replacement for our own buffer::kMaxLength Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows c...

Opengraph URL: https://github.com/nodejs/node/pull/19738

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a221b29-9717-81ba-be94-78a645c2d2e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC306:13AEE3:AEF871:DEA449:69917D39
html-safe-noncea5352fbd1e3fb2a88e35c0ebabb25123571a21d8d1e3cddcf690a5e015818922
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzA2OjEzQUVFMzpBRUY4NzE6REVBNDQ5OjY5OTE3RDM5IiwidmlzaXRvcl9pZCI6IjM4Mzk1MzAxMzgyMjkzNzQyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace5e7b743ea125788c64a3d0cc6af8fb1c79c8ffe19ca2019d2146391a36ecdb7
hovercard-subject-tagpull_request:178764334
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19738/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/51b3c7f120a1dedadd0bb2433a2724ba791f915d18d3be5130832cc94044be27/nodejs/node/pull/19738
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/51b3c7f120a1dedadd0bb2433a2724ba791f915d18d3be5130832cc94044be27/nodejs/node/pull/19738
og:image:altThis was added in v8 6.2 by v8/v8@19fee8b, looks like a safe replacement for our own buffer::kMaxLength Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19738#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19738
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19738
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19738
Reloadhttps://github.com/nodejs/node/pull/19738
Reloadhttps://github.com/nodejs/node/pull/19738
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19738
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:buffer-max-lengthhttps://github.com/joyeecheung/node/tree/buffer-max-length
Conversationhttps://github.com/nodejs/node/pull/19738
Commits1 (1)https://github.com/nodejs/node/pull/19738/commits
Checkshttps://github.com/nodejs/node/pull/19738/checks
Files changedhttps://github.com/nodejs/node/pull/19738/files
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLengthhttps://github.com/nodejs/node/pull/19738#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:buffer-max-lengthhttps://github.com/joyeecheung/node/tree/buffer-max-length
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 2, 2018https://github.com/nodejs/node/pull/19738#issue-310381904
v8/v8@19fee8bhttps://github.com/v8/v8/commit/19fee8b24b2f1580a92910635e0ca02cbdf615af
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19738
https://github.com/joyeecheung
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLengthhttps://github.com/nodejs/node/pull/19738/commits/b56a3075c43ad030cecaad9b3d91b8943bf79761
b56a307https://github.com/nodejs/node/pull/19738/commits/b56a3075c43ad030cecaad9b3d91b8943bf79761
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Apr 2, 2018https://github.com/nodejs/node/pull/19738#event-1551387899
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 2, 2018https://github.com/nodejs/node/pull/19738#issuecomment-377843221
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/19738
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 2, 2018https://github.com/nodejs/node/pull/19738#issuecomment-377843264
https://ci.nodejs.org/job/node-test-pull-request/13979/https://ci.nodejs.org/job/node-test-pull-request/13979/
Please reload this pagehttps://github.com/nodejs/node/pull/19738
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 2, 2018 https://github.com/nodejs/node/pull/19738#ref-pullrequest-310382824
src: add ERR_* helpers in C++ and migrates toString() errors in string_bytes.cc #19739 https://github.com/nodejs/node/pull/19739
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 2, 2018 https://github.com/nodejs/node/pull/19738#pullrequestreview-108621872
View reviewed changes https://github.com/nodejs/node/pull/19738/files/b56a3075c43ad030cecaad9b3d91b8943bf79761
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 2, 2018 https://github.com/nodejs/node/pull/19738#pullrequestreview-108622078
View reviewed changes https://github.com/nodejs/node/pull/19738/files/b56a3075c43ad030cecaad9b3d91b8943bf79761
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 2, 2018 https://github.com/nodejs/node/pull/19738#pullrequestreview-108627972
View reviewed changes https://github.com/nodejs/node/pull/19738/files/b56a3075c43ad030cecaad9b3d91b8943bf79761
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 4, 2018https://github.com/nodejs/node/pull/19738#issuecomment-378495741
30fe55ehttps://github.com/nodejs/node/commit/30fe55e248087664e91928794ef281fbf2ba8c8d
Please reload this pagehttps://github.com/nodejs/node/pull/19738
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 4, 2018https://github.com/nodejs/node/pull/19738#event-1555696893
joyeecheunghttps://github.com/joyeecheung
Apr 4, 2018 https://github.com/nodejs/node/pull/19738#ref-commit-30fe55e
https://github.com/joyeecheung
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLengthhttps://github.com/nodejs/node/commit/30fe55e248087664e91928794ef281fbf2ba8c8d
30fe55ehttps://github.com/nodejs/node/commit/30fe55e248087664e91928794ef281fbf2ba8c8d
#19738https://github.com/nodejs/node/pull/19738
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Apr 4, 2018https://github.com/nodejs/node/pull/19738#event-1556085899
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/19738#ref-commit-0bd78dc
https://github.com/joyeecheung
https://github.com/targos
buffer: use v8::TypedArray::kMaxLength as buffer::kMaxLengthhttps://github.com/nodejs/node/commit/0bd78dc3912d28db293c38423c4581e93b0c16ac
0bd78dchttps://github.com/nodejs/node/commit/0bd78dc3912d28db293c38423c4581e93b0c16ac
#19738https://github.com/nodejs/node/pull/19738
https://github.com/targos
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/19738#ref-pullrequest-311275671
v9.11.0 proposal #19799 https://github.com/nodejs/node/pull/19799
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19738
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/19738/files/b56a3075c43ad030cecaad9b3d91b8943bf79761
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/19738/files/b56a3075c43ad030cecaad9b3d91b8943bf79761
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/19738/files/b56a3075c43ad030cecaad9b3d91b8943bf79761
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/19738
https://github.com/joyeecheung
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.