René's URL Explorer Experiment


Title: lib: fixing isStackOverflowError to account for different JS engines by mike-kaufman · Pull Request #19705 · nodejs/node · GitHub

Open Graph Title: lib: fixing isStackOverflowError to account for different JS engines by mike-kaufman · Pull Request #19705 · nodejs/node

X Title: lib: fixing isStackOverflowError to account for different JS engines by mike-kaufman · Pull Request #19705 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Assumption that stack overflow exception has name == "RangeError" is v8-specific. Updated logic to dynamically capture error name when capturing error message. make -j4 test (UNIX), or...

X Description: Assumption that stack overflow exception has name == "RangeError" is v8-specific. Updated logic to dynamically capture error name when capturing error message. make -j4 test (U...

Opengraph URL: https://github.com/nodejs/node/pull/19705

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7f99e7e6-c322-de5c-2ef4-9fd86055e671
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC2A:E58C0:150780D:1AA3747:69917DC0
html-safe-nonce934db8f307708be26b5bbad3d77c610e9b8302deaae268db5053a6d1d3880fac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzJBOkU1OEMwOjE1MDc4MEQ6MUFBMzc0Nzo2OTkxN0RDMCIsInZpc2l0b3JfaWQiOiI3NDY2Mzc5NTc1ODYzMzc3MzQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacef50e3f9641868ff23c3d34873ff7783be760741e51030577211f4a0b7b0cb30
hovercard-subject-tagpull_request:178601359
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19705/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/47413755556e8e24ee0a6c33af02ec2a77ccdd391f2832223dca26d99c06d5d8/nodejs/node/pull/19705
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/47413755556e8e24ee0a6c33af02ec2a77ccdd391f2832223dca26d99c06d5d8/nodejs/node/pull/19705
og:image:altAssumption that stack overflow exception has name == "RangeError" is v8-specific. Updated logic to dynamically capture error name when capturing error message. make -j4 test (UNIX), or...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemike-kaufman
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19705#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19705
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19705
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19705
Reloadhttps://github.com/nodejs/node/pull/19705
Reloadhttps://github.com/nodejs/node/pull/19705
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19705
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mike-kaufmanhttps://github.com/mike-kaufman
nodejs:masterhttps://github.com/nodejs/node/tree/master
mike-kaufman:mkaufman-fix-is-stack-overflow-for-node-chakracorehttps://github.com/mike-kaufman/node/tree/mkaufman-fix-is-stack-overflow-for-node-chakracore
Conversationhttps://github.com/nodejs/node/pull/19705
Commits3 (3)https://github.com/nodejs/node/pull/19705/commits
Checkshttps://github.com/nodejs/node/pull/19705/checks
Files changedhttps://github.com/nodejs/node/pull/19705/files
lib: fixing isStackOverflowError to account for different JS engineshttps://github.com/nodejs/node/pull/19705#top
mike-kaufmanhttps://github.com/mike-kaufman
nodejs:masterhttps://github.com/nodejs/node/tree/master
mike-kaufman:mkaufman-fix-is-stack-overflow-for-node-chakracorehttps://github.com/mike-kaufman/node/tree/mkaufman-fix-is-stack-overflow-for-node-chakracore
https://github.com/mike-kaufman
mike-kaufmanhttps://github.com/mike-kaufman
Mar 30, 2018https://github.com/nodejs/node/pull/19705#issue-310123166
Please reload this pagehttps://github.com/nodejs/node/pull/19705
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Mar 30, 2018https://github.com/nodejs/node/pull/19705#event-1550068482
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 30, 2018 https://github.com/nodejs/node/pull/19705#pullrequestreview-108384979
View reviewed changes https://github.com/nodejs/node/pull/19705/files
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018 https://github.com/nodejs/node/pull/19705#pullrequestreview-108386714
View reviewed changes https://github.com/nodejs/node/pull/19705/files
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377580030
https://ci.nodejs.org/job/node-test-pull-request/13954/https://ci.nodejs.org/job/node-test-pull-request/13954/
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 30, 2018https://github.com/nodejs/node/pull/19705#event-1550096660
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377580274
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018 https://github.com/nodejs/node/pull/19705#pullrequestreview-108391861
View reviewed changes https://github.com/nodejs/node/pull/19705/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/19705#pullrequestreview-108391861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19705
lib/internal/errors.jshttps://github.com/nodejs/node/pull/19705/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
Trotthttps://github.com/Trott
Mar 30, 2018https://github.com/nodejs/node/pull/19705#discussion_r178340417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19705
mike-kaufmanhttps://github.com/mike-kaufman
Mar 30, 2018https://github.com/nodejs/node/pull/19705#discussion_r178368356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19705
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018https://github.com/nodejs/node/pull/19705#discussion_r178369753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/19705
lib: fixing isStackOverflowError to account for different JS engineshttps://github.com/nodejs/node/pull/19705/commits/01b9afbc41e76969fd2e9f0560cfedbcbc96a207
01b9afbhttps://github.com/nodejs/node/pull/19705/commits/01b9afbc41e76969fd2e9f0560cfedbcbc96a207
https://github.com/mike-kaufman
mike-kaufmanhttps://github.com/mike-kaufman
force-pushedhttps://github.com/nodejs/node/compare/9a19c0ac966096c956f8a6a8ddfde3820856078d..01b9afbc41e76969fd2e9f0560cfedbcbc96a207
9a19c0ahttps://github.com/nodejs/node/commit/9a19c0ac966096c956f8a6a8ddfde3820856078d
01b9afbhttps://github.com/nodejs/node/commit/01b9afbc41e76969fd2e9f0560cfedbcbc96a207
Compare https://github.com/nodejs/node/compare/9a19c0ac966096c956f8a6a8ddfde3820856078d..01b9afbc41e76969fd2e9f0560cfedbcbc96a207
March 30, 2018 18:37https://github.com/nodejs/node/pull/19705#event-1550178414
https://github.com/TimothyGu
fixup! lib: fixing isStackOverflowError to account for different JS e…https://github.com/nodejs/node/pull/19705/commits/2b4118c6bf4e755bc7804d112373f9959e4ebc41
2b4118chttps://github.com/nodejs/node/pull/19705/commits/2b4118c6bf4e755bc7804d112373f9959e4ebc41
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018 https://github.com/nodejs/node/pull/19705#pullrequestreview-108420925
View reviewed changes https://github.com/nodejs/node/pull/19705/files/2b4118c6bf4e755bc7804d112373f9959e4ebc41
lib/internal/errors.jshttps://github.com/nodejs/node/pull/19705/files/2b4118c6bf4e755bc7804d112373f9959e4ebc41#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018https://github.com/nodejs/node/pull/19705#discussion_r178365999
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19705
responding to PR feedbackhttps://github.com/nodejs/node/pull/19705/commits/d6267a811026de4fd4f639624250996bca2534aa
d6267a8https://github.com/nodejs/node/pull/19705/commits/d6267a811026de4fd4f639624250996bca2534aa
https://github.com/Trott
Trotthttps://github.com/Trott
stale reviewhttps://github.com/nodejs/node/pull/19705#pullrequestreview-108391861
March 30, 2018 21:22https://github.com/nodejs/node/pull/19705#event-1550387151
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018 https://github.com/nodejs/node/pull/19705#pullrequestreview-108442326
View reviewed changes https://github.com/nodejs/node/pull/19705/files/d6267a811026de4fd4f639624250996bca2534aa
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377626672
https://ci.nodejs.org/job/node-test-pull-request/13958/https://ci.nodejs.org/job/node-test-pull-request/13958/
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/mike-kaufman
mike-kaufmanhttps://github.com/mike-kaufman
Mar 30, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377647319
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 30, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377648069
@mike-kaufmanhttps://github.com/mike-kaufman
https://ci.nodejs.org/job/node-test-commit/17310/https://ci.nodejs.org/job/node-test-commit/17310/
https://ci.nodejs.org/job/node-test-commit-plinux/16473/https://ci.nodejs.org/job/node-test-commit-plinux/16473/
https://ci.nodejs.org/job/node-test-commit-plinux/16473/nodes=ppcle-ubuntu1404/https://ci.nodejs.org/job/node-test-commit-plinux/16473/nodes=ppcle-ubuntu1404/
https://ci.nodejs.org/job/node-test-commit-plinux/16473/nodes=ppcle-ubuntu1404/consolehttps://ci.nodejs.org/job/node-test-commit-plinux/16473/nodes=ppcle-ubuntu1404/console
https://ci.nodejs.org/job/node-test-commit-plinux/16474/https://ci.nodejs.org/job/node-test-commit-plinux/16474/
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 1, 2018 https://github.com/nodejs/node/pull/19705#pullrequestreview-108531480
View reviewed changes https://github.com/nodejs/node/pull/19705/files/d6267a811026de4fd4f639624250996bca2534aa
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 1, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377824602
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/mike-kaufman
mike-kaufmanhttps://github.com/mike-kaufman
Apr 2, 2018https://github.com/nodejs/node/pull/19705#issuecomment-377944091
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/19705
Trotthttps://github.com/Trott
Apr 2, 2018 https://github.com/nodejs/node/pull/19705#ref-commit-cd5f353
https://github.com/Trott
lib: make isStackOverflowError() engine-agnostichttps://github.com/Trott/io.js/commit/cd5f353405842329fc44d25d677735a8538d6c43
cd5f353https://github.com/Trott/io.js/commit/cd5f353405842329fc44d25d677735a8538d6c43
nodejs#19705https://github.com/nodejs/node/pull/19705
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 2, 2018https://github.com/nodejs/node/pull/19705#issuecomment-378036109
cd5f353https://github.com/nodejs/node/commit/cd5f353405842329fc44d25d677735a8538d6c43
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 2, 2018https://github.com/nodejs/node/pull/19705#event-1552697171
targoshttps://github.com/targos
Apr 3, 2018 https://github.com/nodejs/node/pull/19705#ref-commit-152a86c
https://github.com/targos
lib: make isStackOverflowError() engine-agnostichttps://github.com/nodejs/node/commit/152a86c6aa9b13d112bffef9e29274f8f71caf1c
152a86chttps://github.com/nodejs/node/commit/152a86c6aa9b13d112bffef9e29274f8f71caf1c
#19705https://github.com/nodejs/node/pull/19705
https://github.com/targos
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/19705#ref-pullrequest-311275671
v9.11.0 proposal #19799 https://github.com/nodejs/node/pull/19799
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19705
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/19705/files/d6267a811026de4fd4f639624250996bca2534aa
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/19705/files/d6267a811026de4fd4f639624250996bca2534aa
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/19705/files/9a19c0ac966096c956f8a6a8ddfde3820856078d
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/19705/files/9a19c0ac966096c956f8a6a8ddfde3820856078d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Please reload this pagehttps://github.com/nodejs/node/pull/19705
https://github.com/mike-kaufman
https://github.com/Trott
https://github.com/jasnell
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.