Title: test: fix flaky test-cluster-send-handle-twice by Trott · Pull Request #19700 · nodejs/node · GitHub
Open Graph Title: test: fix flaky test-cluster-send-handle-twice by Trott · Pull Request #19700 · nodejs/node
X Title: test: fix flaky test-cluster-send-handle-twice by Trott · Pull Request #19700 · nodejs/node
Description: Use common.mustCall() to make sure connection callback runs exactly once. Use connect event instead of setTimeout to avoid test failing if timer runs before client is connected. Remove cluster.worker.disconnect() after assert.fail(). It is unreachable code that is unnecessary. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
Open Graph Description: Use common.mustCall() to make sure connection callback runs exactly once. Use connect event instead of setTimeout to avoid test failing if timer runs before client is connected. Remove cluster.work...
X Description: Use common.mustCall() to make sure connection callback runs exactly once. Use connect event instead of setTimeout to avoid test failing if timer runs before client is connected. Remove cluster.work...
Opengraph URL: https://github.com/nodejs/node/pull/19700
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3622ba3b-56b1-8502-fcc3-67bad7f32b50 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECF2:262BEC:620EA1:7F16E1:69928C8F |
| html-safe-nonce | aa8342bea0a796f5bc0c2b0daed5dd80ba41353ba874ad03cdbaf90a517fdce9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0YyOjI2MkJFQzo2MjBFQTE6N0YxNkUxOjY5OTI4QzhGIiwidmlzaXRvcl9pZCI6IjE5ODc1NTUyNjM5ODk4NDUxMzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0e8efd079489f1d9af0bf9b2b53118baab115d899328ddf6b79ffb2b967beba4 |
| hovercard-subject-tag | pull_request:178559314 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/19700/files |
| twitter:image | https://avatars.githubusercontent.com/u/718899?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/718899?s=400&v=4 |
| og:image:alt | Use common.mustCall() to make sure connection callback runs exactly once. Use connect event instead of setTimeout to avoid test failing if timer runs before client is connected. Remove cluster.work... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width