René's URL Explorer Experiment


Title: timers: enable timers to be used as primitives by bmeck · Pull Request #19683 · nodejs/node · GitHub

Open Graph Title: timers: enable timers to be used as primitives by bmeck · Pull Request #19683 · nodejs/node

X Title: timers: enable timers to be used as primitives by bmeck · Pull Request #19683 · nodejs/node

Description: For web compatibility this allows timers to be stored as the key of an Object property and be passed back to corresponding method to clear the timer. Note that this is using the async_id_symbol to ...

Open Graph Description: For web compatibility this allows timers to be stored as the key of an Object property and be passed back to corresponding method to clear the timer. Note that this is using the async_id_symbol to ...

X Description: For web compatibility this allows timers to be stored as the key of an Object property and be passed back to corresponding method to clear the timer. Note that this is using the async_id_symbol to ...

Opengraph URL: https://github.com/nodejs/node/pull/19683

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b1c20ad-5004-6fcc-322e-c1c1a667e8ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E14:193CDB:19D6BD5:21ABEBE:696B2C58
html-safe-noncebd957e7bb2592d1b5c69416857d6fc6d93e96bc799fdc4dc2f531952002a1739
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTE0OjE5M0NEQjoxOUQ2QkQ1OjIxQUJFQkU6Njk2QjJDNTgiLCJ2aXNpdG9yX2lkIjoiMzc0MjY1OTQ3ODczNzg1NzYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb0d86ae99db1a29087b2cb4f255df447943f86027f03d8dd06d01f94bd06607b
hovercard-subject-tagpull_request:178432359
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19683/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/22cf14055c5ede37838ac1191d1b148f359be26a7ae2ec01e79312736df2448c/nodejs/node/pull/19683
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/22cf14055c5ede37838ac1191d1b148f359be26a7ae2ec01e79312736df2448c/nodejs/node/pull/19683
og:image:altFor web compatibility this allows timers to be stored as the key of an Object property and be passed back to corresponding method to clear the timer. Note that this is using the async_id_symbol to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebmeck
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19683#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19683
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19683
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19683
Reloadhttps://github.com/nodejs/node/pull/19683
Reloadhttps://github.com/nodejs/node/pull/19683
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19683
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/19683
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/19683#issue-comment-box
bmeckhttps://github.com/bmeck
nodejs:masterhttps://github.com/nodejs/node/tree/master
bmeck:timeout-toPrimitivehttps://github.com/bmeck/node/tree/timeout-toPrimitive
timers: enable timers to be used as primitives https://github.com/nodejs/node/pull/19683#top
bmeckhttps://github.com/bmeck
nodejs:masterhttps://github.com/nodejs/node/tree/master
bmeck:timeout-toPrimitivehttps://github.com/bmeck/node/tree/timeout-toPrimitive
Conversation 49 https://github.com/nodejs/node/pull/19683
Commits 7 https://github.com/nodejs/node/pull/19683/commits
Checks 0 https://github.com/nodejs/node/pull/19683/checks
Files changed https://github.com/nodejs/node/pull/19683/files
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issue-309891860
Please reload this pagehttps://github.com/nodejs/node/pull/19683
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
timers: enable timers to be used as primitiveshttps://github.com/nodejs/node/pull/19683/commits/9ac2bd41f6d13020d258c861197991b828bd5fe9
9ac2bd4https://github.com/nodejs/node/pull/19683/commits/9ac2bd41f6d13020d258c861197991b828bd5fe9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Mar 29, 2018https://github.com/nodejs/node/pull/19683#event-1548728216
https://github.com/bmeck
bmeckhttps://github.com/bmeck
addaleaxhttps://github.com/addaleax
trevnorrishttps://github.com/trevnorris
March 29, 2018 20:25https://github.com/nodejs/node/pull/19683#event-1548728590
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 29, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108194106
View reviewed changes https://github.com/nodejs/node/pull/19683/files/9ac2bd41f6d13020d258c861197991b828bd5fe9
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/9ac2bd41f6d13020d258c861197991b828bd5fe9#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
addaleaxhttps://github.com/addaleax
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178173506
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178174200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178176234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377363708
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377364674
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
move cache assignment to toPrimitive callhttps://github.com/nodejs/node/pull/19683/commits/6101d5283ad9e565c87a365140fa4823825d0e91
6101d52https://github.com/nodejs/node/pull/19683/commits/6101d5283ad9e565c87a365140fa4823825d0e91
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 29, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108199966
View reviewed changes https://github.com/nodejs/node/pull/19683/files/6101d5283ad9e565c87a365140fa4823825d0e91
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/19683#pullrequestreview-108199966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/6101d5283ad9e565c87a365140fa4823825d0e91#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
addaleaxhttps://github.com/addaleax
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178178328
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178180509
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Mar 29, 2018https://github.com/nodejs/node/pull/19683#event-1548778913
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377374774
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
doc && fix bughttps://github.com/nodejs/node/pull/19683/commits/e32b9698fa324810bfe13501594b264eef694281
e32b969https://github.com/nodejs/node/pull/19683/commits/e32b9698fa324810bfe13501594b264eef694281
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377379500
Please reload this pagehttps://github.com/nodejs/node/pull/19683
@bmeckhttps://github.com/bmeck
https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md#comparing-nodejs-versionshttps://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md#comparing-nodejs-versions
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377379654
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 29, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108211964
View reviewed changes https://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/19683#pullrequestreview-108211964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://ci.nodejs.org/job/node-test-commit/17271/https://ci.nodejs.org/job/node-test-commit/17271/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/145/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/145/
Please reload this pagehttps://github.com/nodejs/node/pull/19683
doc/api/timers.mdhttps://github.com/nodejs/node/pull/19683/files/6101d5283ad9e565c87a365140fa4823825d0e91..e32b9698fa324810bfe13501594b264eef694281#diff-5df4100773a1545e98d8c01219d23b913ac663812e286963b011cf61357a84d6
addaleaxhttps://github.com/addaleax
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178187839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178200038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 29, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108212490
View reviewed changes https://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
TimothyGuhttps://github.com/TimothyGu
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178188289
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178200028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
doc/api/timers.mdhttps://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281#diff-5df4100773a1545e98d8c01219d23b913ac663812e286963b011cf61357a84d6
TimothyGuhttps://github.com/TimothyGu
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178188415
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178200018
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
doc/api/timers.mdhttps://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281#diff-5df4100773a1545e98d8c01219d23b913ac663812e286963b011cf61357a84d6
TimothyGuhttps://github.com/TimothyGu
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178188539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178200177
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
TimothyGuhttps://github.com/TimothyGu
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178188567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178200062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/e32b9698fa324810bfe13501594b264eef694281#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
TimothyGuhttps://github.com/TimothyGu
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178188625
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 29, 2018https://github.com/nodejs/node/pull/19683#discussion_r178199590
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://codepen.io/bradleymeck/pen/eMMpdR?editors=0012https://codepen.io/bradleymeck/pen/eMMpdR?editors=0012
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
March 29, 2018 17:41https://github.com/nodejs/node/pull/19683#commits-pushed-c4ec0e5
https://github.com/bmeck
nitshttps://github.com/nodejs/node/pull/19683/commits/c4ec0e5eebe20c414df03b3fc787bb32843648d6
c4ec0e5https://github.com/nodejs/node/pull/19683/commits/c4ec0e5eebe20c414df03b3fc787bb32843648d6
https://github.com/bmeck
nitshttps://github.com/nodejs/node/pull/19683/commits/d96304708b8b6dba04ffe4b85e8bed75b771e331
d963047https://github.com/nodejs/node/pull/19683/commits/d96304708b8b6dba04ffe4b85e8bed75b771e331
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 29, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377399325
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 29, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108234674
View reviewed changes https://github.com/nodejs/node/pull/19683/files/d96304708b8b6dba04ffe4b85e8bed75b771e331
mscdexhttps://github.com/mscdex
https://github.com/nodejs/node/pull/19683#pullrequestreview-108234674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Mar 30, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377416125
Please reload this pagehttps://github.com/nodejs/node/pull/19683
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
only delete if put into cachehttps://github.com/nodejs/node/pull/19683/commits/54b8894ace554389333bcb5c706ebaceda5cd5ac
54b8894https://github.com/nodejs/node/pull/19683/commits/54b8894ace554389333bcb5c706ebaceda5cd5ac
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108273864
View reviewed changes https://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178241955
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178286648
Please reload this pagehttps://github.com/nodejs/node/pull/19683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
addaleaxhttps://github.com/addaleax
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178286853
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178288171
Please reload this pagehttps://github.com/nodejs/node/pull/19683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
addaleaxhttps://github.com/addaleax
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178288383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178289114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108273949
View reviewed changes https://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178242022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178286612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e32b969https://github.com/nodejs/node/commit/e32b9698fa324810bfe13501594b264eef694281
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-108273958
View reviewed changes https://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac
lib/timers.jshttps://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724
TimothyGuhttps://github.com/TimothyGu
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178242031
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
bmeckhttps://github.com/bmeck
Mar 30, 2018https://github.com/nodejs/node/pull/19683#discussion_r178286579
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
lintinghttps://github.com/nodejs/node/pull/19683/commits/d7ae747df16c48e73187a09291aec8af4b8b5460
d7ae747https://github.com/nodejs/node/pull/19683/commits/d7ae747df16c48e73187a09291aec8af4b8b5460
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Apr 2, 2018https://github.com/nodejs/node/pull/19683#issuecomment-377942103
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Apr 3, 2018https://github.com/nodejs/node/pull/19683#issuecomment-378259081
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/151/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/151/
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 11, 2018 https://github.com/nodejs/node/pull/19683#pullrequestreview-111430910
View reviewed changes https://github.com/nodejs/node/pull/19683/files/d7ae747df16c48e73187a09291aec8af4b8b5460
Fishrock123https://github.com/Fishrock123
https://github.com/nodejs/node/pull/19683#pullrequestreview-111430910
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
test/parallel/test-timers-toPrimitive.jshttps://github.com/nodejs/node/pull/19683/files/d7ae747df16c48e73187a09291aec8af4b8b5460#diff-642e4a870e6958b57d775fd45af712497babe103d0418f7f476cfe83c2c99f26
Fishrock123https://github.com/Fishrock123
Apr 11, 2018https://github.com/nodejs/node/pull/19683#discussion_r180921854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2018 https://github.com/nodejs/node/pull/19683#ref-issue-317402663
[DEP0096] DeprecationWarning: timers.unenroll() question #20261 https://github.com/nodejs/node/issues/20261
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 25, 2018https://github.com/nodejs/node/pull/19683#issuecomment-384333893
@bmeckhttps://github.com/bmeck
[DEP0096] DeprecationWarning: timers.unenroll() question  #20261 (comment)https://github.com/nodejs/node/issues/20261#issuecomment-384329279
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Apr 25, 2018https://github.com/nodejs/node/pull/19683#issuecomment-384460884
…https://github.com/nodejs/node/pull/19683
@bmeckhttps://github.com/bmeck
https://github.com/bmeckhttps://github.com/bmeck
#20261https://github.com/nodejs/node/issues/20261
#20261 (comment)https://github.com/nodejs/node/issues/20261#issuecomment-384329279
#19683 (comment)https://github.com/nodejs/node/pull/19683#issuecomment-384333893
https://github.com/notifications/unsubscribe-auth/AAOUo9g2Dh_7r20OAuAmEcJDcQNZO8aUks5tsJmtgaJpZM4TA7q-https://github.com/notifications/unsubscribe-auth/AAOUo9g2Dh_7r20OAuAmEcJDcQNZO8aUks5tsJmtgaJpZM4TA7q-
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
May 14, 2018https://github.com/nodejs/node/pull/19683#issuecomment-388876595
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 18, 2018https://github.com/nodejs/node/pull/19683#issuecomment-390228451
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 1, 2018https://github.com/nodejs/node/pull/19683#issuecomment-393849163
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Jun 1, 2018https://github.com/nodejs/node/pull/19683#issuecomment-393873526
@apapirovskihttps://github.com/apapirovski
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 1, 2018https://github.com/nodejs/node/pull/19683#issuecomment-393874325
@bmeckhttps://github.com/bmeck
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 5, 2018 https://github.com/nodejs/node/pull/19683#ref-pullrequest-329517907
timers: allow timers to be used as primitives #21152 https://github.com/nodejs/node/pull/21152
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 25, 2018https://github.com/nodejs/node/pull/19683#issuecomment-399835985
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Jun 25, 2018https://github.com/nodejs/node/pull/19683#event-1698033133
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19683
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac
https://github.com/trevnorris
trevnorris https://github.com/trevnorris
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/19683/files/d7ae747df16c48e73187a09291aec8af4b8b5460
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/19683/files/54b8894ace554389333bcb5c706ebaceda5cd5ac
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/19683/files/d96304708b8b6dba04ffe4b85e8bed75b771e331
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Please reload this pagehttps://github.com/nodejs/node/pull/19683
https://github.com/bmeck
https://github.com/mscdex
https://github.com/Trott
https://github.com/addaleax
https://github.com/Fishrock123
https://github.com/apapirovski
https://github.com/TimothyGu
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.