| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2fb2ce9f-62dc-69e3-7fe4-9c192c3df86f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAA8:2362FD:A9888A0:AD084C5:6A50BA42 |
| html-safe-nonce | b5a2b179995217908079db4c2c018b5ede5e3c509a980bca3b3f1fa844815fe8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUE4OjIzNjJGRDpBOTg4OEEwOkFEMDg0QzU6NkE1MEJBNDIiLCJ2aXNpdG9yX2lkIjoiNTI3NzUzMzQyNDU5MzYxODU4IiwicmVnaW9uX2VkZ2UiOiJzZWEiLCJyZWdpb25fcmVuZGVyIjoic2VhIn0= |
| visitor-hmac | e479bffc6bb5e275bfd576f4064c97b10154dec7e14722ac0fa47351fa88d319 |
| hovercard-subject-tag | pull_request:37617708 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1965/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9d08a22e126fa3b3e6877cffda13d37b2889b8523accf39ce6d5017c77674390/nodejs/node/pull/1965 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9d08a22e126fa3b3e6877cffda13d37b2889b8523accf39ce6d5017c77674390/nodejs/node/pull/1965 |
| og:image:alt | Since we will run linting before compiling or testing there's no need to run it as part of the ci testing.
Note to person landing this: Don't merge until we have the linter up and running (... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jbergstroem |
| hostname | github.com |
| expected-hostname | github.com |
| None | 63772747707af4093f0d5fc7aa1bb3bb55f412a9865207c4f421aa34c64cc404 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ded53fe94e3ff1bb4dbf8cc77e285396c92580fb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/1965#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1965 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1965 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1965 |
| Reload | https://github.com/nodejs/node/pull/1965 |
| Reload | https://github.com/nodejs/node/pull/1965 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
979
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| jbergstroem | https://github.com/jbergstroem |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jbergstroem:feature/dont-run-lint-on-testci | https://github.com/jbergstroem/node/tree/feature/dont-run-lint-on-testci |
| Conversation | https://github.com/nodejs/node/pull/1965 |
| Commits1 (1) | https://github.com/nodejs/node/pull/1965/commits |
| Checks | https://github.com/nodejs/node/pull/1965/checks |
| Files changed | https://github.com/nodejs/node/pull/1965/files |
| build: don't run lint from test-ci | https://github.com/nodejs/node/pull/1965#top |
| jbergstroem | https://github.com/jbergstroem |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jbergstroem:feature/dont-run-lint-on-testci | https://github.com/jbergstroem/node/tree/feature/dont-run-lint-on-testci |
|
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#issue-87909518 |
| #1955 | https://github.com/nodejs/node/pull/1955 |
| nodejs/build#109 | https://github.com/nodejs/build/issues/109 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
|
| https://github.com/jbergstroem |
| build: don't run lint from test-ci | https://github.com/nodejs/node/pull/1965/commits/5c72e8bbfb2b59cab4ca1de94ca8641c3a7615e9 |
| 5c72e8b | https://github.com/nodejs/node/pull/1965/commits/5c72e8bbfb2b59cab4ca1de94ca8641c3a7615e9 |
| https://github.com/brendanashworth |
| brendanashworth | https://github.com/brendanashworth |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#event-330084088 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#issuecomment-111672250 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#issuecomment-111674320 |
| @thefourtheye | https://github.com/thefourtheye |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#issuecomment-111676313 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#issuecomment-111710076 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Jun 13, 2015 | https://github.com/nodejs/node/pull/1965#issuecomment-111738466 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
|
Jun 15, 2015
| https://github.com/nodejs/node/pull/1965#ref-issue-87202753 |
|
lint/cclint separately from make test
nodejs/build#109
| https://github.com/nodejs/build/issues/109 |
| jbergstroem | https://github.com/jbergstroem |
|
Jun 15, 2015
| https://github.com/nodejs/node/pull/1965#ref-commit-8d8a26e |
|
| https://github.com/jbergstroem |
| build: don't run lint from test-ci | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| 8d8a26e | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| #1965 | https://github.com/nodejs/node/pull/1965 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Jun 15, 2015 | https://github.com/nodejs/node/pull/1965#issuecomment-111949757 |
| 8d8a26e | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Jun 15, 2015 | https://github.com/nodejs/node/pull/1965#event-330711919 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Jun 16, 2015
| https://github.com/nodejs/node/pull/1965#ref-pullrequest-88863937 |
|
Release proposal: v2.3.1
#1996
| https://github.com/nodejs/node/pull/1996 |
| orangemocha | https://github.com/orangemocha |
|
Jun 17, 2015
| https://github.com/nodejs/node/pull/1965#ref-commit-14e6069 |
|
| https://github.com/jbergstroem |
|
| https://github.com/orangemocha |
| build: don't run lint from test-ci | https://github.com/orangemocha/node/commit/14e606975e9dda74e2e53a1d15ceafa98f02a609 |
| 14e6069 | https://github.com/orangemocha/node/commit/14e606975e9dda74e2e53a1d15ceafa98f02a609 |
| nodejs/node@8d8a26e | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| nodejs/node#1965 | https://github.com/nodejs/node/pull/1965 |
| https://github.com/orangemocha |
| orangemocha | https://github.com/orangemocha |
|
Jun 17, 2015
| https://github.com/nodejs/node/pull/1965#ref-pullrequest-89017950 |
|
build: don't run lint from test-ci
orangemocha/node#11
| https://github.com/orangemocha/node/pull/11 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
|
Jun 17, 2015
| https://github.com/nodejs/node/pull/1965#ref-pullrequest-89146562 |
|
build: remove lint from test-ci on windows
#2004
| https://github.com/nodejs/node/pull/2004 |
| orangemocha | https://github.com/orangemocha |
|
Jun 29, 2015
| https://github.com/nodejs/node/pull/1965#ref-commit-dc74f3b |
|
| https://github.com/jbergstroem |
|
| https://github.com/orangemocha |
| build: don't run lint from test-ci | https://github.com/orangemocha/node/commit/dc74f3b9543f8a371ab310763a8e64bb4277dd13 |
| dc74f3b | https://github.com/orangemocha/node/commit/dc74f3b9543f8a371ab310763a8e64bb4277dd13 |
| nodejs/node@8d8a26e | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| nodejs/node#1965 | https://github.com/nodejs/node/pull/1965 |
| #11 | https://github.com/orangemocha/node/pull/11 |
| rvagg | https://github.com/rvagg |
|
Jul 3, 2015
| https://github.com/nodejs/node/pull/1965#ref-commit-693a516 |
|
| https://github.com/jbergstroem |
|
| https://github.com/rvagg |
| build: don't run lint from test-ci | https://github.com/rvagg/io.js/commit/693a5166260279ed7e3a12f962854a8b02e3059f |
| 693a516 | https://github.com/rvagg/io.js/commit/693a5166260279ed7e3a12f962854a8b02e3059f |
| nodejs#1965 | https://github.com/nodejs/node/pull/1965 |
| jbergstroem | https://github.com/jbergstroem |
|
Jul 3, 2015
| https://github.com/nodejs/node/pull/1965#ref-commit-e52e990 |
|
| https://github.com/jbergstroem |
|
| https://github.com/Fishrock123 |
| build: don't run lint from test-ci | https://github.com/nodejs/node/commit/e52e99085e5675b19288bb081021bd469ec8606d |
| e52e990 | https://github.com/nodejs/node/commit/e52e99085e5675b19288bb081021bd469ec8606d |
| #1965 | https://github.com/nodejs/node/pull/1965 |
| #2101 | https://github.com/nodejs/node/pull/2101 |
| 8d8a26e | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| orangemocha | https://github.com/orangemocha |
|
Jul 7, 2015
| https://github.com/nodejs/node/pull/1965#ref-commit-9d2d6b1 |
|
| https://github.com/jbergstroem |
|
| https://github.com/orangemocha |
| build: don't run lint from test-ci | https://github.com/orangemocha/node/commit/9d2d6b1205c06d4c99af2f9dadf82d15afcf4e6d |
| 9d2d6b1 | https://github.com/orangemocha/node/commit/9d2d6b1205c06d4c99af2f9dadf82d15afcf4e6d |
| nodejs/node@8d8a26e | https://github.com/nodejs/node/commit/8d8a26e8f7b4e65191af80d94bccada2217cbbb2 |
| nodejs/node#1965 | https://github.com/nodejs/node/pull/1965 |
| #11 | https://github.com/orangemocha/node/pull/11 |
|
[Snyk] Fix for 1 vulnerabilities
aliscco/alisco-node#506
| https://github.com/aliscco/alisco-node/pull/506 |
|
[Snyk] Fix for 1 vulnerabilities
aliscco/alisco-node#508
| https://github.com/aliscco/alisco-node/pull/508 |
|
[Snyk] Fix for 1 vulnerabilities
aliscco/alisco-node#543
| https://github.com/aliscco/alisco-node/pull/543 |
|
[Snyk] Fix for 1 vulnerabilities
aliscco/alisco-node#574
| https://github.com/aliscco/alisco-node/pull/574 |
|
[Snyk] Fix for 4 vulnerabilities
leonardoadame/node#63
| https://github.com/leonardoadame/node/pull/63 |
|
[Snyk] Fix for 9 vulnerabilities
leonardoadame/node#128
| https://github.com/leonardoadame/node/pull/128 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1965 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/1965 |
|
| https://github.com/jbergstroem |
|
| https://github.com/thefourtheye |
|
| https://github.com/rvagg |
|
| https://github.com/cjihrig |
|
| https://github.com/evanlucas |
|
| https://github.com/brendanashworth |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |