René's URL Explorer Experiment


Title: deps: turn on std::string for ICU by srl295 · Pull Request #19624 · nodejs/node · GitHub

Open Graph Title: deps: turn on std::string for ICU by srl295 · Pull Request #19624 · nodejs/node

X Title: deps: turn on std::string for ICU by srl295 · Pull Request #19624 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: node and v8 did not call into std::string previously, so that access was shut off. this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 Check...

X Description: node and v8 did not call into std::string previously, so that access was shut off. this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 Check...

Opengraph URL: https://github.com/nodejs/node/pull/19624

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7bd4ec73-f229-809c-484c-bb9394c17ed4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8962:1C3C8A:203F016:28E0236:69919204
html-safe-nonceac91b06b65111d58dd1ad4d6b40cc558d7cc406fe73018d00daadbdeaef4f454
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTYyOjFDM0M4QToyMDNGMDE2OjI4RTAyMzY6Njk5MTkyMDQiLCJ2aXNpdG9yX2lkIjoiMjQ4NDk1MTU2MTA2ODk3NDU5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac89fe890a145e89e434e10c6e527f893b053c69841c7d5203a52db1c648a392e3
hovercard-subject-tagpull_request:177597048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19624/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1fba7e32c0d1f0bae9eb7f54c33ab39340b814ca2882b4064078db21fadf8d9b/nodejs/node/pull/19624
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1fba7e32c0d1f0bae9eb7f54c33ab39340b814ca2882b4064078db21fadf8d9b/nodejs/node/pull/19624
og:image:altnode and v8 did not call into std::string previously, so that access was shut off. this fixes compilation for ICU 58.2 (backlevel) but may be expressed in other versions also. Fixes: #19151 Check...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrl295
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19624#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19624
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19624
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19624
Reloadhttps://github.com/nodejs/node/pull/19624
Reloadhttps://github.com/nodejs/node/pull/19624
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19624
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
srl295https://github.com/srl295
nodejs:masterhttps://github.com/nodejs/node/tree/master
srl295:icu-fix-stdstringhttps://github.com/srl295/node/tree/icu-fix-stdstring
Conversationhttps://github.com/nodejs/node/pull/19624
Commits0 (0)https://github.com/nodejs/node/pull/19624/commits
Checkshttps://github.com/nodejs/node/pull/19624/checks
Files changedhttps://github.com/nodejs/node/pull/19624/files
deps: turn on std::string for ICUhttps://github.com/nodejs/node/pull/19624#top
srl295https://github.com/srl295
nodejs:masterhttps://github.com/nodejs/node/tree/master
srl295:icu-fix-stdstringhttps://github.com/srl295/node/tree/icu-fix-stdstring
https://github.com/srl295
srl295https://github.com/srl295
Mar 26, 2018https://github.com/nodejs/node/pull/19624#issue-308773297
Please reload this pagehttps://github.com/nodejs/node/pull/19624
#19151https://github.com/nodejs/node/issues/19151
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19624
https://github.com/srl295
srl295https://github.com/srl295
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
Mar 26, 2018https://github.com/nodejs/node/pull/19624#event-1542084798
https://github.com/srl295
srl295https://github.com/srl295
Mar 26, 2018https://github.com/nodejs/node/pull/19624#event-1542084799
https://github.com/srl295
srl295https://github.com/srl295
TimothyGuhttps://github.com/TimothyGu
March 26, 2018 23:47https://github.com/nodejs/node/pull/19624#event-1542084800
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Mar 26, 2018https://github.com/nodejs/node/pull/19624#event-1542084843
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 26, 2018 https://github.com/nodejs/node/pull/19624#pullrequestreview-107112642
View reviewed changes https://github.com/nodejs/node/pull/19624/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 27, 2018 https://github.com/nodejs/node/pull/19624#pullrequestreview-107115287
View reviewed changes https://github.com/nodejs/node/pull/19624/files
richardlauhttps://github.com/richardlau
https://github.com/nodejs/node/pull/19624#pullrequestreview-107115287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19624
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 27, 2018 https://github.com/nodejs/node/pull/19624#pullrequestreview-107156073
View reviewed changes https://github.com/nodejs/node/pull/19624/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 27, 2018 https://github.com/nodejs/node/pull/19624#pullrequestreview-107157069
View reviewed changes https://github.com/nodejs/node/pull/19624/files
https://github.com/srl295
srl295https://github.com/srl295
Mar 27, 2018https://github.com/nodejs/node/pull/19624#event-1543444546
https://github.com/srl295
srl295https://github.com/srl295
Mar 27, 2018https://github.com/nodejs/node/pull/19624#issuecomment-376557061
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/19624
icu4c 61.1 Homebrew/homebrew-core#25799 https://github.com/Homebrew/homebrew-core/pull/25799
deps: backport char16ptr.h to 57 #19658 https://github.com/nodejs/node/pull/19658
srl295https://github.com/srl295
Mar 28, 2018 https://github.com/nodejs/node/pull/19624#ref-commit-4de7821
https://github.com/srl295
deps: turn in std::string for ICUhttps://github.com/nodejs/node/commit/4de78219711dcfdc24290520b20dce1fff01e164
4de7821https://github.com/nodejs/node/commit/4de78219711dcfdc24290520b20dce1fff01e164
#19151https://github.com/nodejs/node/issues/19151
#19624https://github.com/nodejs/node/pull/19624
https://github.com/srl295
srl295https://github.com/srl295
Mar 28, 2018https://github.com/nodejs/node/pull/19624#event-1545876510
https://github.com/srl295
srl295https://github.com/srl295
force-pushedhttps://github.com/nodejs/node/compare/f632c6647463cef368c7c1cb8a71e82e325e12ac..4de78219711dcfdc24290520b20dce1fff01e164
f632c66https://github.com/nodejs/node/commit/f632c6647463cef368c7c1cb8a71e82e325e12ac
4de7821https://github.com/nodejs/node/commit/4de78219711dcfdc24290520b20dce1fff01e164
Compare https://github.com/nodejs/node/compare/f632c6647463cef368c7c1cb8a71e82e325e12ac..4de78219711dcfdc24290520b20dce1fff01e164
March 28, 2018 15:22https://github.com/nodejs/node/pull/19624#event-1545876512
https://github.com/srl295
srl295https://github.com/srl295
Mar 28, 2018https://github.com/nodejs/node/pull/19624#issuecomment-376927185
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/19624
https://github.com/srl295
srl295https://github.com/srl295
March 28, 2018 15:24https://github.com/nodejs/node/pull/19624#event-1545881480
targoshttps://github.com/targos
Apr 2, 2018 https://github.com/nodejs/node/pull/19624#ref-commit-97a92c4
https://github.com/srl295
https://github.com/targos
deps: turn in std::string for ICUhttps://github.com/nodejs/node/commit/97a92c4973d8144c959db6e6553fd8652ce4f1bf
97a92c4https://github.com/nodejs/node/commit/97a92c4973d8144c959db6e6553fd8652ce4f1bf
#19151https://github.com/nodejs/node/issues/19151
#19624https://github.com/nodejs/node/pull/19624
https://github.com/targos
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/19624#ref-pullrequest-311275671
v9.11.0 proposal #19799 https://github.com/nodejs/node/pull/19799
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
Aug 7, 2018https://github.com/nodejs/node/pull/19624#event-1775577825
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19624
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/19624/files/f632c6647463cef368c7c1cb8a71e82e325e12ac
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/19624/files/f632c6647463cef368c7c1cb8a71e82e325e12ac
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/19624/files/f632c6647463cef368c7c1cb8a71e82e325e12ac
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/19624/files/f632c6647463cef368c7c1cb8a71e82e325e12ac
https://github.com/srl295
srl295 https://github.com/srl295
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
deps: issues with v8 and prior ICUs https://github.com/nodejs/node/issues/19151
Please reload this pagehttps://github.com/nodejs/node/pull/19624
https://github.com/srl295
https://github.com/danbev
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com/richardlau
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.