René's URL Explorer Experiment


Title: src: general C++ cleanup in node_url.cc by addaleax · Pull Request #19598 · nodejs/node · GitHub

Open Graph Title: src: general C++ cleanup in node_url.cc by addaleax · Pull Request #19598 · nodejs/node

X Title: src: general C++ cleanup in node_url.cc by addaleax · Pull Request #19598 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Merge domain and opaque storage in URL parser: This just simplifies the code a bit, having multiple fields in an union with the same type is usually just overhead. Add move variant of URLHost::To...

X Description: Merge domain and opaque storage in URL parser: This just simplifies the code a bit, having multiple fields in an union with the same type is usually just overhead. Add move variant of URLHost::To...

Opengraph URL: https://github.com/nodejs/node/pull/19598

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0d4fe3d6-c370-9e6c-871d-e016f47e526e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB212:1F3B04:1A87D03:218C3CA:69917DCE
html-safe-nonce1a6cd9af9116fab9f453a5c6d546916e1bafe7ecd186428c9f813dce25510614
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjEyOjFGM0IwNDoxQTg3RDAzOjIxOEMzQ0E6Njk5MTdEQ0UiLCJ2aXNpdG9yX2lkIjoiNTkxMzkzODIxMTkyNzg1MDQ0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdcd011397160aaef7ecc3c2374e97768c8161982f80a072b420ae8c4b6ff7521
hovercard-subject-tagpull_request:177295853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19598/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03dd7d3dbec645d8022cf1ae6b1e7746f9ea6596edb704738631092e2357a42e/nodejs/node/pull/19598
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03dd7d3dbec645d8022cf1ae6b1e7746f9ea6596edb704738631092e2357a42e/nodejs/node/pull/19598
og:image:altMerge domain and opaque storage in URL parser: This just simplifies the code a bit, having multiple fields in an union with the same type is usually just overhead. Add move variant of URLHost::To...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19598#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19598
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19598
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19598
Reloadhttps://github.com/nodejs/node/pull/19598
Reloadhttps://github.com/nodejs/node/pull/19598
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19598
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:url-refactorhttps://github.com/addaleax/node/tree/url-refactor
Conversationhttps://github.com/nodejs/node/pull/19598
Commits2 (2)https://github.com/nodejs/node/pull/19598/commits
Checkshttps://github.com/nodejs/node/pull/19598/checks
Files changedhttps://github.com/nodejs/node/pull/19598/files
src: general C++ cleanup in node_url.cchttps://github.com/nodejs/node/pull/19598#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:url-refactorhttps://github.com/addaleax/node/tree/url-refactor
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 25, 2018https://github.com/nodejs/node/pull/19598#issue-308360095
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/addaleax
src: general C++ cleanup in node_url.cchttps://github.com/nodejs/node/pull/19598/commits/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf
23b5f74https://github.com/nodejs/node/pull/19598/commits/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 25, 2018https://github.com/nodejs/node/pull/19598#event-1539648568
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 25, 2018https://github.com/nodejs/node/pull/19598#issuecomment-375980336
https://ci.nodejs.org/job/node-test-commit/17164/https://ci.nodejs.org/job/node-test-commit/17164/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/142/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/142/
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018 https://github.com/nodejs/node/pull/19598#pullrequestreview-106736678
View reviewed changes https://github.com/nodejs/node/pull/19598/files/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf
TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/nodejs/node/pull/19598#pullrequestreview-106736678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19598
src/node_url.cchttps://github.com/nodejs/node/pull/19598/files/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176947018
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19598
addaleaxhttps://github.com/addaleax
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176947525
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
the spec definitionhttps://url.spec.whatwg.org/#host-representation
Please reload this pagehttps://github.com/nodejs/node/pull/19598
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176949741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19598
jasnellhttps://github.com/jasnell
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176952601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19598
src/node_url.cchttps://github.com/nodejs/node/pull/19598/files/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176947286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19598
addaleaxhttps://github.com/addaleax
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176947527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/19598
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018https://github.com/nodejs/node/pull/19598#discussion_r176949679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 25, 2018https://github.com/nodejs/node/pull/19598#issuecomment-375988120
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 25, 2018https://github.com/nodejs/node/pull/19598#event-1539689423
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018https://github.com/nodejs/node/pull/19598#issuecomment-375997175
Please reload this pagehttps://github.com/nodejs/node/pull/19598
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 25, 2018https://github.com/nodejs/node/pull/19598#issuecomment-375998456
https://user-images.githubusercontent.com/1538624/37879311-c14edd86-302b-11e8-9968-2df7aeb29fd9.png
https://user-images.githubusercontent.com/1538624/37879312-c48080b8-302b-11e8-8120-56d8f165e958.png
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 25, 2018 https://github.com/nodejs/node/pull/19598#pullrequestreview-106742220
View reviewed changes https://github.com/nodejs/node/pull/19598/files/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf
https://github.com/addaleax
[squash] inside_password_flag → password_token_seen_flaghttps://github.com/nodejs/node/pull/19598/commits/ee80e946db0aa006f0f2326473ae6618f8e545a3
ee80e94https://github.com/nodejs/node/pull/19598/commits/ee80e946db0aa006f0f2326473ae6618f8e545a3
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 26, 2018 https://github.com/nodejs/node/pull/19598#pullrequestreview-106789915
View reviewed changes https://github.com/nodejs/node/pull/19598/files/ee80e946db0aa006f0f2326473ae6618f8e545a3
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 29, 2018https://github.com/nodejs/node/pull/19598#event-1548822550
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 30, 2018https://github.com/nodejs/node/pull/19598#issuecomment-377515561
ae70e2bhttps://github.com/nodejs/node/commit/ae70e2bc34aca8b581f53eb49a27460ac1fc3f83
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 30, 2018https://github.com/nodejs/node/pull/19598#event-1549670205
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
March 30, 2018 12:36https://github.com/nodejs/node/pull/19598#event-1549670310
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 30, 2018https://github.com/nodejs/node/pull/19598#event-1549670424
addaleaxhttps://github.com/addaleax
Mar 30, 2018 https://github.com/nodejs/node/pull/19598#ref-commit-ae70e2b
https://github.com/addaleax
src: general C++ cleanup in node_url.cchttps://github.com/nodejs/node/commit/ae70e2bc34aca8b581f53eb49a27460ac1fc3f83
ae70e2bhttps://github.com/nodejs/node/commit/ae70e2bc34aca8b581f53eb49a27460ac1fc3f83
#19598https://github.com/nodejs/node/pull/19598
targoshttps://github.com/targos
Apr 2, 2018 https://github.com/nodejs/node/pull/19598#ref-commit-01e3190
https://github.com/addaleax
https://github.com/targos
src: general C++ cleanup in node_url.cchttps://github.com/nodejs/node/commit/01e31906e8dcce76899ac1c1535c218edb445098
01e3190https://github.com/nodejs/node/commit/01e31906e8dcce76899ac1c1535c218edb445098
#19598https://github.com/nodejs/node/pull/19598
https://github.com/targos
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/19598#ref-pullrequest-311275671
v9.11.0 proposal #19799 https://github.com/nodejs/node/pull/19799
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19598
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/19598/files/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/19598/files/23b5f74e8fb236f4c3be2e603041d4d559aaf5bf
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/19598/files/ee80e946db0aa006f0f2326473ae6618f8e545a3
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Please reload this pagehttps://github.com/nodejs/node/pull/19598
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com/danbev
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.