| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:37876108-f5c2-5272-3c32-62c8c6436579 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6B6:281D19:F1728D:1373400:69918B38 |
| html-safe-nonce | beddfb4a627362841c370c8beca008b43fb5c5ac8cdb36f73c41f73c95c7471f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkI2OjI4MUQxOTpGMTcyOEQ6MTM3MzQwMDo2OTkxOEIzOCIsInZpc2l0b3JfaWQiOiIyMTY0NzAzNzY3MDkzNjc2ODU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 867b5fcf0fec355500480efd8fa3e388f5795b572211468e2391869b95ac7f19 |
| hovercard-subject-tag | pull_request:176379144 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19502/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/970944ddab35855e1024806deb2502b7053c22ab7c4cdca03634d2dbc0f6ac7f/nodejs/node/pull/19502 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/970944ddab35855e1024806deb2502b7053c22ab7c4cdca03634d2dbc0f6ac7f/nodejs/node/pull/19502 |
| og:image:alt | Fixes: #19457
Checklist
make -j4 test (UNIX) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | XadillaX |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/19502#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19502 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19502 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/19502 |
| Reload | https://github.com/nodejs/node/pull/19502 |
| Reload | https://github.com/nodejs/node/pull/19502 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| XadillaX | https://github.com/XadillaX |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| XadillaX:19457 | https://github.com/XadillaX/node/tree/19457 |
| Conversation | https://github.com/nodejs/node/pull/19502 |
| Commits5 (5) | https://github.com/nodejs/node/pull/19502/commits |
| Checks | https://github.com/nodejs/node/pull/19502/checks |
| Files changed | https://github.com/nodejs/node/pull/19502/files |
| http: fix request when setHost is true | https://github.com/nodejs/node/pull/19502#top |
| XadillaX | https://github.com/XadillaX |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| XadillaX:19457 | https://github.com/XadillaX/node/tree/19457 |
|
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#issue-307115415 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| #19457 | https://github.com/nodejs/node/issues/19457 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
|
| https://github.com/XadillaX |
| http: fix request when setHost is true | https://github.com/nodejs/node/pull/19502/commits/867fee86cf65fbd31c3220643f902a9b8a9c2e14 |
| 867fee8 | https://github.com/nodejs/node/pull/19502/commits/867fee86cf65fbd31c3220643f902a9b8a9c2e14 |
| nodejs#19457 | https://github.com/nodejs/node/issues/19457 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#event-1532433036 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Mar 21, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-105633819 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/867fee86cf65fbd31c3220643f902a9b8a9c2e14 |
| test/parallel/test-https-host-headers.js | https://github.com/nodejs/node/pull/19502/files/867fee86cf65fbd31c3220643f902a9b8a9c2e14#diff-cef1608876bcc54a73db202e060119ff1d4f3b09ed0a0ba5d8e325df89cbe677 |
| lpinca | https://github.com/lpinca |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176008639 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Mar 21, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-105648439 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/867fee86cf65fbd31c3220643f902a9b8a9c2e14 |
| lib/_http_client.js | https://github.com/nodejs/node/pull/19502/files/867fee86cf65fbd31c3220643f902a9b8a9c2e14#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| benjamingr | https://github.com/benjamingr |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176021397 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| XadillaX | https://github.com/XadillaX |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176023502 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| benjamingr | https://github.com/benjamingr |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176024121 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| lpinca | https://github.com/lpinca |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176025226 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| XadillaX | https://github.com/XadillaX |
| Mar 24, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176910676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| lpinca | https://github.com/lpinca |
| Mar 24, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176910828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
|
| https://github.com/XadillaX |
| f | https://github.com/nodejs/node/pull/19502/commits/a308e56f88e3790516844224d004e33b89042208 |
| a308e56 | https://github.com/nodejs/node/pull/19502/commits/a308e56f88e3790516844224d004e33b89042208 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Mar 21, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-105745391 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-374959089 |
| https://ci.nodejs.org/job/node-test-pull-request/13811/ | https://ci.nodejs.org/job/node-test-pull-request/13811/ |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Mar 21, 2018 | https://github.com/nodejs/node/pull/19502#event-1533362923 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Mar 22, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-375321018 |
| https://nodejs.org/api/http.html#http_http_request_options_callback | https://nodejs.org/api/http.html#http_http_request_options_callback |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 23, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-106345368 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
|
Mar 23, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-106345619 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
|
Mar 24, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-106699833 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
| lib/_http_client.js | https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| XadillaX | https://github.com/XadillaX |
| Mar 24, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176910026 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
|
| https://github.com/XadillaX |
| doc | https://github.com/nodejs/node/pull/19502/commits/02c474fdbb6ae78fa8ce1b39da1e0b4e47090ca5 |
| 02c474f | https://github.com/nodejs/node/pull/19502/commits/02c474fdbb6ae78fa8ce1b39da1e0b4e47090ca5 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
| Mar 24, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-375893037 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Mar 24, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-106700460 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/02c474fdbb6ae78fa8ce1b39da1e0b4e47090ca5 |
| doc/api/http.md | https://github.com/nodejs/node/pull/19502/files/02c474fdbb6ae78fa8ce1b39da1e0b4e47090ca5#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641 |
| lpinca | https://github.com/lpinca |
| Mar 24, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176910602 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| XadillaX | https://github.com/XadillaX |
| March 24, 2018 22:27 | https://github.com/nodejs/node/pull/19502#commits-pushed-63dff00 |
|
| https://github.com/XadillaX |
| update | https://github.com/nodejs/node/pull/19502/commits/63dff0041f0d6de1718ad3db15c85e0e11101fcb |
| 63dff00 | https://github.com/nodejs/node/pull/19502/commits/63dff0041f0d6de1718ad3db15c85e0e11101fcb |
|
| https://github.com/XadillaX |
| update | https://github.com/nodejs/node/pull/19502/commits/e9035aebc981fa5bc800aaf5a1637823cc9e53d0 |
| e9035ae | https://github.com/nodejs/node/pull/19502/commits/e9035aebc981fa5bc800aaf5a1637823cc9e53d0 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Mar 25, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-106725029 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/e9035aebc981fa5bc800aaf5a1637823cc9e53d0 |
| lib/_http_client.js | https://github.com/nodejs/node/pull/19502/files/e9035aebc981fa5bc800aaf5a1637823cc9e53d0#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43 |
| tniessen | https://github.com/tniessen |
| Mar 25, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176935619 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| XadillaX | https://github.com/XadillaX |
| Mar 26, 2018 | https://github.com/nodejs/node/pull/19502#discussion_r176972082 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Mar 28, 2018
| https://github.com/nodejs/node/pull/19502#pullrequestreview-107545933 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/19502/files/e9035aebc981fa5bc800aaf5a1637823cc9e53d0 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Mar 28, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-377072053 |
| https://ci.nodejs.org/job/node-test-pull-request/13910/ | https://ci.nodejs.org/job/node-test-pull-request/13910/ |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/XadillaX |
| XadillaX | https://github.com/XadillaX |
| Mar 30, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-377509568 |
| https://ci.nodejs.org/job/node-test-pull-request/13941/ | https://ci.nodejs.org/job/node-test-pull-request/13941/ |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Apr 3, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-378423053 |
| b06f686 | https://github.com/nodejs/node/commit/b06f686f8878027ccbd08b36b546378ffc0addfd |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Apr 3, 2018 | https://github.com/nodejs/node/pull/19502#event-1555261663 |
| trivikr | https://github.com/trivikr |
|
Apr 3, 2018
| https://github.com/nodejs/node/pull/19502#ref-commit-b06f686 |
|
| https://github.com/XadillaX |
|
| https://github.com/trivikr |
| http: fix request when setHost is true | https://github.com/nodejs/node/commit/b06f686f8878027ccbd08b36b546378ffc0addfd |
| b06f686 | https://github.com/nodejs/node/commit/b06f686f8878027ccbd08b36b546378ffc0addfd |
| #19457 | https://github.com/nodejs/node/issues/19457 |
| #19502 | https://github.com/nodejs/node/pull/19502 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-378450321 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| Trott | https://github.com/Trott |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19502#ref-commit-b979dab |
|
| https://github.com/Trott |
| test: update test to comply with lint rule | https://github.com/Trott/io.js/commit/b979dab992063c26b9a464b07d91f774c6c17e2d |
| b979dab | https://github.com/Trott/io.js/commit/b979dab992063c26b9a464b07d91f774c6c17e2d |
| nodejs#19502 (comment) | https://github.com/nodejs/node/pull/19502#issuecomment-378450321 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19502#ref-pullrequest-311054177 |
|
test: update test to comply with lint rule
#19784
| https://github.com/nodejs/node/pull/19784 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-378451225 |
| #19784 | https://github.com/nodejs/node/pull/19784 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| Trott | https://github.com/Trott |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19502#ref-commit-8891072 |
|
| https://github.com/Trott |
| test: update test to comply with lint rule | https://github.com/Trott/io.js/commit/88910724c8ccfc55eaabc94496c82ea1a02fd741 |
| 8891072 | https://github.com/Trott/io.js/commit/88910724c8ccfc55eaabc94496c82ea1a02fd741 |
| nodejs#19502 (comment) | https://github.com/nodejs/node/pull/19502#issuecomment-378450321 |
| nodejs#19784 | https://github.com/nodejs/node/pull/19784 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-378466344 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19502#ref-commit-e1f44a6 |
|
| https://github.com/XadillaX |
|
| https://github.com/targos |
| http: fix request when setHost is true | https://github.com/nodejs/node/commit/e1f44a6366c40a5fdd4ad0a67805246e79553237 |
| e1f44a6 | https://github.com/nodejs/node/commit/e1f44a6366c40a5fdd4ad0a67805246e79553237 |
| #19457 | https://github.com/nodejs/node/issues/19457 |
| #19502 | https://github.com/nodejs/node/pull/19502 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19502#ref-commit-4df3377 |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| test: update test to comply with lint rule | https://github.com/nodejs/node/commit/4df3377856f0889f4c84615dd037e543bc2bd8e8 |
| 4df3377 | https://github.com/nodejs/node/commit/4df3377856f0889f4c84615dd037e543bc2bd8e8 |
| #19502 (comment) | https://github.com/nodejs/node/pull/19502#issuecomment-378450321 |
| #19784 | https://github.com/nodejs/node/pull/19784 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19502#ref-pullrequest-311275671 |
|
v9.11.0 proposal
#19799
| https://github.com/nodejs/node/pull/19799 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 13, 2018 | https://github.com/nodejs/node/pull/19502#issuecomment-381020894 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Apr 13, 2018 | https://github.com/nodejs/node/pull/19502#event-1572435233 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
lts-watch-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x |
| Sep 19, 2019 | https://github.com/nodejs/node/pull/19502#event-2648231317 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19502 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/19502/files/867fee86cf65fbd31c3220643f902a9b8a9c2e14 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/19502/files/e9035aebc981fa5bc800aaf5a1637823cc9e53d0 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/19502/files/e9035aebc981fa5bc800aaf5a1637823cc9e53d0 |
|
| https://github.com/hiroppy |
|
hiroppy
| https://github.com/hiroppy |
|
| https://github.com/nodejs/node/pull/19502/files/a308e56f88e3790516844224d004e33b89042208 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
[http_client] setHost: true should not prevent a default "Host" header
| https://github.com/nodejs/node/issues/19457 |
| Please reload this page | https://github.com/nodejs/node/pull/19502 |
|
| https://github.com/XadillaX |
|
| https://github.com/lpinca |
|
| https://github.com/trivikr |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/benjamingr |
|
| https://github.com/tniessen |
|
| https://github.com/hiroppy |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |