René's URL Explorer Experiment


Title: src: fix upcoming v8 deprecation warnings by SirR4T · Pull Request #19490 · nodejs/node · GitHub

Open Graph Title: src: fix upcoming v8 deprecation warnings by SirR4T · Pull Request #19490 · nodejs/node

X Title: src: fix upcoming v8 deprecation warnings by SirR4T · Pull Request #19490 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #18909 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Fixes: #18909 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/19490

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:56329c60-a05d-412f-7a8f-db96b1ecee97
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC09E:1501ED:1D96ED5:2592167:69919C3E
html-safe-noncee1f85d4e91ab574628b7c3b973fcb3b17588c3e48a226ce1fca1f2dd6b6cd772
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDlFOjE1MDFFRDoxRDk2RUQ1OjI1OTIxNjc6Njk5MTlDM0UiLCJ2aXNpdG9yX2lkIjoiMjE2Njk5OTk5NDA0OTA3NjI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2fb92774872c41205c7b48cca2536a29485e5ffd0955c03e72513d13dea743dd
hovercard-subject-tagpull_request:176276930
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19490/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3645c513e695ce3569a6dd1e74e00e5aaffd06db27eed9f5faf6b70ae39e0684/nodejs/node/pull/19490
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3645c513e695ce3569a6dd1e74e00e5aaffd06db27eed9f5faf6b70ae39e0684/nodejs/node/pull/19490
og:image:altFixes: #18909 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSirR4T
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19490#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19490
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19490
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19490
Reloadhttps://github.com/nodejs/node/pull/19490
Reloadhttps://github.com/nodejs/node/pull/19490
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19490
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:deprecationUseMaybehttps://github.com/SirR4T/node/tree/deprecationUseMaybe
Conversationhttps://github.com/nodejs/node/pull/19490
Commits2 (2)https://github.com/nodejs/node/pull/19490/commits
Checkshttps://github.com/nodejs/node/pull/19490/checks
Files changedhttps://github.com/nodejs/node/pull/19490/files
src: fix upcoming v8 deprecation warningshttps://github.com/nodejs/node/pull/19490#top
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:deprecationUseMaybehttps://github.com/SirR4T/node/tree/deprecationUseMaybe
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Mar 20, 2018https://github.com/nodejs/node/pull/19490#issue-306978774
#18909https://github.com/nodejs/node/issues/18909
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19490
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Mar 20, 2018https://github.com/nodejs/node/pull/19490#event-1531613458
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 23, 2018 https://github.com/nodejs/node/pull/19490#pullrequestreview-106346822
View reviewed changes https://github.com/nodejs/node/pull/19490/files
src/node.cchttps://github.com/nodejs/node/pull/19490/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
TimothyGuhttps://github.com/TimothyGu
Mar 23, 2018https://github.com/nodejs/node/pull/19490#discussion_r176610700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19490
src: fix upcoming v8 deprecation warningshttps://github.com/nodejs/node/pull/19490/commits/e0301a9e1a2e975e9b2cb5b6684cf311e850d76f
e0301a9https://github.com/nodejs/node/pull/19490/commits/e0301a9e1a2e975e9b2cb5b6684cf311e850d76f
nodejs#18909https://github.com/nodejs/node/issues/18909
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/84b76a4e5c00d5455356f4c9ade337ce0e57281c..e0301a9e1a2e975e9b2cb5b6684cf311e850d76f
84b76a4https://github.com/nodejs/node/commit/84b76a4e5c00d5455356f4c9ade337ce0e57281c
e0301a9https://github.com/nodejs/node/commit/e0301a9e1a2e975e9b2cb5b6684cf311e850d76f
Compare https://github.com/nodejs/node/compare/84b76a4e5c00d5455356f4c9ade337ce0e57281c..e0301a9e1a2e975e9b2cb5b6684cf311e850d76f
March 23, 2018 04:30https://github.com/nodejs/node/pull/19490#event-1537093668
Removing Nithttps://github.com/nodejs/node/pull/19490/commits/58709d9e2e799fe2076a816b0e5d17a32893268c
58709d9https://github.com/nodejs/node/pull/19490/commits/58709d9e2e799fe2076a816b0e5d17a32893268c
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 23, 2018https://github.com/nodejs/node/pull/19490#issuecomment-375550104
https://ci.nodejs.org/job/node-test-pull-request/13830/https://ci.nodejs.org/job/node-test-pull-request/13830/
Please reload this pagehttps://github.com/nodejs/node/pull/19490
https://github.com/danbev
danbevhttps://github.com/danbev
Mar 23, 2018 https://github.com/nodejs/node/pull/19490#pullrequestreview-106391321
View reviewed changes https://github.com/nodejs/node/pull/19490/files/58709d9e2e799fe2076a816b0e5d17a32893268c
https://github.com/targos
targoshttps://github.com/targos
Mar 23, 2018 https://github.com/nodejs/node/pull/19490#pullrequestreview-106399657
View reviewed changes https://github.com/nodejs/node/pull/19490/files/58709d9e2e799fe2076a816b0e5d17a32893268c
https://github.com/targos
targoshttps://github.com/targos
Mar 23, 2018https://github.com/nodejs/node/pull/19490#issuecomment-375571636
c6c957dhttps://github.com/nodejs/node/commit/c6c957d3cc3de335a0ccc25506d570b0a237a0ce
Please reload this pagehttps://github.com/nodejs/node/pull/19490
https://github.com/targos
targoshttps://github.com/targos
Mar 23, 2018https://github.com/nodejs/node/pull/19490#event-1537284862
targoshttps://github.com/targos
Mar 23, 2018 https://github.com/nodejs/node/pull/19490#ref-commit-c6c957d
https://github.com/targos
src: fix upcoming V8 deprecation warningshttps://github.com/nodejs/node/commit/c6c957d3cc3de335a0ccc25506d570b0a237a0ce
c6c957dhttps://github.com/nodejs/node/commit/c6c957d3cc3de335a0ccc25506d570b0a237a0ce
#19490https://github.com/nodejs/node/pull/19490
#18909https://github.com/nodejs/node/issues/18909
targoshttps://github.com/targos
Mar 30, 2018 https://github.com/nodejs/node/pull/19490#ref-commit-cae9ff2
https://github.com/targos
src: fix upcoming V8 deprecation warningshttps://github.com/nodejs/node/commit/cae9ff256be348101ff3655c4a420945970baa19
cae9ff2https://github.com/nodejs/node/commit/cae9ff256be348101ff3655c4a420945970baa19
#19490https://github.com/nodejs/node/pull/19490
#18909https://github.com/nodejs/node/issues/18909
https://github.com/targos
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/19490#ref-pullrequest-311275671
v9.11.0 proposal #19799 https://github.com/nodejs/node/pull/19799
blattersturmhttps://github.com/blattersturm
Nov 3, 2018 https://github.com/nodejs/node/pull/19490#ref-commit-af07964
https://github.com/blattersturm
src: fix upcoming V8 deprecation warningshttps://github.com/citizenfx/node/commit/af07964a9eaf5f7742b8d96a1c36a0f59b76d0ca
af07964https://github.com/citizenfx/node/commit/af07964a9eaf5f7742b8d96a1c36a0f59b76d0ca
nodejs#19490https://github.com/nodejs/node/pull/19490
nodejs#18909https://github.com/nodejs/node/issues/18909
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19490
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/19490/files/58709d9e2e799fe2076a816b0e5d17a32893268c
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/19490/files/58709d9e2e799fe2076a816b0e5d17a32893268c
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/19490/files/84b76a4e5c00d5455356f4c9ade337ce0e57281c
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
V8: upcoming deprecation warnings https://github.com/nodejs/node/issues/18909
Please reload this pagehttps://github.com/nodejs/node/pull/19490
https://github.com/SirR4T
https://github.com/TimothyGu
https://github.com/targos
https://github.com/danbev
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.