René's URL Explorer Experiment


Title: [v6.x backport] win, build: fix intl-none and without-intl options by poiru · Pull Request #19485 · nodejs/node · GitHub

Open Graph Title: [v6.x backport] win, build: fix intl-none and without-intl options by poiru · Pull Request #19485 · nodejs/node

X Title: [v6.x backport] win, build: fix intl-none and without-intl options by poiru · Pull Request #19485 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This backports #17614 and #18292. Checklist vcbuild test commit message follows commit guidelines

X Description: This backports #17614 and #18292. Checklist vcbuild test commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/19485

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f11de212-befe-867c-1487-16a4e14a1b39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBB4:16ACDA:1FCB514:28B0AC7:6991C377
html-safe-noncefff69c2e20adb501393d871ef213e3a7557ad1b6403ac584ab7e77d2eceb8ad7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkI0OjE2QUNEQToxRkNCNTE0OjI4QjBBQzc6Njk5MUMzNzciLCJ2aXNpdG9yX2lkIjoiMzc5NTcwNzIzMzk5MzYwNjAwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf125c3f9ee4d032aebf2b7ea277c8178dbca4aa3672e860ad446196b311b0378
hovercard-subject-tagpull_request:176259989
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19485/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c4bd863d1ca9da089a7f21574c4ae0cc82bd8309302594412c4bebb78571398/nodejs/node/pull/19485
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c4bd863d1ca9da089a7f21574c4ae0cc82bd8309302594412c4bebb78571398/nodejs/node/pull/19485
og:image:altThis backports #17614 and #18292. Checklist vcbuild test commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepoiru
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19485#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19485
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19485
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19485
Reloadhttps://github.com/nodejs/node/pull/19485
Reloadhttps://github.com/nodejs/node/pull/19485
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19485
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
poiruhttps://github.com/poiru
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
Conversationhttps://github.com/nodejs/node/pull/19485
Commits2 (2)https://github.com/nodejs/node/pull/19485/commits
Checkshttps://github.com/nodejs/node/pull/19485/checks
Files changedhttps://github.com/nodejs/node/pull/19485/files
[v6.x backport] win, build: fix intl-none and without-intl optionshttps://github.com/nodejs/node/pull/19485#top
poiruhttps://github.com/poiru
nodejs:v6.x-staginghttps://github.com/nodejs/node/tree/v6.x-staging
https://github.com/poiru
poiruhttps://github.com/poiru
Mar 20, 2018https://github.com/nodejs/node/pull/19485#issue-306956594
#17614https://github.com/nodejs/node/pull/17614
#18292https://github.com/nodejs/node/pull/18292
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19485
bzozhttps://github.com/bzoz
March 20, 2018 19:01https://github.com/nodejs/node/pull/19485#commits-pushed-caa4f85
https://github.com/bzoz
https://github.com/poiru
win, build: fix without-intl optionhttps://github.com/nodejs/node/pull/19485/commits/caa4f8501ee57245cb36ac0dfbbb3ec4d1c9f277
caa4f85https://github.com/nodejs/node/pull/19485/commits/caa4f8501ee57245cb36ac0dfbbb3ec4d1c9f277
#17614https://github.com/nodejs/node/pull/17614
https://github.com/poiru
win, build: fix intl-none optionhttps://github.com/nodejs/node/pull/19485/commits/0bd6b1de1445de785ab10abecb2d9bdb5ae58559
0bd6b1dhttps://github.com/nodejs/node/pull/19485/commits/0bd6b1de1445de785ab10abecb2d9bdb5ae58559
#17614https://github.com/nodejs/node/pull/17614
#17614https://github.com/nodejs/node/pull/17614
#18292https://github.com/nodejs/node/pull/18292
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Mar 20, 2018https://github.com/nodejs/node/pull/19485#event-1531469907
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2018https://github.com/nodejs/node/pull/19485#issuecomment-374805378
https://ci.nodejs.org/job/node-test-pull-request/13790/https://ci.nodejs.org/job/node-test-pull-request/13790/
Please reload this pagehttps://github.com/nodejs/node/pull/19485
https://github.com/bzoz
bzozhttps://github.com/bzoz
Mar 21, 2018 https://github.com/nodejs/node/pull/19485#pullrequestreview-105639995
View reviewed changes https://github.com/nodejs/node/pull/19485/files/0bd6b1de1445de785ab10abecb2d9bdb5ae58559
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2018 https://github.com/nodejs/node/pull/19485#ref-commit-ca4b4a9
https://github.com/bzoz
https://github.com/MylesBorins
win, build: fix without-intl optionhttps://github.com/nodejs/node/commit/ca4b4a91ad8f2bb4cf2755056bd45bd62c693850
ca4b4a9https://github.com/nodejs/node/commit/ca4b4a91ad8f2bb4cf2755056bd45bd62c693850
#19485https://github.com/nodejs/node/pull/19485
#17614https://github.com/nodejs/node/pull/17614
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2018 https://github.com/nodejs/node/pull/19485#ref-commit-331b4fd
https://github.com/poiru
https://github.com/MylesBorins
win, build: fix intl-none optionhttps://github.com/nodejs/node/commit/331b4fd8382a37ee253c9405bd1952e247adb0bb
331b4fdhttps://github.com/nodejs/node/commit/331b4fd8382a37ee253c9405bd1952e247adb0bb
#17614https://github.com/nodejs/node/pull/17614
#19485https://github.com/nodejs/node/pull/19485
#17614https://github.com/nodejs/node/pull/17614
#18292https://github.com/nodejs/node/pull/18292
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2018https://github.com/nodejs/node/pull/19485#issuecomment-374901033
fe477e4...331b4fdhttps://github.com/nodejs/node/compare/fe477e47b5cef35d885135b8922fa90c7649a22b...331b4fd8382a37ee253c9405bd1952e247adb0bb
Please reload this pagehttps://github.com/nodejs/node/pull/19485
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2018https://github.com/nodejs/node/pull/19485#event-1532934662
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2018 https://github.com/nodejs/node/pull/19485#ref-commit-a47fda4
https://github.com/bzoz
https://github.com/MylesBorins
win, build: fix without-intl optionhttps://github.com/nodejs/node/commit/a47fda4c3679bfb48a2d5137ddd51484b6eea1fa
a47fda4https://github.com/nodejs/node/commit/a47fda4c3679bfb48a2d5137ddd51484b6eea1fa
#19485https://github.com/nodejs/node/pull/19485
#17614https://github.com/nodejs/node/pull/17614
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2018 https://github.com/nodejs/node/pull/19485#ref-commit-d4d4cec
https://github.com/poiru
https://github.com/MylesBorins
win, build: fix intl-none optionhttps://github.com/nodejs/node/commit/d4d4cec6ad0545cd4c54d7d3be7dbce56a4f1ba0
d4d4cechttps://github.com/nodejs/node/commit/d4d4cec6ad0545cd4c54d7d3be7dbce56a4f1ba0
#17614https://github.com/nodejs/node/pull/17614
#19485https://github.com/nodejs/node/pull/19485
#17614https://github.com/nodejs/node/pull/17614
#18292https://github.com/nodejs/node/pull/18292
MylesBorinshttps://github.com/MylesBorins
Mar 30, 2018 https://github.com/nodejs/node/pull/19485#ref-commit-6ff763b
https://github.com/bzoz
https://github.com/MylesBorins
win, build: fix without-intl optionhttps://github.com/nodejs/node/commit/6ff763bd665a5fddbff0948bd6b4e91cbcec3216
6ff763bhttps://github.com/nodejs/node/commit/6ff763bd665a5fddbff0948bd6b4e91cbcec3216
#19485https://github.com/nodejs/node/pull/19485
#17614https://github.com/nodejs/node/pull/17614
MylesBorinshttps://github.com/MylesBorins
Mar 30, 2018 https://github.com/nodejs/node/pull/19485#ref-commit-a91b1b9
https://github.com/poiru
https://github.com/MylesBorins
win, build: fix intl-none optionhttps://github.com/nodejs/node/commit/a91b1b928ca7705e03f1002989677811c8098799
a91b1b9https://github.com/nodejs/node/commit/a91b1b928ca7705e03f1002989677811c8098799
#17614https://github.com/nodejs/node/pull/17614
#19485https://github.com/nodejs/node/pull/19485
#17614https://github.com/nodejs/node/pull/17614
#18292https://github.com/nodejs/node/pull/18292
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19485
https://github.com/bzoz
bzoz https://github.com/bzoz
https://github.com/nodejs/node/pull/19485/files/0bd6b1de1445de785ab10abecb2d9bdb5ae58559
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
windows https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows
Please reload this pagehttps://github.com/nodejs/node/pull/19485
https://github.com/poiru
https://github.com/MylesBorins
https://github.com/bzoz
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.