| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f01d5c3b-d46a-2f2a-2ae9-d2cf81046bbe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D18:12F068:1AA5AE9:21CDDC8:69917DC4 |
| html-safe-nonce | d7476bac4115a35b80b7e08438682839f3ac2b662eac08df16a1d54e4e0e25ea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDE4OjEyRjA2ODoxQUE1QUU5OjIxQ0REQzg6Njk5MTdEQzQiLCJ2aXNpdG9yX2lkIjoiNTcxODg3ODQyODE4NDI4MDUxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 45d7d72f7c4438ec5a14369fa48d5e86350d064a284611c90e02b4d0a708a13b |
| hovercard-subject-tag | pull_request:175286131 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19374/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/60e142369c0951459ee2ffe0acb981672f5f87a1eb5fd3aa8285fbd17c7fcae6/nodejs/node/pull/19374 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/60e142369c0951459ee2ffe0acb981672f5f87a1eb5fd3aa8285fbd17c7fcae6/nodejs/node/pull/19374 |
| og:image:alt | src: move internal loaders out of bootstrap_node.js
Moves the creation of process.binding(), process._linkedBinding()
internalBinding() and NativeModule into a separate file
lib/internal/bootstrap... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/19374#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19374 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19374 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/19374 |
| Reload | https://github.com/nodejs/node/pull/19374 |
| Reload | https://github.com/nodejs/node/pull/19374 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
711
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:v9.x-staging | https://github.com/nodejs/node/tree/v9.x-staging |
| joyeecheung:backport-refactors-to-v9.x | https://github.com/joyeecheung/node/tree/backport-refactors-to-v9.x |
| Conversation | https://github.com/nodejs/node/pull/19374 |
| Commits5 (5) | https://github.com/nodejs/node/pull/19374/commits |
| Checks | https://github.com/nodejs/node/pull/19374/checks |
| Files changed | https://github.com/nodejs/node/pull/19374/files |
| [9.x] backport 19112, 19177 (bootstrapper & loaders reafactor) | https://github.com/nodejs/node/pull/19374#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:v9.x-staging | https://github.com/nodejs/node/tree/v9.x-staging |
| joyeecheung:backport-refactors-to-v9.x | https://github.com/joyeecheung/node/tree/backport-refactors-to-v9.x |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 15, 2018 | https://github.com/nodejs/node/pull/19374#issue-305598929 |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
| #19112 | https://github.com/nodejs/node/pull/19112 |
| #19177 | https://github.com/nodejs/node/pull/19177 |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v9.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av9.x |
| Mar 15, 2018 | https://github.com/nodejs/node/pull/19374#event-1523565355 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/123623d5bc417b267ed7452069d7e4b0247cbb62..aa9976ceeec92ae2d411beb4eafb108c2aa04edd |
| 123623d | https://github.com/nodejs/node/commit/123623d5bc417b267ed7452069d7e4b0247cbb62 |
| aa9976c | https://github.com/nodejs/node/commit/aa9976ceeec92ae2d411beb4eafb108c2aa04edd |
|
Compare
| https://github.com/nodejs/node/compare/123623d5bc417b267ed7452069d7e4b0247cbb62..aa9976ceeec92ae2d411beb4eafb108c2aa04edd |
| March 15, 2018 16:01 | https://github.com/nodejs/node/pull/19374#event-1523664277 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/d457b9d767c8c4f450d87705a0ab476022ee2abf..03c321a713c7f8679838f0664316ce9738f4d99d |
| d457b9d | https://github.com/nodejs/node/commit/d457b9d767c8c4f450d87705a0ab476022ee2abf |
| 03c321a | https://github.com/nodejs/node/commit/03c321a713c7f8679838f0664316ce9738f4d99d |
|
Compare
| https://github.com/nodejs/node/compare/d457b9d767c8c4f450d87705a0ab476022ee2abf..03c321a713c7f8679838f0664316ce9738f4d99d |
| March 20, 2018 11:56 | https://github.com/nodejs/node/pull/19374#event-1530715887 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19374#ref-pullrequest-302829912 |
|
src: restructure modules and bootstrappers
#19177
| https://github.com/nodejs/node/pull/19177 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 24, 2018 | https://github.com/nodejs/node/pull/19374#issuecomment-375866871 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/305fe4c009577cefe13ad08d81de08e62dc8e440..4844a263cef49984c86908e2fb2bb2484eccb940 |
| 305fe4c | https://github.com/nodejs/node/commit/305fe4c009577cefe13ad08d81de08e62dc8e440 |
| 4844a26 | https://github.com/nodejs/node/commit/4844a263cef49984c86908e2fb2bb2484eccb940 |
|
Compare
| https://github.com/nodejs/node/compare/305fe4c009577cefe13ad08d81de08e62dc8e440..4844a263cef49984c86908e2fb2bb2484eccb940 |
| March 28, 2018 16:23 | https://github.com/nodejs/node/pull/19374#event-1546018439 |
| joyeecheung | https://github.com/joyeecheung |
| March 31, 2018 00:35 | https://github.com/nodejs/node/pull/19374#commits-pushed-ae516be |
|
| https://github.com/joyeecheung |
| src: move internal loaders out of bootstrap_node.js | https://github.com/nodejs/node/pull/19374/commits/ae516bed01dd061f286d450216987b9e5519c8cf |
| ae516be | https://github.com/nodejs/node/pull/19374/commits/ae516bed01dd061f286d450216987b9e5519c8cf |
| nodejs#19112 | https://github.com/nodejs/node/pull/19112 |
|
| https://github.com/joyeecheung |
| test: remove NODE_DEBUG in global module loading test | https://github.com/nodejs/node/pull/19374/commits/d65da3bff28643312aeea3e98c3afabc8b3b76e8 |
| d65da3b | https://github.com/nodejs/node/pull/19374/commits/d65da3bff28643312aeea3e98c3afabc8b3b76e8 |
| nodejs#19177 | https://github.com/nodejs/node/pull/19177 |
| nodejs#19112 | https://github.com/nodejs/node/pull/19112 |
|
| https://github.com/joyeecheung |
| src: put bootstrappers in lib/internal/bootstrap/ | https://github.com/nodejs/node/pull/19374/commits/3eb760763dccdc15050c555430b616d818e50809 |
| 3eb7607 | https://github.com/nodejs/node/pull/19374/commits/3eb760763dccdc15050c555430b616d818e50809 |
| nodejs#19177 | https://github.com/nodejs/node/pull/19177 |
| nodejs#19112 | https://github.com/nodejs/node/pull/19112 |
|
| https://github.com/joyeecheung |
| lib: restructure cjs and esm loaders | https://github.com/nodejs/node/pull/19374/commits/6be0bc5cb8b8ae41c797f9eb0da72e52c7af7bcd |
| 6be0bc5 | https://github.com/nodejs/node/pull/19374/commits/6be0bc5cb8b8ae41c797f9eb0da72e52c7af7bcd |
| nodejs#19177 | https://github.com/nodejs/node/pull/19177 |
| nodejs#19112 | https://github.com/nodejs/node/pull/19112 |
|
| https://github.com/joyeecheung |
| lib: add back lib/module.js redirection | https://github.com/nodejs/node/pull/19374/commits/f0d97225e05735dce9c3679afe25b1d0fc6065e1 |
| f0d9722 | https://github.com/nodejs/node/pull/19374/commits/f0d97225e05735dce9c3679afe25b1d0fc6065e1 |
| nodejs#19177 | https://github.com/nodejs/node/pull/19177 |
| nodejs#19112 | https://github.com/nodejs/node/pull/19112 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/aa9976ceeec92ae2d411beb4eafb108c2aa04edd..f0d97225e05735dce9c3679afe25b1d0fc6065e1 |
| aa9976c | https://github.com/nodejs/node/commit/aa9976ceeec92ae2d411beb4eafb108c2aa04edd |
| f0d9722 | https://github.com/nodejs/node/commit/f0d97225e05735dce9c3679afe25b1d0fc6065e1 |
|
Compare
| https://github.com/nodejs/node/compare/aa9976ceeec92ae2d411beb4eafb108c2aa04edd..f0d97225e05735dce9c3679afe25b1d0fc6065e1 |
| March 30, 2018 17:18 | https://github.com/nodejs/node/pull/19374#event-1550049844 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 30, 2018 | https://github.com/nodejs/node/pull/19374#issuecomment-377574613 |
| https://ci.nodejs.org/job/node-test-pull-request/13950/ | https://ci.nodejs.org/job/node-test-pull-request/13950/ |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19374#ref-commit-ff7a116 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: move internal loaders out of bootstrap_node.js | https://github.com/nodejs/node/commit/ff7a116ba3b4c3992aaec6212c79a7006784d91b |
| ff7a116 | https://github.com/nodejs/node/commit/ff7a116ba3b4c3992aaec6212c79a7006784d91b |
| #19374 | https://github.com/nodejs/node/pull/19374 |
| #19112 | https://github.com/nodejs/node/pull/19112 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19374#ref-commit-ebdcf91 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: put bootstrappers in lib/internal/bootstrap/ | https://github.com/nodejs/node/commit/ebdcf91dccea68c2ef589e317d23ab024795e885 |
| ebdcf91 | https://github.com/nodejs/node/commit/ebdcf91dccea68c2ef589e317d23ab024795e885 |
| #19374 | https://github.com/nodejs/node/pull/19374 |
| #19177 | https://github.com/nodejs/node/pull/19177 |
| #19112 | https://github.com/nodejs/node/pull/19112 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19374#ref-commit-83ebaf0 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| test: remove NODE_DEBUG in global module loading test | https://github.com/nodejs/node/commit/83ebaf08d9cd36bfbae0b3fbf7406736cfd72aef |
| 83ebaf0 | https://github.com/nodejs/node/commit/83ebaf08d9cd36bfbae0b3fbf7406736cfd72aef |
| #19374 | https://github.com/nodejs/node/pull/19374 |
| #19177 | https://github.com/nodejs/node/pull/19177 |
| #19112 | https://github.com/nodejs/node/pull/19112 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19374#ref-commit-45c477c |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| lib: restructure cjs and esm loaders | https://github.com/nodejs/node/commit/45c477c2e6e28d85fca7f0d7e4441501c45e6851 |
| 45c477c | https://github.com/nodejs/node/commit/45c477c2e6e28d85fca7f0d7e4441501c45e6851 |
| #19374 | https://github.com/nodejs/node/pull/19374 |
| #19177 | https://github.com/nodejs/node/pull/19177 |
| #19112 | https://github.com/nodejs/node/pull/19112 |
| targos | https://github.com/targos |
|
Apr 4, 2018
| https://github.com/nodejs/node/pull/19374#ref-commit-8e44011 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| lib: add back lib/module.js redirection | https://github.com/nodejs/node/commit/8e440115ecbe94a0e05fbd334ec9748e261da59b |
| 8e44011 | https://github.com/nodejs/node/commit/8e440115ecbe94a0e05fbd334ec9748e261da59b |
| #19374 | https://github.com/nodejs/node/pull/19374 |
| #19177 | https://github.com/nodejs/node/pull/19177 |
| #19112 | https://github.com/nodejs/node/pull/19112 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/19374#issuecomment-378617435 |
| 5e90fc6...8e44011 | https://github.com/nodejs/node/compare/5e90fc6a85f08e8e474cea3c5bfb5db1d8faf5fe...8e440115ecbe94a0e05fbd334ec9748e261da59b |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/19374#event-1556589153 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
May 2, 2018
| https://github.com/nodejs/node/pull/19374#ref-pullrequest-319112194 |
|
[9.x] Backport a lot of things
#20448
| https://github.com/nodejs/node/pull/20448 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19374 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/19374 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |