| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:70742a46-06a3-45c5-6f32-37f491c53db2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B6E6:161581:1E075AC:268258D:69927B54 |
| html-safe-nonce | 12a9e1af8d0f0ff8a7e2d31747b4cbcc00e2fb02baf9b2ee85b8b62362edc08d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkU2OjE2MTU4MToxRTA3NUFDOjI2ODI1OEQ6Njk5MjdCNTQiLCJ2aXNpdG9yX2lkIjoiMTc5ODM1MDM3MTA3NDI0MzQxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 631545135fc602e484acbe3aa969aa849989d01bded96f1216e57f0d184ae493 |
| hovercard-subject-tag | pull_request:173766352 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19230/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/31d19994fa96c7166903bf4421ca4ddfa7578b977c866701fc09fd2cb4450956/nodejs/node/pull/19230 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/31d19994fa96c7166903bf4421ca4ddfa7578b977c866701fc09fd2cb4450956/nodejs/node/pull/19230 |
| og:image:alt | This is a backport of all assert PRs to 9.x that are requested at the moment (as far as I know) plus one util PR. I felt this is much easier because as soon as a couple conflicts were resolved most... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BridgeAR |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/19230#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19230 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19230 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/19230 |
| Reload | https://github.com/nodejs/node/pull/19230 |
| Reload | https://github.com/nodejs/node/pull/19230 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/19230 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
716
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:v9.x-staging | https://github.com/nodejs/node/tree/v9.x-staging |
| BridgeAR:9.backport-assert-stuff | https://github.com/BridgeAR/node/tree/9.backport-assert-stuff |
| Conversation | https://github.com/nodejs/node/pull/19230 |
| Commits21 (21) | https://github.com/nodejs/node/pull/19230/commits |
| Checks | https://github.com/nodejs/node/pull/19230/checks |
| Files changed | https://github.com/nodejs/node/pull/19230/files |
| [9.x backport] assert & util PRs | https://github.com/nodejs/node/pull/19230#top |
| BridgeAR | https://github.com/BridgeAR |
| nodejs:v9.x-staging | https://github.com/nodejs/node/tree/v9.x-staging |
| BridgeAR:9.backport-assert-stuff | https://github.com/BridgeAR/node/tree/9.backport-assert-stuff |
|
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Mar 8, 2018 | https://github.com/nodejs/node/pull/19230#issue-303520519 |
| #17576 | https://github.com/nodejs/node/pull/17576 |
| #17002 | https://github.com/nodejs/node/pull/17002 |
| #17582 | https://github.com/nodejs/node/pull/17582 |
| #17703 | https://github.com/nodejs/node/pull/17703 |
| #17585 | https://github.com/nodejs/node/pull/17585 |
| #17584 | https://github.com/nodejs/node/pull/17584 |
| #17903 | https://github.com/nodejs/node/pull/17903 |
| #18029 | https://github.com/nodejs/node/pull/18029 |
| @bnoordhuis | https://github.com/bnoordhuis |
| #17615 | https://github.com/nodejs/node/pull/17615 |
| #18595 | https://github.com/nodejs/node/pull/18595 |
| #18248 | https://github.com/nodejs/node/pull/18248 |
| #18611 | https://github.com/nodejs/node/pull/18611 |
| 8e6e1c9 | https://github.com/nodejs/node/commit/8e6e1c9dcc83843aa17225b14ef91b92f337aebb |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/19230 |
| BridgeAR | https://github.com/BridgeAR |
| March 8, 2018 14:28 | https://github.com/nodejs/node/pull/19230#commits-pushed-c6aa5ff |
|
| https://github.com/BridgeAR |
| doc: improve assert documentation | https://github.com/nodejs/node/pull/19230/commits/c6aa5ff7e2b701039f803626af1c3263b0c2beb2 |
| c6aa5ff | https://github.com/nodejs/node/pull/19230/commits/c6aa5ff7e2b701039f803626af1c3263b0c2beb2 |
| nodejs#17002 | https://github.com/nodejs/node/pull/17002 |
|
| https://github.com/BridgeAR |
| assert: add strict functionality export | https://github.com/nodejs/node/pull/19230/commits/b3e4476c224b328c6c8e6a1a1c47a5ea526eb728 |
| b3e4476 | https://github.com/nodejs/node/pull/19230/commits/b3e4476c224b328c6c8e6a1a1c47a5ea526eb728 |
| nodejs#17002 | https://github.com/nodejs/node/pull/17002 |
|
| https://github.com/BridgeAR |
| assert: use object argument in innerFail | https://github.com/nodejs/node/pull/19230/commits/da780220c9136c7d988e18f59e210f459c18cdf8 |
| da78022 | https://github.com/nodejs/node/pull/19230/commits/da780220c9136c7d988e18f59e210f459c18cdf8 |
| nodejs#17582 | https://github.com/nodejs/node/pull/17582 |
|
| https://github.com/BridgeAR |
| assert: fix throws and doesNotThrow stack frames | https://github.com/nodejs/node/pull/19230/commits/9664cc825a923786db19aff9effbfad59cbc5ec6 |
| 9664cc8 | https://github.com/nodejs/node/pull/19230/commits/9664cc825a923786db19aff9effbfad59cbc5ec6 |
| nodejs#17703 | https://github.com/nodejs/node/pull/17703 |
|
| https://github.com/BridgeAR |
| test: refactor common.expectsError | https://github.com/nodejs/node/pull/19230/commits/0ed963bf891bf3651bff4947741be65588e84965 |
| 0ed963b | https://github.com/nodejs/node/pull/19230/commits/0ed963bf891bf3651bff4947741be65588e84965 |
| nodejs#17703 | https://github.com/nodejs/node/pull/17703 |
|
| https://github.com/BridgeAR |
| assert: improve assert.throws | https://github.com/nodejs/node/pull/19230/commits/cc52decfd22cfba59248572c1779eb50b7b54d61 |
| cc52dec | https://github.com/nodejs/node/pull/19230/commits/cc52decfd22cfba59248572c1779eb50b7b54d61 |
| nodejs#17585 | https://github.com/nodejs/node/pull/17585 |
|
| https://github.com/BridgeAR |
| doc: improve .throws RegExp info | https://github.com/nodejs/node/pull/19230/commits/f38be4193ee20a20cbe6ed29e5c7713d92e9e970 |
| f38be41 | https://github.com/nodejs/node/pull/19230/commits/f38be4193ee20a20cbe6ed29e5c7713d92e9e970 |
| nodejs#17585 | https://github.com/nodejs/node/pull/17585 |
|
| https://github.com/BridgeAR |
| assert: .throws accept objects | https://github.com/nodejs/node/pull/19230/commits/7f558d55db79b352e3294b130621f56f23c15b63 |
| 7f558d5 | https://github.com/nodejs/node/pull/19230/commits/7f558d55db79b352e3294b130621f56f23c15b63 |
| nodejs#17584 | https://github.com/nodejs/node/pull/17584 |
| nodejs#17557 | https://github.com/nodejs/node/pull/17557 |
|
| https://github.com/BridgeAR |
| assert: fix strict regression | https://github.com/nodejs/node/pull/19230/commits/fe9f098df2b877a06dcf587dca5092997e48da25 |
| fe9f098 | https://github.com/nodejs/node/pull/19230/commits/fe9f098df2b877a06dcf587dca5092997e48da25 |
| nodejs#17582 | https://github.com/nodejs/node/pull/17582 |
| nodejs#17903 | https://github.com/nodejs/node/pull/17903 |
| nodejs#17582 | https://github.com/nodejs/node/pull/17582 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/BridgeAR |
| lib: handle throw undefined in assert.throws() | https://github.com/nodejs/node/pull/19230/commits/49dc778ae0d6ece0f575b0a14b9f5a26d8427115 |
| 49dc778 | https://github.com/nodejs/node/pull/19230/commits/49dc778ae0d6ece0f575b0a14b9f5a26d8427115 |
| nodejs#18029 | https://github.com/nodejs/node/pull/18029 |
| nodejs#18027 | https://github.com/nodejs/node/issues/18027 |
|
| https://github.com/BridgeAR |
| util: fix custom inspect description | https://github.com/nodejs/node/pull/19230/commits/5d8855739d8cc150c7163993773920acadd60055 |
| 5d88557 | https://github.com/nodejs/node/pull/19230/commits/5d8855739d8cc150c7163993773920acadd60055 |
| nodejs#17576 | https://github.com/nodejs/node/pull/17576 |
|
| https://github.com/BridgeAR |
| util: rename util.inspect argument | https://github.com/nodejs/node/pull/19230/commits/f77f91d6f93857e991ff92f679c38886887f4f1d |
| f77f91d | https://github.com/nodejs/node/pull/19230/commits/f77f91d6f93857e991ff92f679c38886887f4f1d |
| nodejs#17576 | https://github.com/nodejs/node/pull/17576 |
|
| https://github.com/BridgeAR |
| util: add util.inspect compact option | https://github.com/nodejs/node/pull/19230/commits/fb85597aa4efdadf7bd94c67475875e7ac1f942e |
| fb85597 | https://github.com/nodejs/node/pull/19230/commits/fb85597aa4efdadf7bd94c67475875e7ac1f942e |
| nodejs#17576 | https://github.com/nodejs/node/pull/17576 |
|
| https://github.com/BridgeAR |
| assert: improve error messages | https://github.com/nodejs/node/pull/19230/commits/70ac31896bda9f47225ec7d029c09b0fc3915879 |
| 70ac318 | https://github.com/nodejs/node/pull/19230/commits/70ac31896bda9f47225ec7d029c09b0fc3915879 |
| nodejs#17615 | https://github.com/nodejs/node/pull/17615 |
|
| https://github.com/BridgeAR |
| tty: add getColorDepth function | https://github.com/nodejs/node/pull/19230/commits/fae00e37cd327894d23b96f6d7c4ac330ae8793b |
| fae00e3 | https://github.com/nodejs/node/pull/19230/commits/fae00e37cd327894d23b96f6d7c4ac330ae8793b |
| nodejs#17615 | https://github.com/nodejs/node/pull/17615 |
|
| https://github.com/BridgeAR |
| tty: refactor to es6 | https://github.com/nodejs/node/pull/19230/commits/073cf692be409891f6fee07dfcca7448acbffdbf |
| 073cf69 | https://github.com/nodejs/node/pull/19230/commits/073cf692be409891f6fee07dfcca7448acbffdbf |
| nodejs#17615 | https://github.com/nodejs/node/pull/17615 |
|
| https://github.com/BridgeAR |
| assert: use destructuring for errors | https://github.com/nodejs/node/pull/19230/commits/4fbed718e1a4c51274b4a6e29c47f7ecc2783ce6 |
| 4fbed71 | https://github.com/nodejs/node/pull/19230/commits/4fbed718e1a4c51274b4a6e29c47f7ecc2783ce6 |
| nodejs#18247 | https://github.com/nodejs/node/pull/18247 |
|
| https://github.com/BridgeAR |
| assert: fix throws trace | https://github.com/nodejs/node/pull/19230/commits/6694f485eab898eff20347cf77ef9ee95ecc88f4 |
| 6694f48 | https://github.com/nodejs/node/pull/19230/commits/6694f485eab898eff20347cf77ef9ee95ecc88f4 |
| nodejs#18595 | https://github.com/nodejs/node/pull/18595 |
|
| https://github.com/BridgeAR |
| doc: document asserts Weak(Map|Set) behavior | https://github.com/nodejs/node/pull/19230/commits/1ce2898d951c5754c319f6128a6382891b80a821 |
| 1ce2898 | https://github.com/nodejs/node/pull/19230/commits/1ce2898d951c5754c319f6128a6382891b80a821 |
| nodejs#18248 | https://github.com/nodejs/node/pull/18248 |
| nodejs#18228 | https://github.com/nodejs/node/pull/18228 |
| nodejs#18228 | https://github.com/nodejs/node/pull/18228 |
|
| https://github.com/BridgeAR |
| assert: fix infinite loop | https://github.com/nodejs/node/pull/19230/commits/ca8a59144eaf7dca02e7c0aee95c10320200c401 |
| ca8a591 | https://github.com/nodejs/node/pull/19230/commits/ca8a59144eaf7dca02e7c0aee95c10320200c401 |
| nodejs#18611 | https://github.com/nodejs/node/pull/18611 |
|
| https://github.com/BridgeAR |
| assert: show proper differences | https://github.com/nodejs/node/pull/19230/commits/254f8881b52a3e088e80fcbe05ef896c2ba8db56 |
| 254f888 | https://github.com/nodejs/node/pull/19230/commits/254f8881b52a3e088e80fcbe05ef896c2ba8db56 |
| nodejs#18611 | https://github.com/nodejs/node/pull/18611 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
tty
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
|
v9.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av9.x |
| Mar 8, 2018 | https://github.com/nodejs/node/pull/19230#event-1511372902 |
|
util: add util.inspect compact option
#17576
| https://github.com/nodejs/node/pull/17576 |
|
assert: add strict functionality export
#17002
| https://github.com/nodejs/node/pull/17002 |
|
assert: use object argument in innerFail
#17582
| https://github.com/nodejs/node/pull/17582 |
|
assert: fix .throws and .doesNotThrow stack frames
#17703
| https://github.com/nodejs/node/pull/17703 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 15, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-240924e |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| doc: document asserts Weak(Map|Set) behavior | https://github.com/nodejs/node/commit/240924e7fa4c55774a61d0a42e48ce8dcf168904 |
| 240924e | https://github.com/nodejs/node/commit/240924e7fa4c55774a61d0a42e48ce8dcf168904 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18248 | https://github.com/nodejs/node/pull/18248 |
| #18228 | https://github.com/nodejs/node/pull/18228 |
| #18228 | https://github.com/nodejs/node/pull/18228 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 15, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-4ca0fc4 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: fix infinite loop | https://github.com/nodejs/node/commit/4ca0fc4f0621dbcef59cffffc0d99c3d06135be7 |
| 4ca0fc4 | https://github.com/nodejs/node/commit/4ca0fc4f0621dbcef59cffffc0d99c3d06135be7 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18611 | https://github.com/nodejs/node/pull/18611 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 15, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-61baaba |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: show proper differences | https://github.com/nodejs/node/commit/61baaba4e4f52ab7ebf8792228b6c92e15ae501e |
| 61baaba | https://github.com/nodejs/node/commit/61baaba4e4f52ab7ebf8792228b6c92e15ae501e |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18611 | https://github.com/nodejs/node/pull/18611 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 20, 2018 | https://github.com/nodejs/node/pull/19230#issuecomment-374566218 |
| 16ab3b5...bae5de1 | https://github.com/nodejs/node/compare/16ab3b54d1c1d381b84f946cf60d80c1a8a2d094...bae5de1949b8fed3b6f0653e7c1e9d860666e5af |
| Please reload this page | https://github.com/nodejs/node/pull/19230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 20, 2018 | https://github.com/nodejs/node/pull/19230#event-1530680172 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-bae5de1 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: add strict functionality export | https://github.com/nodejs/node/commit/bae5de1949b8fed3b6f0653e7c1e9d860666e5af |
| bae5de1 | https://github.com/nodejs/node/commit/bae5de1949b8fed3b6f0653e7c1e9d860666e5af |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17002 | https://github.com/nodejs/node/pull/17002 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-db73d1c |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: use object argument in innerFail | https://github.com/nodejs/node/commit/db73d1c13bd65ceb1293353e4fb733d0f3f81460 |
| db73d1c | https://github.com/nodejs/node/commit/db73d1c13bd65ceb1293353e4fb733d0f3f81460 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17582 | https://github.com/nodejs/node/pull/17582 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-24aeca7 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: fix throws and doesNotThrow stack frames | https://github.com/nodejs/node/commit/24aeca7dd5e1a1236001098922927d00e74a5211 |
| 24aeca7 | https://github.com/nodejs/node/commit/24aeca7dd5e1a1236001098922927d00e74a5211 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17703 | https://github.com/nodejs/node/pull/17703 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-1e5c7e3 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| test: refactor common.expectsError | https://github.com/nodejs/node/commit/1e5c7e3e4732bde06a471f4b4d775467f9d39e24 |
| 1e5c7e3 | https://github.com/nodejs/node/commit/1e5c7e3e4732bde06a471f4b4d775467f9d39e24 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17703 | https://github.com/nodejs/node/pull/17703 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-612ba1a |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: improve assert.throws | https://github.com/nodejs/node/commit/612ba1a3f02160e784a0753080b6e10f8b5b78fe |
| 612ba1a | https://github.com/nodejs/node/commit/612ba1a3f02160e784a0753080b6e10f8b5b78fe |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17585 | https://github.com/nodejs/node/pull/17585 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-7457093 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| doc: improve .throws RegExp info | https://github.com/nodejs/node/commit/745709396c04d1d12bfc1c2a1c3e7b21bab8911d |
| 7457093 | https://github.com/nodejs/node/commit/745709396c04d1d12bfc1c2a1c3e7b21bab8911d |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17585 | https://github.com/nodejs/node/pull/17585 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-ebd60fa |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: .throws accept objects | https://github.com/nodejs/node/commit/ebd60fa505c5c4b5606064fa25dd17c687095bc5 |
| ebd60fa | https://github.com/nodejs/node/commit/ebd60fa505c5c4b5606064fa25dd17c687095bc5 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17584 | https://github.com/nodejs/node/pull/17584 |
| #17557 | https://github.com/nodejs/node/pull/17557 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-f96ea47 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: fix strict regression | https://github.com/nodejs/node/commit/f96ea47cf50ffdad50dbc70d7d4302f2e2cd8df1 |
| f96ea47 | https://github.com/nodejs/node/commit/f96ea47cf50ffdad50dbc70d7d4302f2e2cd8df1 |
| #17582 | https://github.com/nodejs/node/pull/17582 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17903 | https://github.com/nodejs/node/pull/17903 |
| #17582 | https://github.com/nodejs/node/pull/17582 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-b35eabb |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| lib: handle throw undefined in assert.throws() | https://github.com/nodejs/node/commit/b35eabb83771aab59dc9fdff33df8a06d98598c3 |
| b35eabb | https://github.com/nodejs/node/commit/b35eabb83771aab59dc9fdff33df8a06d98598c3 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18029 | https://github.com/nodejs/node/pull/18029 |
| #18027 | https://github.com/nodejs/node/issues/18027 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-fd4c05a |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| util: fix custom inspect description | https://github.com/nodejs/node/commit/fd4c05ab56fb40f4f855b76dca66f5c488207c68 |
| fd4c05a | https://github.com/nodejs/node/commit/fd4c05ab56fb40f4f855b76dca66f5c488207c68 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17576 | https://github.com/nodejs/node/pull/17576 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-ce3a5af |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| util: rename util.inspect argument | https://github.com/nodejs/node/commit/ce3a5af69f81893d53cf68a465eea7e6e19efcf9 |
| ce3a5af | https://github.com/nodejs/node/commit/ce3a5af69f81893d53cf68a465eea7e6e19efcf9 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17576 | https://github.com/nodejs/node/pull/17576 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-c18ac52 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| util: add util.inspect compact option | https://github.com/nodejs/node/commit/c18ac52970b116b7d17ab7ff842e9ab5f60881f5 |
| c18ac52 | https://github.com/nodejs/node/commit/c18ac52970b116b7d17ab7ff842e9ab5f60881f5 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17576 | https://github.com/nodejs/node/pull/17576 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-5aa3a2d |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: improve error messages | https://github.com/nodejs/node/commit/5aa3a2d172efb5cdca07ba6f0f2b8b054ced97ea |
| 5aa3a2d | https://github.com/nodejs/node/commit/5aa3a2d172efb5cdca07ba6f0f2b8b054ced97ea |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17615 | https://github.com/nodejs/node/pull/17615 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-ead727c |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| tty: add getColorDepth function | https://github.com/nodejs/node/commit/ead727c274a5545af70bbca6b1b887c7055660fe |
| ead727c | https://github.com/nodejs/node/commit/ead727c274a5545af70bbca6b1b887c7055660fe |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17615 | https://github.com/nodejs/node/pull/17615 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-74f0d1a |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| tty: refactor to es6 | https://github.com/nodejs/node/commit/74f0d1aa6059fe019e382affa50f7ae409758d1a |
| 74f0d1a | https://github.com/nodejs/node/commit/74f0d1aa6059fe019e382affa50f7ae409758d1a |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #17615 | https://github.com/nodejs/node/pull/17615 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-d3c2534 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: use destructuring for errors | https://github.com/nodejs/node/commit/d3c2534bbeb12b813cecdd543e9da04dc9fb70d9 |
| d3c2534 | https://github.com/nodejs/node/commit/d3c2534bbeb12b813cecdd543e9da04dc9fb70d9 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18247 | https://github.com/nodejs/node/pull/18247 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-e9ac468 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: fix throws trace | https://github.com/nodejs/node/commit/e9ac468146a997f8a0d00fd1042d6de52e4afa42 |
| e9ac468 | https://github.com/nodejs/node/commit/e9ac468146a997f8a0d00fd1042d6de52e4afa42 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18595 | https://github.com/nodejs/node/pull/18595 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-968b867 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| doc: document asserts Weak(Map|Set) behavior | https://github.com/nodejs/node/commit/968b867bf2357d214ee0bbd43911564955228056 |
| 968b867 | https://github.com/nodejs/node/commit/968b867bf2357d214ee0bbd43911564955228056 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18248 | https://github.com/nodejs/node/pull/18248 |
| #18228 | https://github.com/nodejs/node/pull/18228 |
| #18228 | https://github.com/nodejs/node/pull/18228 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-9abbb6b |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: fix infinite loop | https://github.com/nodejs/node/commit/9abbb6b857d4f85a291342a9ae088105fca85782 |
| 9abbb6b | https://github.com/nodejs/node/commit/9abbb6b857d4f85a291342a9ae088105fca85782 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18611 | https://github.com/nodejs/node/pull/18611 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 20, 2018
| https://github.com/nodejs/node/pull/19230#ref-commit-5e6b42e |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
| assert: show proper differences | https://github.com/nodejs/node/commit/5e6b42ec9cc8a8b2b2903db482ab89cb8abf4862 |
| 5e6b42e | https://github.com/nodejs/node/commit/5e6b42ec9cc8a8b2b2903db482ab89cb8abf4862 |
| #19230 | https://github.com/nodejs/node/pull/19230 |
| #18611 | https://github.com/nodejs/node/pull/18611 |
| https://github.com/bzoz |
| bzoz | https://github.com/bzoz |
|
Mar 28, 2018
| https://github.com/nodejs/node/pull/19230#ref-pullrequest-293208782 |
|
test: fix test-tty-get-color-depth
#18478
| https://github.com/nodejs/node/pull/18478 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 31, 2018 | https://github.com/nodejs/node/pull/19230#issuecomment-409320596 |
| @BridgeAR | https://github.com/BridgeAR |
| Please reload this page | https://github.com/nodejs/node/pull/19230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x |
| Aug 7, 2018 | https://github.com/nodejs/node/pull/19230#event-1775876010 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 7, 2018 | https://github.com/nodejs/node/pull/19230#issuecomment-411138315 |
| #18478 | https://github.com/nodejs/node/pull/18478 |
| Please reload this page | https://github.com/nodejs/node/pull/19230 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| April 1, 2019 23:39 | https://github.com/nodejs/node/pull/19230#event-2244909929 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19230 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/19230/files/254f8881b52a3e088e80fcbe05ef896c2ba8db56 |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
tty
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atty |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/19230 |
|
| https://github.com/BridgeAR |
|
| https://github.com/MylesBorins |
|
| https://github.com/mcollina |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bnoordhuis |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |