René's URL Explorer Experiment


Title: assert: do not use EOL in ERR_ASSERTION messages by joyeecheung · Pull Request #19221 · nodejs/node · GitHub

Open Graph Title: assert: do not use EOL in ERR_ASSERTION messages by joyeecheung · Pull Request #19221 · nodejs/node

X Title: assert: do not use EOL in ERR_ASSERTION messages by joyeecheung · Pull Request #19221 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: On Windows if an error is thrown from a script that uses \n to break lines - which is very common in the JavaScript ecosystem, and is the case in our own code base - then the error messages would c...

X Description: On Windows if an error is thrown from a script that uses \n to break lines - which is very common in the JavaScript ecosystem, and is the case in our own code base - then the error messages would c...

Opengraph URL: https://github.com/nodejs/node/pull/19221

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1e6672fc-e165-af7d-626f-06445ea3af30
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC23A:12E2F2:D1B25:10BABD:699217D9
html-safe-nonce40052cfc5e7606cb2c87a5e3bd10db0666ba213d530cf3175b708d7d2a45226b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjNBOjEyRTJGMjpEMUIyNToxMEJBQkQ6Njk5MjE3RDkiLCJ2aXNpdG9yX2lkIjoiNTQxNTIyODAyNDIyMzMwNzczNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace62066aa18ecae5617eb443e76e9e329f51bc76ee71802bcd45ae6526e8faac7
hovercard-subject-tagpull_request:173667857
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19221/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ae769fbcdc9c6877ee59e3c2c63e55acd5e7d89eebdfa4357530e5f31c8d0fbd/nodejs/node/pull/19221
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ae769fbcdc9c6877ee59e3c2c63e55acd5e7d89eebdfa4357530e5f31c8d0fbd/nodejs/node/pull/19221
og:image:altOn Windows if an error is thrown from a script that uses \n to break lines - which is very common in the JavaScript ecosystem, and is the case in our own code base - then the error messages would c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19221#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19221
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19221
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19221
Reloadhttps://github.com/nodejs/node/pull/19221
Reloadhttps://github.com/nodejs/node/pull/19221
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19221
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:dont-eol-in-errhttps://github.com/joyeecheung/node/tree/dont-eol-in-err
Conversationhttps://github.com/nodejs/node/pull/19221
Commits1 (1)https://github.com/nodejs/node/pull/19221/commits
Checkshttps://github.com/nodejs/node/pull/19221/checks
Files changedhttps://github.com/nodejs/node/pull/19221/files
assert: do not use EOL in ERR_ASSERTION messageshttps://github.com/nodejs/node/pull/19221#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:dont-eol-in-errhttps://github.com/joyeecheung/node/tree/dont-eol-in-err
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issue-303387501
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joyeecheung
assert: do not use EOL in ERR_ASSERTION messageshttps://github.com/nodejs/node/pull/19221/commits/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
25a18afhttps://github.com/nodejs/node/pull/19221/commits/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
Mar 8, 2018https://github.com/nodejs/node/pull/19221#event-1510585968
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371409218
Please reload this pagehttps://github.com/nodejs/node/pull/19221
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371409385
https://ci.nodejs.org/job/node-test-pull-request/13582/https://ci.nodejs.org/job/node-test-pull-request/13582/
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371429356
#18967https://github.com/nodejs/node/issues/18967
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371430747
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 8, 2018 https://github.com/nodejs/node/pull/19221#pullrequestreview-102257382
View reviewed changes https://github.com/nodejs/node/pull/19221/files/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Mar 8, 2018https://github.com/nodejs/node/pull/19221#event-1510873983
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371452209
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Mar 8, 2018https://github.com/nodejs/node/pull/19221#event-1510874966
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371454502
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 8, 2018https://github.com/nodejs/node/pull/19221#issuecomment-371523602
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 8, 2018 https://github.com/nodejs/node/pull/19221#pullrequestreview-102375540
View reviewed changes https://github.com/nodejs/node/pull/19221/files/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Mar 14, 2018https://github.com/nodejs/node/pull/19221#event-1521512981
https://github.com/daynin
dayninhttps://github.com/daynin
Mar 14, 2018 https://github.com/nodejs/node/pull/19221#pullrequestreview-103920712
View reviewed changes https://github.com/nodejs/node/pull/19221/files/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 14, 2018 https://github.com/nodejs/node/pull/19221#ref-issue-305269874
Use git config core.autocrlf false on windows machines nodejs/build#1184 https://github.com/nodejs/build/issues/1184
https://github.com/MSLaguana
MSLaguanahttps://github.com/MSLaguana
Mar 14, 2018https://github.com/nodejs/node/pull/19221#issuecomment-373194269
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 14, 2018https://github.com/nodejs/node/pull/19221#issuecomment-373195079
@MSLaguanahttps://github.com/MSLaguana
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Mar 20, 2018https://github.com/nodejs/node/pull/19221#issuecomment-374643989
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Apr 4, 2018 https://github.com/nodejs/node/pull/19221#ref-pullrequest-311270110
test: improve common.expectsError #19797 https://github.com/nodejs/node/pull/19797
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 15, 2018 https://github.com/nodejs/node/pull/19221#ref-pullrequest-323363384
assert: fix EOL issue in messages on Windows #20754 https://github.com/nodejs/node/pull/20754
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/19221#issuecomment-390219795
#20754https://github.com/nodejs/node/pull/20754
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/19221#event-1634371655
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19221
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/19221/files/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/19221/files/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
https://github.com/daynin
daynin https://github.com/daynin
https://github.com/nodejs/node/pull/19221/files/25a18afa82ce48d91a63e7dc7cc319c23e28f1fa
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/19221
https://github.com/joyeecheung
https://github.com/vsemozhetbyt
https://github.com/BridgeAR
https://github.com/MSLaguana
https://github.com/joaocgreis
https://github.com/jasnell
https://github.com/daynin
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.