René's URL Explorer Experiment


Title: buffer: prevent failed assertions by brendanashworth · Pull Request #1922 · nodejs/node · GitHub

Open Graph Title: buffer: prevent failed assertions by brendanashworth · Pull Request #1922 · nodejs/node

X Title: buffer: prevent failed assertions by brendanashworth · Pull Request #1922 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This commit adds assert() calls in JS, which prevents non-buffer instances from triggering failed C++ assertions (killing the process). They will now die with an AssertionError. Buffer.prototype.co...

X Description: This commit adds assert() calls in JS, which prevents non-buffer instances from triggering failed C++ assertions (killing the process). They will now die with an AssertionError. Buffer.prototype.co...

Opengraph URL: https://github.com/nodejs/node/pull/1922

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b348ba1-fb9b-36bd-380a-0a9ec3b60b6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD140:C3948:659748E:8F97AAF:6A4FE138
html-safe-noncebf78530e86479568165fdb2424bc5ebcc1afc874f8cb7a82e9a0d1120a2eaa56
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTQwOkMzOTQ4OjY1OTc0OEU6OEY5N0FBRjo2QTRGRTEzOCIsInZpc2l0b3JfaWQiOiI2NTI5MzE1OTgwNzQwMzg3MTI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0c362bddf290534744564862d5a0af873a8c1169fe83ec5c2e047ecc61635ec0
hovercard-subject-tagpull_request:37223026
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1922/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6128df184c50500cdfaea9e48028cd8833bcca01377671e4734045d7bcd9c1f3/nodejs/node/pull/1922
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6128df184c50500cdfaea9e48028cd8833bcca01377671e4734045d7bcd9c1f3/nodejs/node/pull/1922
og:image:altThis commit adds assert() calls in JS, which prevents non-buffer instances from triggering failed C++ assertions (killing the process). They will now die with an AssertionError. Buffer.prototype.co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrendanashworth
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1922#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1922
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1922
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1922
Reloadhttps://github.com/nodejs/node/pull/1922
Reloadhttps://github.com/nodejs/node/pull/1922
Please reload this pagehttps://github.com/nodejs/node/pull/1922
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1922
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 974 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
brendanashworthhttps://github.com/brendanashworth
nodejs:masterhttps://github.com/nodejs/node/tree/master
brendanashworth:fix/buffer-segfault-thishttps://github.com/brendanashworth/io.js/tree/fix/buffer-segfault-this
Conversationhttps://github.com/nodejs/node/pull/1922
Commits2 (2)https://github.com/nodejs/node/pull/1922/commits
Checkshttps://github.com/nodejs/node/pull/1922/checks
Files changedhttps://github.com/nodejs/node/pull/1922/files
buffer: prevent failed assertionshttps://github.com/nodejs/node/pull/1922#top
brendanashworthhttps://github.com/brendanashworth
nodejs:masterhttps://github.com/nodejs/node/tree/master
brendanashworth:fix/buffer-segfault-thishttps://github.com/brendanashworth/io.js/tree/fix/buffer-segfault-this
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issue-86472389
#1485https://github.com/nodejs/node/issues/1485
#1486https://github.com/nodejs/node/pull/1486
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
buffer: prevent failed assertionshttps://github.com/nodejs/node/pull/1922/commits/ca408dcb586e3273c824d1eecc87e80da9cf2aef
ca408dchttps://github.com/nodejs/node/pull/1922/commits/ca408dcb586e3273c824d1eecc87e80da9cf2aef
nodejs#1485https://github.com/nodejs/node/issues/1485
domenichttps://github.com/domenic
Jun 9, 2015 https://github.com/nodejs/node/pull/1922#discussion-diff-31985523
View reviewed changes https://github.com/nodejs/node/pull/1922/files/ca408dcb586e3273c824d1eecc87e80da9cf2aef#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
lib/buffer.jshttps://github.com/nodejs/node/pull/1922/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
domenichttps://github.com/domenic
Jun 9, 2015https://github.com/nodejs/node/pull/1922#discussion_r31985523
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1922
brendanashworthhttps://github.com/brendanashworth
Jun 9, 2015https://github.com/nodejs/node/pull/1922#discussion_r31985697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1922
domenichttps://github.com/domenic
Jun 9, 2015https://github.com/nodejs/node/pull/1922#discussion_r31985773
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1922
trevnorrishttps://github.com/trevnorris
Jun 9, 2015https://github.com/nodejs/node/pull/1922#discussion_r31986837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@domenichttps://github.com/domenic
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/domenic
domenichttps://github.com/domenic
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110244555
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110255851
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110256331
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Jun 9, 2015https://github.com/nodejs/node/pull/1922#event-326016189
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110260138
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
!fixup remove checks besides toString()https://github.com/nodejs/node/pull/1922/commits/ece2b4e651a7f5c1d694ea1cba769d509764ca6b
ece2b4ehttps://github.com/nodejs/node/pull/1922/commits/ece2b4e651a7f5c1d694ea1cba769d509764ca6b
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110266159
@trevnorrishttps://github.com/trevnorris
@domenichttps://github.com/domenic
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110425849
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/786/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/786/
Please reload this pagehttps://github.com/nodejs/node/pull/1922
domenichttps://github.com/domenic
Jun 9, 2015 https://github.com/nodejs/node/pull/1922#discussion-diff-32039167
View reviewed changes https://github.com/nodejs/node/pull/1922/files/ece2b4e651a7f5c1d694ea1cba769d509764ca6b#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
lib/buffer.jshttps://github.com/nodejs/node/pull/1922/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630
domenichttps://github.com/domenic
Jun 9, 2015https://github.com/nodejs/node/pull/1922#discussion_r32039167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/domenic
domenichttps://github.com/domenic
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110439573
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110442661
@domenichttps://github.com/domenic
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/domenic
domenichttps://github.com/domenic
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110443832
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110444460
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 9, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110530367
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 10, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110583363
@brendanashworthhttps://github.com/brendanashworth
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 10, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110583703
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 10, 2015https://github.com/nodejs/node/pull/1922#event-327013119
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jun 10, 2015https://github.com/nodejs/node/pull/1922#issuecomment-110583865
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 19, 2015https://github.com/nodejs/node/pull/1922#issuecomment-113365045
#2012https://github.com/nodejs/node/pull/2012
Please reload this pagehttps://github.com/nodejs/node/pull/1922
trevnorrishttps://github.com/trevnorris
Jun 25, 2015 https://github.com/nodejs/node/pull/1922#ref-commit-1cd9eeb
https://github.com/trevnorris
buffer: prevent abort on bad protohttps://github.com/nodejs/node/commit/1cd9eeb55696625ee8413f9e169c73e9eb21ce76
1cd9eebhttps://github.com/nodejs/node/commit/1cd9eeb55696625ee8413f9e169c73e9eb21ce76
#1486https://github.com/nodejs/node/pull/1486
#1922https://github.com/nodejs/node/pull/1922
#1485https://github.com/nodejs/node/issues/1485
#2012https://github.com/nodejs/node/pull/2012
mscdexhttps://github.com/mscdex
Jul 9, 2015 https://github.com/nodejs/node/pull/1922#ref-commit-40c334d
https://github.com/trevnorris
https://github.com/mscdex
buffer: prevent abort on bad protohttps://github.com/mscdex/io.js/commit/40c334de2c4e855fda9f75ec5444c7b4ced2c77b
40c334dhttps://github.com/mscdex/io.js/commit/40c334de2c4e855fda9f75ec5444c7b4ced2c77b
nodejs#1486https://github.com/nodejs/node/pull/1486
nodejs#1922https://github.com/nodejs/node/pull/1922
nodejs#1485https://github.com/nodejs/node/issues/1485
nodejs#2012https://github.com/nodejs/node/pull/2012
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1922
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
Please reload this pagehttps://github.com/nodejs/node/pull/1922
https://github.com/brendanashworth
https://github.com/domenic
https://github.com/trevnorris
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.