René's URL Explorer Experiment


Title: test: shared lib build doesn't handle SIGPIPE by yhwang · Pull Request #19211 · nodejs/node · GitHub

Open Graph Title: test: shared lib build doesn't handle SIGPIPE by yhwang · Pull Request #19211 · nodejs/node

X Title: test: shared lib build doesn't handle SIGPIPE by yhwang · Pull Request #19211 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: For shared lib build, we leave the signal handling for embedding users. In these two test cases: parallel/test-process-external-stdio-close-spawn parallel/test-process-external-stdio-close The pi...

X Description: For shared lib build, we leave the signal handling for embedding users. In these two test cases: parallel/test-process-external-stdio-close-spawn parallel/test-process-external-stdio-close The pi...

Mail addresses
yh.wang@ibm.com

Opengraph URL: https://github.com/nodejs/node/pull/19211

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:411e041f-63a8-d206-ca65-e15e57644179
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0E8:22DB63:24E1A0A:2F2A1C6:6991BA50
html-safe-nonce4a6768b68d4fba9f20b90234f56ce355556a9b3b3cab60fa06df3da934d0a582
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEU4OjIyREI2MzoyNEUxQTBBOjJGMkExQzY6Njk5MUJBNTAiLCJ2aXNpdG9yX2lkIjoiNDIwMTYxODg3NjUzNzA5MjY4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7d8bb4751b6fb8f4abdc57541aae95016b9bd10ea32153f33bf2410556b2bfcb
hovercard-subject-tagpull_request:173566966
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/19211/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0e8d664bd498d50955b84bcfd138bacb8d451099985d385ddc54f33998462f7f/nodejs/node/pull/19211
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0e8d664bd498d50955b84bcfd138bacb8d451099985d385ddc54f33998462f7f/nodejs/node/pull/19211
og:image:altFor shared lib build, we leave the signal handling for embedding users. In these two test cases: parallel/test-process-external-stdio-close-spawn parallel/test-process-external-stdio-close The pi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyhwang
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/19211#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19211
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19211
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/19211
Reloadhttps://github.com/nodejs/node/pull/19211
Reloadhttps://github.com/nodejs/node/pull/19211
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/19211
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
yhwanghttps://github.com/yhwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
yhwang:sharedlib-test-child-fork-pipehttps://github.com/yhwang/node/tree/sharedlib-test-child-fork-pipe
Conversationhttps://github.com/nodejs/node/pull/19211
Commits1 (1)https://github.com/nodejs/node/pull/19211/commits
Checkshttps://github.com/nodejs/node/pull/19211/checks
Files changedhttps://github.com/nodejs/node/pull/19211/files
test: shared lib build doesn't handle SIGPIPEhttps://github.com/nodejs/node/pull/19211#top
yhwanghttps://github.com/yhwang
nodejs:masterhttps://github.com/nodejs/node/tree/master
yhwang:sharedlib-test-child-fork-pipehttps://github.com/yhwang/node/tree/sharedlib-test-child-fork-pipe
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 7, 2018https://github.com/nodejs/node/pull/19211#issue-303250773
#18535https://github.com/nodejs/node/issues/18535
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Mar 7, 2018https://github.com/nodejs/node/pull/19211#event-1509793716
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371372976
@yhwanghttps://github.com/yhwang
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
Mar 8, 2018https://github.com/nodejs/node/pull/19211#event-1510375772
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371423072
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371541316
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/nodejs/node/blob/master/src/node.cc#L4103-L4117https://github.com/nodejs/node/blob/master/src/node.cc#L4103-L4117
https://github.com/nodejs/node/blob/master/lib/console.js#L110-L132https://github.com/nodejs/node/blob/master/lib/console.js#L110-L132
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 8, 2018 https://github.com/nodejs/node/pull/19211#pullrequestreview-102373497
View reviewed changes https://github.com/nodejs/node/pull/19211/files
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371554180
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371565634
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371586364
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371588243
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371598217
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 8, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371609113
Please reload this pagehttps://github.com/nodejs/node/pull/19211
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/24c5de47a227f18f61de8afa6af1439cbb466c21..c89b462487f5a6e16d0985f7bb18fcb8e6e25c2d
24c5de4https://github.com/nodejs/node/commit/24c5de47a227f18f61de8afa6af1439cbb466c21
c89b462https://github.com/nodejs/node/commit/c89b462487f5a6e16d0985f7bb18fcb8e6e25c2d
Compare https://github.com/nodejs/node/compare/24c5de47a227f18f61de8afa6af1439cbb466c21..c89b462487f5a6e16d0985f7bb18fcb8e6e25c2d
March 9, 2018 01:05https://github.com/nodejs/node/pull/19211#event-1512399636
https://github.com/yhwang
test: shared lib build doesn't handle SIGPIPEhttps://github.com/nodejs/node/pull/19211/commits/4a7be0733f67b97c66b489c609a71fc0ae01ca28
4a7be07https://github.com/nodejs/node/pull/19211/commits/4a7be0733f67b97c66b489c609a71fc0ae01ca28
nodejs#18535https://github.com/nodejs/node/issues/18535
https://github.com/yhwang
yhwanghttps://github.com/yhwang
force-pushedhttps://github.com/nodejs/node/compare/c89b462487f5a6e16d0985f7bb18fcb8e6e25c2d..4a7be0733f67b97c66b489c609a71fc0ae01ca28
c89b462https://github.com/nodejs/node/commit/c89b462487f5a6e16d0985f7bb18fcb8e6e25c2d
4a7be07https://github.com/nodejs/node/commit/4a7be0733f67b97c66b489c609a71fc0ae01ca28
Compare https://github.com/nodejs/node/compare/c89b462487f5a6e16d0985f7bb18fcb8e6e25c2d..4a7be0733f67b97c66b489c609a71fc0ae01ca28
March 9, 2018 01:10https://github.com/nodejs/node/pull/19211#event-1512405047
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 9, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371680242
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 9, 2018 https://github.com/nodejs/node/pull/19211#pullrequestreview-102568738
View reviewed changes https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
jasnellhttps://github.com/jasnell
stale reviewhttps://github.com/nodejs/node/pull/19211#pullrequestreview-102373497
March 9, 2018 08:07https://github.com/nodejs/node/pull/19211#event-1512784067
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 9, 2018 https://github.com/nodejs/node/pull/19211#pullrequestreview-102653570
View reviewed changes https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 9, 2018 https://github.com/nodejs/node/pull/19211#pullrequestreview-102693272
View reviewed changes https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Mar 9, 2018 https://github.com/nodejs/node/pull/19211#pullrequestreview-102701029
View reviewed changes https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/19211#pullrequestreview-102701029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 9, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371885168
https://ci.nodejs.org/job/node-test-commit/16816/https://ci.nodejs.org/job/node-test-commit/16816/
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 9, 2018https://github.com/nodejs/node/pull/19211#issuecomment-371915804
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 9, 2018https://github.com/nodejs/node/pull/19211#event-1513939117
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 10, 2018 https://github.com/nodejs/node/pull/19211#pullrequestreview-102840671
View reviewed changes https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/gireeshpunathil
gireeshpunathilhttps://github.com/gireeshpunathil
Mar 10, 2018https://github.com/nodejs/node/pull/19211#issuecomment-372003682
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 12, 2018https://github.com/nodejs/node/pull/19211#issuecomment-372379694
@gireeshpunathilhttps://github.com/gireeshpunathil
0f0f3d3https://github.com/nodejs/node/commit/0f0f3d33309d3382deb33825fdffeb048f80ec18
Please reload this pagehttps://github.com/nodejs/node/pull/19211
yhwanghttps://github.com/yhwang
Mar 13, 2018 https://github.com/nodejs/node/pull/19211#ref-commit-ffd618b
https://github.com/yhwang
test: shared lib build doesn't handle SIGPIPEhttps://github.com/nodejs/node/commit/ffd618bd5cde77e19ab6458eaf454c4df71dd638
ffd618bhttps://github.com/nodejs/node/commit/ffd618bd5cde77e19ab6458eaf454c4df71dd638
#18535https://github.com/nodejs/node/issues/18535
#19211https://github.com/nodejs/node/pull/19211
#18535https://github.com/nodejs/node/issues/18535
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 13, 2018https://github.com/nodejs/node/pull/19211#issuecomment-372504095
ffd618bhttps://github.com/nodejs/node/commit/ffd618bd5cde77e19ab6458eaf454c4df71dd638
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 13, 2018https://github.com/nodejs/node/pull/19211#event-1517527404
https://github.com/yhwang
yhwanghttps://github.com/yhwang
March 13, 2018 00:14https://github.com/nodejs/node/pull/19211#event-1517527527
https://github.com/yhwang
yhwanghttps://github.com/yhwang
Mar 13, 2018 https://github.com/nodejs/node/pull/19211#ref-issue-293988732
Some test cases fail when the node executable is built by --shared #18535 https://github.com/nodejs/node/issues/18535
targoshttps://github.com/targos
Mar 17, 2018 https://github.com/nodejs/node/pull/19211#ref-commit-1b12f1d
https://github.com/yhwang
https://github.com/targos
test: shared lib build doesn't handle SIGPIPEhttps://github.com/nodejs/node/commit/1b12f1dac9f3e97257d45383918ce9f76efa2321
1b12f1dhttps://github.com/nodejs/node/commit/1b12f1dac9f3e97257d45383918ce9f76efa2321
#18535https://github.com/nodejs/node/issues/18535
#19211https://github.com/nodejs/node/pull/19211
#18535https://github.com/nodejs/node/issues/18535
https://github.com/targos
targoshttps://github.com/targos
Mar 18, 2018 https://github.com/nodejs/node/pull/19211#ref-pullrequest-306242070
v9.9.0 proposal #19428 https://github.com/nodejs/node/pull/19428
MylesBorinshttps://github.com/MylesBorins
Mar 20, 2018 https://github.com/nodejs/node/pull/19211#ref-commit-be20914
https://github.com/yhwang
https://github.com/MylesBorins
test: shared lib build doesn't handle SIGPIPEhttps://github.com/nodejs/node/commit/be209149584efb1710ebb49ab0bf5d0dad34e42c
be20914https://github.com/nodejs/node/commit/be209149584efb1710ebb49ab0bf5d0dad34e42c
#18535https://github.com/nodejs/node/issues/18535
#19211https://github.com/nodejs/node/pull/19211
#18535https://github.com/nodejs/node/issues/18535
MayaLekovahttps://github.com/MayaLekova
May 8, 2018 https://github.com/nodejs/node/pull/19211#ref-commit-dbf338d
https://github.com/yhwang
https://github.com/MayaLekova
test: shared lib build doesn't handle SIGPIPEhttps://github.com/MayaLekova/node/commit/dbf338d0904e7d4e55b5aec40366af5eadfe8c42
dbf338dhttps://github.com/MayaLekova/node/commit/dbf338d0904e7d4e55b5aec40366af5eadfe8c42
nodejs#18535https://github.com/nodejs/node/issues/18535
nodejs#19211https://github.com/nodejs/node/pull/19211
nodejs#18535https://github.com/nodejs/node/issues/18535
BethGriggshttps://github.com/BethGriggs
Mar 21, 2019 https://github.com/nodejs/node/pull/19211#ref-commit-eaf474c
https://github.com/yhwang
https://github.com/BethGriggs
test: shared lib build doesn't handle SIGPIPEhttps://github.com/nodejs/node/commit/eaf474cc5dcf2c915cf1a91c4742df57ceb4ae2d
eaf474chttps://github.com/nodejs/node/commit/eaf474cc5dcf2c915cf1a91c4742df57ceb4ae2d
#18535https://github.com/nodejs/node/issues/18535
#19211https://github.com/nodejs/node/pull/19211
#18535https://github.com/nodejs/node/issues/18535
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 26, 2019 https://github.com/nodejs/node/pull/19211#ref-pullrequest-425612104
v8.16.0 proposal #26933 https://github.com/nodejs/node/pull/26933
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F19211
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/gireeshpunathil
gireeshpunathil https://github.com/gireeshpunathil
https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/19211/files/4a7be0733f67b97c66b489c609a71fc0ae01ca28
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/19211
https://github.com/yhwang
https://github.com/gireeshpunathil
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.