| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ea4dea04-2e89-8881-2086-78098834bcc1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A5DC:13B2CF:12E0453:19B587F:6A52191B |
| html-safe-nonce | c0207eb56df801fd5345304a965c701a25298073c3d239b57fa1cf4cf3f69c6a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNURDOjEzQjJDRjoxMkUwNDUzOjE5QjU4N0Y6NkE1MjE5MUIiLCJ2aXNpdG9yX2lkIjoiNTA3NzYyNzI3ODE4OTUzMzQ2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e5f147ae2f41924c29959ccdaab45d3068c6070347ded65ea7d74b3515cad5ca |
| hovercard-subject-tag | pull_request:171193121 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18981/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d18cbfb96094d7ba61c1f588547363a433447d59b99600bec22c8ac6d962d8af/nodejs/node/pull/18981 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d18cbfb96094d7ba61c1f588547363a433447d59b99600bec22c8ac6d962d8af/nodejs/node/pull/18981 |
| og:image:alt | Fixes: #18978
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
build |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/18981#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18981 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18981 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/18981 |
| Reload | https://github.com/nodejs/node/pull/18981 |
| Reload | https://github.com/nodejs/node/pull/18981 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
984
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:fix-lint-md-build | https://github.com/joyeecheung/node/tree/fix-lint-md-build |
| Conversation | https://github.com/nodejs/node/pull/18981 |
| Commits1 (1) | https://github.com/nodejs/node/pull/18981/commits |
| Checks | https://github.com/nodejs/node/pull/18981/checks |
| Files changed | https://github.com/nodejs/node/pull/18981/files |
| build: fix lint-md-build dependency | https://github.com/nodejs/node/pull/18981#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| joyeecheung:fix-lint-md-build | https://github.com/joyeecheung/node/tree/fix-lint-md-build |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 24, 2018 | https://github.com/nodejs/node/pull/18981#issue-299965390 |
| #18978 | https://github.com/nodejs/node/issues/18978 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Feb 24, 2018 | https://github.com/nodejs/node/pull/18981#event-1490545714 |
|
| https://github.com/joyeecheung |
| build: fix lint-md-build dependency | https://github.com/nodejs/node/pull/18981/commits/85c125f8029f788f9ff592de47c087492924cd40 |
| 85c125f | https://github.com/nodejs/node/pull/18981/commits/85c125f8029f788f9ff592de47c087492924cd40 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/fdda2ab7a89ef5a48c9b150f132b3384d437768b..85c125f8029f788f9ff592de47c087492924cd40 |
| fdda2ab | https://github.com/nodejs/node/commit/fdda2ab7a89ef5a48c9b150f132b3384d437768b |
| 85c125f | https://github.com/nodejs/node/commit/85c125f8029f788f9ff592de47c087492924cd40 |
|
Compare
| https://github.com/nodejs/node/compare/fdda2ab7a89ef5a48c9b150f132b3384d437768b..85c125f8029f788f9ff592de47c087492924cd40 |
| February 24, 2018 19:20 | https://github.com/nodejs/node/pull/18981#event-1490546009 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Feb 24, 2018
| https://github.com/nodejs/node/pull/18981#pullrequestreview-99120846 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 24, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368253008 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 24, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368253162 |
| https://ci.nodejs.org/job/node-test-pull-request/13361/ | https://ci.nodejs.org/job/node-test-pull-request/13361/ |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Feb 24, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368269072 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| @refack | https://github.com/refack |
| @watilde | https://github.com/watilde |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Feb 26, 2018 | https://github.com/nodejs/node/pull/18981#event-1491820406 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 26, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368477970 |
| @ChALkeR | https://github.com/ChALkeR |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
| Feb 26, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368518712 |
| node-test-linter npm installs remark-cli for each build #16628 | https://github.com/nodejs/node/issues/16628 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Feb 26, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368520364 |
| @joyeecheung | https://github.com/joyeecheung |
| @watilde | https://github.com/watilde |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Feb 26, 2018
| https://github.com/nodejs/node/pull/18981#pullrequestreview-99317727 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Feb 26, 2018
| https://github.com/nodejs/node/pull/18981#pullrequestreview-99323628 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 26, 2018
| https://github.com/nodejs/node/pull/18981#pullrequestreview-99414463 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
| joyeecheung | https://github.com/joyeecheung |
|
Feb 27, 2018
| https://github.com/nodejs/node/pull/18981#ref-commit-0bff955 |
|
| https://github.com/joyeecheung |
| build: fix lint-md-build dependency | https://github.com/nodejs/node/commit/0bff955b6d9e1d3f5b1c0b1b71e68f7c0da33de7 |
| 0bff955 | https://github.com/nodejs/node/commit/0bff955b6d9e1d3f5b1c0b1b71e68f7c0da33de7 |
| #18981 | https://github.com/nodejs/node/pull/18981 |
| #18978 | https://github.com/nodejs/node/issues/18978 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 27, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-368833321 |
| 0bff955 | https://github.com/nodejs/node/commit/0bff955b6d9e1d3f5b1c0b1b71e68f7c0da33de7 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 27, 2018 | https://github.com/nodejs/node/pull/18981#event-1494095942 |
| https://github.com/estrada9166 |
| estrada9166 | https://github.com/estrada9166 |
|
Mar 1, 2018
| https://github.com/nodejs/node/pull/18981#ref-pullrequest-301256236 |
|
[v8.x backport] doc: add new documentation rule
#19065
| https://github.com/nodejs/node/pull/19065 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 2, 2018
| https://github.com/nodejs/node/pull/18981#ref-issue-299953528 |
|
lint-md on master failing
#18978
| https://github.com/nodejs/node/issues/18978 |
| addaleax | https://github.com/addaleax |
|
Mar 5, 2018
| https://github.com/nodejs/node/pull/18981#ref-commit-28a5362 |
|
| https://github.com/joyeecheung |
|
| https://github.com/addaleax |
| build: fix lint-md-build dependency | https://github.com/addaleax/node/commit/28a5362e8311f9baca03411c5687bace75858ce4 |
| 28a5362 | https://github.com/addaleax/node/commit/28a5362e8311f9baca03411c5687bace75858ce4 |
| nodejs#18981 | https://github.com/nodejs/node/pull/18981 |
| nodejs#18978 | https://github.com/nodejs/node/issues/18978 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 6, 2018
| https://github.com/nodejs/node/pull/18981#ref-pullrequest-302883941 |
|
v9.8.0 proposal
#19181
| https://github.com/nodejs/node/pull/19181 |
|
[v9.x backport] doc: add new documentation rule
#19189
| https://github.com/nodejs/node/pull/19189 |
|
build: search missing dependencies on lint-md
#19248
| https://github.com/nodejs/node/pull/19248 |
|
build: search missing dependencies on lint-md
#19249
| https://github.com/nodejs/node/pull/19249 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Mar 13, 2018
| https://github.com/nodejs/node/pull/18981#ref-issue-304956208 |
|
test: Error: Cannot parse file .remarkrc
#19334
| https://github.com/nodejs/node/issues/19334 |
| MayaLekova | https://github.com/MayaLekova |
|
May 8, 2018
| https://github.com/nodejs/node/pull/18981#ref-commit-b5c962c |
|
| https://github.com/joyeecheung |
|
| https://github.com/MayaLekova |
| build: fix lint-md-build dependency | https://github.com/MayaLekova/node/commit/b5c962cb4f8c944742913398abcff4680dc50779 |
| b5c962c | https://github.com/MayaLekova/node/commit/b5c962cb4f8c944742913398abcff4680dc50779 |
| nodejs#18981 | https://github.com/nodejs/node/pull/18981 |
| nodejs#18978 | https://github.com/nodejs/node/issues/18978 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-413998990 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/18981#event-1795639236 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/18981#issuecomment-414001867 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| #17964 | https://github.com/nodejs/node/pull/17964 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
lts-watch-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x |
| Sep 19, 2019 | https://github.com/nodejs/node/pull/18981#event-2648229568 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18981 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/18981/files/85c125f8029f788f9ff592de47c087492924cd40 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
lint-md on master failing
| https://github.com/nodejs/node/issues/18978 |
| Please reload this page | https://github.com/nodejs/node/pull/18981 |
|
| https://github.com/joyeecheung |
|
| https://github.com/ChALkeR |
|
| https://github.com/watilde |
|
| https://github.com/jasnell |
|
| https://github.com/devsnek |
|
| https://github.com/BethGriggs |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |