René's URL Explorer Experiment


Title: child_process: fix exec set stdout.setEncoding by killagu · Pull Request #18976 · nodejs/node · GitHub

Open Graph Title: child_process: fix exec set stdout.setEncoding by killagu · Pull Request #18976 · nodejs/node

X Title: child_process: fix exec set stdout.setEncoding by killagu · Pull Request #18976 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: cp.exec decide to use _stdout(_stdout is string) or Buffer.concat(_stdout)(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null...

X Description: cp.exec decide to use _stdout(_stdout is string) or Buffer.concat(_stdout)(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null...

Opengraph URL: https://github.com/nodejs/node/pull/18976

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fa186233-2bd6-e763-fb50-ea8c63a8f450
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF62:189F37:1EE39E:270B2C:69920D8F
html-safe-nonce219ba07987b74ae51450b0c497a53e78731a364affaa2201c1782c9ebe388e29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjYyOjE4OUYzNzoxRUUzOUU6MjcwQjJDOjY5OTIwRDhGIiwidmlzaXRvcl9pZCI6IjU1MzAyMTYxMDk4OTcyODkxMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac713a0185c4ca92cff8fd207a30a82908edaf7f1978b1315d39b678d55d04aa11
hovercard-subject-tagpull_request:171179956
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18976/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ad2db2077b011c63cd971854de3c98659d9af593f33ed136eae7c2ee529dde4f/nodejs/node/pull/18976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad2db2077b011c63cd971854de3c98659d9af593f33ed136eae7c2ee529dde4f/nodejs/node/pull/18976
og:image:altcp.exec decide to use _stdout(_stdout is string) or Buffer.concat(_stdout)(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekillagu
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18976#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18976
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18976
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18976
Reloadhttps://github.com/nodejs/node/pull/18976
Reloadhttps://github.com/nodejs/node/pull/18976
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18976
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
killaguhttps://github.com/killagu
nodejs:masterhttps://github.com/nodejs/node/tree/master
killagu:fix-cp-exec-set-encodinghttps://github.com/killagu/node/tree/fix-cp-exec-set-encoding
Conversationhttps://github.com/nodejs/node/pull/18976
Commits3 (3)https://github.com/nodejs/node/pull/18976/commits
Checkshttps://github.com/nodejs/node/pull/18976/checks
Files changedhttps://github.com/nodejs/node/pull/18976/files
child_process: fix exec set stdout.setEncodinghttps://github.com/nodejs/node/pull/18976#top
killaguhttps://github.com/killagu
nodejs:masterhttps://github.com/nodejs/node/tree/master
killagu:fix-cp-exec-set-encodinghttps://github.com/killagu/node/tree/fix-cp-exec-set-encoding
https://github.com/killagu
killaguhttps://github.com/killagu
Feb 24, 2018https://github.com/nodejs/node/pull/18976#issue-299943225
#18969https://github.com/nodejs/node/issues/18969
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Feb 24, 2018https://github.com/nodejs/node/pull/18976#event-1490441602
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 24, 2018 https://github.com/nodejs/node/pull/18976#pullrequestreview-99113822
View reviewed changes https://github.com/nodejs/node/pull/18976/files
test/parallel/test-child-process-exec-std-encoding.jshttps://github.com/nodejs/node/pull/18976/files#diff-8dbe8fe0d5b153e24a85547d670a9aefb18b20b13f630d15e0fb4c0ee474bf74
lpincahttps://github.com/lpinca
Feb 24, 2018https://github.com/nodejs/node/pull/18976#discussion_r170422486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18976
killaguhttps://github.com/killagu
Feb 25, 2018https://github.com/nodejs/node/pull/18976#discussion_r170440228
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
encodinghttps://github.com/nodejs/node/blob/master/test/parallel/test-child-process-exec-encoding.js#L12
envhttps://github.com/nodejs/node/blob/master/test/parallel/test-child-process-exec-env.js#L34
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/hstarorg
hstarorghttps://github.com/hstarorg
Feb 25, 2018https://github.com/nodejs/node/pull/18976#issuecomment-368278603
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/killagu/node/blob/c40252d80610765e5f6efefc02ea6ba1b95cee17/lib/child_process.js#L336-L345https://github.com/killagu/node/blob/c40252d80610765e5f6efefc02ea6ba1b95cee17/lib/child_process.js#L336-L345
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/killagu
killaguhttps://github.com/killagu
Feb 25, 2018https://github.com/nodejs/node/pull/18976#issuecomment-368279962
@hstarorghttps://github.com/hstarorg
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/killagu
killaguhttps://github.com/killagu
Feb 25, 2018 https://github.com/nodejs/node/pull/18976#pullrequestreview-99131184
View reviewed changes https://github.com/nodejs/node/pull/18976/files
lib/_stream_readable.jshttps://github.com/nodejs/node/pull/18976/files#diff-1fd696295b3ae3f444c5c6839a11f89a91e2a42edeb5827e54e86b8acc3e6fe7
killaguhttps://github.com/killagu
Feb 25, 2018https://github.com/nodejs/node/pull/18976#discussion_r170440756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 9, 2018https://github.com/nodejs/node/pull/18976#issuecomment-379928731
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
bnoordhuishttps://github.com/bnoordhuis
mafintoshhttps://github.com/mafintosh
mcollinahttps://github.com/mcollina
April 9, 2018 23:54https://github.com/nodejs/node/pull/18976#event-1565024804
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 10, 2018 https://github.com/nodejs/node/pull/18976#pullrequestreview-110791401
View reviewed changes https://github.com/nodejs/node/pull/18976/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/18976#pullrequestreview-110791401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 16, 2018https://github.com/nodejs/node/pull/18976#issuecomment-381470302
@killaguhttps://github.com/killagu
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Apr 28, 2018https://github.com/nodejs/node/pull/18976#issuecomment-385177359
@killaguhttps://github.com/killagu
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/killagu
killaguhttps://github.com/killagu
May 2, 2018https://github.com/nodejs/node/pull/18976#issuecomment-385902920
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/18976
killaguhttps://github.com/killagu
May 2, 2018 22:15https://github.com/nodejs/node/pull/18976#commits-pushed-2623b7e
https://github.com/killagu
child_process: fix exec set stdout.setEncodinghttps://github.com/nodejs/node/pull/18976/commits/2623b7e0205c7bba30266983764643adecbeaa91
2623b7ehttps://github.com/nodejs/node/pull/18976/commits/2623b7e0205c7bba30266983764643adecbeaa91
nodejs#18969https://github.com/nodejs/node/issues/18969
https://github.com/killagu
improve testhttps://github.com/nodejs/node/pull/18976/commits/1ac8dc77f8c1dfcfcb5be0c53114c10afdf8f864
1ac8dc7https://github.com/nodejs/node/pull/18976/commits/1ac8dc77f8c1dfcfcb5be0c53114c10afdf8f864
https://github.com/killagu
fhttps://github.com/nodejs/node/pull/18976/commits/72ebad258c15fe1a940a8a92da48f8c6983bcc49
72ebad2https://github.com/nodejs/node/pull/18976/commits/72ebad258c15fe1a940a8a92da48f8c6983bcc49
https://github.com/killagu
killaguhttps://github.com/killagu
force-pushedhttps://github.com/nodejs/node/compare/daf4caedb6a092479be09818aa20e74f1eee41cf..72ebad258c15fe1a940a8a92da48f8c6983bcc49
daf4caehttps://github.com/nodejs/node/commit/daf4caedb6a092479be09818aa20e74f1eee41cf
72ebad2https://github.com/nodejs/node/commit/72ebad258c15fe1a940a8a92da48f8c6983bcc49
Compare https://github.com/nodejs/node/compare/daf4caedb6a092479be09818aa20e74f1eee41cf..72ebad258c15fe1a940a8a92da48f8c6983bcc49
May 2, 2018 14:43https://github.com/nodejs/node/pull/18976#event-1605644108
https://github.com/killagu
killaguhttps://github.com/killagu
May 2, 2018https://github.com/nodejs/node/pull/18976#issuecomment-386002949
@mcollinahttps://github.com/mcollina
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 15, 2018https://github.com/nodejs/node/pull/18976#issuecomment-389164505
https://ci.nodejs.org/job/node-test-pull-request/14885/https://ci.nodejs.org/job/node-test-pull-request/14885/
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 15, 2018 https://github.com/nodejs/node/pull/18976#pullrequestreview-120229393
View reviewed changes https://github.com/nodejs/node/pull/18976/files/72ebad258c15fe1a940a8a92da48f8c6983bcc49
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 15, 2018https://github.com/nodejs/node/pull/18976#event-1627187875
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 15, 2018https://github.com/nodejs/node/pull/18976#issuecomment-389165092
Please reload this pagehttps://github.com/nodejs/node/pull/18976
BridgeARhttps://github.com/BridgeAR
May 18, 2018 https://github.com/nodejs/node/pull/18976#ref-commit-7d81f5d
https://github.com/killagu
https://github.com/BridgeAR
child_process: fix exec set stdout.setEncodinghttps://github.com/BridgeAR/node/commit/7d81f5d1435a208f34f0d3ca15034ff8eaf060ce
7d81f5dhttps://github.com/BridgeAR/node/commit/7d81f5d1435a208f34f0d3ca15034ff8eaf060ce
nodejs#18976https://github.com/nodejs/node/pull/18976
nodejs#18969https://github.com/nodejs/node/issues/18969
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/18976#issuecomment-390204839
7d81f5dhttps://github.com/nodejs/node/commit/7d81f5d1435a208f34f0d3ca15034ff8eaf060ce
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
May 18, 2018https://github.com/nodejs/node/pull/18976#event-1634254308
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/18976#ref-commit-4710349
https://github.com/killagu
https://github.com/MylesBorins
child_process: fix exec set stdout.setEncodinghttps://github.com/nodejs/node/commit/47103493f7031c7f2b9bf82b0e25badf634433a1
4710349https://github.com/nodejs/node/commit/47103493f7031c7f2b9bf82b0e25badf634433a1
#18976https://github.com/nodejs/node/pull/18976
#18969https://github.com/nodejs/node/issues/18969
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 22, 2018 https://github.com/nodejs/node/pull/18976#ref-pullrequest-322922249
v10.2.0 proposal #20724 https://github.com/nodejs/node/pull/20724
https://github.com/killagu
killaguhttps://github.com/killagu
July 18, 2018 05:54https://github.com/nodejs/node/pull/18976#event-1739288777
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18976
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/18976/files/c40252d80610765e5f6efefc02ea6ba1b95cee17
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/18976/files/daf4caedb6a092479be09818aa20e74f1eee41cf
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/18976/files/72ebad258c15fe1a940a8a92da48f8c6983bcc49
https://github.com/mafintosh
mafintosh https://github.com/mafintosh
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
child_process instance set encoding will trigger exception https://github.com/nodejs/node/issues/18969
Please reload this pagehttps://github.com/nodejs/node/pull/18976
https://github.com/killagu
https://github.com/hstarorg
https://github.com/BridgeAR
https://github.com/mcollina
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.