René's URL Explorer Experiment


Title: readline: add support for async iteration by prog1dev · Pull Request #18904 · nodejs/node · GitHub

Open Graph Title: readline: add support for async iteration by prog1dev · Pull Request #18904 · nodejs/node

X Title: readline: add support for async iteration by prog1dev · Pull Request #18904 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Sync readline API with for-await-of support in readable streams Resolves #18603 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentat...

X Description: Sync readline API with for-await-of support in readable streams Resolves #18603 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentat...

Opengraph URL: https://github.com/nodejs/node/pull/18904

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f39cb3db-7a53-2211-d3e6-fc8f3b72c24e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE21E:13E721:BF1098:F6DA17:6990BD7C
html-safe-noncee3a914bd318e4f396cee45b2afbf77d9e313d952d270968b7867f3759a2d3a44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjFFOjEzRTcyMTpCRjEwOTg6RjZEQTE3OjY5OTBCRDdDIiwidmlzaXRvcl9pZCI6IjU5NjI4MTUxMTE1NTQ5NzMwNTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2116301bca5fcf8b660552aae362253b809d08df1cdd0e3133183dbb582e456e
hovercard-subject-tagpull_request:170523417
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18904/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03d280fe262126c4a4f36192943b0f8eecb9b8697d8d4f14bd6c78a0a8932cee/nodejs/node/pull/18904
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03d280fe262126c4a4f36192943b0f8eecb9b8697d8d4f14bd6c78a0a8932cee/nodejs/node/pull/18904
og:image:altSync readline API with for-await-of support in readable streams Resolves #18603 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameprog1dev
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18904#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18904
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18904
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18904
Reloadhttps://github.com/nodejs/node/pull/18904
Reloadhttps://github.com/nodejs/node/pull/18904
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 705 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
prog1devhttps://github.com/prog1dev
nodejs:masterhttps://github.com/nodejs/node/tree/master
prog1dev:readline/add_support_for_async_iterationhttps://github.com/prog1dev/node/tree/readline/add_support_for_async_iteration
Conversationhttps://github.com/nodejs/node/pull/18904
Commits2 (2)https://github.com/nodejs/node/pull/18904/commits
Checkshttps://github.com/nodejs/node/pull/18904/checks
Files changedhttps://github.com/nodejs/node/pull/18904/files
readline: add support for async iterationhttps://github.com/nodejs/node/pull/18904#top
prog1devhttps://github.com/prog1dev
nodejs:masterhttps://github.com/nodejs/node/tree/master
prog1dev:readline/add_support_for_async_iterationhttps://github.com/prog1dev/node/tree/readline/add_support_for_async_iteration
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Feb 21, 2018https://github.com/nodejs/node/pull/18904#issue-299041239
Please reload this pagehttps://github.com/nodejs/node/pull/18904
for-await-of support in readable streamshttps://github.com/nodejs/node/pull/17755
#18603https://github.com/nodejs/node/issues/18603
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@vsemozhetbythttps://github.com/vsemozhetbyt
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
Feb 21, 2018https://github.com/nodejs/node/pull/18904#event-1485086744
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98276223
View reviewed changes https://github.com/nodejs/node/pull/18904/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/18904#pullrequestreview-98276223
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mcollina
mcollinahttps://github.com/mcollina
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Feb 21, 2018https://github.com/nodejs/node/pull/18904#event-1485138014
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 21, 2018https://github.com/nodejs/node/pull/18904#issuecomment-367395703
https://ci.nodejs.org/job/node-test-pull-request/13312/https://ci.nodejs.org/job/node-test-pull-request/13312/
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98295088
View reviewed changes https://github.com/nodejs/node/pull/18904/files
test/parallel/test-readline-async-iterators.jshttps://github.com/nodejs/node/pull/18904/files#diff-cc6323568ca9b580d8872b938f4c1707d122b54eef595897b709913dd7ace57b
mscdexhttps://github.com/mscdex
Feb 21, 2018https://github.com/nodejs/node/pull/18904#discussion_r169722255
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98295201
View reviewed changes https://github.com/nodejs/node/pull/18904/files
test/parallel/test-readline-async-iterators.jshttps://github.com/nodejs/node/pull/18904/files#diff-cc6323568ca9b580d8872b938f4c1707d122b54eef595897b709913dd7ace57b
mscdexhttps://github.com/mscdex
Feb 21, 2018https://github.com/nodejs/node/pull/18904#discussion_r169722358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Trotthttps://github.com/Trott
Feb 21, 2018https://github.com/nodejs/node/pull/18904#discussion_r169722814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
prog1devhttps://github.com/prog1dev
Feb 22, 2018https://github.com/nodejs/node/pull/18904#discussion_r169848664
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
examplehttps://github.com/nodejs/node/blob/master/test/parallel/test-fs-write-file.js#L106
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/targos
targoshttps://github.com/targos
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Feb 21, 2018https://github.com/nodejs/node/pull/18904#event-1485425998
https://github.com/targos
targoshttps://github.com/targos
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98328318
View reviewed changes https://github.com/nodejs/node/pull/18904/files
test/parallel/test-readline-async-iterators.jshttps://github.com/nodejs/node/pull/18904/files#diff-cc6323568ca9b580d8872b938f4c1707d122b54eef595897b709913dd7ace57b
targoshttps://github.com/targos
Feb 21, 2018https://github.com/nodejs/node/pull/18904#discussion_r169750558
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98378168
View reviewed changes https://github.com/nodejs/node/pull/18904/files
test/parallel/test-readline-async-iterators.jshttps://github.com/nodejs/node/pull/18904/files#diff-cc6323568ca9b580d8872b938f4c1707d122b54eef595897b709913dd7ace57b
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 21, 2018https://github.com/nodejs/node/pull/18904#discussion_r169792671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98384871
View reviewed changes https://github.com/nodejs/node/pull/18904/files
test/parallel/test-readline-async-iterators.jshttps://github.com/nodejs/node/pull/18904/files#diff-cc6323568ca9b580d8872b938f4c1707d122b54eef595897b709913dd7ace57b
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 21, 2018https://github.com/nodejs/node/pull/18904#discussion_r169798240
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 21, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98385030
View reviewed changes https://github.com/nodejs/node/pull/18904/files
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 21, 2018https://github.com/nodejs/node/pull/18904#issuecomment-367500379
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Feb 22, 2018https://github.com/nodejs/node/pull/18904#issuecomment-367562216
Please reload this pagehttps://github.com/nodejs/node/pull/18904
@vsemozhetbythttps://github.com/vsemozhetbyt
Interface.prototype[Symbol.asyncIterator]https://github.com/nodejs/node/pull/18904/files#diff-d2acee21faac11dc676c3e4570bad979R244
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Feb 22, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98444620
View reviewed changes https://github.com/nodejs/node/pull/18904/files
lib/readline.jshttps://github.com/nodejs/node/pull/18904/files#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
devsnekhttps://github.com/devsnek
Feb 22, 2018https://github.com/nodejs/node/pull/18904#discussion_r169851604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Feb 22, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98444643
View reviewed changes https://github.com/nodejs/node/pull/18904/files
devsnekhttps://github.com/devsnek
https://github.com/nodejs/node/pull/18904#pullrequestreview-98444643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 22, 2018https://github.com/nodejs/node/pull/18904#issuecomment-367629684
@prog1devhttps://github.com/prog1dev
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 23, 2018https://github.com/nodejs/node/pull/18904#issuecomment-368051157
Please reload this pagehttps://github.com/nodejs/node/pull/18904
@prog1devhttps://github.com/prog1dev
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Feb 23, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-98969330
View reviewed changes https://github.com/nodejs/node/pull/18904/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/18904#pullrequestreview-98969330
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Feb 23, 2018https://github.com/nodejs/node/pull/18904#issuecomment-368072779
Please reload this pagehttps://github.com/nodejs/node/pull/18904
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
Feb 23, 2018https://github.com/nodejs/node/pull/18904#event-1489562044
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 23, 2018 https://github.com/nodejs/node/pull/18904#ref-issue-299857596
test: test-assert.js fails locally #18967 https://github.com/nodejs/node/issues/18967
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Feb 23, 2018https://github.com/nodejs/node/pull/18904#issuecomment-368168175
#16178https://github.com/nodejs/node/issues/16178
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 23, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-99086014
View reviewed changes https://github.com/nodejs/node/pull/18904/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/18904#pullrequestreview-99086014
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@vsemozhetbythttps://github.com/vsemozhetbyt
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Feb 23, 2018https://github.com/nodejs/node/pull/18904#issuecomment-368173054
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 2, 2018https://github.com/nodejs/node/pull/18904#issuecomment-369792752
@prog1devhttps://github.com/prog1dev
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Mar 3, 2018https://github.com/nodejs/node/pull/18904#issuecomment-370164135
Please reload this pagehttps://github.com/nodejs/node/pull/18904
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
force-pushedhttps://github.com/nodejs/node/compare/e3532d88b34420357b4a62eb0d194d1980450519..3468ed93d5f91fab68113b4dbe76237c446c1719
e3532d8https://github.com/nodejs/node/commit/e3532d88b34420357b4a62eb0d194d1980450519
3468ed9https://github.com/nodejs/node/commit/3468ed93d5f91fab68113b4dbe76237c446c1719
Compare https://github.com/nodejs/node/compare/e3532d88b34420357b4a62eb0d194d1980450519..3468ed93d5f91fab68113b4dbe76237c446c1719
March 12, 2018 20:20https://github.com/nodejs/node/pull/18904#event-1517175442
https://github.com/prog1dev
stream: move common async iteration logic to base_async_iteratorhttps://github.com/nodejs/node/pull/18904/commits/2f5c5584276eaa7160c295425f228f5106e925df
2f5c558https://github.com/nodejs/node/pull/18904/commits/2f5c5584276eaa7160c295425f228f5106e925df
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
force-pushedhttps://github.com/nodejs/node/compare/716e6f12a15901babc3f2a4d1b7e5eb3df229b8e..2f5c5584276eaa7160c295425f228f5106e925df
716e6f1https://github.com/nodejs/node/commit/716e6f12a15901babc3f2a4d1b7e5eb3df229b8e
2f5c558https://github.com/nodejs/node/commit/2f5c5584276eaa7160c295425f228f5106e925df
Compare https://github.com/nodejs/node/compare/716e6f12a15901babc3f2a4d1b7e5eb3df229b8e..2f5c5584276eaa7160c295425f228f5106e925df
May 5, 2018 17:21https://github.com/nodejs/node/pull/18904#event-1611355617
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
May 5, 2018https://github.com/nodejs/node/pull/18904#issuecomment-386821685
https://ci.nodejs.org/job/node-test-pull-request/14676/https://ci.nodejs.org/job/node-test-pull-request/14676/
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 5, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-117827788
View reviewed changes https://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df
lib/readline.jshttps://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
TimothyGuhttps://github.com/TimothyGu
May 5, 2018https://github.com/nodejs/node/pull/18904#discussion_r186275084
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
prog1devhttps://github.com/prog1dev
May 20, 2018https://github.com/nodejs/node/pull/18904#discussion_r189459452
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
lib/readline.jshttps://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
TimothyGuhttps://github.com/TimothyGu
May 5, 2018https://github.com/nodejs/node/pull/18904#discussion_r186275097
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
lib/readline.jshttps://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
TimothyGuhttps://github.com/TimothyGu
May 5, 2018https://github.com/nodejs/node/pull/18904#discussion_r186275121
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
prog1devhttps://github.com/prog1dev
May 20, 2018https://github.com/nodejs/node/pull/18904#discussion_r189459683
Please reload this pagehttps://github.com/nodejs/node/pull/18904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
lib/readline.jshttps://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
TimothyGuhttps://github.com/TimothyGu
May 5, 2018https://github.com/nodejs/node/pull/18904#discussion_r186275130
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
May 5, 2018https://github.com/nodejs/node/pull/18904#issuecomment-386843246
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 7, 2018 https://github.com/nodejs/node/pull/18904#pullrequestreview-118001258
View reviewed changes https://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df
lib/readline.jshttps://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df#diff-36f855786dc2ab46536bcb72a1f08f98c9b730ffa5dcd9dcff2ff952d7ee5c50
mcollinahttps://github.com/mcollina
May 7, 2018https://github.com/nodejs/node/pull/18904#discussion_r186426858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 7, 2018https://github.com/nodejs/node/pull/18904#issuecomment-387070265
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/Trott
Trotthttps://github.com/Trott
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jul 19, 2018https://github.com/nodejs/node/pull/18904#event-1741434473
https://github.com/jasnell
jasnellhttps://github.com/jasnell
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
dont-land-on-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v9.x
Aug 12, 2018https://github.com/nodejs/node/pull/18904#event-1784042385
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Sep 22, 2018 https://github.com/nodejs/node/pull/18904#ref-issue-362894606
Readline: emit data events along with current line events #23032 https://github.com/nodejs/node/issues/23032
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 17, 2018https://github.com/nodejs/node/pull/18904#issuecomment-430714455
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Oct 17, 2018https://github.com/nodejs/node/pull/18904#issuecomment-430718487
@jasnellhttps://github.com/jasnell
#18904 (comment)https://github.com/nodejs/node/pull/18904#discussion_r186275130
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 22, 2018https://github.com/nodejs/node/pull/18904#issuecomment-431995089
@prog1devhttps://github.com/prog1dev
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Oct 22, 2018https://github.com/nodejs/node/pull/18904#issuecomment-432004710
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 25, 2018https://github.com/nodejs/node/pull/18904#event-1927560667
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 27, 2018 https://github.com/nodejs/node/pull/18904#ref-pullrequest-374593003
readline: add support for async iteration #23916 https://github.com/nodejs/node/pull/23916
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Oct 27, 2018https://github.com/nodejs/node/pull/18904#issuecomment-433581340
#23916https://github.com/nodejs/node/pull/23916
Please reload this pagehttps://github.com/nodejs/node/pull/18904
TimothyGuhttps://github.com/TimothyGu
Nov 20, 2018 https://github.com/nodejs/node/pull/18904#ref-commit-179dd7b
https://github.com/TimothyGu
https://github.com/prog1dev
readline: add support for async iterationhttps://github.com/TimothyGu/node/commit/179dd7b48f204be01a65c9a8f719b6c9a793ba2e
179dd7bhttps://github.com/TimothyGu/node/commit/179dd7b48f204be01a65c9a8f719b6c9a793ba2e
nodejs#18603https://github.com/nodejs/node/issues/18603
nodejs#18904https://github.com/nodejs/node/pull/18904
Trotthttps://github.com/Trott
Nov 20, 2018 https://github.com/nodejs/node/pull/18904#ref-commit-2a7432d
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/Trott
readline: add support for async iterationhttps://github.com/Trott/io.js/commit/2a7432dadec08bbe7063d84f1aa4a6396807305c
2a7432dhttps://github.com/Trott/io.js/commit/2a7432dadec08bbe7063d84f1aa4a6396807305c
nodejs#18603https://github.com/nodejs/node/issues/18603
nodejs#18904https://github.com/nodejs/node/pull/18904
nodejs#23916https://github.com/nodejs/node/pull/23916
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
Nov 20, 2018https://github.com/nodejs/node/pull/18904#event-1978760586
https://github.com/prog1dev
prog1devhttps://github.com/prog1dev
November 20, 2018 23:46https://github.com/nodejs/node/pull/18904#event-1978760714
targoshttps://github.com/targos
Nov 21, 2018 https://github.com/nodejs/node/pull/18904#ref-commit-e88a950
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/targos
readline: add support for async iterationhttps://github.com/nodejs/node/commit/e88a950c43f921532c9ce42b47449e4746e80c03
e88a950https://github.com/nodejs/node/commit/e88a950c43f921532c9ce42b47449e4746e80c03
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
rvagghttps://github.com/rvagg
Nov 28, 2018 https://github.com/nodejs/node/pull/18904#ref-commit-b22e95d
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/rvagg
readline: add support for async iterationhttps://github.com/nodejs/node/commit/b22e95d5ed3f214724ba1d8c5e37386ae7c37c7c
b22e95dhttps://github.com/nodejs/node/commit/b22e95d5ed3f214724ba1d8c5e37386ae7c37c7c
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
refackhttps://github.com/refack
Jan 14, 2019 https://github.com/nodejs/node/pull/18904#ref-commit-e86e768
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/refack
readline: add support for async iterationhttps://github.com/refack/node/commit/e86e7689e38b72e25e0de5676215a06a69210bd4
e86e768https://github.com/refack/node/commit/e86e7689e38b72e25e0de5676215a06a69210bd4
nodejs#18603https://github.com/nodejs/node/issues/18603
nodejs#18904https://github.com/nodejs/node/pull/18904
nodejs#23916https://github.com/nodejs/node/pull/23916
BethGriggshttps://github.com/BethGriggs
Apr 17, 2019 https://github.com/nodejs/node/pull/18904#ref-commit-b364fa3
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/BethGriggs
readline: add support for async iterationhttps://github.com/nodejs/node/commit/b364fa341db5e69edc73b1a784cbee9d355dbada
b364fa3https://github.com/nodejs/node/commit/b364fa341db5e69edc73b1a784cbee9d355dbada
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
BethGriggshttps://github.com/BethGriggs
Apr 28, 2019 https://github.com/nodejs/node/pull/18904#ref-commit-a0a3095
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/BethGriggs
readline: add support for async iterationhttps://github.com/nodejs/node/commit/a0a3095aab402884f4e893112982b386989f15df
a0a3095https://github.com/nodejs/node/commit/a0a3095aab402884f4e893112982b386989f15df
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
MylesBorinshttps://github.com/MylesBorins
May 16, 2019 https://github.com/nodejs/node/pull/18904#ref-commit-d3f15b0
https://github.com/TimothyGu
https://github.com/prog1dev
https://github.com/MylesBorins
readline: add support for async iterationhttps://github.com/nodejs/node/commit/d3f15b0ffb48f1ef8c38cba3c20aedecd8cd57b7
d3f15b0https://github.com/nodejs/node/commit/d3f15b0ffb48f1ef8c38cba3c20aedecd8cd57b7
#18603https://github.com/nodejs/node/issues/18603
#18904https://github.com/nodejs/node/pull/18904
#23916https://github.com/nodejs/node/pull/23916
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18904
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/18904/files/e3532d88b34420357b4a62eb0d194d1980450519
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/18904/files/e3532d88b34420357b4a62eb0d194d1980450519
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/18904/files/e3532d88b34420357b4a62eb0d194d1980450519
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/18904/files/2f5c5584276eaa7160c295425f228f5106e925df
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/18904/files/e3532d88b34420357b4a62eb0d194d1980450519
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/18904/files/e3532d88b34420357b4a62eb0d194d1980450519
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
readline https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/18904
https://github.com/prog1dev
https://github.com/mcollina
https://github.com/vsemozhetbyt
https://github.com/BridgeAR
https://github.com/TimothyGu
https://github.com/jasnell
https://github.com/mscdex
https://github.com/Trott
https://github.com/targos
https://github.com/devsnek
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.