René's URL Explorer Experiment


Title: test: make tls test more rigorous by bnoordhuis · Pull Request #18792 · nodejs/node · GitHub

Open Graph Title: test: make tls test more rigorous by bnoordhuis · Pull Request #18792 · nodejs/node

X Title: test: make tls test more rigorous by bnoordhuis · Pull Request #18792 · nodejs/node

Description: exit naturally, don't use process.exit() ensure callbacks are actually called

Open Graph Description: exit naturally, don't use process.exit() ensure callbacks are actually called

X Description: exit naturally, don't use process.exit() ensure callbacks are actually called

Opengraph URL: https://github.com/nodejs/node/pull/18792

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a4df8f7-8dea-5e47-1d99-609d190def7a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD044:231D79:24EA5B2:309A7D1:696B1B04
html-safe-nonce9cb2dd7e675fd8380e81707160eeed2c76b119f52ffee34ecf2c2604635bd749
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDQ0OjIzMUQ3OToyNEVBNUIyOjMwOUE3RDE6Njk2QjFCMDQiLCJ2aXNpdG9yX2lkIjoiNDMzMDEwNzQxMDIxOTQ3MzY2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac92366b8671498d0845252fcf9ea59f9c829e0fa9f76341e2b4bac1516dbf6c78
hovercard-subject-tagpull_request:169333361
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18792/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/582e26f4700b056dd82479da53e4de3f31897054a9aa04d71db6db4a727dfbef/nodejs/node/pull/18792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/582e26f4700b056dd82479da53e4de3f31897054a9aa04d71db6db4a727dfbef/nodejs/node/pull/18792
og:image:altexit naturally, don't use process.exit() ensure callbacks are actually called
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18792#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18792
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18792
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18792
Reloadhttps://github.com/nodejs/node/pull/18792
Reloadhttps://github.com/nodejs/node/pull/18792
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18792
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/18792
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/18792#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:improve-tls-testhttps://github.com/bnoordhuis/io.js/tree/improve-tls-test
test: make tls test more rigorous https://github.com/nodejs/node/pull/18792#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:improve-tls-testhttps://github.com/bnoordhuis/io.js/tree/improve-tls-test
Conversation 2 https://github.com/nodejs/node/pull/18792
Commits 1 https://github.com/nodejs/node/pull/18792/commits
Checks 0 https://github.com/nodejs/node/pull/18792/checks
Files changed https://github.com/nodejs/node/pull/18792/files
Please reload this pagehttps://github.com/nodejs/node/pull/18792
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 15, 2018https://github.com/nodejs/node/pull/18792#issue-297395738
Please reload this pagehttps://github.com/nodejs/node/pull/18792
https://github.com/bnoordhuis
test: make tls test more rigoroushttps://github.com/nodejs/node/pull/18792/commits/a3f0ea5cc240ea1707190673585648625cf9541a
a3f0ea5https://github.com/nodejs/node/pull/18792/commits/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Feb 15, 2018https://github.com/nodejs/node/pull/18792#event-1475565710
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96798996
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96799350
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96824446
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96838325
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96851639
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96854904
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/mmarchini
mmarchinihttps://github.com/mmarchini
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96975768
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 15, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-96990685
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 16, 2018 https://github.com/nodejs/node/pull/18792#pullrequestreview-97149553
View reviewed changes https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 16, 2018https://github.com/nodejs/node/pull/18792#issuecomment-366291283
https://ci.nodejs.org/job/node-test-pull-request/13211/https://ci.nodejs.org/job/node-test-pull-request/13211/
Please reload this pagehttps://github.com/nodejs/node/pull/18792
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 16, 2018https://github.com/nodejs/node/pull/18792#event-1478410563
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 16, 2018https://github.com/nodejs/node/pull/18792#issuecomment-366317706
3c29adbhttps://github.com/nodejs/node/commit/3c29adb84fac00dfc16c51725e4832789610c6a7
Please reload this pagehttps://github.com/nodejs/node/pull/18792
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 16, 2018https://github.com/nodejs/node/pull/18792#event-1478425006
BridgeARhttps://github.com/BridgeAR
Feb 16, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-3c29adb
https://github.com/bnoordhuis
https://github.com/BridgeAR
test: make tls test more rigoroushttps://github.com/BridgeAR/node/commit/3c29adb84fac00dfc16c51725e4832789610c6a7
3c29adbhttps://github.com/BridgeAR/node/commit/3c29adb84fac00dfc16c51725e4832789610c6a7
nodejs#18792https://github.com/nodejs/node/pull/18792
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-80e1cb7
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: make tls test more rigoroushttps://github.com/nodejs/node/commit/80e1cb7ed57a7fd8241b8236e02408f38a626b8f
80e1cb7https://github.com/nodejs/node/commit/80e1cb7ed57a7fd8241b8236e02408f38a626b8f
#18792https://github.com/nodejs/node/pull/18792
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18792#ref-pullrequest-299038228
v9.6.0 proposal #18902 https://github.com/nodejs/node/pull/18902
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-849f5c3
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: make tls test more rigoroushttps://github.com/nodejs/node/commit/849f5c31c846fa712fa60a84b5d4e9753ff22510
849f5c3https://github.com/nodejs/node/commit/849f5c31c846fa712fa60a84b5d4e9753ff22510
#18792https://github.com/nodejs/node/pull/18792
MayaLekovahttps://github.com/MayaLekova
May 8, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-35a9b72
https://github.com/bnoordhuis
https://github.com/MayaLekova
test: make tls test more rigoroushttps://github.com/MayaLekova/node/commit/35a9b728e6fd4eb49b9126b9b01a77ba0b49c6c7
35a9b72https://github.com/MayaLekova/node/commit/35a9b728e6fd4eb49b9126b9b01a77ba0b49c6c7
nodejs#18792https://github.com/nodejs/node/pull/18792
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Aug 7, 2018https://github.com/nodejs/node/pull/18792#event-1775919482
MylesBorinshttps://github.com/MylesBorins
Aug 7, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-077fb0a
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: make tls test more rigoroushttps://github.com/nodejs/node/commit/077fb0a2fb2bb567083809a4722f5f9398b46d20
077fb0ahttps://github.com/nodejs/node/commit/077fb0a2fb2bb567083809a4722f5f9398b46d20
#18792https://github.com/nodejs/node/pull/18792
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
dont-land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v8.x
Aug 7, 2018https://github.com/nodejs/node/pull/18792#event-1775936920
MylesBorinshttps://github.com/MylesBorins
Aug 7, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-d46ae57
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: make tls test more rigoroushttps://github.com/nodejs/node/commit/d46ae57324536f00ea98a162c05ef42653b95357
d46ae57https://github.com/nodejs/node/commit/d46ae57324536f00ea98a162c05ef42653b95357
#18792https://github.com/nodejs/node/pull/18792
MylesBorinshttps://github.com/MylesBorins
Aug 9, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-aeb0f96
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: make tls test more rigoroushttps://github.com/nodejs/node/commit/aeb0f96260c2e59206060800623049c9127bdd7a
aeb0f96https://github.com/nodejs/node/commit/aeb0f96260c2e59206060800623049c9127bdd7a
#18792https://github.com/nodejs/node/pull/18792
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2018 https://github.com/nodejs/node/pull/18792#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
MylesBorinshttps://github.com/MylesBorins
Aug 16, 2018 https://github.com/nodejs/node/pull/18792#ref-commit-f534bd8
https://github.com/bnoordhuis
https://github.com/MylesBorins
test: make tls test more rigoroushttps://github.com/nodejs/node/commit/f534bd889ab0013437087ed49b89f66e5702c387
f534bd8https://github.com/nodejs/node/commit/f534bd889ab0013437087ed49b89f66e5702c387
#18792https://github.com/nodejs/node/pull/18792
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18792
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/evanlucas
evanlucas https://github.com/evanlucas
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
https://github.com/mmarchini
mmarchini https://github.com/mmarchini
https://github.com/nodejs/node/pull/18792/files/a3f0ea5cc240ea1707190673585648625cf9541a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/18792
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/evanlucas
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/mmarchini
https://github.com/richardlau
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.