René's URL Explorer Experiment


Title: test: more test coverage for maxConnections by Trott · Pull Request #1855 · nodejs/node · GitHub

Open Graph Title: test: more test coverage for maxConnections by Trott · Pull Request #1855 · nodejs/node

X Title: test: more test coverage for maxConnections by Trott · Pull Request #1855 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If the server is not accepting connections because maxConnections is exceeded, the server should start accepting connections again when a connection closes. Eliminates a TODO comment. ref: #264

X Description: If the server is not accepting connections because maxConnections is exceeded, the server should start accepting connections again when a connection closes. Eliminates a TODO comment. ref: #264

Opengraph URL: https://github.com/nodejs/node/pull/1855

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76b84807-fb36-ea41-7a38-4a589423cb49
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE940:D9F0:18BA869:1F7236D:699189D0
html-safe-nonceca8dae3c917f80f25008a67601148aff360b669e7a69173a39c65680ac828464
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTQwOkQ5RjA6MThCQTg2OToxRjcyMzZEOjY5OTE4OUQwIiwidmlzaXRvcl9pZCI6IjM4MDcxNDg3MzA1MTczOTE4MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7b7cbf83244c56bbd8c483d21395f4566968bfcc081164417d62806f459ade95
hovercard-subject-tagpull_request:36588527
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1855/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2b0b0460ffa1e5eace0bbb12c49a3158f18cc72683d875fbfa127097b176bb55/nodejs/node/pull/1855
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b0b0460ffa1e5eace0bbb12c49a3158f18cc72683d875fbfa127097b176bb55/nodejs/node/pull/1855
og:image:altIf the server is not accepting connections because maxConnections is exceeded, the server should start accepting connections again when a connection closes. Eliminates a TODO comment. ref: #264
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1855#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1855
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1855
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1855
Reloadhttps://github.com/nodejs/node/pull/1855
Reloadhttps://github.com/nodejs/node/pull/1855
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1855
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:maxconnecthttps://github.com/Trott/io.js/tree/maxconnect
Conversationhttps://github.com/nodejs/node/pull/1855
Commits1 (1)https://github.com/nodejs/node/pull/1855/commits
Checkshttps://github.com/nodejs/node/pull/1855/checks
Files changedhttps://github.com/nodejs/node/pull/1855/files
test: more test coverage for maxConnectionshttps://github.com/nodejs/node/pull/1855#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:maxconnecthttps://github.com/Trott/io.js/tree/maxconnect
https://github.com/Trott
Trotthttps://github.com/Trott
May 31, 2015https://github.com/nodejs/node/pull/1855#issue-83176637
#264https://github.com/nodejs/node/issues/264
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/mscdex
mscdexhttps://github.com/mscdex
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
May 31, 2015https://github.com/nodejs/node/pull/1855#event-318256311
brendanashworthhttps://github.com/brendanashworth
May 31, 2015 https://github.com/nodejs/node/pull/1855#discussion-diff-31394737
View reviewed changes https://github.com/nodejs/node/pull/1855/files/f13c5537027403de932cf96626d3478f50f29610#diff-0f06ce9053b29e247f39b4cc03e9d18c36ba55175ea602dc0cbd8bcddac768a8
test/parallel/test-net-server-max-connections-close-makes-more-available.jshttps://github.com/nodejs/node/pull/1855/files#diff-0f06ce9053b29e247f39b4cc03e9d18c36ba55175ea602dc0cbd8bcddac768a8
brendanashworthhttps://github.com/brendanashworth
May 31, 2015https://github.com/nodejs/node/pull/1855#discussion_r31394737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/f13c5537027403de932cf96626d3478f50f29610..f5f0b93265c7229b1f6a7e07e606ec37bc242783
f13c553https://github.com/nodejs/node/commit/f13c5537027403de932cf96626d3478f50f29610
f5f0b93https://github.com/nodejs/node/commit/f5f0b93265c7229b1f6a7e07e606ec37bc242783
Compare https://github.com/nodejs/node/compare/f13c5537027403de932cf96626d3478f50f29610..f5f0b93265c7229b1f6a7e07e606ec37bc242783
May 31, 2015 22:39https://github.com/nodejs/node/pull/1855#event-318285730
https://github.com/Trott
Trotthttps://github.com/Trott
May 31, 2015https://github.com/nodejs/node/pull/1855#issuecomment-107254551
@brendanashworthhttps://github.com/brendanashworth
Please reload this pagehttps://github.com/nodejs/node/pull/1855
brendanashworthhttps://github.com/brendanashworth
Jun 1, 2015 https://github.com/nodejs/node/pull/1855#discussion-diff-31402898
View reviewed changes https://github.com/nodejs/node/pull/1855/files/f5f0b93265c7229b1f6a7e07e606ec37bc242783#diff-0f06ce9053b29e247f39b4cc03e9d18c36ba55175ea602dc0cbd8bcddac768a8
test/parallel/test-net-server-max-connections-close-makes-more-available.jshttps://github.com/nodejs/node/pull/1855/files#diff-0f06ce9053b29e247f39b4cc03e9d18c36ba55175ea602dc0cbd8bcddac768a8
brendanashworthhttps://github.com/brendanashworth
Jun 1, 2015https://github.com/nodejs/node/pull/1855#discussion_r31402898
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 1, 2015https://github.com/nodejs/node/pull/1855#issuecomment-107329384
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/f5f0b93265c7229b1f6a7e07e606ec37bc242783..82bb18cfbb4536fdb5c69f2fe9f558485a09d298
f5f0b93https://github.com/nodejs/node/commit/f5f0b93265c7229b1f6a7e07e606ec37bc242783
82bb18chttps://github.com/nodejs/node/commit/82bb18cfbb4536fdb5c69f2fe9f558485a09d298
Compare https://github.com/nodejs/node/compare/f5f0b93265c7229b1f6a7e07e606ec37bc242783..82bb18cfbb4536fdb5c69f2fe9f558485a09d298
June 2, 2015 05:25https://github.com/nodejs/node/pull/1855#event-319635253
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 2, 2015https://github.com/nodejs/node/pull/1855#issuecomment-107811851
@brendanashworthhttps://github.com/brendanashworth
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581
311c3e4https://github.com/nodejs/node/commit/311c3e4371ee520a977a7e895c280f326cb85732
b926718https://github.com/nodejs/node/commit/b9267189a58e48e587faec78a5e83b6bbfc72581
Compare https://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581
June 2, 2015 17:25https://github.com/nodejs/node/pull/1855#event-320249180
brendanashworthhttps://github.com/brendanashworth
Jun 3, 2015 https://github.com/nodejs/node/pull/1855#discussion-diff-31591798
View reviewed changes https://github.com/nodejs/node/pull/1855/files/82bb18cfbb4536fdb5c69f2fe9f558485a09d298#diff-0f06ce9053b29e247f39b4cc03e9d18c36ba55175ea602dc0cbd8bcddac768a8
test/parallel/test-net-server-max-connections-close-makes-more-available.jshttps://github.com/nodejs/node/pull/1855/files#diff-0f06ce9053b29e247f39b4cc03e9d18c36ba55175ea602dc0cbd8bcddac768a8
brendanashworthhttps://github.com/brendanashworth
Jun 3, 2015https://github.com/nodejs/node/pull/1855#discussion_r31591798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 3, 2015https://github.com/nodejs/node/pull/1855#issuecomment-108179203
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/Trott
test: more test coverage for maxConnectionshttps://github.com/nodejs/node/pull/1855/commits/b8ed63cb4645ee95af40ce4b3a7d8c91fbc19255
b8ed63chttps://github.com/nodejs/node/pull/1855/commits/b8ed63cb4645ee95af40ce4b3a7d8c91fbc19255
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/82bb18cfbb4536fdb5c69f2fe9f558485a09d298..b8ed63cb4645ee95af40ce4b3a7d8c91fbc19255
82bb18chttps://github.com/nodejs/node/commit/82bb18cfbb4536fdb5c69f2fe9f558485a09d298
b8ed63chttps://github.com/nodejs/node/commit/b8ed63cb4645ee95af40ce4b3a7d8c91fbc19255
Compare https://github.com/nodejs/node/compare/82bb18cfbb4536fdb5c69f2fe9f558485a09d298..b8ed63cb4645ee95af40ce4b3a7d8c91fbc19255
June 3, 2015 03:51https://github.com/nodejs/node/pull/1855#event-320725734
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 3, 2015https://github.com/nodejs/node/pull/1855#issuecomment-108182343
Please reload this pagehttps://github.com/nodejs/node/pull/1855
brendanashworthhttps://github.com/brendanashworth
Jun 3, 2015 https://github.com/nodejs/node/pull/1855#ref-commit-bd99e8d
https://github.com/Trott
https://github.com/brendanashworth
test: more test coverage for maxConnectionshttps://github.com/nodejs/node/commit/bd99e8de8e41b4e86591f4fd50fa2e8cae42bb3c
bd99e8dhttps://github.com/nodejs/node/commit/bd99e8de8e41b4e86591f4fd50fa2e8cae42bb3c
#1855https://github.com/nodejs/node/pull/1855
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 3, 2015https://github.com/nodejs/node/pull/1855#issuecomment-108185224
bd99e8dhttps://github.com/nodejs/node/commit/bd99e8de8e41b4e86591f4fd50fa2e8cae42bb3c
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
Jun 3, 2015https://github.com/nodejs/node/pull/1855#event-320736306
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jun 3, 2015 https://github.com/nodejs/node/pull/1855#ref-pullrequest-84466830
test: fix net-server-max-connections-close-makes-more-available #1881 https://github.com/nodejs/node/pull/1881
andrewdeandradehttps://github.com/andrewdeandrade
Jun 3, 2015 https://github.com/nodejs/node/pull/1855#ref-commit-ae03f12
https://github.com/Trott
https://github.com/andrewdeandrade
test: more test coverage for maxConnectionshttps://github.com/andrewdeandrade/node/commit/ae03f120fe1907c57e9d3fb0d4907e8842f8ebbf
ae03f12https://github.com/andrewdeandrade/node/commit/ae03f120fe1907c57e9d3fb0d4907e8842f8ebbf
nodejs/node#1855https://github.com/nodejs/node/pull/1855
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 4, 2015 https://github.com/nodejs/node/pull/1855#ref-pullrequest-84737415
[libuv] upgrade to 1.6.0 #1889 https://github.com/nodejs/node/pull/1889
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jun 11, 2015 https://github.com/nodejs/node/pull/1855#ref-issue-87035908
Release proposal: 2.3.0 #1939 https://github.com/nodejs/node/issues/1939
https://github.com/Trott
Trotthttps://github.com/Trott
October 14, 2021 13:47https://github.com/nodejs/node/pull/1855#event-5463976092
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1855
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/1855
https://github.com/Trott
https://github.com/brendanashworth
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.