René's URL Explorer Experiment


Title: fs: check argument type on createStream method by yosuke-furukawa · Pull Request #1845 · nodejs/node · GitHub

Open Graph Title: fs: check argument type on createStream method by yosuke-furukawa · Pull Request #1845 · nodejs/node

X Title: fs: check argument type on createStream method by yosuke-furukawa · Pull Request #1845 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: separeted #1412 On Node.js v0.12 // illegal option but does not throw an Error, just ignore. fs.createReadStream('foo.txt', 'utf8'); // illegal option but does not throw an Error, ...

X Description: separeted #1412 On Node.js v0.12 // illegal option but does not throw an Error, just ignore. fs.createReadStream('foo.txt', 'utf8'); // illegal option but does not ...

Opengraph URL: https://github.com/nodejs/node/pull/1845

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:03544eed-c04c-3b03-e3e8-4e7fd3b53c40
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD2A:22CA14:E61AB3:12C9424:6AED5606
html-safe-nonce93dca4faf693d52fda06dabc85d1902f515c3e5f43feb48a2e1c3a2677fb324b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDJBOjIyQ0ExNDpFNjFBQjM6MTJDOTQyNDo2QUVENTYwNiIsInZpc2l0b3JfaWQiOiIxODU2NzUxNjY5OTQwNjcyMDA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2365826dd24b3a9ea4d01a56279397eb07ced952b4c57cc34f790bdaf3941036
hovercard-subject-tagpull_request:36570444
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1845/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/041f4299a3e9597cc2c71776fe2d79e2cc99e5a171f6a02b6135aa38d2283252/nodejs/node/pull/1845
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/041f4299a3e9597cc2c71776fe2d79e2cc99e5a171f6a02b6135aa38d2283252/nodejs/node/pull/1845
og:image:altsepareted #1412 On Node.js v0.12 // illegal option but does not throw an Error, just ignore. fs.createReadStream('foo.txt', 'utf8'); // illegal option but does not throw an Error, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyosuke-furukawa
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1845#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1845
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1845
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1845
Reloadhttps://github.com/nodejs/node/pull/1845
Reloadhttps://github.com/nodejs/node/pull/1845
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
yosuke-furukawahttps://github.com/yosuke-furukawa
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/1845
Commits1 (1)https://github.com/nodejs/node/pull/1845/commits
Checkshttps://github.com/nodejs/node/pull/1845/checks
Files changedhttps://github.com/nodejs/node/pull/1845/files
fs: check argument type on createStream methodhttps://github.com/nodejs/node/pull/1845#top
yosuke-furukawahttps://github.com/yosuke-furukawa
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
May 30, 2015https://github.com/nodejs/node/pull/1845#issue-82889047
#1412https://github.com/nodejs/node/pull/1412
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
May 30, 2015https://github.com/nodejs/node/pull/1845#issuecomment-107077111
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/mscdex
mscdexhttps://github.com/mscdex
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
May 30, 2015https://github.com/nodejs/node/pull/1845#event-317954714
brendanashworthhttps://github.com/brendanashworth
May 30, 2015 https://github.com/nodejs/node/pull/1845#discussion-diff-31383769
View reviewed changes https://github.com/nodejs/node/pull/1845/files/af28ca8100c448fda0da90743ec25d5aed835a2d#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/fs.jshttps://github.com/nodejs/node/pull/1845/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
brendanashworthhttps://github.com/brendanashworth
May 30, 2015https://github.com/nodejs/node/pull/1845#discussion_r31383769
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
cjihrighttps://github.com/cjihrig
May 30, 2015https://github.com/nodejs/node/pull/1845#discussion_r31383800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
yosuke-furukawahttps://github.com/yosuke-furukawa
May 31, 2015https://github.com/nodejs/node/pull/1845#discussion_r31393037
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
cjihrighttps://github.com/cjihrig
Jun 1, 2015https://github.com/nodejs/node/pull/1845#discussion_r31434543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
brendanashworthhttps://github.com/brendanashworth
Jun 1, 2015https://github.com/nodejs/node/pull/1845#discussion_r31446660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
cjihrighttps://github.com/cjihrig
Jun 1, 2015https://github.com/nodejs/node/pull/1845#discussion_r31447069
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
thefourtheyehttps://github.com/thefourtheye
Jun 1, 2015https://github.com/nodejs/node/pull/1845#discussion_r31447261
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 1, 2015https://github.com/nodejs/node/pull/1845#discussion_r31453308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/silverwind
silverwindhttps://github.com/silverwind
force-pushedhttps://github.com/nodejs/node/compare/9396d85217983714cc88e64ab743e6accaecb124..4d6b768e5d8d04c76eb1d13bb3750dcc8d9935b2
9396d85https://github.com/nodejs/node/commit/9396d85217983714cc88e64ab743e6accaecb124
4d6b768https://github.com/nodejs/node/commit/4d6b768e5d8d04c76eb1d13bb3750dcc8d9935b2
Compare https://github.com/nodejs/node/compare/9396d85217983714cc88e64ab743e6accaecb124..4d6b768e5d8d04c76eb1d13bb3750dcc8d9935b2
May 31, 2015 18:38https://github.com/nodejs/node/pull/1845#event-318235279
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 1, 2015 https://github.com/nodejs/node/pull/1845#discussion-diff-31455838
View reviewed changes https://github.com/nodejs/node/pull/1845/files/27b57a54da3379dcb170d836aee0eece3d083638#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/fs.jshttps://github.com/nodejs/node/pull/1845/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 1, 2015https://github.com/nodejs/node/pull/1845#discussion_r31455838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
fs: check argument type on createStream methodhttps://github.com/nodejs/node/pull/1845/commits/cef9da0412b8fbfa7d3aa73665ed29c546125df6
cef9da0https://github.com/nodejs/node/pull/1845/commits/cef9da0412b8fbfa7d3aa73665ed29c546125df6
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 2, 2015https://github.com/nodejs/node/pull/1845#issuecomment-107799721
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jun 2, 2015https://github.com/nodejs/node/pull/1845#event-320204621
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 2, 2015https://github.com/nodejs/node/pull/1845#issuecomment-108008947
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/754/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/754/
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581
311c3e4https://github.com/nodejs/node/commit/311c3e4371ee520a977a7e895c280f326cb85732
b926718https://github.com/nodejs/node/commit/b9267189a58e48e587faec78a5e83b6bbfc72581
Compare https://github.com/nodejs/node/compare/311c3e4371ee520a977a7e895c280f326cb85732..b9267189a58e48e587faec78a5e83b6bbfc72581
June 2, 2015 17:25https://github.com/nodejs/node/pull/1845#event-320249178
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 5, 2015https://github.com/nodejs/node/pull/1845#issuecomment-109126712
Please reload this pagehttps://github.com/nodejs/node/pull/1845
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 5, 2015 https://github.com/nodejs/node/pull/1845#ref-commit-353e26e
https://github.com/yosuke-furukawa
fs: Add string encoding option for Stream methodhttps://github.com/nodejs/node/commit/353e26e3c7ed9d160028ea7517d05edbebab5e7d
353e26ehttps://github.com/nodejs/node/commit/353e26e3c7ed9d160028ea7517d05edbebab5e7d
#1845https://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 5, 2015https://github.com/nodejs/node/pull/1845#issuecomment-109134229
353e26ehttps://github.com/nodejs/node/commit/353e26e3c7ed9d160028ea7517d05edbebab5e7d
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 5, 2015https://github.com/nodejs/node/pull/1845#event-323149480
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jun 11, 2015 https://github.com/nodejs/node/pull/1845#ref-issue-87035908
Release proposal: 2.3.0 #1939 https://github.com/nodejs/node/issues/1939
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jun 15, 2015https://github.com/nodejs/node/pull/1845#issuecomment-112126881
@yosuke-furukawahttps://github.com/yosuke-furukawa
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Jun 15, 2015https://github.com/nodejs/node/pull/1845#issuecomment-112145485
#1412https://github.com/nodejs/node/pull/1412
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 17, 2019 https://github.com/nodejs/node/pull/1845#ref-pullrequest-479370396
fs: allow overring fs for streams #29083 https://github.com/nodejs/node/pull/29083
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1845
Please reload this pagehttps://github.com/nodejs/node/pull/1845
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/1845
https://github.com/yosuke-furukawa
https://github.com/Fishrock123
https://github.com/thefourtheye
https://github.com/cjihrig
https://github.com/brendanashworth
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.