| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b7481753-632b-64a2-236e-44a3fce10388 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C920:2F179B:27E96:332C4:696AF892 |
| html-safe-nonce | d40e9dde3e11e524e55ab9451a4c2f735fe9b55703ae62003b073c07afb659d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTIwOjJGMTc5QjoyN0U5NjozMzJDNDo2OTZBRjg5MiIsInZpc2l0b3JfaWQiOiI3NTA5MTAzODQ4OTM3MTU4ODAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e00ab5c9d3b79cf9e45f60d762dc2daf3ec1a8181b0ba298518f5bc5ab879889 |
| hovercard-subject-tag | pull_request:165861552 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18445/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/afbaeda5ab54149df86394e1f504cda1695630bbaceb238851c28f4bc71103eb/nodejs/node/pull/18445 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/afbaeda5ab54149df86394e1f504cda1695630bbaceb238851c28f4bc71103eb/nodejs/node/pull/18445 |
| og:image:alt | When #16939 landed it broke the linter on master. This fixes that issue.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected cor... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | apapirovski |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/18445#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18445 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18445 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/18445 |
| Reload | https://github.com/nodejs/node/pull/18445 |
| Reload | https://github.com/nodejs/node/pull/18445 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/18445#issue-comment-box |
| apapirovski | https://github.com/apapirovski |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| apapirovski:fix-16939 | https://github.com/apapirovski/node/tree/fix-16939 |
|
tools: fix icu README lint error
| https://github.com/nodejs/node/pull/18445#top |
| apapirovski | https://github.com/apapirovski |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| apapirovski:fix-16939 | https://github.com/apapirovski/node/tree/fix-16939 |
|
Conversation
4
| https://github.com/nodejs/node/pull/18445 |
|
Commits
1
| https://github.com/nodejs/node/pull/18445/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/18445/checks |
|
Files changed
| https://github.com/nodejs/node/pull/18445/files |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#issue-292618423 |
| #16939 | https://github.com/nodejs/node/pull/16939 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
|
| https://github.com/apapirovski |
| tools: fix icu readme lint error | https://github.com/nodejs/node/pull/18445/commits/34142cd7e5662022796ce5bb2d891a9c7061b08e |
| 34142cd | https://github.com/nodejs/node/pull/18445/commits/34142cd7e5662022796ce5bb2d891a9c7061b08e |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#event-1447591713 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#event-1447591782 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
Jan 30, 2018
| https://github.com/nodejs/node/pull/18445#ref-pullrequest-292613243 |
|
doc: linkify missing types
#18444
| https://github.com/nodejs/node/pull/18444 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#issuecomment-361442726 |
| https://ci.nodejs.org/job/node-test-pull-request-lite/134/ | https://ci.nodejs.org/job/node-test-pull-request-lite/134/ |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#event-1447596430 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 30, 2018
| https://github.com/nodejs/node/pull/18445#pullrequestreview-92414995 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18445/files/34142cd7e5662022796ce5bb2d891a9c7061b08e |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jan 30, 2018
| https://github.com/nodejs/node/pull/18445#pullrequestreview-92415571 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18445/files/34142cd7e5662022796ce5bb2d891a9c7061b08e |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#issuecomment-361446107 |
| 6790ba9 | https://github.com/nodejs/node/commit/6790ba9ed1d467e2295ae3779aaaf973bd04fca0 |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18445#event-1447612641 |
| https://github.com/apapirovski |
| apapirovski | https://github.com/apapirovski |
| January 30, 2018 01:28 | https://github.com/nodejs/node/pull/18445#event-1447612722 |
| apapirovski | https://github.com/apapirovski |
|
Jan 30, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-6790ba9 |
|
| https://github.com/apapirovski |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/6790ba9ed1d467e2295ae3779aaaf973bd04fca0 |
| 6790ba9 | https://github.com/nodejs/node/commit/6790ba9ed1d467e2295ae3779aaaf973bd04fca0 |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
Jan 30, 2018
| https://github.com/nodejs/node/pull/18445#pullrequestreview-92421299 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18445/files/34142cd7e5662022796ce5bb2d891a9c7061b08e |
| srl295 | https://github.com/srl295 |
| https://github.com/nodejs/node/pull/18445#pullrequestreview-92421299 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 20, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-f48b47c |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/f48b47c4cf4f50f5b8899415deef283b2cf7d0c4 |
| f48b47c | https://github.com/nodejs/node/commit/f48b47c4cf4f50f5b8899415deef283b2cf7d0c4 |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-3476b81 |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/3476b8124fa124213a798339cf92ae50c396bf31 |
| 3476b81 | https://github.com/nodejs/node/commit/3476b8124fa124213a798339cf92ae50c396bf31 |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-ef45bb4 |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/ef45bb430577472a7fa8f52f90e0ec0433ba68bb |
| ef45bb4 | https://github.com/nodejs/node/commit/ef45bb430577472a7fa8f52f90e0ec0433ba68bb |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 21, 2018
| https://github.com/nodejs/node/pull/18445#ref-pullrequest-299038228 |
|
v9.6.0 proposal
#18902
| https://github.com/nodejs/node/pull/18902 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Mar 20, 2018 | https://github.com/nodejs/node/pull/18445#event-1531262232 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 20, 2018 | https://github.com/nodejs/node/pull/18445#issuecomment-374647202 |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
| MayaLekova | https://github.com/MayaLekova |
|
May 8, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-a266b02 |
|
| https://github.com/apapirovski |
|
| https://github.com/MayaLekova |
| tools: fix icu readme lint error | https://github.com/MayaLekova/node/commit/a266b0256cfb1fa57a51cdddb376346634f507af |
| a266b02 | https://github.com/MayaLekova/node/commit/a266b0256cfb1fa57a51cdddb376346634f507af |
| nodejs#18445 | https://github.com/nodejs/node/pull/18445 |
| MylesBorins | https://github.com/MylesBorins |
|
May 23, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-de963da |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/de963dac91dd357e654623591328dd9d90716ebd |
| de963da | https://github.com/nodejs/node/commit/de963dac91dd357e654623591328dd9d90716ebd |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x |
| May 23, 2018 | https://github.com/nodejs/node/pull/18445#event-1642568336 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| May 23, 2018 | https://github.com/nodejs/node/pull/18445#event-1642568341 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 14, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-5686d64 |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/5686d64aa10786cd163e0a626d327903c09c58cb |
| 5686d64 | https://github.com/nodejs/node/commit/5686d64aa10786cd163e0a626d327903c09c58cb |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 9, 2018
| https://github.com/nodejs/node/pull/18445#ref-pullrequest-337147468 |
|
v8.12.0 proposal
#21593
| https://github.com/nodejs/node/pull/21593 |
| rvagg | https://github.com/rvagg |
|
Aug 16, 2018
| https://github.com/nodejs/node/pull/18445#ref-commit-ab967b7 |
|
| https://github.com/apapirovski |
|
| https://github.com/rvagg |
| tools: fix icu readme lint error | https://github.com/nodejs/node/commit/ab967b725e5c8cb9a7454372a2422a45dac49dfb |
| ab967b7 | https://github.com/nodejs/node/commit/ab967b725e5c8cb9a7454372a2422a45dac49dfb |
| #18445 | https://github.com/nodejs/node/pull/18445 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18445 |
|
| https://github.com/srl295 |
|
srl295
| https://github.com/srl295 |
|
| https://github.com/nodejs/node/pull/18445/files/34142cd7e5662022796ce5bb2d891a9c7061b08e |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/18445/files/34142cd7e5662022796ce5bb2d891a9c7061b08e |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/18445/files/34142cd7e5662022796ce5bb2d891a9c7061b08e |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/18445 |
|
| https://github.com/apapirovski |
|
| https://github.com/MylesBorins |
|
| https://github.com/srl295 |
|
| https://github.com/cjihrig |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |