René's URL Explorer Experiment


Title: fs: cleanup fd lchown and lchownSync by jasnell · Pull Request #18329 · nodejs/node · GitHub

Open Graph Title: fs: cleanup fd lchown and lchownSync by jasnell · Pull Request #18329 · nodejs/node

X Title: fs: cleanup fd lchown and lchownSync by jasnell · Pull Request #18329 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: lchown and lchownSync were opening file descriptors without closing them. Looks like it has been that way for 7 years. Does anyone actually use these functions? :-) Checklist make -j4 test (UNIX)...

X Description: lchown and lchownSync were opening file descriptors without closing them. Looks like it has been that way for 7 years. Does anyone actually use these functions? :-) Checklist make -j4 test (UNIX)...

Opengraph URL: https://github.com/nodejs/node/pull/18329

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e28c899f-c8c0-904f-978a-4a456817082e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC232:22DB63:21723D5:2AB33C8:6991ADC3
html-safe-nonce096d0c418e25d049a9a7bb89ef2e5ce1b9effba6e4746377c1676acde9070e4a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjMyOjIyREI2MzoyMTcyM0Q1OjJBQjMzQzg6Njk5MUFEQzMiLCJ2aXNpdG9yX2lkIjoiODU1NjE5MDE5OTY2MjYyMDA5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacba8a5b97ae780600edceb4da1397e58008b38240e86cfc41739f0884bb0d0984
hovercard-subject-tagpull_request:164716900
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18329/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3f82e375b1bd2292d7f7766e3b77f63b76af2bfbc2ac9b49fc358936fe978514/nodejs/node/pull/18329
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3f82e375b1bd2292d7f7766e3b77f63b76af2bfbc2ac9b49fc358936fe978514/nodejs/node/pull/18329
og:image:altlchown and lchownSync were opening file descriptors without closing them. Looks like it has been that way for 7 years. Does anyone actually use these functions? :-) Checklist make -j4 test (UNIX)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18329#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18329
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18329
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18329
Reloadhttps://github.com/nodejs/node/pull/18329
Reloadhttps://github.com/nodejs/node/pull/18329
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18329
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fs-fix-lchownhttps://github.com/jasnell/node/tree/fs-fix-lchown
Conversationhttps://github.com/nodejs/node/pull/18329
Commits1 (1)https://github.com/nodejs/node/pull/18329/commits
Checkshttps://github.com/nodejs/node/pull/18329/checks
Files changedhttps://github.com/nodejs/node/pull/18329/files
fs: cleanup fd lchown and lchownSynchttps://github.com/nodejs/node/pull/18329#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:fs-fix-lchownhttps://github.com/jasnell/node/tree/fs-fix-lchown
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 23, 2018https://github.com/nodejs/node/pull/18329#issue-291029266
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/18329
https://github.com/jasnell
fs: cleanup fd lchown and lchownSynchttps://github.com/nodejs/node/pull/18329/commits/26c2f26238a69b37321314024f000bc48fdae55e
26c2f26https://github.com/nodejs/node/pull/18329/commits/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jan 23, 2018https://github.com/nodejs/node/pull/18329#event-1438456329
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2018 https://github.com/nodejs/node/pull/18329#pullrequestreview-91019532
View reviewed changes https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Jan 23, 2018https://github.com/nodejs/node/pull/18329#event-1438464949
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 23, 2018 https://github.com/nodejs/node/pull/18329#pullrequestreview-91019878
View reviewed changes https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 23, 2018https://github.com/nodejs/node/pull/18329#issuecomment-359971997
https://ci.nodejs.org/job/node-test-pull-request/12695/https://ci.nodejs.org/job/node-test-pull-request/12695/
Please reload this pagehttps://github.com/nodejs/node/pull/18329
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Jan 23, 2018 https://github.com/nodejs/node/pull/18329#pullrequestreview-91024541
View reviewed changes https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 24, 2018 https://github.com/nodejs/node/pull/18329#pullrequestreview-91036298
View reviewed changes https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 24, 2018https://github.com/nodejs/node/pull/18329#issuecomment-360226792
Please reload this pagehttps://github.com/nodejs/node/pull/18329
jasnellhttps://github.com/jasnell
Jan 26, 2018 https://github.com/nodejs/node/pull/18329#ref-commit-082f952
https://github.com/jasnell
fs: cleanup fd lchown and lchownSynchttps://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab
082f952https://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab
#18329https://github.com/nodejs/node/pull/18329
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 26, 2018https://github.com/nodejs/node/pull/18329#issuecomment-360866438
Please reload this pagehttps://github.com/nodejs/node/pull/18329
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 26, 2018https://github.com/nodejs/node/pull/18329#event-1444121145
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Jan 30, 2018 https://github.com/nodejs/node/pull/18329#ref-pullrequest-292910934
v9.5.0 release proposal #18464 https://github.com/nodejs/node/pull/18464
evanlucashttps://github.com/evanlucas
Jan 30, 2018 https://github.com/nodejs/node/pull/18329#ref-commit-230a102
https://github.com/jasnell
https://github.com/evanlucas
fs: cleanup fd lchown and lchownSynchttps://github.com/nodejs/node/commit/230a1026471ca6bf94e830840a8938a8360af6ed
230a102https://github.com/nodejs/node/commit/230a1026471ca6bf94e830840a8938a8360af6ed
#18329https://github.com/nodejs/node/pull/18329
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v8.x
Feb 27, 2018https://github.com/nodejs/node/pull/18329#event-1493677224
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 27, 2018https://github.com/nodejs/node/pull/18329#issuecomment-368766487
Please reload this pagehttps://github.com/nodejs/node/pull/18329
#14055https://github.com/nodejs/node/pull/14055
created the leakhttps://github.com/nodejs/node/commit/18069523f87aa4c5f7d361201aa20745e2ede20e#diff-9a205ef7ee967ee32efee02e58b3482dR1106
6.xhttps://github.com/nodejs/node/blob/v6.x/lib/fs.js#L1154
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/18329
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Feb 27, 2018https://github.com/nodejs/node/pull/18329#event-1493686633
MylesBorinshttps://github.com/MylesBorins
Feb 27, 2018 https://github.com/nodejs/node/pull/18329#ref-commit-577933a
https://github.com/jasnell
https://github.com/MylesBorins
fs: cleanup fd lchown and lchownSynchttps://github.com/nodejs/node/commit/577933a7c67e389027fab3bb0e77715df5e03c7b
577933ahttps://github.com/nodejs/node/commit/577933a7c67e389027fab3bb0e77715df5e03c7b
#18329https://github.com/nodejs/node/pull/18329
MayaLekovahttps://github.com/MayaLekova
May 8, 2018 https://github.com/nodejs/node/pull/18329#ref-commit-5f45bf9
https://github.com/jasnell
https://github.com/MayaLekova
fs: cleanup fd lchown and lchownSynchttps://github.com/MayaLekova/node/commit/5f45bf9999640246021a30815e90d60c2d539f90
5f45bf9https://github.com/MayaLekova/node/commit/5f45bf9999640246021a30815e90d60c2d539f90
nodejs#18329https://github.com/nodejs/node/pull/18329
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18329
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
https://github.com/evanlucas
evanlucas https://github.com/evanlucas
https://github.com/nodejs/node/pull/18329/files/26c2f26238a69b37321314024f000bc48fdae55e
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/18329
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com/MylesBorins
https://github.com/evanlucas
https://github.com/addaleax
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.