| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:feeac1ba-3da1-e75b-7c6a-9c14483eafad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5B4:CF40E:DB2C90:12EF0C4:696A8D52 |
| html-safe-nonce | 7ec7078811c720707f737411b4813fe8f438ffc4141910a0dbfca599d7f671ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUI0OkNGNDBFOkRCMkM5MDoxMkVGMEM0OjY5NkE4RDUyIiwidmlzaXRvcl9pZCI6Ijc0OTEzODIxNDgxNTM5MDQ0NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a49520ad9a8dfb6530d2e8bb90508478e39b77ae2466880de83eb620cc661d13 |
| hovercard-subject-tag | pull_request:162806970 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18138/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f7ecf15387a49568e9373c84a6970b97b474b59fb4e2296f8d6f072fa5d50517/nodejs/node/pull/18138 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f7ecf15387a49568e9373c84a6970b97b474b59fb4e2296f8d6f072fa5d50517/nodejs/node/pull/18138 |
| og:image:alt | CCM ("Counter with Cipher Block Chaining-Message Authentication Code")
OpenSSL currently supports two AEAD algorithms, GCM and CCM. While node has supported GCM for years, CCM is a bit mo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/18138#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18138 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18138 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/18138 |
| Reload | https://github.com/nodejs/node/pull/18138 |
| Reload | https://github.com/nodejs/node/pull/18138 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/18138#issue-comment-box |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:ccm-is-still-weird | https://github.com/tniessen/node/tree/ccm-is-still-weird |
|
crypto: add support for AES-CCM
| https://github.com/nodejs/node/pull/18138#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:ccm-is-still-weird | https://github.com/tniessen/node/tree/ccm-is-still-weird |
|
Conversation
117
| https://github.com/nodejs/node/pull/18138 |
|
Commits
5
| https://github.com/nodejs/node/pull/18138/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/18138/checks |
|
Files changed
| https://github.com/nodejs/node/pull/18138/files |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 14, 2018 | https://github.com/nodejs/node/pull/18138#issue-288376913 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| @brycekahle | https://github.com/brycekahle |
| #2383 | https://github.com/nodejs/node/issues/2383 |
| pycryptodome | http://pycryptodome.readthedocs.io/en/latest/src/cipher/aes.html |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
| Jan 14, 2018 | https://github.com/nodejs/node/pull/18138#event-1423177484 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Jan 14, 2018 | https://github.com/nodejs/node/pull/18138#event-1423177493 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 15, 2018 | https://github.com/nodejs/node/pull/18138#event-1424222755 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jan 17, 2018 | https://github.com/nodejs/node/pull/18138#event-1427348323 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| force-pushed | https://github.com/nodejs/node/compare/991a94ceb98f035ccb07d61153a1a92533376022..6d0a3e0996b85b3f86a0e9cd9d0dcd46b76ae019 |
| 991a94c | https://github.com/nodejs/node/commit/991a94ceb98f035ccb07d61153a1a92533376022 |
| 6d0a3e0 | https://github.com/nodejs/node/commit/6d0a3e0996b85b3f86a0e9cd9d0dcd46b76ae019 |
|
Compare
| https://github.com/nodejs/node/compare/991a94ceb98f035ccb07d61153a1a92533376022..6d0a3e0996b85b3f86a0e9cd9d0dcd46b76ae019 |
| January 17, 2018 16:34 | https://github.com/nodejs/node/pull/18138#event-1428650776 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 17, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-358364087 |
| #18017 | https://github.com/nodejs/node/pull/18017 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 17, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-89529254 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files |
| lib/internal/crypto/cipher.js | https://github.com/nodejs/node/pull/18138/files#diff-a67ba473bd51070dc4bebcecd8cdc60166f57a48e9e1bebadb932d893a96565f |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 17, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-89529657 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/18138#pullrequestreview-89529657 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 17, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-358401231 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| January 21, 2018 13:10 | https://github.com/nodejs/node/pull/18138#event-1434049611 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/18138#ref-issue-280086996 |
|
Additional validation of tag length in AES GCM decryption
#17523
| https://github.com/nodejs/node/issues/17523 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 22, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-359462673 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-90516448 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jan 22, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-90474990 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/18138/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/18138/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/18138/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| lib/internal/crypto/cipher.js | https://github.com/nodejs/node/pull/18138/files#diff-a67ba473bd51070dc4bebcecd8cdc60166f57a48e9e1bebadb932d893a96565f |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| lib/internal/crypto/cipher.js | https://github.com/nodejs/node/pull/18138/files#diff-a67ba473bd51070dc4bebcecd8cdc60166f57a48e9e1bebadb932d893a96565f |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| force-pushed | https://github.com/nodejs/node/compare/be707a9284521a451622319b67dd45cb170aa665..78d0441c43bcd8a83f053778d0191d505d845ad1 |
| be707a9 | https://github.com/nodejs/node/commit/be707a9284521a451622319b67dd45cb170aa665 |
| 78d0441 | https://github.com/nodejs/node/commit/78d0441c43bcd8a83f053778d0191d505d845ad1 |
|
Compare
| https://github.com/nodejs/node/compare/be707a9284521a451622319b67dd45cb170aa665..78d0441c43bcd8a83f053778d0191d505d845ad1 |
| January 23, 2018 23:55 | https://github.com/nodejs/node/pull/18138#event-1438499336 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 24, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-359975177 |
| @bnoordhuis | https://github.com/bnoordhuis |
| #18138 (comment) | https://github.com/nodejs/node/pull/18138#discussion_r162945057 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jan 25, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-91579906 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| src/node_crypto.cc | https://github.com/nodejs/node/pull/18138/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| force-pushed | https://github.com/nodejs/node/compare/e2f87d406c9bdb51dc76e6efb361e559cc43d847..4c4dad07917ca375a9090323aaae3458e318cf2e |
| e2f87d4 | https://github.com/nodejs/node/commit/e2f87d406c9bdb51dc76e6efb361e559cc43d847 |
| 4c4dad0 | https://github.com/nodejs/node/commit/4c4dad07917ca375a9090323aaae3458e318cf2e |
|
Compare
| https://github.com/nodejs/node/compare/e2f87d406c9bdb51dc76e6efb361e559cc43d847..4c4dad07917ca375a9090323aaae3458e318cf2e |
| January 25, 2018 17:51 | https://github.com/nodejs/node/pull/18138#event-1442163858 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 26, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-360831622 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://ci.nodejs.org/job/node-test-commit-light/179/ | https://ci.nodejs.org/job/node-test-commit-light/179/ |
| https://ci.nodejs.org/job/node-test-pull-request/12752/ | https://ci.nodejs.org/job/node-test-pull-request/12752/ |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/maclover7 |
| maclover7 | https://github.com/maclover7 |
| force-pushed | https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c |
| bb5575a | https://github.com/nodejs/node/commit/bb5575aa75fd3071724d5eccde39a3041e1af57a |
| 993b716 | https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c |
|
Compare
| https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c |
| January 26, 2018 22:02 | https://github.com/nodejs/node/pull/18138#event-1444448882 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab |
| 993b716 | https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c |
| 082f952 | https://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab |
|
Compare
| https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab |
| January 26, 2018 22:36 | https://github.com/nodejs/node/pull/18138#event-1444493792 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 29, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-361251713 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| openssl/openssl@9cca7be | https://github.com/openssl/openssl/commit/9cca7be11d62298b2af0722f94345012c86eaed4 |
| @bnoordhuis | https://github.com/bnoordhuis |
| @jasnell | https://github.com/jasnell |
| conflicting line | https://github.com/openssl/openssl/blob/d11e6a4410d5aae70ad545d085d344644c33d9cc/crypto/evp/e_aes.c#L1281-L1285 |
| openssl/openssl#2550 (comment) | https://github.com/openssl/openssl/pull/2550#discussion_r99657275 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jan 29, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-361285873 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 29, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-361354041 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 30, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-361615629 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/bluetiger30 |
| bluetiger30 | https://github.com/bluetiger30 |
| Jan 31, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-361872790 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 31, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-361908529 |
| @bluetiger30 | https://github.com/bluetiger30 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-378677511 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| @addaleax | https://github.com/addaleax |
| #18138 (comment) | https://github.com/nodejs/node/pull/18138#issuecomment-375768055 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
tsc-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda |
| Apr 4, 2018 | https://github.com/nodejs/node/pull/18138#event-1557004862 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Apr 5, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-378799427 |
| #19794 | https://github.com/nodejs/node/pull/19794 |
| @tniessen | https://github.com/tniessen |
| #19794 | https://github.com/nodejs/node/pull/19794 |
| @tniessen | https://github.com/tniessen |
| @shigeki | https://github.com/shigeki |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Apr 5, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-378896253 |
| @shigeki | https://github.com/shigeki |
| https://ci.nodejs.org/job/node-test-commit-lite/589/ | https://ci.nodejs.org/job/node-test-commit-lite/589/ |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 5, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379097196 |
| @danbev | https://github.com/danbev |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Apr 5, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379108332 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Apr 5, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-109912002 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files/8715bb53b790afc15d52e060ac5c7fc73eeda50a |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 5, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379110769 |
| https://ci.nodejs.org/job/node-test-commit-linux/17674/ | https://ci.nodejs.org/job/node-test-commit-linux/17674/ |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| tniessen | https://github.com/tniessen |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-2a01ff8 |
|
| https://github.com/danbev |
|
| https://github.com/tniessen |
| test: fix multiple expectedWarnings bug | https://github.com/tniessen/node/commit/2a01ff85ded9fa703431fdbbd1378913e2025506 |
| 2a01ff8 | https://github.com/tniessen/node/commit/2a01ff85ded9fa703431fdbbd1378913e2025506 |
| 8fb4ea9 | https://github.com/tniessen/node/commit/8fb4ea9f75c8c82c46286bd5ca0c1115c4a5e956 |
| nodejs#18138 | https://github.com/nodejs/node/pull/18138 |
| nodejs#18138 | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Apr 6, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379120515 |
| @rvagg | https://github.com/rvagg |
| @Trott | https://github.com/Trott |
| tniessen@a191f6b | https://github.com/tniessen/node/commit/a191f6bbe79b05560048a21fe9d6faf1943939d1 |
| #19766 | https://github.com/nodejs/node/pull/19766 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| #19794 | https://github.com/nodejs/node/pull/19794 |
| https://ci.nodejs.org/job/node-test-commit/17477/ | https://ci.nodejs.org/job/node-test-commit/17477/ |
| #19766 | https://github.com/nodejs/node/pull/19766 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| danbev | https://github.com/danbev |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-682b850 |
|
| https://github.com/danbev |
| test: fix multiple expectedWarnings bug | https://github.com/nodejs/node/commit/682b85036efcaa87c580483f68ba71fbb13af4b9 |
| 682b850 | https://github.com/nodejs/node/commit/682b85036efcaa87c580483f68ba71fbb13af4b9 |
| 8fb4ea9 | https://github.com/nodejs/node/commit/8fb4ea9f75c8c82c46286bd5ca0c1115c4a5e956 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| #19766 | https://github.com/nodejs/node/pull/19766 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/18138#pullrequestreview-109925175 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/18138/files/8715bb53b790afc15d52e060ac5c7fc73eeda50a |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Apr 6, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379139591 |
| @tniessen | https://github.com/tniessen |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| tniessen | https://github.com/tniessen |
|
Apr 6, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-1e07acd |
|
| https://github.com/tniessen |
| crypto: add support for AES-CCM | https://github.com/nodejs/node/commit/1e07acd476309e7ddc4981160b89731b61a31179 |
| 1e07acd | https://github.com/nodejs/node/commit/1e07acd476309e7ddc4981160b89731b61a31179 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| #2383 | https://github.com/nodejs/node/issues/2383 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Apr 6, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379224170 |
| 1e07acd | https://github.com/nodejs/node/commit/1e07acd476309e7ddc4981160b89731b61a31179 |
| #19794 | https://github.com/nodejs/node/pull/19794 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Apr 6, 2018 | https://github.com/nodejs/node/pull/18138#event-1560692601 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Apr 6, 2018 | https://github.com/nodejs/node/pull/18138#event-1560698076 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Apr 6, 2018 | https://github.com/nodejs/node/pull/18138#issuecomment-379224996 |
| @Trott | https://github.com/Trott |
| nodejs/TSC#516 | https://github.com/nodejs/TSC/issues/516 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| tniessen | https://github.com/tniessen |
|
Apr 11, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-3bb9d4e |
|
| https://github.com/tniessen |
| doc: mention CCM along with GCM in crypto APIs | https://github.com/tniessen/node/commit/3bb9d4e760bce7c29369c6a763871c8b2fdbda4f |
| 3bb9d4e | https://github.com/tniessen/node/commit/3bb9d4e760bce7c29369c6a763871c8b2fdbda4f |
| nodejs#18138 | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Apr 11, 2018
| https://github.com/nodejs/node/pull/18138#ref-pullrequest-313317147 |
|
doc: mention CCM along with GCM in crypto APIs
#19945
| https://github.com/nodejs/node/pull/19945 |
| tniessen | https://github.com/tniessen |
|
Apr 13, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-04148b1 |
|
| https://github.com/tniessen |
| doc: mention CCM along with GCM in crypto APIs | https://github.com/nodejs/node/commit/04148b1121e6a63359a623729e3b717389f24539 |
| 04148b1 | https://github.com/nodejs/node/commit/04148b1121e6a63359a623729e3b717389f24539 |
| #19945 | https://github.com/nodejs/node/pull/19945 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Apr 15, 2018
| https://github.com/nodejs/node/pull/18138#ref-pullrequest-314374978 |
|
crypto: allow to restrict valid GCM tag length
#20039
| https://github.com/nodejs/node/pull/20039 |
| jasnell | https://github.com/jasnell |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-0d1b77e |
|
| https://github.com/tniessen |
|
| https://github.com/jasnell |
| doc: mention CCM along with GCM in crypto APIs | https://github.com/nodejs/node/commit/0d1b77eeb2ed81b3ab1c561e54f56f457b94f2a7 |
| 0d1b77e | https://github.com/nodejs/node/commit/0d1b77eeb2ed81b3ab1c561e54f56f457b94f2a7 |
| #19945 | https://github.com/nodejs/node/pull/19945 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| tniessen | https://github.com/tniessen |
|
Apr 26, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-c7ab3cf |
|
| https://github.com/tniessen |
| crypto: use new OpenSSL constants in CipherBase | https://github.com/tniessen/node/commit/c7ab3cf7e776c31dad0908b4033e705501731287 |
| c7ab3cf | https://github.com/tniessen/node/commit/c7ab3cf7e776c31dad0908b4033e705501731287 |
| nodejs#19794 | https://github.com/nodejs/node/pull/19794 |
| nodejs#18138 | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Apr 26, 2018
| https://github.com/nodejs/node/pull/18138#ref-pullrequest-318162996 |
|
crypto: use new OpenSSL constants in CipherBase
#20339
| https://github.com/nodejs/node/pull/20339 |
| tniessen | https://github.com/tniessen |
|
Apr 30, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-0e63724 |
|
| https://github.com/tniessen |
| crypto: use new OpenSSL constants in CipherBase | https://github.com/nodejs/node/commit/0e63724fe15e7ecd853399a039a10cc9f3e09958 |
| 0e63724 | https://github.com/nodejs/node/commit/0e63724fe15e7ecd853399a039a10cc9f3e09958 |
| #20339 | https://github.com/nodejs/node/pull/20339 |
| #19794 | https://github.com/nodejs/node/pull/19794 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| MylesBorins | https://github.com/MylesBorins |
|
May 4, 2018
| https://github.com/nodejs/node/pull/18138#ref-commit-dfcf20f |
|
| https://github.com/tniessen |
|
| https://github.com/MylesBorins |
| crypto: use new OpenSSL constants in CipherBase | https://github.com/nodejs/node/commit/dfcf20f5fd76fe5448115c7d448878868d8e7567 |
| dfcf20f | https://github.com/nodejs/node/commit/dfcf20f5fd76fe5448115c7d448878868d8e7567 |
| #20339 | https://github.com/nodejs/node/pull/20339 |
| #19794 | https://github.com/nodejs/node/pull/19794 |
| #18138 | https://github.com/nodejs/node/pull/18138 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Aug 11, 2018
| https://github.com/nodejs/node/pull/18138#ref-pullrequest-349668793 |
|
doc: require two approvals to land changes
#22255
| https://github.com/nodejs/node/pull/22255 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| May 15, 2019 | https://github.com/nodejs/node/pull/18138#issuecomment-492795365 |
| openssl/openssl@67c81ec | https://github.com/openssl/openssl/commit/67c81ec311d696464bdbf4c6d6f8a887a3ddf9f8 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18138 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/18138/files/69367bd482e08ba945d9378c453ee6683d06ef4b |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/18138/files/8e7680ce7c6ab87d3b5ddb9f318c61333c50608c |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/18138/files/e0b8e34c01f1c61e4b88cdcef6e6a7592c636263 |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/18138/files/8715bb53b790afc15d52e060ac5c7fc73eeda50a |
|
| https://github.com/rvagg |
|
rvagg
| https://github.com/rvagg |
|
| https://github.com/nodejs/node/pull/18138/files/8715bb53b790afc15d52e060ac5c7fc73eeda50a |
|
| https://github.com/shigeki |
|
shigeki
| https://github.com/shigeki |
|
| https://github.com/nodejs/node/pull/18138/files/e0b8e34c01f1c61e4b88cdcef6e6a7592c636263 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
10.0.0
| https://github.com/nodejs/node/milestone/26 |
| Please reload this page | https://github.com/nodejs/node/pull/18138 |
|
| https://github.com/tniessen |
|
| https://github.com/jasnell |
|
| https://github.com/bnoordhuis |
|
| https://github.com/bluetiger30 |
|
| https://github.com/rvagg |
|
| https://github.com/shigeki |
|
| https://github.com/BridgeAR |
|
| https://github.com/Trott |
|
| https://github.com/danbev |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |