René's URL Explorer Experiment


Title: Revert "src: remove unused function" by jasnell · Pull Request #18049 · nodejs/node · GitHub

Open Graph Title: Revert "src: remove unused function" by jasnell · Pull Request #18049 · nodejs/node

X Title: Revert "src: remove unused function" by jasnell · Pull Request #18049 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit d5cef71. Note: This targets v9.x-staging, not master This commit should not have landed as it was dependent on a semver-major. This should be fast tracked to unbreak v9.x-stagi...

X Description: This reverts commit d5cef71. Note: This targets v9.x-staging, not master This commit should not have landed as it was dependent on a semver-major. This should be fast tracked to unbreak v9.x-stagi...

Opengraph URL: https://github.com/nodejs/node/pull/18049

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a28787c4-674a-2dba-45f8-1ddc4d83ec68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8DA:1B00D1:321354:42349C:6A516A70
html-safe-nonce4e441153a0f4222f1816401ce63d4439763d2262f4a88d5e4285dc02c10f3b54
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOERBOjFCMDBEMTozMjEzNTQ6NDIzNDlDOjZBNTE2QTcwIiwidmlzaXRvcl9pZCI6Ijg5MzUwOTE1ODMxNjgxMTMyNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2acd74a5d345e157a0369e56fb97d430d60dfbfc2f7c3c04ad4d9593c63e3e56
hovercard-subject-tagpull_request:161761179
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18049/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8f06b5aa8d0343e353e73c0141114fb606dad6c152b24b4ea9e871329412083d/nodejs/node/pull/18049
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8f06b5aa8d0343e353e73c0141114fb606dad6c152b24b4ea9e871329412083d/nodejs/node/pull/18049
og:image:altThis reverts commit d5cef71. Note: This targets v9.x-staging, not master This commit should not have landed as it was dependent on a semver-major. This should be fast tracked to unbreak v9.x-stagi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release60eaaf6d4dbaa817031b556aebd8a0a7eeb81b97
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18049#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18049
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18049
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18049
Reloadhttps://github.com/nodejs/node/pull/18049
Reloadhttps://github.com/nodejs/node/pull/18049
Please reload this pagehttps://github.com/nodejs/node/pull/18049
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18049
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 980 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:v9.x-staginghttps://github.com/nodejs/node/tree/v9.x-staging
jasnell:revert-d5cef718https://github.com/jasnell/node/tree/revert-d5cef718
Conversationhttps://github.com/nodejs/node/pull/18049
Commits153 (153)https://github.com/nodejs/node/pull/18049/commits
Checkshttps://github.com/nodejs/node/pull/18049/checks
Files changedhttps://github.com/nodejs/node/pull/18049/files
Revert "src: remove unused function"https://github.com/nodejs/node/pull/18049#top
jasnellhttps://github.com/jasnell
nodejs:v9.x-staginghttps://github.com/nodejs/node/tree/v9.x-staging
jasnell:revert-d5cef718https://github.com/jasnell/node/tree/revert-d5cef718
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 9, 2018https://github.com/nodejs/node/pull/18049#issue-286935478
Please reload this pagehttps://github.com/nodejs/node/pull/18049
d5cef71https://github.com/nodejs/node/commit/d5cef7181e81719efaf00f5ddbde4cbb4f82ea84
#18048https://github.com/nodejs/node/issues/18048
@MylesBorinshttps://github.com/MylesBorins
@cjihrighttps://github.com/cjihrig
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/18049
cjihrighttps://github.com/cjihrig
January 8, 2018 02:21https://github.com/nodejs/node/pull/18049#commits-pushed-d5cef71
https://github.com/cjihrig
https://github.com/MylesBorins
src: remove unused functionhttps://github.com/nodejs/node/pull/18049/commits/d5cef7181e81719efaf00f5ddbde4cbb4f82ea84
d5cef71https://github.com/nodejs/node/pull/18049/commits/d5cef7181e81719efaf00f5ddbde4cbb4f82ea84
nodejs#17671https://github.com/nodejs/node/pull/17671
https://github.com/addaleax
https://github.com/MylesBorins
stream: remove undefined checkhttps://github.com/nodejs/node/pull/18049/commits/49472d658ef758eabb21aab332a869880c25df9a
49472d6https://github.com/nodejs/node/pull/18049/commits/49472d658ef758eabb21aab332a869880c25df9a
nodejs#17644https://github.com/nodejs/node/pull/17644
https://github.com/addaleax
https://github.com/MylesBorins
net: remove Socket.prototype.writehttps://github.com/nodejs/node/pull/18049/commits/be8284e2e08ba0cb8702888ef56e503d8bb3741f
be8284ehttps://github.com/nodejs/node/pull/18049/commits/be8284e2e08ba0cb8702888ef56e503d8bb3741f
nodejs#17644https://github.com/nodejs/node/pull/17644
https://github.com/MylesBorins
doc: add C++ style comments to the style guidehttps://github.com/nodejs/node/pull/18049/commits/3d375ee9c2fbbc4dd9c4d7a5239e6f011d1a49a9
3d375eehttps://github.com/nodejs/node/pull/18049/commits/3d375ee9c2fbbc4dd9c4d7a5239e6f011d1a49a9
nodejs#17617https://github.com/nodejs/node/pull/17617
https://github.com/bnoordhuis
https://github.com/MylesBorins
http: remove adapter frame from onParserExecutehttps://github.com/nodejs/node/pull/18049/commits/57be78a688daea6ac33589f439aef1a4d4b9b54f
57be78ahttps://github.com/nodejs/node/pull/18049/commits/57be78a688daea6ac33589f439aef1a4d4b9b54f
#3https://github.com/jasnell/node/pull/3
nodejs#17693https://github.com/nodejs/node/pull/17693
https://github.com/calvinmetcalf
https://github.com/MylesBorins
stream: add flow and buffer properties to streamshttps://github.com/nodejs/node/pull/18049/commits/5cabbe86379b7e105502c33f54913a5e4611fe00
5cabbe8https://github.com/nodejs/node/pull/18049/commits/5cabbe86379b7e105502c33f54913a5e4611fe00
nodejs#445https://github.com/nodejs/node/issues/445
nodejs#12855https://github.com/nodejs/node/pull/12855
https://github.com/Leko
https://github.com/MylesBorins
test: check socketOnDrain where needPause is falsehttps://github.com/nodejs/node/pull/18049/commits/ad9953929827d4c341beeec5a45823c41ddf96ed
ad99539https://github.com/nodejs/node/pull/18049/commits/ad9953929827d4c341beeec5a45823c41ddf96ed
nodejs#17654https://github.com/nodejs/node/pull/17654
https://github.com/skanamaru
https://github.com/MylesBorins
test: change callback function to arrow functionhttps://github.com/nodejs/node/pull/18049/commits/90e3161bc99895ad6f6eb23046ff027889b7d25b
90e3161https://github.com/nodejs/node/pull/18049/commits/90e3161bc99895ad6f6eb23046ff027889b7d25b
nodejs#17699https://github.com/nodejs/node/pull/17699
https://github.com/you12724
https://github.com/MylesBorins
test: change callback function to arrow functionhttps://github.com/nodejs/node/pull/18049/commits/1f9f88cba24ead15fea81b0558bd689ed059a245
1f9f88chttps://github.com/nodejs/node/pull/18049/commits/1f9f88cba24ead15fea81b0558bd689ed059a245
nodejs#17698https://github.com/nodejs/node/pull/17698
https://github.com/routerman
https://github.com/MylesBorins
test: change callback function to arrow functionhttps://github.com/nodejs/node/pull/18049/commits/b37318c1657beecfb82cd6b051da125f701ff539
b37318chttps://github.com/nodejs/node/pull/18049/commits/b37318c1657beecfb82cd6b051da125f701ff539
nodejs#17697https://github.com/nodejs/node/pull/17697
https://github.com/addaleax
https://github.com/MylesBorins
src: remove unused strings from env.hhttps://github.com/nodejs/node/pull/18049/commits/fb76ec4c5d87ab5440d43c943bad66fb3e60a546
fb76ec4https://github.com/nodejs/node/pull/18049/commits/fb76ec4c5d87ab5440d43c943bad66fb3e60a546
nodejs#17643https://github.com/nodejs/node/pull/17643
https://github.com/addaleax
https://github.com/MylesBorins
src: rename On* -> Emit* for stream callbackshttps://github.com/nodejs/node/pull/18049/commits/37ed0a70edbbe363ac4ca18219e621eb83ef11ec
37ed0a7https://github.com/nodejs/node/pull/18049/commits/37ed0a70edbbe363ac4ca18219e621eb83ef11ec
nodejs#17701https://github.com/nodejs/node/pull/17701
https://github.com/watson
https://github.com/MylesBorins
doc: remove extra whitespace in module docshttps://github.com/nodejs/node/pull/18049/commits/9586f66515e1b96c4ef53a9f281978e741aa01ab
9586f66https://github.com/nodejs/node/pull/18049/commits/9586f66515e1b96c4ef53a9f281978e741aa01ab
nodejs#17711https://github.com/nodejs/node/pull/17711
https://github.com/aprilwebster
https://github.com/MylesBorins
doc: change eventName type annotationshttps://github.com/nodejs/node/pull/18049/commits/29600cba8fa88036ba5a370904177da7b1dd4c5c
29600cbhttps://github.com/nodejs/node/pull/18049/commits/29600cba8fa88036ba5a370904177da7b1dd4c5c
nodejs#17666https://github.com/nodejs/node/pull/17666
nodejs#17657https://github.com/nodejs/node/issues/17657
https://github.com/jure
https://github.com/MylesBorins
src: replace SetAccessor w/ SetAccessorPropertyhttps://github.com/nodejs/node/pull/18049/commits/6a221869de5784c7bdfc8816434f9610eb376856
6a22186https://github.com/nodejs/node/pull/18049/commits/6a221869de5784c7bdfc8816434f9610eb376856
nodejs#17665https://github.com/nodejs/node/pull/17665
nodejs#17636https://github.com/nodejs/node/issues/17636
nodejs#16482https://github.com/nodejs/node/pull/16482
nodejs#16860https://github.com/nodejs/node/pull/16860
https://github.com/lossycache
https://github.com/MylesBorins
doc: change "Node.js style cb" to "error-first cb"https://github.com/nodejs/node/pull/18049/commits/e97c858b25481f385277e6ea2ea7d66397889f9a
e97c858https://github.com/nodejs/node/pull/18049/commits/e97c858b25481f385277e6ea2ea7d66397889f9a
nodejs#17638https://github.com/nodejs/node/pull/17638
https://github.com/mithunsasidharan
https://github.com/MylesBorins
test: coverage for emitExperimentalWarninghttps://github.com/nodejs/node/pull/18049/commits/fbe368fdb71e2d15d48c4d6b447478f17ea9cccd
fbe368fhttps://github.com/nodejs/node/pull/18049/commits/fbe368fdb71e2d15d48c4d6b447478f17ea9cccd
nodejs#17635https://github.com/nodejs/node/pull/17635
https://github.com/Bamieh
https://github.com/MylesBorins
doc: add countdown module to writing tests guidehttps://github.com/nodejs/node/pull/18049/commits/92d08d9a25d738c79bf6999af46de7ef5a40b783
92d08d9https://github.com/nodejs/node/pull/18049/commits/92d08d9a25d738c79bf6999af46de7ef5a40b783
nodejs#17201https://github.com/nodejs/node/pull/17201
https://github.com/Bamieh
https://github.com/MylesBorins
test: update test-http-content-length to use countdownhttps://github.com/nodejs/node/pull/18049/commits/c626f8a717998a9cb6e885df52bf6c53ba835116
c626f8ahttps://github.com/nodejs/node/pull/18049/commits/c626f8a717998a9cb6e885df52bf6c53ba835116
nodejs#17201https://github.com/nodejs/node/pull/17201
https://github.com/sreepurnajasti
https://github.com/MylesBorins
test: Use countdown in test filehttps://github.com/nodejs/node/pull/18049/commits/d83d973a93eb3c6fa3b9c362ea3edb2111f71883
d83d973https://github.com/nodejs/node/pull/18049/commits/d83d973a93eb3c6fa3b9c362ea3edb2111f71883
nodejs#17169https://github.com/nodejs/node/issues/17169
nodejs#17646https://github.com/nodejs/node/pull/17646
https://github.com/calvinmetcalf
https://github.com/MylesBorins
stream: rm {writeable/readable}State.lengthhttps://github.com/nodejs/node/pull/18049/commits/ef56ea4e1c618539214316b8046698d6d3b9bc0f
ef56ea4https://github.com/nodejs/node/pull/18049/commits/ef56ea4e1c618539214316b8046698d6d3b9bc0f
nodejs#445https://github.com/nodejs/node/issues/445
nodejs#445https://github.com/nodejs/node/issues/445
nodejs#12857https://github.com/nodejs/node/pull/12857
https://github.com/cjihrig
https://github.com/MylesBorins
test: add test for postmortem metadata validationhttps://github.com/nodejs/node/pull/18049/commits/91c6488609a9eb83c3f8119711432e7fd1b04a4b
91c6488https://github.com/nodejs/node/pull/18049/commits/91c6488609a9eb83c3f8119711432e7fd1b04a4b
nodejs#17685https://github.com/nodejs/node/pull/17685
https://github.com/Fishrock123
https://github.com/MylesBorins
doc: improve documentation.mdhttps://github.com/nodejs/node/pull/18049/commits/b83fc9b79cc5b0132896260dec94af04774c3a97
b83fc9bhttps://github.com/nodejs/node/pull/18049/commits/b83fc9b79cc5b0132896260dec94af04774c3a97
nodejs#17702https://github.com/nodejs/node/pull/17702
https://github.com/Fishrock123
https://github.com/MylesBorins
doc: fix fs.existsSync descriptionhttps://github.com/nodejs/node/pull/18049/commits/07be7fbb600ee12d351eca163428bacd63825ce9
07be7fbhttps://github.com/nodejs/node/pull/18049/commits/07be7fbb600ee12d351eca163428bacd63825ce9
nodejs#17702https://github.com/nodejs/node/pull/17702
https://github.com/Fishrock123
https://github.com/MylesBorins
doc: adjust TTY wording & add inter-doc linkshttps://github.com/nodejs/node/pull/18049/commits/4c3d34e8e60d41231f61e2a5bad92dfd90416028
4c3d34ehttps://github.com/nodejs/node/pull/18049/commits/4c3d34e8e60d41231f61e2a5bad92dfd90416028
nodejs#17702https://github.com/nodejs/node/pull/17702
https://github.com/Fishrock123
https://github.com/MylesBorins
doc: not all example code can be run without 1:1https://github.com/nodejs/node/pull/18049/commits/d7cf4732a872304efd498f2bf60ea9720e24f913
d7cf473https://github.com/nodejs/node/pull/18049/commits/d7cf4732a872304efd498f2bf60ea9720e24f913
nodejs#17702https://github.com/nodejs/node/pull/17702
https://github.com/jasnell
https://github.com/MylesBorins
doc: some fs doc improvementshttps://github.com/nodejs/node/pull/18049/commits/e70e08324dffed86946b983e3d93ed64c323ee24
e70e083https://github.com/nodejs/node/pull/18049/commits/e70e08324dffed86946b983e3d93ed64c323ee24
nodejs#17692https://github.com/nodejs/node/pull/17692
https://github.com/MylesBorins
n-api: fix memory leak in napi_async_destroy()https://github.com/nodejs/node/pull/18049/commits/e54a836c1e1a57972756312a2beccaa01f4e80b8
e54a836https://github.com/nodejs/node/pull/18049/commits/e54a836c1e1a57972756312a2beccaa01f4e80b8
nodejs#17714https://github.com/nodejs/node/pull/17714
https://github.com/evanlucas
https://github.com/MylesBorins
doc: improve release guidehttps://github.com/nodejs/node/pull/18049/commits/c722b56a442ca4843df53ace69c36d5b7c899389
c722b56https://github.com/nodejs/node/pull/18049/commits/c722b56a442ca4843df53ace69c36d5b7c899389
nodejs#17677https://github.com/nodejs/node/pull/17677
https://github.com/Trott
https://github.com/MylesBorins
doc: edit CONTRIBUTING.md preamblehttps://github.com/nodejs/node/pull/18049/commits/7c70bcd909501bb80f2db4a68a3fb5264b2cfea1
7c70bcdhttps://github.com/nodejs/node/pull/18049/commits/7c70bcd909501bb80f2db4a68a3fb5264b2cfea1
nodejs#17700https://github.com/nodejs/node/pull/17700
apapirovskihttps://github.com/apapirovski
January 8, 2018 02:51https://github.com/nodejs/node/pull/18049#commits-pushed-ec9f361
https://github.com/apapirovski
https://github.com/MylesBorins
test: fix flaky test-pipe-unrefhttps://github.com/nodejs/node/pull/18049/commits/ec9f3617319f8da605fdab7a21b44f886f9205f8
ec9f361https://github.com/nodejs/node/pull/18049/commits/ec9f3617319f8da605fdab7a21b44f886f9205f8
nodejs#17950https://github.com/nodejs/node/pull/17950
nodejs#16875https://github.com/nodejs/node/issues/16875
https://github.com/evanlucas
https://github.com/MylesBorins
http: remove duplicate exporthttps://github.com/nodejs/node/pull/18049/commits/ba55006c65305d1c76809e8393cb33bcf473631d
ba55006https://github.com/nodejs/node/pull/18049/commits/ba55006c65305d1c76809e8393cb33bcf473631d
5425e0dhttps://github.com/jasnell/node/commit/5425e0dcbee1ed8f6687203eafb7c3cf214f3393
nodejs#17982https://github.com/nodejs/node/pull/17982
https://github.com/apapirovski
https://github.com/MylesBorins
test: fix flaky test-http-highwatermarkhttps://github.com/nodejs/node/pull/18049/commits/8b9e4789626008402e8ae1c22a679e90346ebf61
8b9e478https://github.com/nodejs/node/pull/18049/commits/8b9e4789626008402e8ae1c22a679e90346ebf61
nodejs#17949https://github.com/nodejs/node/pull/17949
nodejs#17857https://github.com/nodejs/node/issues/17857
https://github.com/tniessen
https://github.com/MylesBorins
test: rename regression testshttps://github.com/nodejs/node/pull/18049/commits/faf6be0b704a6b9a80cd93147545f7378af0c79f
faf6be0https://github.com/nodejs/node/pull/18049/commits/faf6be0b704a6b9a80cd93147545f7378af0c79f
nodejs#17948https://github.com/nodejs/node/pull/17948
https://github.com/toddwong
https://github.com/MylesBorins
cluster: support windowsHide option for workershttps://github.com/nodejs/node/pull/18049/commits/e8abfeb1dfe0079a3d2d73869ffeaf2d72d9b7a6
e8abfebhttps://github.com/nodejs/node/pull/18049/commits/e8abfeb1dfe0079a3d2d73869ffeaf2d72d9b7a6
nodejs#17370https://github.com/nodejs/node/issues/17370
nodejs#17412https://github.com/nodejs/node/pull/17412
nodejs#17370https://github.com/nodejs/node/issues/17370
https://github.com/maclover7
https://github.com/MylesBorins
tools: host remark-preset-lint-node in-treehttps://github.com/nodejs/node/pull/18049/commits/253c3e4dffcda7ca373c0482d19e8a58a9d56590
253c3e4https://github.com/nodejs/node/pull/18049/commits/253c3e4dffcda7ca373c0482d19e8a58a9d56590
https://github.com/watilde/remark-preset-lint-nodehttps://github.com/watilde/remark-preset-lint-node
nodejs#17441https://github.com/nodejs/node/pull/17441
https://github.com/MylesBorins
build: put .PHONY directly before its targethttps://github.com/nodejs/node/pull/18049/commits/64e6e465dd6d6c5240466e2c3d13a91a25834281
64e6e46https://github.com/nodejs/node/pull/18049/commits/64e6e465dd6d6c5240466e2c3d13a91a25834281
nodejs#17964https://github.com/nodejs/node/pull/17964
nodejs#16968https://github.com/nodejs/node/issues/16968
https://github.com/jasnell
https://github.com/MylesBorins
http2: verify that a dependency cycle may existhttps://github.com/nodejs/node/pull/18049/commits/a069f44a190a1ad680f08cee87a8926f4b30715d
a069f44https://github.com/nodejs/node/pull/18049/commits/a069f44a190a1ad680f08cee87a8926f4b30715d
nodejs#17968https://github.com/nodejs/node/pull/17968
https://github.com/refack
https://github.com/MylesBorins
test: fix common.expectsErrorhttps://github.com/nodejs/node/pull/18049/commits/d7e536d27273f8fb7161a72ee9dadb9a4358f35b
d7e536dhttps://github.com/nodejs/node/pull/18049/commits/d7e536d27273f8fb7161a72ee9dadb9a4358f35b
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
https://github.com/refack
https://github.com/MylesBorins
test: add more asserts to test-internal-errorshttps://github.com/nodejs/node/pull/18049/commits/015c1469e6b4bb89c2ac290ee5db2fa381810e44
015c146https://github.com/nodejs/node/pull/18049/commits/015c1469e6b4bb89c2ac290ee5db2fa381810e44
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
https://github.com/apapirovski
https://github.com/MylesBorins
test: fix flaky test-http-pipeline-floodhttps://github.com/nodejs/node/pull/18049/commits/7711f00bdabf0b2fce895ec35f1c96249685fce2
7711f00https://github.com/nodejs/node/pull/18049/commits/7711f00bdabf0b2fce895ec35f1c96249685fce2
nodejs#17955https://github.com/nodejs/node/pull/17955
nodejs#16317https://github.com/nodejs/node/issues/16317
https://github.com/Trott
https://github.com/MylesBorins
doc: move matthewloring to emeritihttps://github.com/nodejs/node/pull/18049/commits/9a36c65adf906f01446c795bdc82921445218a0f
9a36c65https://github.com/nodejs/node/pull/18049/commits/9a36c65adf906f01446c795bdc82921445218a0f
nodejs#17998https://github.com/nodejs/node/pull/17998
https://github.com/mhdawson
https://github.com/MylesBorins
doc: updates examples to use NULLhttps://github.com/nodejs/node/pull/18049/commits/4a11da76cdda78fde6892f00d9af3958bd03a582
4a11da7https://github.com/nodejs/node/pull/18049/commits/4a11da76cdda78fde6892f00d9af3958bd03a582
nodejs#18008https://github.com/nodejs/node/pull/18008
https://github.com/addaleax
https://github.com/MylesBorins
lib: remove queue implementation from JSStreamWraphttps://github.com/nodejs/node/pull/18049/commits/bd744b13143f49bcf08627ad618ed8b2a5f7afd7
bd744b1https://github.com/nodejs/node/pull/18049/commits/bd744b13143f49bcf08627ad618ed8b2a5f7afd7
nodejs#17918https://github.com/nodejs/node/pull/17918
https://github.com/jasnell
Revert "src: remove unused function"https://github.com/nodejs/node/pull/18049/commits/c11afbf5871e87befea431e07afeb5974fee1d6d
c11afbfhttps://github.com/nodejs/node/pull/18049/commits/c11afbf5871e87befea431e07afeb5974fee1d6d
d5cef71https://github.com/jasnell/node/commit/d5cef7181e81719efaf00f5ddbde4cbb4f82ea84
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av9.x
Jan 9, 2018https://github.com/nodejs/node/pull/18049#event-1414739241
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 9, 2018https://github.com/nodejs/node/pull/18049#issuecomment-356143814
https://ci.nodejs.org/job/node-test-pull-request/12454/https://ci.nodejs.org/job/node-test-pull-request/12454/
Please reload this pagehttps://github.com/nodejs/node/pull/18049
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 9, 2018 https://github.com/nodejs/node/pull/18049#pullrequestreview-87386383
View reviewed changes https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jan 9, 2018https://github.com/nodejs/node/pull/18049#event-1414741447
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 9, 2018https://github.com/nodejs/node/pull/18049#issuecomment-356145132
@MylesBorinshttps://github.com/MylesBorins
https://ci.nodejs.org/job/node-test-commit-linux/15439/https://ci.nodejs.org/job/node-test-commit-linux/15439/
Please reload this pagehttps://github.com/nodejs/node/pull/18049
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 9, 2018 https://github.com/nodejs/node/pull/18049#ref-pullrequest-286938214
http2: backport changes to v9.x-staging #18050 https://github.com/nodejs/node/pull/18050
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 9, 2018 https://github.com/nodejs/node/pull/18049#pullrequestreview-87423656
View reviewed changes https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
https://github.com/targos
targoshttps://github.com/targos
Jan 9, 2018 https://github.com/nodejs/node/pull/18049#pullrequestreview-87429833
View reviewed changes https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 9, 2018 https://github.com/nodejs/node/pull/18049#pullrequestreview-87433692
View reviewed changes https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/18049#pullrequestreview-87433692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18049
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/18049#issuecomment-356211023
…https://github.com/nodejs/node/pull/18049
#18049 (review)https://github.com/nodejs/node/pull/18049#pullrequestreview-87433692
https://github.com/notifications/unsubscribe-auth/AAecV15IRcykYSkE85WZlSzQPUd3xAhYks5tIxoWgaJpZM4RXKPAhttps://github.com/notifications/unsubscribe-auth/AAecV15IRcykYSkE85WZlSzQPUd3xAhYks5tIxoWgaJpZM4RXKPA
Please reload this pagehttps://github.com/nodejs/node/pull/18049
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/bd744b13143f49bcf08627ad618ed8b2a5f7afd7..f55a5e876289aa5d9b9e7b392c33b118e51abce4
bd744b1https://github.com/nodejs/node/commit/bd744b13143f49bcf08627ad618ed8b2a5f7afd7
f55a5e8https://github.com/nodejs/node/commit/f55a5e876289aa5d9b9e7b392c33b118e51abce4
Compare https://github.com/nodejs/node/compare/bd744b13143f49bcf08627ad618ed8b2a5f7afd7..f55a5e876289aa5d9b9e7b392c33b118e51abce4
January 9, 2018 08:20https://github.com/nodejs/node/pull/18049#event-1415137368
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/18049#issuecomment-356212148
Please reload this pagehttps://github.com/nodejs/node/pull/18049
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/18049#event-1415137522
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18049
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/18049/files/c11afbf5871e87befea431e07afeb5974fee1d6d
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/18049
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/mcollina
https://github.com/danbev
https://github.com/targos
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/bnoordhuis
https://github.com/calvinmetcalf
https://github.com/Leko
https://github.com/skanamaru
https://github.com/you12724
https://github.com/routerman
https://github.com/watson
https://github.com/aprilwebster
https://github.com/jure
https://github.com/lossycache
https://github.com/mithunsasidharan
https://github.com/Bamieh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.