René's URL Explorer Experiment


Title: tools: non-Ascii linter for /lib only by SirR4T · Pull Request #18043 · nodejs/node · GitHub

Open Graph Title: tools: non-Ascii linter for /lib only by SirR4T · Pull Request #18043 · nodejs/node

X Title: tools: non-Ascii linter for /lib only by SirR4T · Pull Request #18043 · nodejs/node

Description: Non-ASCII characters in /lib get compiled into the node binary, and may bloat the binary size unnecessarily. A linter rule may help prevent this. Fixes: #11209 Checklist make -j4 test (UNIX), o...

Open Graph Description: Non-ASCII characters in /lib get compiled into the node binary, and may bloat the binary size unnecessarily. A linter rule may help prevent this. Fixes: #11209 Checklist make -j4 test (UNIX), o...

X Description: Non-ASCII characters in /lib get compiled into the node binary, and may bloat the binary size unnecessarily. A linter rule may help prevent this. Fixes: #11209 Checklist make -j4 test (UNIX), o...

Opengraph URL: https://github.com/nodejs/node/pull/18043

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9cfcb8a7-0bf2-8445-9210-7a85d9952fc0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9702:34E8DF:5720DB:7A627D:696A0F3E
html-safe-nonceadc0a2a4bb9e40813730e201c8f196f39841f962a292e28044ede85f12cc673e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzAyOjM0RThERjo1NzIwREI6N0E2MjdEOjY5NkEwRjNFIiwidmlzaXRvcl9pZCI6IjU1OTQwMjczMDY1OTQ3MzM4ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4a9ab8f06e241d17fc45fcd1285cdbec3aafe9dbb28dc9a47a45588e34791faa
hovercard-subject-tagpull_request:161687419
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18043/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7fbeb8b77e423c146f328ad5c5698c6f00ff55949a2b79a7b433ffb00db3fd41/nodejs/node/pull/18043
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7fbeb8b77e423c146f328ad5c5698c6f00ff55949a2b79a7b433ffb00db3fd41/nodejs/node/pull/18043
og:image:altNon-ASCII characters in /lib get compiled into the node binary, and may bloat the binary size unnecessarily. A linter rule may help prevent this. Fixes: #11209 Checklist make -j4 test (UNIX), o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSirR4T
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18043#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18043
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18043
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18043
Reloadhttps://github.com/nodejs/node/pull/18043
Reloadhttps://github.com/nodejs/node/pull/18043
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18043
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/18043
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/18043#issue-comment-box
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:eslintForLibhttps://github.com/SirR4T/node/tree/eslintForLib
tools: non-Ascii linter for /lib only https://github.com/nodejs/node/pull/18043#top
SirR4Thttps://github.com/SirR4T
nodejs:masterhttps://github.com/nodejs/node/tree/master
SirR4T:eslintForLibhttps://github.com/SirR4T/node/tree/eslintForLib
Conversation 18 https://github.com/nodejs/node/pull/18043
Commits 4 https://github.com/nodejs/node/pull/18043/commits
Checks 0 https://github.com/nodejs/node/pull/18043/checks
Files changed https://github.com/nodejs/node/pull/18043/files
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 8, 2018https://github.com/nodejs/node/pull/18043#issue-286828579
Please reload this pagehttps://github.com/nodejs/node/pull/18043
#11209https://github.com/nodejs/node/issues/11209
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Jan 8, 2018https://github.com/nodejs/node/pull/18043#event-1414113835
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 8, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-87287717
View reviewed changes https://github.com/nodejs/node/pull/18043/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/18043#pullrequestreview-87287717
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 8, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356044688
@hkalhttps://github.com/hkal
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 8, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356045343
@SirR4Thttps://github.com/SirR4T
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 8, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356052641
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 9, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356170399
@addaleaxhttps://github.com/addaleax
#11371https://github.com/nodejs/node/pull/11371
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/1233f7b818e28c3c572615f71a04deb18e1a407b..04030943a3160ee6eaf584da1111213f0d31af2d
1233f7bhttps://github.com/nodejs/node/commit/1233f7b818e28c3c572615f71a04deb18e1a407b
0403094https://github.com/nodejs/node/commit/04030943a3160ee6eaf584da1111213f0d31af2d
Compare https://github.com/nodejs/node/compare/1233f7b818e28c3c572615f71a04deb18e1a407b..04030943a3160ee6eaf584da1111213f0d31af2d
January 9, 2018 03:37https://github.com/nodejs/node/pull/18043#event-1414889881
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Jan 10, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356467931
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 10, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356600324
@not-an-aardvarkhttps://github.com/not-an-aardvark
#11129 (comment)https://github.com/nodejs/node/pull/11129#issuecomment-277123437
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 10, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356602228
@SirR4Thttps://github.com/SirR4T
node/tools/js2c.pyhttps://github.com/nodejs/node/blob/1e0f3315c77033ef0e01bb37c3d41c8e1d65e686/tools/js2c.py#L230-L240
1e0f331https://github.com/nodejs/node/commit/1e0f3315c77033ef0e01bb37c3d41c8e1d65e686
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 10, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-87835399
View reviewed changes https://github.com/nodejs/node/pull/18043/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/18043#pullrequestreview-87835399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 10, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-87991446
View reviewed changes https://github.com/nodejs/node/pull/18043/files
tools/eslint-rules/non-ascii-character.jshttps://github.com/nodejs/node/pull/18043/files#diff-d6a90da4411ba8afc7ee739ccf762b7bc0d1d507c45167fe3e73f68571a90859
Trotthttps://github.com/Trott
Jan 10, 2018https://github.com/nodejs/node/pull/18043#discussion_r160807831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Jan 10, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-87998010
View reviewed changes https://github.com/nodejs/node/pull/18043/files
tools/eslint-rules/non-ascii-character.jshttps://github.com/nodejs/node/pull/18043/files#diff-d6a90da4411ba8afc7ee739ccf762b7bc0d1d507c45167fe3e73f68571a90859
not-an-aardvarkhttps://github.com/not-an-aardvark
Jan 10, 2018https://github.com/nodejs/node/pull/18043#discussion_r160813249
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/04030943a3160ee6eaf584da1111213f0d31af2d..cf8e8216aa63cc81b200be2b87924fe48af3f0d8
0403094https://github.com/nodejs/node/commit/04030943a3160ee6eaf584da1111213f0d31af2d
cf8e821https://github.com/nodejs/node/commit/cf8e8216aa63cc81b200be2b87924fe48af3f0d8
Compare https://github.com/nodejs/node/compare/04030943a3160ee6eaf584da1111213f0d31af2d..cf8e8216aa63cc81b200be2b87924fe48af3f0d8
January 11, 2018 08:54https://github.com/nodejs/node/pull/18043#event-1419307400
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 11, 2018https://github.com/nodejs/node/pull/18043#issuecomment-356877051
@Trotthttps://github.com/Trott
@not-an-aardvarkhttps://github.com/not-an-aardvark
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/d4fb97c1fa0e4eae00c5060b3a20a94638f2fb88..004ffb3d016d177946ccad5b02d802f4968726c8
d4fb97chttps://github.com/nodejs/node/commit/d4fb97c1fa0e4eae00c5060b3a20a94638f2fb88
004ffb3https://github.com/nodejs/node/commit/004ffb3d016d177946ccad5b02d802f4968726c8
Compare https://github.com/nodejs/node/compare/d4fb97c1fa0e4eae00c5060b3a20a94638f2fb88..004ffb3d016d177946ccad5b02d802f4968726c8
January 11, 2018 16:58https://github.com/nodejs/node/pull/18043#event-1420170683
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 19, 2018https://github.com/nodejs/node/pull/18043#issuecomment-359025465
@Trotthttps://github.com/Trott
@not-an-aardvarkhttps://github.com/not-an-aardvark
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Jan 19, 2018https://github.com/nodejs/node/pull/18043#issuecomment-359027054
Please reload this pagehttps://github.com/nodejs/node/pull/18043
January 19, 2018 22:36https://github.com/nodejs/node/pull/18043#commits-pushed-3d63b03
tools: non-Ascii linter for /lib onlyhttps://github.com/nodejs/node/pull/18043/commits/3d63b03afb0af82abc688856db52ba003d209d60
3d63b03https://github.com/nodejs/node/pull/18043/commits/3d63b03afb0af82abc688856db52ba003d209d60
nodejs#11209https://github.com/nodejs/node/issues/11209
tools: fix non-ascii linter detectionhttps://github.com/nodejs/node/pull/18043/commits/1399bf5f2befe6d78f674fd49ffa20f844c9530d
1399bf5https://github.com/nodejs/node/pull/18043/commits/1399bf5f2befe6d78f674fd49ffa20f844c9530d
tools: using source.text instead of tokenshttps://github.com/nodejs/node/pull/18043/commits/bd452d5b3783a52cdc0c2fc19a015e3025ee30af
bd452d5https://github.com/nodejs/node/pull/18043/commits/bd452d5b3783a52cdc0c2fc19a015e3025ee30af
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Jan 19, 2018https://github.com/nodejs/node/pull/18043#issuecomment-359038535
@not-an-aardvarkhttps://github.com/not-an-aardvark
Please reload this pagehttps://github.com/nodejs/node/pull/18043
Adding loc to reporthttps://github.com/nodejs/node/pull/18043/commits/1e0ab236de01738c3c2677efbf8bb825ee2744a5
1e0ab23https://github.com/nodejs/node/pull/18043/commits/1e0ab236de01738c3c2677efbf8bb825ee2744a5
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
force-pushedhttps://github.com/nodejs/node/compare/004ffb3d016d177946ccad5b02d802f4968726c8..1e0ab236de01738c3c2677efbf8bb825ee2744a5
004ffb3https://github.com/nodejs/node/commit/004ffb3d016d177946ccad5b02d802f4968726c8
1e0ab23https://github.com/nodejs/node/commit/1e0ab236de01738c3c2677efbf8bb825ee2744a5
Compare https://github.com/nodejs/node/compare/004ffb3d016d177946ccad5b02d802f4968726c8..1e0ab236de01738c3c2677efbf8bb825ee2744a5
January 19, 2018 18:10https://github.com/nodejs/node/pull/18043#event-1432962349
https://github.com/maclover7
maclover7https://github.com/maclover7
force-pushedhttps://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c
bb5575ahttps://github.com/nodejs/node/commit/bb5575aa75fd3071724d5eccde39a3041e1af57a
993b716https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c
Compare https://github.com/nodejs/node/compare/bb5575aa75fd3071724d5eccde39a3041e1af57a..993b7164933addab4021efe52d1e736976685d7c
January 26, 2018 22:02https://github.com/nodejs/node/pull/18043#event-1444448772
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab
993b716https://github.com/nodejs/node/commit/993b7164933addab4021efe52d1e736976685d7c
082f952https://github.com/nodejs/node/commit/082f9525d92532867bc7172acebdf9b89a715dab
Compare https://github.com/nodejs/node/compare/993b7164933addab4021efe52d1e736976685d7c..082f9525d92532867bc7172acebdf9b89a715dab
January 26, 2018 22:36https://github.com/nodejs/node/pull/18043#event-1444493742
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 2, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-93576025
View reviewed changes https://github.com/nodejs/node/pull/18043/files/1e0ab236de01738c3c2677efbf8bb825ee2744a5
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Feb 2, 2018https://github.com/nodejs/node/pull/18043#issuecomment-362546735
https://ci.nodejs.org/job/node-test-pull-request/12908/https://ci.nodejs.org/job/node-test-pull-request/12908/
@not-an-aardvarkhttps://github.com/not-an-aardvark
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/not-an-aardvark
not-an-aardvarkhttps://github.com/not-an-aardvark
Feb 2, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-93647578
View reviewed changes https://github.com/nodejs/node/pull/18043/files/1e0ab236de01738c3c2677efbf8bb825ee2744a5
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 2, 2018https://github.com/nodejs/node/pull/18043#event-1455375419
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 2, 2018 https://github.com/nodejs/node/pull/18043#pullrequestreview-93728939
View reviewed changes https://github.com/nodejs/node/pull/18043/files/1e0ab236de01738c3c2677efbf8bb825ee2744a5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 4, 2018https://github.com/nodejs/node/pull/18043#issuecomment-362917366
c45afe8https://github.com/nodejs/node/commit/c45afe819840d2915823df55f24574f0da139dcc
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 4, 2018https://github.com/nodejs/node/pull/18043#event-1456875983
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Feb 4, 2018https://github.com/nodejs/node/pull/18043#event-1456876025
addaleaxhttps://github.com/addaleax
Feb 4, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-c45afe8
https://github.com/addaleax
tools: non-Ascii linter for /lib onlyhttps://github.com/nodejs/node/commit/c45afe819840d2915823df55f24574f0da139dcc
c45afe8https://github.com/nodejs/node/commit/c45afe819840d2915823df55f24574f0da139dcc
#18043https://github.com/nodejs/node/pull/18043
#11209https://github.com/nodejs/node/issues/11209
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-46b8481
https://github.com/MylesBorins
tools: non-Ascii linter for /lib onlyhttps://github.com/nodejs/node/commit/46b84811d2f0d73c3feb27463f971f1541c7d1c9
46b8481https://github.com/nodejs/node/commit/46b84811d2f0d73c3feb27463f971f1541c7d1c9
#18043https://github.com/nodejs/node/pull/18043
#11209https://github.com/nodejs/node/issues/11209
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-e1fffbc
https://github.com/MylesBorins
tools: non-Ascii linter for /lib onlyhttps://github.com/nodejs/node/commit/e1fffbca4997f9440202d8109ad60f580be30aa5
e1fffbchttps://github.com/nodejs/node/commit/e1fffbca4997f9440202d8109ad60f580be30aa5
#18043https://github.com/nodejs/node/pull/18043
#11209https://github.com/nodejs/node/issues/11209
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-e00bb16
https://github.com/MylesBorins
tools: non-Ascii linter for /lib onlyhttps://github.com/nodejs/node/commit/e00bb1657f1ee5e466547d2f0e3a47504815cbf6
e00bb16https://github.com/nodejs/node/commit/e00bb1657f1ee5e466547d2f0e3a47504815cbf6
#18043https://github.com/nodejs/node/pull/18043
#11209https://github.com/nodejs/node/issues/11209
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2018 https://github.com/nodejs/node/pull/18043#ref-pullrequest-299038228
v9.6.0 proposal #18902 https://github.com/nodejs/node/pull/18902
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x
Mar 20, 2018https://github.com/nodejs/node/pull/18043#event-1531416102
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 20, 2018https://github.com/nodejs/node/pull/18043#issuecomment-374670073
the guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Mar 20, 2018 https://github.com/nodejs/node/pull/18043#ref-pullrequest-306991140
[v6.x backport] tools: non-Ascii linter for /lib only #19493 https://github.com/nodejs/node/pull/19493
https://github.com/SirR4T
SirR4Thttps://github.com/SirR4T
Mar 21, 2018 https://github.com/nodejs/node/pull/18043#ref-pullrequest-307085054
[v8.x backport] tools: non-Ascii linter for /lib only #19499 https://github.com/nodejs/node/pull/19499
SirR4Thttps://github.com/SirR4T
Mar 29, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-6ba7fd0
tools: non-Ascii linter for /lib onlyhttps://github.com/SirR4T/node/commit/6ba7fd02ef7f15b9c2ab89e8ec0d2df3f8808760
6ba7fd0https://github.com/SirR4T/node/commit/6ba7fd02ef7f15b9c2ab89e8ec0d2df3f8808760
nodejs#18043https://github.com/nodejs/node/pull/18043
nodejs#11209https://github.com/nodejs/node/issues/11209
SirR4Thttps://github.com/SirR4T
Mar 29, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-bc22bf0
tools: non-Ascii linter for /lib onlyhttps://github.com/SirR4T/node/commit/bc22bf0acc80151847e8b2ba5909d804bd95b056
bc22bf0https://github.com/SirR4T/node/commit/bc22bf0acc80151847e8b2ba5909d804bd95b056
nodejs#18043https://github.com/nodejs/node/pull/18043
nodejs#11209https://github.com/nodejs/node/issues/11209
BethGriggshttps://github.com/BethGriggs
Apr 10, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-016a28a
https://github.com/BethGriggs
tools: non-Ascii linter for /lib onlyhttps://github.com/nodejs/node/commit/016a28ac08a60498dd1f36dfdc550df8e6f8118c
016a28ahttps://github.com/nodejs/node/commit/016a28ac08a60498dd1f36dfdc550df8e6f8118c
#18043https://github.com/nodejs/node/pull/18043
#19499https://github.com/nodejs/node/pull/19499
#11209https://github.com/nodejs/node/issues/11209
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 2, 2018 https://github.com/nodejs/node/pull/18043#ref-pullrequest-319669485
v8.11.2 proposal #20478 https://github.com/nodejs/node/pull/20478
MayaLekovahttps://github.com/MayaLekova
May 8, 2018 https://github.com/nodejs/node/pull/18043#ref-commit-ee8bdf3
https://github.com/MayaLekova
tools: non-Ascii linter for /lib onlyhttps://github.com/MayaLekova/node/commit/ee8bdf3b834e0d1a112bf9571484157f6b4827a6
ee8bdf3https://github.com/MayaLekova/node/commit/ee8bdf3b834e0d1a112bf9571484157f6b4827a6
nodejs#18043https://github.com/nodejs/node/pull/18043
nodejs#11209https://github.com/nodejs/node/issues/11209
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18043
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/18043/files/04030943a3160ee6eaf584da1111213f0d31af2d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/18043/files/1e0ab236de01738c3c2677efbf8bb825ee2744a5
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/18043/files/1e0ab236de01738c3c2677efbf8bb825ee2744a5
https://github.com/not-an-aardvark
not-an-aardvark https://github.com/not-an-aardvark
https://github.com/nodejs/node/pull/18043/files/1e0ab236de01738c3c2677efbf8bb825ee2744a5
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Linter rule: use ASCII quotes not Unicode ones https://github.com/nodejs/node/issues/11209
Please reload this pagehttps://github.com/nodejs/node/pull/18043
https://github.com/SirR4T
https://github.com/addaleax
https://github.com/not-an-aardvark
https://github.com/BridgeAR
https://github.com/MylesBorins
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.