René's URL Explorer Experiment


Title: src: harden JSStream callbacks by addaleax · Pull Request #18028 · nodejs/node · GitHub

Open Graph Title: src: harden JSStream callbacks by addaleax · Pull Request #18028 · nodejs/node

X Title: src: harden JSStream callbacks by addaleax · Pull Request #18028 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since these are executing JS code, and in particular parts of that code may be provided by userland, handle such exceptions in C++. Ref: #17938 (comment) (/cc @jasnell) Checklist make -j4 test (U...

X Description: Since these are executing JS code, and in particular parts of that code may be provided by userland, handle such exceptions in C++. Ref: #17938 (comment) (/cc @jasnell) Checklist make -j4 test (U...

Opengraph URL: https://github.com/nodejs/node/pull/18028

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6cd75a0e-0577-e4ad-f2eb-d336f2c177db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id875C:15F1A6:109FEA:158C0F:6A52EC60
html-safe-nonce650129abd7d1fc6d8fff891a6ce4dc2973cfbfc78afbb9abd1817e47b143f919
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzVDOjE1RjFBNjoxMDlGRUE6MTU4QzBGOjZBNTJFQzYwIiwidmlzaXRvcl9pZCI6IjI3NzQ4NTY4MTk4NTk5NzUyNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac85c1e81054a77e7fe22315c5396c0d59c20deaec6d22e27bfa6463f6ad67f91d
hovercard-subject-tagpull_request:161539267
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/18028/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/773ca97251c363fffa25853bef4a5b8e81bf3815f98e6f635295956210d639ec/nodejs/node/pull/18028
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/773ca97251c363fffa25853bef4a5b8e81bf3815f98e6f635295956210d639ec/nodejs/node/pull/18028
og:image:altSince these are executing JS code, and in particular parts of that code may be provided by userland, handle such exceptions in C++. Ref: #17938 (comment) (/cc @jasnell) Checklist make -j4 test (U...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/18028#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18028
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18028
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/18028
Reloadhttps://github.com/nodejs/node/pull/18028
Reloadhttps://github.com/nodejs/node/pull/18028
Please reload this pagehttps://github.com/nodejs/node/pull/18028
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/18028
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 995 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:jsstream-hardenhttps://github.com/addaleax/node/tree/jsstream-harden
Conversationhttps://github.com/nodejs/node/pull/18028
Commits2 (2)https://github.com/nodejs/node/pull/18028/commits
Checkshttps://github.com/nodejs/node/pull/18028/checks
Files changedhttps://github.com/nodejs/node/pull/18028/files
src: harden JSStream callbackshttps://github.com/nodejs/node/pull/18028#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:jsstream-hardenhttps://github.com/addaleax/node/tree/jsstream-harden
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 7, 2018https://github.com/nodejs/node/pull/18028#issue-286599533
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
@jasnellhttps://github.com/jasnell
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/addaleax
src: harden JSStream callbackshttps://github.com/nodejs/node/pull/18028/commits/7707494bc56ba0282e149a1f8dd0eb872ea3b56c
7707494https://github.com/nodejs/node/pull/18028/commits/7707494bc56ba0282e149a1f8dd0eb872ea3b56c
nodejs#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 7, 2018https://github.com/nodejs/node/pull/18028#event-1412874008
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 7, 2018 https://github.com/nodejs/node/pull/18028#pullrequestreview-87111547
View reviewed changes https://github.com/nodejs/node/pull/18028/files/7707494bc56ba0282e149a1f8dd0eb872ea3b56c
src/js_stream.cchttps://github.com/nodejs/node/pull/18028/files/7707494bc56ba0282e149a1f8dd0eb872ea3b56c#diff-767d0f8c3b89817c9e92f8b50631596abab2c72bc27107c9ed53ee010566f017
bnoordhuishttps://github.com/bnoordhuis
Jan 7, 2018https://github.com/nodejs/node/pull/18028#discussion_r160061748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/18028
addaleaxhttps://github.com/addaleax
Jan 7, 2018https://github.com/nodejs/node/pull/18028#discussion_r160061899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/addaleax
[squash] handle return from FatalException()https://github.com/nodejs/node/pull/18028/commits/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
9b1e0e9https://github.com/nodejs/node/pull/18028/commits/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 7, 2018 https://github.com/nodejs/node/pull/18028#pullrequestreview-87112718
View reviewed changes https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 8, 2018 https://github.com/nodejs/node/pull/18028#pullrequestreview-87240674
View reviewed changes https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 8, 2018 https://github.com/nodejs/node/pull/18028#pullrequestreview-87258277
View reviewed changes https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/danbev
danbevhttps://github.com/danbev
Jan 9, 2018 https://github.com/nodejs/node/pull/18028#pullrequestreview-87423818
View reviewed changes https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 9, 2018https://github.com/nodejs/node/pull/18028#issuecomment-356447508
https://ci.nodejs.org/job/node-test-pull-request/12471/https://ci.nodejs.org/job/node-test-pull-request/12471/
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 10, 2018https://github.com/nodejs/node/pull/18028#issuecomment-356632673
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jan 11, 2018 https://github.com/nodejs/node/pull/18028#pullrequestreview-88324148
View reviewed changes https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2018https://github.com/nodejs/node/pull/18028#issuecomment-357513681
36daf1dhttps://github.com/nodejs/node/commit/36daf1d6344137c7ab0e6b39998d1030721de45c
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2018https://github.com/nodejs/node/pull/18028#event-1423317285
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 14, 2018 13:58https://github.com/nodejs/node/pull/18028#event-1423317301
addaleaxhttps://github.com/addaleax
Jan 14, 2018 https://github.com/nodejs/node/pull/18028#ref-commit-36daf1d
https://github.com/addaleax
src: harden JSStream callbackshttps://github.com/nodejs/node/commit/36daf1d6344137c7ab0e6b39998d1030721de45c
36daf1dhttps://github.com/nodejs/node/commit/36daf1d6344137c7ab0e6b39998d1030721de45c
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
#18028https://github.com/nodejs/node/pull/18028
evanlucashttps://github.com/evanlucas
Jan 30, 2018 https://github.com/nodejs/node/pull/18028#ref-commit-ac0a0a6
https://github.com/addaleax
https://github.com/evanlucas
src: harden JSStream callbackshttps://github.com/nodejs/node/commit/ac0a0a6775bc9a2960a501bdb40144fc5914dc37
ac0a0a6https://github.com/nodejs/node/commit/ac0a0a6775bc9a2960a501bdb40144fc5914dc37
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
#18028https://github.com/nodejs/node/pull/18028
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Jan 30, 2018 https://github.com/nodejs/node/pull/18028#ref-pullrequest-292910934
v9.5.0 release proposal #18464 https://github.com/nodejs/node/pull/18464
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
Feb 27, 2018https://github.com/nodejs/node/pull/18028#event-1493602726
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 27, 2018https://github.com/nodejs/node/pull/18028#issuecomment-368753925
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 22, 2018https://github.com/nodejs/node/pull/18028#issuecomment-391085513
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v8.x
lts-watch-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x
May 22, 2018https://github.com/nodejs/node/pull/18028#event-1639996443
MylesBorinshttps://github.com/MylesBorins
May 22, 2018 https://github.com/nodejs/node/pull/18028#ref-commit-5b8e46d
https://github.com/addaleax
https://github.com/MylesBorins
src: harden JSStream callbackshttps://github.com/nodejs/node/commit/5b8e46dd29773e2115fac18372ef073138444c05
5b8e46dhttps://github.com/nodejs/node/commit/5b8e46dd29773e2115fac18372ef073138444c05
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
#18028https://github.com/nodejs/node/pull/18028
MylesBorinshttps://github.com/MylesBorins
Jun 14, 2018 https://github.com/nodejs/node/pull/18028#ref-commit-7da4ca0
https://github.com/addaleax
https://github.com/MylesBorins
src: harden JSStream callbackshttps://github.com/nodejs/node/commit/7da4ca0a42373f4ec5924214008ad3f4cf0fbc17
7da4ca0https://github.com/nodejs/node/commit/7da4ca0a42373f4ec5924214008ad3f4cf0fbc17
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
#18028https://github.com/nodejs/node/pull/18028
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 9, 2018 https://github.com/nodejs/node/pull/18028#ref-pullrequest-337147468
v8.12.0 proposal #21593 https://github.com/nodejs/node/pull/21593
rvagghttps://github.com/rvagg
Aug 16, 2018 https://github.com/nodejs/node/pull/18028#ref-commit-15c4717
https://github.com/addaleax
https://github.com/rvagg
src: harden JSStream callbackshttps://github.com/nodejs/node/commit/15c4717e0aea7a69bd531f4e01b051423eed0962
15c4717https://github.com/nodejs/node/commit/15c4717e0aea7a69bd531f4e01b051423eed0962
#17938 (comment)https://github.com/nodejs/node/pull/17938#issuecomment-354683850
#18028https://github.com/nodejs/node/pull/18028
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F18028
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/danbev
danbev https://github.com/danbev
https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/18028/files/9b1e0e963741b8d8103221ae7bf817a3187ab4ec
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/18028
https://github.com/addaleax
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/bnoordhuis
https://github.com/danbev
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.